Re: [PATCH] Make DOMString data be non-opaque in order to support debugging, Take 2

2000-01-05 Thread Mike Pogue
Ah, I see. You're just changing the visibility of the classes. The vtable layout doesn't change (I misread the code -- sorry!). Mike [EMAIL PROTECTED] wrote: > > Now, who said they were incompatible?? All we're doing is exposing some > additional symbols to allow debugging. This are just dec

Re: [PATCH] Make DOMString data be non-opaque in order to support debugging, Take 2

2000-01-04 Thread roddey
It should use XML_DEBUG, not _DEBUG, which is VC++ specific. Each compiler gets to look at its own debug on/off setting and is supposed to turn on XML_DEBUG if the compiler specific one is on. This lets us have debug only code that is not dependent upon any particular compiler scheme. But, other

Re: [PATCH] Make DOMString data be non-opaque in order to support debugging, Take 2

2000-01-04 Thread Robert_Weir
Now, who said they were incompatible?? All we're doing is exposing some additional symbols to allow debugging. This are just declarations, no executable code, no change in object layouts, vtables, inlines, etc. We just need to get this stuff seen by the modules that use DOMString.hpp so the deb

Re: [PATCH] Make DOMString data be non-opaque in order to support debugging, Take 2

2000-01-04 Thread Mike Pogue
Ooooh. A Debug build that's binary incompatible with the Release version of the same build. This sounds like a dangerous idea to me. Alarm bells are going off in my head (or maybe I forgot to take my Prozac today? :-) Mike [EMAIL PROTECTED] wrote: > > Here it is, conditionalized, so release b