[Xfce-bugs] [Bug 11690] Add setting to show file sizes in bytes

2018-02-04 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11690

--- Comment #26 from Adam Purkrt  ---
Alex, I am all for double spaces and to add this without a setting, but your
patch is definitely wrong. You can not substitute
g_format_size_full (size_summary, ...)
with
thunar_file_get_size_string_long (file, ...)
the size_summary contains the size of all selected files (e.g.), whereas in the
second case you are working with not well defined file
Let me prepare a correct patch (with double spaces as separator).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 11690] Add setting to show file sizes in bytes

2018-02-04 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11690

--- Comment #25 from alexxcons  ---
Created attachment 7578
  --> https://bugzilla.xfce.org/attachment.cgi?id=7578=edit
some more changes for statusbar

argh, forgot to add patch ...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 11690] Add setting to show file sizes in bytes

2018-02-04 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11690

--- Comment #24 from alexxcons  ---
I struggled across some more occasions where the statusbar still shows the old
format:
- Select multiple files
- Select multiple files + folders
- If no item is selected
- If file is a symlink
To provide a constant "look", I modified all of them accordingly.


Before pushing this, I will ask some other dev(s), if they think it is fine
without a setting to enable/disable the feature.
And if there should be a setting, weather it should be opt-in or opt-out.

Personally I dont have a strong preference on that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs