Patch to ease the overworked String

2004-08-25 Thread Dave Brosius
Seems mean to overwork the trusty String class by making it call toString on itself.   --   Index: java/src/org/apache/xindice/core/indexer/MemValueIndexer.java===RCS file: /home/cvspublic/xml

Patch removes vars named 'enum' to avoid conflicting with 1.5's keyword

2004-07-16 Thread Dave Brosius
enum -> iter enum_be_gone.patch Description: Binary data

Re: Suspicious code

2004-07-12 Thread Dave Brosius
1b4, has no such package at all. Your efforts > will be so much more appreciated if you take a look at current CVS HEAD > version (it has couple of changes/bugfixes over b4 version). > > Thanks, > Vadim > > > Dave Brosius wrote: > > > In org.apache.xindice.core

Suspicious code

2004-07-12 Thread Dave Brosius
In org.apache.xindice.xml.dom.traversal.TreeWalkerImpl is this code   Clearly this is wrong:   if ( node == null )    node = node.getParentNode();          public Node previousNode() {  Node node = next;  while ( true ) { node = node.getPreviousSibling();

Suspicious code

2004-07-12 Thread Dave Brosius
In org.apache.xindice.core.objects.Variant is this code     public void set(Object object) {  this.value = value;  type = value != null ? Types.OBJECT   : Types.EMPTY;   }   should this be   this.value = object; type = object != null .