Re: Suspicious code

2004-07-12 Thread Neil Cook
Original line: node = node.getParentNode(); Suggestion: node = next.getParentNode(); With that change, the traversal would first go through the deepest descendant of the previous node, or the previous node itself, or the parent node, in that order of choices. If all thos

RE: Notes on Xindice 1.0 to 1.1 Upgrade for Embedded Use

2004-02-21 Thread Neil Cook
Murray, That is a great description for any upgraders. It seems suitable for the Wiki or a page on the Xindice website. In your description, below, on the lines which start "database.setProperty(", should there really be three such calls? Does the second call override the first one? /Neil -

Patch for bin\xindice.bat and bin/xindice.sh

2004-01-16 Thread Neil Cook
In bin\xindice.bat: If XINDICE_HOME is not defined, the parent directory of where xindice.bat is, is tested for a dist\xindice*.jar file. If found, XINDICE_HOME is set to the parent directory. Otherwise it exits with an explanatory error. More local environment variables are used to avoid uninten

RE: cvs commit: xml-xindice/bin xindice.war.bat xindice.war.sh xindice.bat

2004-01-16 Thread Neil Cook
Vadim, >Neil Cook wrote: > >>A difference is that the war version has a very good default for >>XINDICE_HOME. Requiring users of xindice.bat to define XINDICE_HOME seems a >>small detail and would allow xindice.bat to be simplified. >> >>In the latest xindi

RE: cvs commit: xml-xindice/bin xindice.war.bat xindice.war.sh xindice.bat

2004-01-15 Thread Neil Cook
ED] Sent: Thursday, January 15, 2004 2:15 PM To: [EMAIL PROTECTED] Subject: Re: cvs commit: xml-xindice/bin xindice.war.bat xindice.war.sh xindice.bat Neil Cook wrote: >Vadim, > >In xindice.bat, you might consider using the environment variable >%ProgramFiles% when searching for the Xin

RE: cvs commit: xml-xindice/bin xindice.war.bat xindice.war.sh xindice.bat

2004-01-15 Thread Neil Cook
Vadim, In xindice.bat, you might consider using the environment variable %ProgramFiles% when searching for the Xindice installation directory. I think that "Program Files" might be translated on non-English versions of Windows. /Neil -Original Message- From: [EMAIL PROTECTED] [mailto:[EM

BUG & FIX for build.xml

2004-01-08 Thread Neil Cook
For 1.1b3, many build properties were extracted into build.properties so: Previously, the actual properties followed the declaration of ENVIRONMENT. Now, it follows their references in local.build.properties and build.properties. As build.properties references ENVIRONMENT, those re