Re: Suspicious code

2004-08-26 Thread Vadim Gritsenko
Neil Cook wrote: Original line: node = node.getParentNode(); Suggestion: node = next.getParentNode(); With that change, the traversal would first go through the deepest descendant of the previous node, or the previous node itself, or the parent node, in that order of cho

Re: Suspicious code

2004-07-12 Thread Neil Cook
Original line: node = node.getParentNode(); Suggestion: node = next.getParentNode(); With that change, the traversal would first go through the deepest descendant of the previous node, or the previous node itself, or the parent node, in that order of choices. If all thos

Re: Suspicious code

2004-07-12 Thread Vadim Gritsenko
Dave Brosius wrote: In org.apache.xindice.xml.dom.traversal.TreeWalkerImpl is this code Clearly this is wrong: if ( node == null ) node = node.getParentNode(); Ack. This code is still in there. Do you have patch suggestion? And if you can also provide a JUnit test for

Re: Suspicious code

2004-07-12 Thread Vadim Gritsenko
/download.cgi Vadim - Original Message - From: "Vadim Gritsenko" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, July 12, 2004 8:00 AM Subject: Re: Suspicious code Dave, Current Xindice version, 1.1b4, has no such package at all. Your efforts will be so mu

Re: Suspicious code

2004-07-12 Thread Dave Brosius
Ah silly me, i just looked at the src in the distribution. - Original Message - From: "Vadim Gritsenko" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, July 12, 2004 8:00 AM Subject: Re: Suspicious code > Dave, > > Current Xindice version, 1.

Re: Suspicious code

2004-07-12 Thread Vadim Gritsenko
Dave, Current Xindice version, 1.1b4, has no such package at all. Your efforts will be so much more appreciated if you take a look at current CVS HEAD version (it has couple of changes/bugfixes over b4 version). Thanks, Vadim Dave Brosius wrote: In org.apache.xindice.core.objects.Variant is this