Re: [xiphos-devel] back from the dead

2020-04-16 Thread Karl Kleinpaste
On 4/15/20 11:41 PM, Greg Hellings wrote:
> Plus my NASB patch
Of course that patch has been merged, so that can go away for next release.

I see that the critical(ly dumb) thing I was missing was -DGTKHTML=ON,
as indicated by both you and Caleb. Thanx, don't know why I didn't
realize what that was about, it gets the gtkhtml editor. Fine so far.
Duh, and all that.

But yours includes a ":BOOL" component. Is that a necessary or
especially advisable cmake-ism?
___
xiphos-devel mailing list
xiphos-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/xiphos-devel


Re: [xiphos-devel] back from the dead

2020-04-16 Thread Caleb Maclennan
Greg,

On Arch Linux we are still building 4.1.0 using the waf build system, but
on our VCS package that builds from git head the cmake build system is
working perfectly as is. From the git clone directory, our cmake
incantation looks like this:

cmake -S . -B build \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=/usr \
-DGTKHTML=ON
make -C build
make -C build DESTDIR="$pkgdir" install

Given the right system deps, this works great and is pretty generic cmake
usage. Note the package build environment already hase CFlags/CXXFlags/etc.
set properly so they are not part of the build recipie. The full package
script is here if you are interested in the dependencies:

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=xiphos-git

Caleb





On Thu, Apr 16, 2020 at 6:42 AM Greg Hellings 
wrote:

> Here's the magic source of Fedora building:
> https://src.fedoraproject.org/rpms/xiphos/tree/master
>
> Specifically we have 4.1.0 tarball
> Plus the cmake.patch which is a massive commit corresponding to "git diff
> 4.1.0..fccfbdc" and pulls in the CMake build and gets rid of the waf
> Plus my NASB patch
>
> CMake incantation is:
> mkdir build && cd build
> export CFLAGS=-fPIC
> export CXXFLAGS=-fPIC
> cmake -DGTKHTML:BOOL=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo ..
> make && sudo make install
>
> --Greg
>
> On Wed, Apr 15, 2020 at 10:35 PM Karl Kleinpaste 
> wrote:
>
>> On 4/15/20 11:18 PM, Greg Hellings wrote:
>>
>> it's gonna require some amount of ugly hackery to get that editor
>> working, now.
>>
>> So my first attempts at cmake-driven build have failed because the attempt
>> to build the editor chokes.
>> What's the magic you're using for Fedora et al builds, to avoid including
>> the editor at all for the time being?
>> ___
>> xiphos-devel mailing list
>> xiphos-devel@crosswire.org
>> http://www.crosswire.org/mailman/listinfo/xiphos-devel
>>
> ___
> xiphos-devel mailing list
> xiphos-devel@crosswire.org
> http://www.crosswire.org/mailman/listinfo/xiphos-devel
>
___
xiphos-devel mailing list
xiphos-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/xiphos-devel


Re: [xiphos-devel] back from the dead

2020-04-15 Thread Greg Hellings
Here's the magic source of Fedora building:
https://src.fedoraproject.org/rpms/xiphos/tree/master

Specifically we have 4.1.0 tarball
Plus the cmake.patch which is a massive commit corresponding to "git diff
4.1.0..fccfbdc" and pulls in the CMake build and gets rid of the waf
Plus my NASB patch

CMake incantation is:
mkdir build && cd build
export CFLAGS=-fPIC
export CXXFLAGS=-fPIC
cmake -DGTKHTML:BOOL=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo ..
make && sudo make install

--Greg

On Wed, Apr 15, 2020 at 10:35 PM Karl Kleinpaste 
wrote:

> On 4/15/20 11:18 PM, Greg Hellings wrote:
>
> it's gonna require some amount of ugly hackery to get that editor working,
> now.
>
> So my first attempts at cmake-driven build have failed because the attempt
> to build the editor chokes.
> What's the magic you're using for Fedora et al builds, to avoid including
> the editor at all for the time being?
> ___
> xiphos-devel mailing list
> xiphos-devel@crosswire.org
> http://www.crosswire.org/mailman/listinfo/xiphos-devel
>
___
xiphos-devel mailing list
xiphos-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/xiphos-devel


Re: [xiphos-devel] back from the dead

2020-04-15 Thread Karl Kleinpaste
On 4/15/20 11:18 PM, Greg Hellings wrote:
> it's gonna require some amount of ugly hackery to get that editor
> working, now.
So my first attempts at cmake-driven build have failed because the
attempt to build the editor chokes.
What's the magic you're using for Fedora et al builds, to avoid
including the editor at all for the time being?
___
xiphos-devel mailing list
xiphos-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/xiphos-devel


Re: [xiphos-devel] back from the dead

2020-04-15 Thread Greg Hellings
If you'd like to cry into your soup at some point, I can tell you about
what I've discovered about the state of our WebKit2 editor. Which becomes
increasingly important as more distros drop GtkHTML altogether.

In the past 3-4 releases of webkit2gtk they've moved all DOM access code
out of the main thread, so you can't even do what we do anymore. The
methods are still there, but only for the headers to a separate plugin
library to the webkit engine which you must preload before you initialize
any webkit components. What remains nebulous according to all the docs is
how to get information back and forth between the main application and the
plugin (seems you have to communicate over DBus or a similar mechanism for
systems that don't support DBus). This is drive by them moving webkit out
of the application's thread and into a subprocess of its own that
communicates back and forth with the application's GUI thread. This is
similar to how Chrome/Chromium/Blink operate and it's one way to prevent
bad things happening in the web component from happening in the main
application.

But it's gonna require some amount of ugly hackery to get that editor
working, now.

--Greg

On Wed, Apr 15, 2020 at 10:12 PM Greg Hellings 
wrote:

> Welcome back, Mr Kleinpaste.
>
> We missed you. 
>
> On Wed, Apr 15, 2020 at 9:01 PM Karl Kleinpaste 
> wrote:
>
>> At least, I think I'm back.
>>
>> I've been out of commission for doing Xiphos things for way too long. I'm
>> back now, I think. I've just gone through ~150 emails from the github issue
>> tracker. Merged a bunch of pending stuff, need to look at a few more still
>> pending, made intermediate comments on many more. Working on a couple
>> simple updates. Hope to get to a release point for 4.1.1 sometime Real Soon
>> Now. Apologies for long absence. Life hasn't been my friend.
>> ___
>> xiphos-devel mailing list
>> xiphos-devel@crosswire.org
>> http://www.crosswire.org/mailman/listinfo/xiphos-devel
>>
>
___
xiphos-devel mailing list
xiphos-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/xiphos-devel


Re: [xiphos-devel] back from the dead

2020-04-15 Thread Greg Hellings
Welcome back, Mr Kleinpaste.

We missed you. 

On Wed, Apr 15, 2020 at 9:01 PM Karl Kleinpaste  wrote:

> At least, I think I'm back.
>
> I've been out of commission for doing Xiphos things for way too long. I'm
> back now, I think. I've just gone through ~150 emails from the github issue
> tracker. Merged a bunch of pending stuff, need to look at a few more still
> pending, made intermediate comments on many more. Working on a couple
> simple updates. Hope to get to a release point for 4.1.1 sometime Real Soon
> Now. Apologies for long absence. Life hasn't been my friend.
> ___
> xiphos-devel mailing list
> xiphos-devel@crosswire.org
> http://www.crosswire.org/mailman/listinfo/xiphos-devel
>
___
xiphos-devel mailing list
xiphos-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/xiphos-devel