Re: [xml] Availability of libxml2-2.9.4 release candidate 2
Hi Daniel,
Daniel Veillard wrote:
As planned I tagged in git a release candidate 2, and pushed to the
server the signed tarball and rpms for rc2:
ftp://xmlsoft.org/xml/
I will run this on my machine until the release and try to see if there
is any nastyness popping up. I suggest others to do so too for their workload !
I still have pending patches, but most likely next week end I will push the
final 2.9.4, if things don't look nice I may push an rc3 instead.
Please give it some testing and report,
I note a minor documentation issue :
- patch "Fix typos: dictio{ nn -> n }ar{y,ies}" does not modify "xml.html"
No issues with build and tests.
Regard,
Roumen
___
xml mailing list, project page http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Availability of libxml2-2.9.4 release candidate 2 - regexp
On 09/05/2016 13:55, Daniel Veillard wrote:
On Mon, May 09, 2016 at 11:35:28AM +0100, Pete Cordell wrote:
On 09/05/2016 10:26, Daniel Veillard wrote:
Is this OK? I used git format-patch. I'm new to submitting diffs! If you
want another format let me know.
Yup, just add it as an attachment instead, it's easier to process and avoid
mail agents and tools to mess with the content. Also would need to results ;-)
Hopefully the attached is better...
Pete.
Date: Mon, 9 May 2016 11:08:26 +0100
Subject: [PATCH] Additional regexp test vectors
---
result/regexp/multiple-rollback-paths | 2 ++
result/regexp/optional-as-zero-one| 15 +++
test/regexp/multiple-rollback-paths | 2 ++
test/regexp/optional-as-zero-one | 15 +++
4 files changed, 34 insertions(+)
create mode 100644 result/regexp/multiple-rollback-paths
create mode 100644 result/regexp/optional-as-zero-one
create mode 100644 test/regexp/multiple-rollback-paths
create mode 100644 test/regexp/optional-as-zero-one
diff --git a/result/regexp/multiple-rollback-paths
b/result/regexp/multiple-rollback-paths
new file mode 100644
index 000..84d53b7
--- /dev/null
+++ b/result/regexp/multiple-rollback-paths
@@ -0,0 +1,2 @@
+Regexp: ((2{1,2}|24)\.){2}2
+24.24.2: Fail
diff --git a/result/regexp/optional-as-zero-one
b/result/regexp/optional-as-zero-one
new file mode 100644
index 000..9eccc6b
--- /dev/null
+++ b/result/regexp/optional-as-zero-one
@@ -0,0 +1,15 @@
+Regexp: ab?c{0,1}
+a: Ok
+ab: Ok
+abc: Ok
+ac: Ok
+Regexp: ab?c?
+a: Ok
+ab: Ok
+abc: Ok
+ac: Ok
+Regexp: ab{0,1}c{0,1}
+a: Ok
+ab: Ok
+abc: Ok
+ac: Ok
diff --git a/test/regexp/multiple-rollback-paths
b/test/regexp/multiple-rollback-paths
new file mode 100644
index 000..eea526a
--- /dev/null
+++ b/test/regexp/multiple-rollback-paths
@@ -0,0 +1,2 @@
+=>((2{1,2}|24)\.){2}2
+24.24.2
diff --git a/test/regexp/optional-as-zero-one b/test/regexp/optional-as-zero-one
new file mode 100644
index 000..0c696f1
--- /dev/null
+++ b/test/regexp/optional-as-zero-one
@@ -0,0 +1,15 @@
+=>ab?c{0,1}
+a
+ab
+abc
+ac
+=>ab?c?
+a
+ab
+abc
+ac
+=>ab{0,1}c{0,1}
+a
+ab
+abc
+ac
--
2.5.3.windows.1
___
xml mailing list, project page http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Availability of libxml2-2.9.4 release candidate 2 - regexp
On Mon, May 09, 2016 at 11:35:28AM +0100, Pete Cordell wrote:
> On 09/05/2016 10:26, Daniel Veillard wrote:
> > Hi Pete,
> >
> > On Mon, May 09, 2016 at 10:02:28AM +0100, Pete Cordell wrote:
> > > Thanks Daniel. I've managed to verify that the ab?c{0,1} pattern now
> > > works.
> > > But the following pattern still appears to fail:
> > >
> > > =>((2{1,2}|24)\.){2}2
> > > #fails
> > > 24.24.2
> >
> > Right, I gave it 30mn, looked at the graph buildup, epsilon transition
> > and state reduction, and then the advance through the state machine
> > (it's a non-determinist one with rollbacks) and somehow the rollback to pick
> > 24 instead of 2{1,2} works in the first 24. occurence but not the second
> > one, didn't finished and decided to let this for after the rc2 release
>
> Rather you than me :-) Thanks for trying. I mainly wanted to make sure
> that you hadn't missed it as it was buried at the end of a message after
> quite a lot of noise!
:-)
> > > Also, I see you haven't had a chance to put the test vectors in the
> > > test/regexp dir. If you let me know what form you'd like them in I could
> > > submit something as a patch / copy of files / whatever.
> >
> > a git diff with the new tests and results would be great if you can
> > provide it :-)
>
> Is this OK? I used git format-patch. I'm new to submitting diffs! If you
> want another format let me know.
Yup, just add it as an attachment instead, it's easier to process and avoid
mail agents and tools to mess with the content. Also would need to results ;-)
Daniel
> -
>
> Date: Mon, 9 May 2016 11:08:26 +0100
> Subject: [PATCH] Additional regexp test vectors
>
> ---
> test/regexp/multiple-rollback-paths | 3 +++
> test/regexp/optional-as-zero-one| 15 +++
> 2 files changed, 18 insertions(+)
> create mode 100644 test/regexp/multiple-rollback-paths
> create mode 100644 test/regexp/optional-as-zero-one
>
> diff --git a/test/regexp/multiple-rollback-paths
> b/test/regexp/multiple-rollback-paths
> new file mode 100644
> index 000..98bc5c3
> --- /dev/null
> +++ b/test/regexp/multiple-rollback-paths
> @@ -0,0 +1,3 @@
> +=>((2{1,2}|24)\.){2}2
> +#fails
> +24.24.2
> diff --git a/test/regexp/optional-as-zero-one
> b/test/regexp/optional-as-zero-one
> new file mode 100644
> index 000..0c696f1
> --- /dev/null
> +++ b/test/regexp/optional-as-zero-one
> @@ -0,0 +1,15 @@
> +=>ab?c{0,1}
> +a
> +ab
> +abc
> +ac
> +=>ab?c?
> +a
> +ab
> +abc
> +ac
> +=>ab{0,1}c{0,1}
> +a
> +ab
> +abc
> +ac
> --
> 2.5.3.windows.1
>
> ---
>
> Thanks again,
>
> Pete.
--
Daniel Veillard | Open Source and Standards, Red Hat
veill...@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | virtualization library http://libvirt.org/
___
xml mailing list, project page http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Availability of libxml2-2.9.4 release candidate 2 - regexp
On 09/05/2016 10:26, Daniel Veillard wrote:
Hi Pete,
On Mon, May 09, 2016 at 10:02:28AM +0100, Pete Cordell wrote:
Thanks Daniel. I've managed to verify that the ab?c{0,1} pattern now works.
But the following pattern still appears to fail:
=>((2{1,2}|24)\.){2}2
#fails
24.24.2
Right, I gave it 30mn, looked at the graph buildup, epsilon transition
and state reduction, and then the advance through the state machine
(it's a non-determinist one with rollbacks) and somehow the rollback to pick
24 instead of 2{1,2} works in the first 24. occurence but not the second
one, didn't finished and decided to let this for after the rc2 release
Rather you than me :-) Thanks for trying. I mainly wanted to make sure
that you hadn't missed it as it was buried at the end of a message after
quite a lot of noise!
Also, I see you haven't had a chance to put the test vectors in the
test/regexp dir. If you let me know what form you'd like them in I could
submit something as a patch / copy of files / whatever.
a git diff with the new tests and results would be great if you can
provide it :-)
Is this OK? I used git format-patch. I'm new to submitting diffs! If
you want another format let me know.
-
Date: Mon, 9 May 2016 11:08:26 +0100
Subject: [PATCH] Additional regexp test vectors
---
test/regexp/multiple-rollback-paths | 3 +++
test/regexp/optional-as-zero-one| 15 +++
2 files changed, 18 insertions(+)
create mode 100644 test/regexp/multiple-rollback-paths
create mode 100644 test/regexp/optional-as-zero-one
diff --git a/test/regexp/multiple-rollback-paths
b/test/regexp/multiple-rollback-paths
new file mode 100644
index 000..98bc5c3
--- /dev/null
+++ b/test/regexp/multiple-rollback-paths
@@ -0,0 +1,3 @@
+=>((2{1,2}|24)\.){2}2
+#fails
+24.24.2
diff --git a/test/regexp/optional-as-zero-one
b/test/regexp/optional-as-zero-one
new file mode 100644
index 000..0c696f1
--- /dev/null
+++ b/test/regexp/optional-as-zero-one
@@ -0,0 +1,15 @@
+=>ab?c{0,1}
+a
+ab
+abc
+ac
+=>ab?c?
+a
+ab
+abc
+ac
+=>ab{0,1}c{0,1}
+a
+ab
+abc
+ac
--
2.5.3.windows.1
---
Thanks again,
Pete.
___
xml mailing list, project page http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Availability of libxml2-2.9.4 release candidate 2 - regexp
Hi Pete,
On Mon, May 09, 2016 at 10:02:28AM +0100, Pete Cordell wrote:
> Thanks Daniel. I've managed to verify that the ab?c{0,1} pattern now works.
> But the following pattern still appears to fail:
>
> =>((2{1,2}|24)\.){2}2
> #fails
> 24.24.2
Right, I gave it 30mn, looked at the graph buildup, epsilon transition
and state reduction, and then the advance through the state machine
(it's a non-determinist one with rollbacks) and somehow the rollback to pick
24 instead of 2{1,2} works in the first 24. occurence but not the second
one, didn't finished and decided to let this for after the rc2 release
> Also, I see you haven't had a chance to put the test vectors in the
> test/regexp dir. If you let me know what form you'd like them in I could
> submit something as a patch / copy of files / whatever.
a git diff with the new tests and results would be great if you can
provide it :-)
thanks !
Daniel
> Thanks again,
>
> Pete.
>
> On 09/05/2016 03:56, Daniel Veillard wrote:
> >As planned I tagged in git a release candidate 2, and pushed to the
> > server the signed tarball and rpms for rc2:
> >
> > ftp://xmlsoft.org/xml/
> >
> >I will run this on my machine until the release and try to see if there
> > is any nastyness popping up. I suggest others to do so too for their
> > workload !
> >
> > I still have pending patches, but most likely next week end I will push
> > the
> > final 2.9.4, if things don't look nice I may push an rc3 instead.
> >
> >Please give it some testing and report,
> >
> > thanks !
> >
> > Daniel
> >
> ___
> xml mailing list, project page http://xmlsoft.org/
> xml@gnome.org
> https://mail.gnome.org/mailman/listinfo/xml
--
Daniel Veillard | Open Source and Standards, Red Hat
veill...@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | virtualization library http://libvirt.org/
___
xml mailing list, project page http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Availability of libxml2-2.9.4 release candidate 2 - regexp
Thanks Daniel. I've managed to verify that the ab?c{0,1} pattern now
works. But the following pattern still appears to fail:
=>((2{1,2}|24)\.){2}2
#fails
24.24.2
Also, I see you haven't had a chance to put the test vectors in the
test/regexp dir. If you let me know what form you'd like them in I
could submit something as a patch / copy of files / whatever.
Thanks again,
Pete.
On 09/05/2016 03:56, Daniel Veillard wrote:
As planned I tagged in git a release candidate 2, and pushed to the
server the signed tarball and rpms for rc2:
ftp://xmlsoft.org/xml/
I will run this on my machine until the release and try to see if there
is any nastyness popping up. I suggest others to do so too for their workload !
I still have pending patches, but most likely next week end I will push the
final 2.9.4, if things don't look nice I may push an rc3 instead.
Please give it some testing and report,
thanks !
Daniel
___
xml mailing list, project page http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml
