Re: [xml] VC10\config.h and include\win32config.h

2016-03-07 Thread Peter Kasting
I echo Bruce's request for a single upstream Windows config file. It looks like include/win32config.h is older; win32/VC10/config.h seems to have only its initial addition in its log. It looks like that addition happened here:

Re: [xml] Possible 64-bit issues in xml 2.9.2

2015-11-10 Thread Peter Kasting
On Tue, Nov 10, 2015 at 2:21 PM, Bruce Dawson wrote: > On Tue, Nov 10, 2015 at 1:26 PM, Eric S. Eberhard > wrote: > >> I am not 100% sure this applies but I'd check into it. I run AIX mostly >> and it's compiler defaults to unsigned. When moving my

Re: [xml] Possible 64-bit issues in xml 2.9.2

2015-11-10 Thread Peter Kasting
On Tue, Nov 10, 2015 at 3:38 PM, Eric S. Eberhard wrote: > But I also found a /clr compiler switch which DOES allow a 64 bit > application to call a 32 bit dll application ... with the implied > assumption that the addressing will be taken care of: > > >

[xml] [PATCH] Signed vs. unsigned comparison warnings in dict.c

2015-07-21 Thread Peter Kasting
When compiled in MSVC, dict.c triggers warning C4018 for comparing signed and unsigned values in two places. In both cases, the code basically does: if (pool-end - pool-free unsigned int) ... The type of the LHS here is ptrdiff_t, which is signed. When comparing signed to unsigned values, the

Re: [xml] [PATCH] Signed vs. unsigned comparison warnings in dict.c

2015-07-21 Thread Peter Kasting
On Tue, Jul 21, 2015 at 11:19 AM, Peter Kasting pkast...@google.com wrote: The attached patch is one conservative way to fix this, which should be correct in all cases on all platforms. For some reason on the archives the patch downloads as a .bin file instead of a text file. While you can