Re: [xml] Report libxslt bug (minor issue)
Hi, Roumen, I unerstand your tests. Maybe I should state the issue more clearly. Everything is fine IF: tar zvxf libxslt-1.1.26.tar.gz cd libxslt-1.1.26 ./configure make Things went wrong IF: (Since libtool actually supports compile outside of the package folder) tar zvxf libxslt-1.1.26.tar.gz mkdir BUILD_FOLDER cd BUILD_FOLER ../libxslt-1.1.26/configure make Then the configure actually will generate another exsltconfig.h under the BUILD_FOLER, and that's the correct one to use. But since in the exslt.c, it's #include exsltconfig.h, so the compiler actually uses the original exsltconfig.h instead of the new generated one. Hope I made my point clear this time. Thanks a lot for the reply. Best, Hao On Wed, Oct 6, 2010 at 2:33 PM, Roumen Petrov xml...@roumenpetrov.info wrote: Hao Hu wrote: Basically, in libexslt/exslt.c The #include exsltconfig.h should be #includelibexslt/exsltconfig.h Else the issue is: When trying to compile outside of the libxslt source tree. It won't use the new exsltconfig.h generated by libtool. Hmm, $ find -name exsltconfig.h ./libexslt/exsltconfig.h $ ./libtool --version ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.492 2008/01/30 06:40:56) $ grep ^srcdir Makefile | head -1 srcdir = /work/repo/GIT/GNOME/libxslt/origin $ grep ^builddir Makefile | head -1 builddir = . $ pwd //repo-builds/libxslt-origin Cheers, Roumen ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org http://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Report libxslt bug (minor issue)
Hao Hu wrote: Basically, in libexslt/exslt.c The #include exsltconfig.h should be #includelibexslt/exsltconfig.h Else the issue is: When trying to compile outside of the libxslt source tree. It won't use the new exsltconfig.h generated by libtool. Hmm, $ find -name exsltconfig.h ./libexslt/exsltconfig.h $ ./libtool --version ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.492 2008/01/30 06:40:56) $ grep ^srcdir Makefile | head -1 srcdir = /work/repo/GIT/GNOME/libxslt/origin $ grep ^builddir Makefile | head -1 builddir = . $ pwd //repo-builds/libxslt-origin Cheers, Roumen ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org http://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Report libxslt bug (minor issue)
Hi, Daniel, Great. Thanks. Best, Hao On Tue, Oct 12, 2010 at 6:06 AM, Daniel Veillard veill...@redhat.com wrote: On Mon, Sep 20, 2010 at 06:15:28PM -0700, Hao Hu wrote: Basically, in libexslt/exslt.c The #include exsltconfig.h should be #include libexslt/exsltconfig.h Else the issue is: When trying to compile outside of the libxslt source tree. It won't use the new exsltconfig.h generated by libtool. Right, small problem, easy to fix, commited to git, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org http://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Report libxslt bug (minor issue)
On Mon, Sep 20, 2010 at 06:15:28PM -0700, Hao Hu wrote: Basically, in libexslt/exslt.c The #include exsltconfig.h should be #include libexslt/exsltconfig.h Else the issue is: When trying to compile outside of the libxslt source tree. It won't use the new exsltconfig.h generated by libtool. Right, small problem, easy to fix, commited to git, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org http://mail.gnome.org/mailman/listinfo/xml
[xml] Report libxslt bug (minor issue)
Basically, in libexslt/exslt.c The #include exsltconfig.h should be #include libexslt/exsltconfig.h Else the issue is: When trying to compile outside of the libxslt source tree. It won't use the new exsltconfig.h generated by libtool. Cheers, ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org http://mail.gnome.org/mailman/listinfo/xml