Re: [xml] xmlIO enhancements?

2005-04-09 Thread Joel Reed
On Tue, Apr 05, 2005 at 01:22:50PM -0400, Joel Reed wrote: > I'm reviewing xmlFileOpen_real and xmlGzfileOpen_real in xmlIO.c and have > two quick questions/possible improvements (i'll fire off a patch if no > dissenters). > > 1) xmlFileOpen_real does a > > if (!xmlCheckFilename(path)) return(N

Re: [xml] xmlIO enhancements?

2005-04-05 Thread Joel Reed
On Tue, Apr 05, 2005 at 04:32:02PM -0400, Daniel Veillard wrote: > On Tue, Apr 05, 2005 at 03:49:05PM -0400, Joel Reed wrote: > > On Tue, Apr 05, 2005 at 01:34:32PM -0400, Daniel Veillard wrote: > > > On Tue, Apr 05, 2005 at 01:22:50PM -0400, Joel Reed wrote: > > > > I'm reviewing xmlFileOpen_real

Re: [xml] xmlIO enhancements?

2005-04-05 Thread Daniel Veillard
On Tue, Apr 05, 2005 at 03:49:05PM -0400, Joel Reed wrote: > On Tue, Apr 05, 2005 at 01:34:32PM -0400, Daniel Veillard wrote: > > On Tue, Apr 05, 2005 at 01:22:50PM -0400, Joel Reed wrote: > > > I'm reviewing xmlFileOpen_real and xmlGzfileOpen_real in xmlIO.c and have > > > two quick questions/poss

Re: [xml] xmlIO enhancements?

2005-04-05 Thread Daniel Veillard
On Tue, Apr 05, 2005 at 04:06:46PM -0400, Joel Reed wrote: > On Tue, Apr 05, 2005 at 01:22:50PM -0400, Joel Reed wrote: > > I'm reviewing xmlFileOpen_real and xmlGzfileOpen_real in xmlIO.c and have > > two quick questions/possible improvements (i'll fire off a patch if no > > dissenters). > > i be

Re: [xml] xmlIO enhancements?

2005-04-05 Thread Joel Reed
On Tue, Apr 05, 2005 at 01:22:50PM -0400, Joel Reed wrote: > I'm reviewing xmlFileOpen_real and xmlGzfileOpen_real in xmlIO.c and have > two quick questions/possible improvements (i'll fire off a patch if no > dissenters). i better stop looking at xmlIO.c! is it me or is xmlNoNetExists and xmlSysI

Re: [xml] xmlIO enhancements?

2005-04-05 Thread Joel Reed
On Tue, Apr 05, 2005 at 01:34:32PM -0400, Daniel Veillard wrote: > On Tue, Apr 05, 2005 at 01:22:50PM -0400, Joel Reed wrote: > > I'm reviewing xmlFileOpen_real and xmlGzfileOpen_real in xmlIO.c and have > > two quick questions/possible improvements (i'll fire off a patch if no > > dissenters). > >

Re: [xml] xmlIO enhancements?

2005-04-05 Thread Daniel Veillard
On Tue, Apr 05, 2005 at 01:22:50PM -0400, Joel Reed wrote: > I'm reviewing xmlFileOpen_real and xmlGzfileOpen_real in xmlIO.c and have > two quick questions/possible improvements (i'll fire off a patch if no > dissenters). > > 1) xmlFileOpen_real does a > > if (!xmlCheckFilename(path)) return(N

[xml] xmlIO enhancements?

2005-04-05 Thread Joel Reed
I'm reviewing xmlFileOpen_real and xmlGzfileOpen_real in xmlIO.c and have two quick questions/possible improvements (i'll fire off a patch if no dissenters). 1) xmlFileOpen_real does a if (!xmlCheckFilename(path)) return(NULL); before the fopen(path, "r") call. This quick-out prevents library