Re: Alignment error in libXi

2011-03-29 Thread Peter Hutterer
On Sun, Mar 27, 2011 at 10:42:14PM +0200, Matthieu Herrb wrote: On Thu, Mar 24, 2011 at 11:51:32PM -0700, Jeremy Huddleston wrote: Don't feel too bad. I missed it too and bugged Peter about it before I pushed the release ;) Unfortunatly, as Peter forsaid it, there are other issues.

Re: Alignment error in libXi

2011-03-27 Thread Matthieu Herrb
On Thu, Mar 24, 2011 at 11:51:32PM -0700, Jeremy Huddleston wrote: Don't feel too bad. I missed it too and bugged Peter about it before I pushed the release ;) Unfortunatly, as Peter forsaid it, there are other issues. I'm currently fighting with the code for XISelectEvents(). It uses

Re: Alignment error in libXi

2011-03-26 Thread Julien Cristau
On Fri, Mar 25, 2011 at 06:31:38 +, Matt Turner wrote: Oh, I didn't realize it had already been fixed. Odd that it was fixed, reviewed, and tested without another comment in this thread. Guess I just missed the patch. The followup with patch was only on -devel. Cheers, Julien

Re: Alignment error in libXi

2011-03-25 Thread Matt Turner
On Sun, Mar 13, 2011 at 10:11 PM, Christian Weisgerber na...@mips.inka.de wrote: GTK+3 blows up on LP64 archs with strict alignment.  This comes down to an unaligned access error in libXi, specifically in the XIButtonClass case in copy_classes() in XExtInt.c.    cls_lib-num_buttons =

Re: Alignment error in libXi

2011-03-25 Thread Jeremy Huddleston
On Mar 24, 2011, at 11:06 PM, Matt Turner wrote: Is this one of those cases where someone, long ago, thought using longs was inherently good? Can we just change labels to be an array of ints, or is that too easy? You can just get the latest libXi release with the fix.

Re: Alignment error in libXi

2011-03-25 Thread Matt Turner
On Fri, Mar 25, 2011 at 6:19 AM, Jeremy Huddleston jerem...@apple.com wrote: On Mar 24, 2011, at 11:06 PM, Matt Turner wrote: Is this one of those cases where someone, long ago, thought using longs was inherently good? Can we just change labels to be an array of ints, or is that too easy?

Re: Alignment error in libXi

2011-03-25 Thread Jeremy Huddleston
Don't feel too bad. I missed it too and bugged Peter about it before I pushed the release ;) On Mar 24, 2011, at 11:31 PM, Matt Turner wrote: On Fri, Mar 25, 2011 at 6:19 AM, Jeremy Huddleston jerem...@apple.com wrote: On Mar 24, 2011, at 11:06 PM, Matt Turner wrote: Is this one of

Alignment error in libXi

2011-03-13 Thread Christian Weisgerber
GTK+3 blows up on LP64 archs with strict alignment. This comes down to an unaligned access error in libXi, specifically in the XIButtonClass case in copy_classes() in XExtInt.c. cls_lib-num_buttons = cls_wire-num_buttons; cls_lib-state.mask_len = cls_wire-num_buttons + 7)/8) + 3)/4)