Additional NULL (??) layout group with evdev+hal
Hello Peter, after upgrading to xserver 1.5.2 using the new evdev + hal I'm observing that I receive an additional layout group. The gnome keyboard indicator is showing this as ?? and using the libxklavier test program I get: [1227322878,150,xklavier.c:xkl_engine_constructor/] Actual backend: XKB [1227322878,200,xklavier_xkb.c:xkl_xkb_load_all_info/] found 3 groups [1227322878,200,xklavier_xkb.c:xkl_xkb_load_all_info/] Group 2 has name [Germany] [1227322878,200,xklavier_xkb.c:xkl_xkb_load_all_info/] Group 1 has name [Japan] [1227322878,200,xklavier_xkb.c:xkl_xkb_load_all_info/] Group 0 has name [-] The German and Japanese Layout-Group is in my setup, but the system added an additional Group 0 with name -?? I already read though your blog (http://who-t.blogspot.com/), but could not find anything explaining such a odd behaviour. I added a lot of description and logfiles to a bug report at this link: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/283128 I'm not using Autologin (that was causing trouble in other case). There are a lot of devices coming up with evdev/hal, but all have de,jp assigned (lshal). What could causing such a problem? What can I do to avoid this problem? Thank you very much. Best regards, Thomas ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Additional NULL (??) layout group with evdev+hal
Hello Peter, That's oddI have installed latest Ubuntu package for xorg-server and this is 1.5.2. http://changelogs.ubuntu.com/changelogs/pool/main/x/xorg-server/xorg-server_1.5.2-2ubuntu3/changelog I'll try to double check the source package when I have access to my linux box tonight, but currently it seems something is now working even with these patches. Is there any more information I can provide you except of the earlier attached output from xkbcomp -xkb :0 - ? Thanks so much for your help. Cheers, Thomas On Tue, Nov 25, 2008 at 7:03 AM, Peter Hutterer [EMAIL PROTECTED] wrote: On Mon, Nov 24, 2008 at 11:19:33PM +0900, Thomas Fritzsche wrote: Somehow this first version is broken creating the 3rd layout group. I guess I need to put these 2 patches in my xserver that you created for: http://bugs.freedesktop.org/show_bug.cgi?id=14373 Or is this other case? yeah, but both of them should be in 1.5.2. Can you please check whether you have that code, or whether it's something else gone wrong? Cheers, Peter ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
Re: Additional NULL (??) layout group with evdev+hal
Hi Peter,
this is regression caused by correction for 14373 (fixed with commit
ae986d1c73d).
I rebuild server removing the coding that copy more than 2 shift level
and more than 2 groups like this:
/* AB..CDE... - ABABCDE... */
if (groupWidth 0 maxSymsPerKey = 3)
pCore[2] = pCore[0];
if (groupWidth 1 maxSymsPerKey = 4)
pCore[3] = pCore[1];
/* ABABCDE... - ABABCDECDE */
/* idx = 2 + groupWidth;
while (groupWidth 2
idx maxSymsPerKey
idx groupWidth * 2)
{
pCore[idx] = pCore[idx - groupWidth + 2];
idx++;
}
idx = 2 * groupWidth;
if (idx 4)
idx = 4;
/* 3 or more groups: ABABCDECDEABCDEABCDE
for (n = 0; n groupWidth idx maxSymsPerKey; n++)
pCore[idx++] = pXKB[n];
*/
}
After installing this patched server the system doesn't generate this
strange 3rd groups any more. :-)
My guess is that keys not available on the keyboard can not have
keytype and thus the number of shift level is unknown thus keys with
more than 2 shift level generate this additional groups.
Cheers,
Thomas
On Wed, Nov 26, 2008 at 1:26 PM, Peter Hutterer
[EMAIL PROTECTED] wrote:
Haven't had time to look at it yet, but can you check with Bug 16105 if that's
the same. If so, please attach everything to said bug.
My guess is that the xkb-core-xkb conversion breaks somehow again.
Cheers,
Peter
___
xorg mailing list
xorg@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/xorg
Re: [PATCH 0/4] xkb core-xkb conversion fixes
Hello Peter, sorry for late reply. Great,.. Works! I downported to the version of my distribution (1.5.2) and compiled a single patch out of it: http://linux.pengin.de/#keyboard Would be great to have it committed (if not already done). Cheers, Thomas On Tue, Dec 2, 2008 at 3:53 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Dec 02, 2008 at 04:45:19PM +1000, Peter Hutterer wrote: Thomas, here's the set of patches that appears to fix the problem. It's a combination of some bugs and insanity in the XKB protocol. Great. that didn't work out as planned. You need the following patches, in this order: xkb: ensure enough symbols for core Group1 replication. xkb: don't replicate past the number of groups we have. xkb: explicitly check for group replication in the core representation. xkb: don't treat groups with different no of symbols as identical. Cheers, Peter ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg
