Re: Blend modes take 3

2008-12-02 Thread Soeren Sandmann
Benjamin Otte [EMAIL PROTECTED] writes: On Tue, Nov 25, 2008 at 10:10 PM, Soeren Sandmann [EMAIL PROTECTED] wrote: - When mask is 0, there is no reason to read the source. - There is no reason to read the destination if the inverse combined src/mask is 0 Don't compilers

Re: Blend modes take 3

2008-11-25 Thread Benjamin Otte
On Tue, Nov 25, 2008 at 10:10 PM, Soeren Sandmann [EMAIL PROTECTED] wrote: - When mask is 0, there is no reason to read the source. - There is no reason to read the destination if the inverse combined src/mask is 0 Don't compilers take care of that? The code looks better to me if

Re: Blend modes take 3

2008-11-23 Thread Benjamin Otte
On Wed, Nov 19, 2008 at 7:00 PM, Soeren Sandmann [EMAIL PROTECTED] wrote: Hi Benjamin, Overall, the separable blend mode stuff looks good, except for the component alpha versions. New update pushed to my git branches of pixman/cairo. I've updated the separable blend modes according to your

Re: Blend modes take 3

2008-11-13 Thread Benjamin Otte
Hey, I've updated the patch again here at the hackfest, and as far as I'm concerned the patch can go in now. But I'd like you to ok it before I push it. We decided to prefix the non-seperable blend-modes with HSL to avoid the confusion with the SATURATE operator. Otherwise I've used the exact

Re: Blend modes take 3

2008-10-20 Thread Carl Worth
On Sun, 2008-10-19 at 01:54 +0200, Soeren Sandmann wrote: This sort of suggests that instead of adding all the PDF blend modes as separate operators, they could instead be given as modifiers to an existing operator. For example, you could then specify IN and MULTIPLY, and the result would be