Re: [PATCH xserver] xfixes: Remove the CursorCurrent array

2017-12-08 Thread Keith Packard
Alan Hourihane writes: > But I've gone ahead and tested your fix, and it works too. So I'm fine > with this. Awesome, thanks for your review! -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org:

Re: X is consuming ~100 GiB of RAM(!)

2017-12-08 Thread Ewen Chan
Hi-Angel: Actually, I tried running it with SLES12 SP2 (which would have a newer kernel than SLES12 SP1) and the analysis software actually failed to run in SLES12 SP2. Tried it (not for this issue, just in general). Didn't work. The analysis software is not certified to run in SLES12 SP2,

Re: [PATCH xserver] xfixes: Remove the CursorCurrent array

2017-12-08 Thread Alan Hourihane
On 08/12/17 17:04, Alan Hourihane wrote: > On 08/12/17 16:57, Adam Jackson wrote: >> On Fri, 2017-12-08 at 09:41 +, Alan Hourihane wrote: >>> On 08/06/17 22:51, Keith Packard wrote: Adam Jackson writes: > We're not wrapping all the ways a cursor can be

Re: [PATCH xserver] xfixes: Remove the CursorCurrent array

2017-12-08 Thread Alan Hourihane
On 08/12/17 16:57, Adam Jackson wrote: > On Fri, 2017-12-08 at 09:41 +, Alan Hourihane wrote: >> On 08/06/17 22:51, Keith Packard wrote: >>> Adam Jackson writes: >>> We're not wrapping all the ways a cursor can be destroyed, so this array ends up with stale data.

Re: [PATCH xserver] xfixes: Remove the CursorCurrent array

2017-12-08 Thread Adam Jackson
On Fri, 2017-12-08 at 09:41 +, Alan Hourihane wrote: > On 08/06/17 22:51, Keith Packard wrote: > > Adam Jackson writes: > > > > > We're not wrapping all the ways a cursor can be destroyed, so this array > > > ends up with stale data. Rather than try harder to wrap more code

Re: [PATCH xserver] os: Fix strtok/free crash in ComputeLocalClient

2017-12-08 Thread Michel Dänzer
On 2017-12-07 11:19 AM, walter harms wrote: > Am 06.12.2017 12:16, schrieb Tomasz Śniatowski: >> Don't reuse cmd for strtok output to ensure the proper pointer is >> freed afterwards. >> >> The code incorrectly assumed the pointer returned by strtok(cmd, ":") >> would always point to cmd. However,

Re: [PATCH] XFixes: Fix cursor reference when calling, XFixesGetCursorImage or XFixesGetCursorImageAndName.

2017-12-08 Thread Alan Hourihane
[v3] No need to check for NULL, FreeCursor deals with that and this matches dix. XFixes: Fix cursor reference when calling, XFixesGetCursorImage or XFixesGetCursorImageAndName. These two calls save a pointer to the current cursor during DisplayCursor(), but the cursor can be destroyed leaving a

Re: [PATCH xserver] xfixes: Remove the CursorCurrent array

2017-12-08 Thread Alan Hourihane
On 08/06/17 22:51, Keith Packard wrote: > Adam Jackson writes: > >> We're not wrapping all the ways a cursor can be destroyed, so this array >> ends up with stale data. Rather than try harder to wrap more code paths, >> just look up the cursor when we need it. > I'm pretty sure

Re: X is consuming ~100 GiB of RAM(!)

2017-12-08 Thread Hi-Angel
On 7 December 2017 at 19:22, Ewen Chan wrote: > Pros (for Linux): It's faster when it is running at runlevel 3. Oh, by the way, I forgot to mention — just a tiny detail you might be curious of. I'm pretty sure you're running some old kernel, however in every kernel release