Re: [PATCH] VidMode: prevent crash with no modes

2011-01-24 Thread Chris Wilson
On Mon, 24 Jan 2011 11:20:12 +, Chris Wilson ch...@chris-wilson.co.uk wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=14731 Having just hit this myself, I'd like to get this trivial patch reviewed and included in the rc. :) -Chris -- Chris Wilson, Intel Open Source

Re: EVIOC mechanism for MT slots

2011-01-20 Thread Chris Bagwell
during start up of applications it would be really useful to query pre-existing ABS_MT_TRACKING_ID so that user doesn't have to lift object/hand/whatever before application starts working. Chris Original Message Subject:        Re: [PATCH 0/2] input: mt: Add EVIOC mechanism for MT

Re: [PATCH] ClickPad support v4

2011-01-08 Thread Chris Bagwell
On Fri, Jan 7, 2011 at 8:19 PM, AIC a...@hi.t-com.hr wrote: Chris Bagwell ch...@... writes: Synaptics Touchpad, model: 1, fw: 7.4, id: 0x1e0b1, caps: 0xd04731/0xe4/0x5a0400 Can you clarify what you mean about not detecting?  Do you mean not detected as clickpad? Yes, I have read

Re: [PATCH] ClickPad support v4

2011-01-06 Thread Chris Bagwell
. Thanks, Chris ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] ClickPad support v4

2010-12-28 Thread Chris Bagwell
On Tue, Dec 28, 2010 at 8:54 PM, Yan Li yan.i...@intel.com wrote: On Tue, 2010-12-28 at 02:18 +0800, Chris Bagwell wrote: On Sat, Dec 18, 2010 at 9:50 PM, Matt Rogers ma...@kde.org wrote: This is the use case that I prefer, and at least for me, the one causing the most issues. The fact

Re: [PATCH] ClickPad support v4

2010-12-28 Thread Chris Bagwell
On Tue, Dec 28, 2010 at 9:17 PM, Yan Li yan.i...@intel.com wrote: On Tue, 2010-12-28 at 05:04 +0800, Chris Bagwell wrote: Since xf86-input-synaptics 1.3.0 handles (X,Y) jumps during finger transitions, if clickpad users set their EmulateTwoFingerMinW to 5 I suspect they will see a lot less big

Re: [PATCH] ClickPad support v4

2010-12-27 Thread Chris Bagwell
On Sat, Dec 18, 2010 at 9:50 PM, Matt Rogers ma...@kde.org wrote: On Sat, Dec 18, 2010 at 11:38 AM, Chris Bagwell ch...@cnpbagwell.com Thank for detailed reply.  Do you mind helping me understand how touchpad is being used when jumps occur?  Is use case: * Move cursor to area you want

Re: [PATCH] ClickPad support v4

2010-12-27 Thread Chris Bagwell
On Sat, Dec 25, 2010 at 12:48 PM, Kevin O'Connor ke...@koconnor.net wrote: Hi Chris, I noticed this message on the xorg-devel mailing list: Thank for detailed reply.  Do you mind helping me understand how touchpad is being used when jumps occur?  Is use case: * Move cursor to area you

Re: [PATCH evdev 3/3] Add use_proximity bit for BTN_TOOL handling.

2010-12-20 Thread Chris Bagwell
BTN_TOOL_FINGER right now but that will change I think. Chris On Mon, Dec 20, 2010 at 7:21 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Touchpads send garbage data between BTN_TOOL_FINGER and BTN_TOUCH. This leads to cursor movement towards invalid positions (bottom left corner, usually). Add

Re: [PATCH evdev 3/3] Add use_proximity bit for BTN_TOOL handling.

2010-12-20 Thread Chris Bagwell
On Mon, Dec 20, 2010 at 9:28 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, 20 Dec 2010 20:38:30 -0600, Chris Bagwell ch...@cnpbagwell.com wrote: I ack on patch concept.  Its easy to see this invalid data on synaptics hardware and needs to be accounted for. I'm not up on current

Re: [PATCH] ClickPad support v4

2010-12-18 Thread Chris Bagwell
On Sat, Dec 18, 2010 at 7:17 AM, Yan Li yan.i...@intel.com wrote: On Sat, 2010-12-18 at 03:18 +0800, Chris Bagwell wrote: OK, I've re-reviewed patch and I've decided I understand what its trying to do now.  Most my original comments still apply but I've added new ones. First, I need

Re: [PATCH] ClickPad support v4

2010-12-17 Thread Chris Bagwell
@@ HandleState(LocalDevicePtr local, struct SynapticsHwState *hw)     if (para-touchpad_off == 1)        return delay; +    edge = edge_detection(priv, hw-x, hw-y); + This needs the if (inside_active_area) check to keep definition in man page of Area*Edge. Thats all for now. Chris

[PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2010-12-10 Thread Chris Wilson
Although there may be more than one resource handles pointing to the Drawable, we only want to destroy it once and only reference the resource which may have just been deleted on the first instance. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Kristian Høgsberg k...@bitplanet.net Cc

[PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2010-12-10 Thread Chris Wilson
://bugs.freedesktop.org/show_bug.cgi?id=28181 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Kristian Høgsberg k...@bitplanet.net Cc: Michel Dänzer daen...@vmware.com --- glx/glxcmds.c | 23 +++ glx/glxdrawable.h |3 +++ glx/glxext.c | 15 ++- 3 files changed

Re: [PATCH] ClickPad support v4

2010-12-09 Thread Chris Bagwell
SynapticsHwState *hw)     if (para-touchpad_off == 1)        return delay; +    edge = edge_detection(priv, hw-x, hw-y); Should this be protected by if() that it was in below? Chris + +    /* Clickpad handling for button area */ +    if (priv-is_clickpad) +       HandleClickpad(local, hw, edge

Re: [PULL modular] Assorted updates.

2010-12-07 Thread Chris Wilson
be pretty useless for me to try to review these changes... Anyone else care about jhbuild these days? I use it and the xorg.modules on my boxes to rebuild the stack. But I think Cyril just volunteered to maintain it. ;-) -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: rendercheck segfaults [Re: rendercheck: 10 commits]

2010-12-01 Thread Chris Wilson
because height=0 and it crashes at the bottom of the loop because it tries to XDestroyImage(NULL). And I thought I had covered my bases by looking at the combinations of formats offered by the Xorg. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: rendercheck segfaults [Re: rendercheck: 10 commits]

2010-12-01 Thread Chris Wilson
of blend and composite that I tested with windows both larger and smaller than num_src. Cheers, -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: rendercheck segfaults [Re: rendercheck: 10 commits]

2010-12-01 Thread Chris Wilson
On Wed, 1 Dec 2010 13:57:15 -0800, Aaron Plattner aplatt...@nvidia.com wrote: On Wed, Dec 01, 2010 at 01:47:47PM -0800, Chris Wilson wrote: On Wed, 1 Dec 2010 13:06:47 -0800, Aaron Plattner aplatt...@nvidia.com wrote: This series causes a segmentation fault in blend_test because the loop

Re: [RFC] Multi-Touch (MT) support - arbitration or not

2010-11-10 Thread Chris Bagwell
On Tue, Nov 9, 2010 at 10:46 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Nov 08, 2010 at 10:14:56PM -0600, Chris Bagwell wrote: I've copied #2 below and added my own text in [] to be sure and clarify text in context of case #2. 2.     Report first finger touch as ABS_X/Y

Re: [RFC] Multi-Touch (MT) support - arbitration or not

2010-11-09 Thread Chris Bagwell
update MT interface so you can have per slot values for clients to query (or MT logic automatically scales for driver as another option). Then slots 0-1 are reserved for touch and slot 3 is reserved for pen. Chris ___ xorg-devel@lists.x.org: X.Org

Re: [RFC] Multi-Touch (MT) support - arbitration or not

2010-11-08 Thread Chris Bagwell
not really give a personal opinion. My opinion is likely to change as we make individual decisions. Chris ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH x11proto] Add XF86XK_TouchpadOn/Off

2010-11-08 Thread Chris Bagwell
to align with them we need to update below value from xkeyboard-config's inet + synchronized udev release to prevent breakage of existing feature. key FK22 { [ XF86TouchpadToggle] }; Chris ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH x11proto] Add XF86XK_TouchpadOn/Off

2010-11-08 Thread Chris Bagwell
On Mon, Nov 8, 2010 at 4:37 PM, Bastien Nocera had...@hadess.net wrote: On Mon, 2010-11-08 at 16:32 -0600, Chris Bagwell wrote: On Sun, Nov 7, 2010 at 11:24 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Patch is fine with me. any NAKs? The udev patch to standardise the behaviour

Re: [RFC] Multi-Touch (MT) support - arbitration or not

2010-11-08 Thread Chris Bagwell
On Mon, Nov 8, 2010 at 9:31 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Nov 08, 2010 at 03:54:51PM -0600, Chris Bagwell wrote: I think we may be mixing some topics and so I'd like to try to re-frame the discussion. There are two different cases and they may have different

Re: [PATCH x11proto] Add XF86XK_TouchpadOn/Off

2010-11-08 Thread Chris Bagwell
On Mon, Nov 8, 2010 at 9:42 PM, Bastien Nocera had...@hadess.net wrote: On Mon, 2010-11-08 at 21:17 -0600, Chris Bagwell wrote: On Mon, Nov 8, 2010 at 4:37 PM, Bastien Nocera had...@hadess.net wrote: On Mon, 2010-11-08 at 16:32 -0600, Chris Bagwell wrote: On Sun, Nov 7, 2010 at 11:24 PM

Re: [RFC] Multi-Touch (MT) support - arbitration or not

2010-11-06 Thread Chris Bagwell
the touchpad can currently be re-routed to xf86-input-synaptics. Chris ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

xserver default modes and arcade monitors

2010-11-02 Thread Chris Kennedy
to be done about the default modes so they aren't in there when a user has a monitor they need to completely send custom modelines to and knows what they are. Thanks, Chris -- Chris Kennedy c...@groovy.org ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 10/18] Add multi-touch support

2010-10-14 Thread Chris Bagwell
is working. Also, I'm sure you've already thought about issue when we add ABS_X/ABS_Y reports back into MT-mode. Unless we are able to make ABS_X/ABS_Y always the preferred values on kernel side then we'll need some flag above to say we are in MT mode and to ignore ST values. Chris

Re: [PATCH 12/18] Add pinch gesture support

2010-10-14 Thread Chris Bagwell
in later patch? Especially in 3 finger that is V pattern as well. Chris ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 07/18] Allow touching in clickpad button area

2010-10-13 Thread Chris Bagwell
are sending MT events, should there be any strict rules on how BTN_TOOL_DOUBLETAP behave. For example, if kernel filtered out ABS_X/ABS_Y events during clickpad button press should it also set BTN_TOOL_DOUBLETAP to 0? Even if its sending MT reports for both fingers? Chris

Re: [PATCH evdev v2] Add proximity support.

2010-10-12 Thread Chris Bagwell
Reviewed-by: Chris Bagwell ch...@cnpbagwell.com I'm not up to speed with queuing in evdev driver. Mostly I was concentrating EvdevProcessProximityState() and looked like it covers all cases. Chris On Tue, Oct 12, 2010 at 8:44 PM, Peter Hutterer peter.hutte...@who-t.net wrote: When one

Re: [PATCH 0/3] Input: synaptics - multitouch and multifinger support

2010-10-11 Thread Chris Bagwell
transition of multi-touch occur (both adding or removing fingers via BTN_TOOL_*TAP). So one new-ish option is for ABS_X/ABS_Y to not track 1st finger but become average of 2 fingers. Chris ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 3/3] Input: synaptics - remove touches over button click area

2010-10-11 Thread Chris Bagwell
takes but not sure from only quick review. Chris ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 08/18] Avoid unexpected jumps

2010-10-11 Thread Chris Bagwell
=a6ca4d2523904b7ce49edc29ba408979bdf0d45e Chris Signed-off-by: Takashi Iwai ti...@suse.de ---  src/synaptics.c    |   10 ++  src/synapticsstr.h |    1 +  2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index 3ba918a..bd52730 100644 --- a/src/synaptics.c +++ b

Re: [PATCH 3/3] Input: synaptics - remove touches over button click area

2010-10-11 Thread Chris Bagwell
On Mon, Oct 11, 2010 at 12:10 PM, Takashi Iwai ti...@suse.de wrote: At Mon, 11 Oct 2010 11:24:04 -0500, Chris Bagwell wrote: On Fri, Oct 8, 2010 at 9:58 AM, Chase Douglas chase.doug...@canonical.com wrote: Now that we have proper multitouch support, we can handle integrated buttons better

Re: [PATCH evdev 3/3] Add handling for tablets that do not send axes with tools (#29645)

2010-10-11 Thread Chris Bagwell
Reviewed-by: Chris Bagwell ch...@cnpbagwell.com Hmmm, guess xf86-input-wacom would need similar logic to handle same non-wacom tablets. But then again with this series of changes xf86-input-evdev may be better choice for 1 tool tablets. Chris On Sun, Oct 10, 2010 at 6:33 PM, Peter Hutterer

Re: [PATCH evdev 1/3] Rename evdev-tool to evdev-proximity.

2010-10-11 Thread Chris Bagwell
Reviewed-by: Chris Bagwell ch...@cnpbagwell.com On Sun, Oct 10, 2010 at 6:33 PM, Peter Hutterer peter.hutte...@who-t.net wrote: evdev doesn't care about the actual tool used, only that it is used as an indicator for proximity. Rename the field accordingly to make the code more obvious to read

Re: [PATCH 1/3] Input: synaptics - add multitouch support

2010-10-10 Thread Chris Bagwell
-multitouch) + input_mt_sync(dev); This mt_sync would seem more nature to be sent after ABS_MT_PRESSURE to match MT packet processing. Chris input_sync(dev); } @@ -605,6 +657,14 @@ static void set_input_params(struct input_dev *dev, struct synaptics_data *priv

Re: [PATCH 1/3] Input: synaptics - add multitouch support

2010-10-10 Thread Chris Bagwell
-multitouch) + input_mt_sync(dev); This mt_sync would seem more nature to be sent after ABS_MT_PRESSURE to match MT packet processing. Chris input_sync(dev); } @@ -605,6 +657,14 @@ static void set_input_params(struct input_dev *dev, struct synaptics_data *priv

Re: [PATCH 2/3] Input: synaptics - add multitouch multifinger support

2010-10-10 Thread Chris Bagwell
On 10/08/2010 09:57 AM, Chase Douglas wrote: Newer multitouch Synaptics trackpads do not advertise multifinger support. Now that we have multitouch support, we can use the number of touches to report multifinger functionality. In conjunction with the X synaptics input module, this enables

Re: [PATCH 3/3] Input: synaptics - remove touches over button click area

2010-10-10 Thread Chris Bagwell
the logic from kernel side that maps HW's middle button to left button. It seems just limping a long with single button support anyways. I haven't had time to review Takashi's xf86-input-synaptics patches just sent yet but seems along this line of thinking as well. Chris

[PATCH] xfree86: Fix regression from ab7f057 on LoaderOpen failure

2010-10-08 Thread Chris Wilson
In ab7f057 LoaderOpen was changed to return a NULL pointer instead of -1 in case of failure. However, one callsite was overlooked during the conversion. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Adam Jackson a...@redhat.com --- hw/xfree86/loader/loadmod.c |2 +- 1 files

[PATCH] xfree86: Do not call dlclose(NULL) [regression after ab7f057]

2010-10-03 Thread Chris Wilson
During unwind following an error when attempting to a load a module, we attempt to call dlclose on a potentially NULL handle. This is a side-effect of removing the abstraction layer in ab7f057. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: ab7f057ce9df4e905b12cebc1e587b9a7f200418

[PATCH] xfree86: Do not call dlclose(NULL) [regression after ab7f057]

2010-10-03 Thread Chris Wilson
During unwind following an error when attempting to a load a module, we attempt to call dlclose on a potentially NULL handle. This is a side-effect of removing the abstraction layer in ab7f057. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Adam Jackson a...@redhat.com --- hw/xfree86

Trivial fixes to allow the driver to switch root pixmaps

2010-09-27 Thread Chris Wilson
A third iteration of the patches to fix a couple of segfaults should the driver tweak the root pixmap whilst resizing the framebuffer. In this iteration, the removal of the pixmapPrivate is squashed with the workaround as nobody argued for its continued existence. Please review and test! -Chris

[PATCH 1/2] modes: Beware the driver switching root pixmaps

2010-09-27 Thread Chris Wilson
-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Julien Cristau jcris...@debian.org Tested-by: Julien Cristau jcris...@debian.org Cc: Keith Packard kei...@keithp.com Reviewed-by: Keith Packard kei...@keithp.com --- hw/xfree86/modes/xf86RandR12.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH 2/2] xfree86: Kill pixmapPrivate with a vengeance

2010-09-27 Thread Chris Wilson
ScrnInfo-pixmapPrivate only existed in order to catch invalid access to the framebuffer by making the backing data NULL across the VT switch. This was causing more confusion in the higher layers during mode setting without any real benefit, so remove it. Signed-off-by: Chris Wilson ch...@chris

[PATCH] xfree86: Kill pixmapPrivate with a vengeance (v2)

2010-09-27 Thread Chris Wilson
() as well. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Julien Cristau jcris...@debian.org Cc: Andrew Guertin li...@dolphinling.net --- hw/xfree86/common/xf86Helper.c | 11 hw/xfree86/common/xf86str.h|1 - hw/xfree86/modes/xf86RandR12.c |9 --- hw/xfree86/shadowfb

Re: [PATCH v2] glx: Fix use after free in DrawableGone

2010-09-23 Thread Chris Wilson
On Thu, 23 Sep 2010 09:04:11 -0400, Kristian Høgsberg k...@bitplanet.net wrote: Signed-off-by: Kristian Høgsberg k...@bitplanet.net Now that is starting to look familiar ;-) Reported-by: Julien Cristau jcris...@debian.org Tested-by: Chris Wilson ch...@chris-wilson.co.uk -- Chris Wilson

Updating the screen pixmap across mode change

2010-09-14 Thread Chris Wilson
to workaround it. The third patch does that and could be squashed with the second if nobody sees the value in keep the sanity check of a NULL dereference for the framebuffer across VT switch. -Chris ___ xorg-devel@lists.x.org: X.Org development Archives: http

[PATCH 1/3] modes: Beware the driver switching root pixmaps

2010-09-14 Thread Chris Wilson
-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Julien Cristau jcris...@debian.org Tested-by: Julien Cristau jcris...@debian.org Cc: Keith Packard kei...@keithp.com Reviewed-by: Keith Packard kei...@keithp.com --- hw/xfree86/modes/xf86RandR12.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH 2/3] modes: Update pixmapPrivate after driver-resize() calls ModifyPixmapHeader

2010-09-14 Thread Chris Wilson
As with xf86SwitchMode(), if the driver modifies the Screen pixmap header in the course of resizing the framebuffer, this change needs to be propagated to the ScrnInfo-pixmapPrivate or else the pixmap header will be overwritten by xf86EnableDisableFBAccess(). Signed-off-by: Chris Wilson ch

[PATCH 3/3] xfree86: Kill pixmapPrivate with a vengeance

2010-09-14 Thread Chris Wilson
ScrnInfo-pixmapPrivate only existed in order to catch invalid access to the framebuffer by making the backing data NULL across the VT switch. This was causing more confusion in the higher layers during mode setting without any real benefit, so remove it. Signed-off-by: Chris Wilson ch...@chris

[PATCH] modes: Update pixmapPrivate after driver-resize() calls ModifyPixmapHeader

2010-09-10 Thread Chris Wilson
As with xf86SwitchMode(), if the driver modifies the Screen pixmap header in the course of resizing the framebuffer, this change needs to be propagated to the ScrnInfo-pixmapPrivate or else the pixmap header will be overwritten by xf86EnableDisableFBAccess(). Signed-off-by: Chris Wilson ch

[PATCH] randr: Beware the driver switching root pixmaps

2010-08-30 Thread Chris Wilson
-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Julien Cristau jcris...@debian.org --- hw/xfree86/modes/xf86RandR12.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c index 043ceee..c17b5fa 100644 --- a/hw

Current tinderbox regression (xauth, Linux)

2010-08-26 Thread Chris Ball
://cgit.freedesktop.org/xorg/app/xauth/commit/?id=135338af9a141d609e07e42208b9104465346ae4 -- Chris Ball c...@laptop.org One Laptop Per Child ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: Current tinderbox regression (xauth, Linux)

2010-08-26 Thread Chris Ball
); lots of other projects do that. - Chris. -- Chris Ball c...@laptop.org One Laptop Per Child ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: Synaptics style multi-touch and cursor jumps

2010-08-20 Thread Chris Bagwell
On Wed, Aug 18, 2010 at 10:03 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Suggested xf86-input-synaptics behaviour change: Its not a terrible problem but I think could stand to be improved.  I propose following change to help further get rid of jumps: Start tracking previous finger count

Re: [PATCH synaptics 1/2] Added friction physics so coasting can stop on its own.

2010-08-19 Thread Chris Bagwell
On Thu, Aug 19, 2010 at 8:13 PM, Peter Hutterer peter.hutte...@who-t.net wrote: From: Patrick Curran pjcur...@wisc.edu When you are coasting (but not corner coasting) you might want the scrolling to slow down and stop on its own.  This also lets you start coasting while using a two finger

[PATCH] xace: Invalid reference to out-of-scope data.

2010-08-10 Thread Chris Wilson
SEGV during XFixesGetCursorImage() https://bugs.freedesktop.org/show_bug.cgi?id=18451 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- Xext/xace.c | 170 +++ hw/xfree86/modes/xf86Crtc.c |8 ++- 2 files changed, 82 insertions

[PATCH] xace: Invalid reference to out-of-scope data.

2010-08-10 Thread Chris Wilson
SEGV during XFixesGetCursorImage() https://bugs.freedesktop.org/show_bug.cgi?id=18451 v2: Drop the unrelated hunk that snuck in when ammending the commit message. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- Xext/xace.c | 170

[PATCH] [RFC] xf86Crtc: Trust the drivers to report the correct output modes

2010-08-05 Thread Chris Wilson
world) between the kernel and X over valid modes. References: Bug 23833 - X uses different refresh rate to that set by kernel module https://bugs.freedesktop.org/show_bug.cgi?id=23833 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86/modes/xf86Crtc.c | 264

Re: [Intel-gfx] xf86-video-intel: configure.ac

2010-07-28 Thread Chris Wilson
From memory, I think this is just a bit of idiocacy in the driver inappropriately using a GL type, i.e. for a variable unconnected with any of the GL interfaces. -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH video-intel] simplify Makefile as per-target compilation flags are not needed

2010-07-24 Thread Chris Wilson
? -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH v2 video-intel] simplify Makefile as per-target compilation flags are not needed

2010-07-24 Thread Chris Wilson
, as there is only one. Signed-off-by: Gaetan Nadon mems...@videotron.ca Thanks for the explanation. Acked-by: Chris Wilson ch...@chris-wilson.co.uk -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH] Synchronize list macros with xf86-video-intel

2010-07-13 Thread Chris Wilson
On Tue, 13 Jul 2010 11:11:42 +0100, Magnus Kessler magnus.kess...@gmx.net wrote: Commit 5de1b74d64f807b59c730871d4cb171484db9780 in xf86-video-intel introduced a fix for the container_of macro. Port this fix over to xorg, to fix compilation failure of xf86-video-intel. Reviewed-by: Chris

Re: [PATCH] XWin: Fix for static libXfont use

2010-07-06 Thread Chris Ball
symbols). This produces a libXfont which might only be useful to the xserver, but the only other user we might care about is xfs, which is obsolete... Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk Ping: can we get a fix pushed? This is still affecting the cygwin build. Thanks, - Chris

[PATCH] fb: Trim fill to drawable bounds

2010-07-02 Thread Chris Wilson
Fixes: Bug 27313 - random X11 crash (SIGSEGV) when rendering firefox in pixman/intel https://bugs.freedesktop.org/show_bug.cgi?id=27313 As pixman does not guard against a fill request outside of the buffer, we must be be careful and trim oversized fills. Signed-off-by: Chris Wilson ch

[PATCH] fb: Trim fill to drawable bounds

2010-07-02 Thread Chris Wilson
Fixes: Bug 27313 - random X11 crash (SIGSEGV) when rendering firefox in pixman/intel https://bugs.freedesktop.org/show_bug.cgi?id=27313 As pixman does not guard against a fill request outside of the buffer, we must be be careful and trim oversized fills. Signed-off-by: Chris Wilson ch

Re: [PATCH] fb: Trim fill to drawable bounds

2010-07-02 Thread Chris Wilson
On 02 Jul 2010 17:19:18 +0200, Soeren Sandmann sandm...@daimi.au.dk wrote: Chris Wilson ch...@chris-wilson.co.uk writes: Fixes: Bug 27313 - random X11 crash (SIGSEGV) when rendering firefox in pixman/intel https://bugs.freedesktop.org/show_bug.cgi?id=27313 As pixman does

Current tinderbox regression (xserver, OS X)

2010-06-30 Thread Chris Ball
http://tinderbox.x.org/builds/2010-06-30-0016/logs/xserver/#configure configure: error: Package requirements (glproto = 1.4.10 gl = 7.1.0) were not met: No package 'gl' found -- Chris Ball c...@laptop.org One Laptop Per Child ___ xorg-devel

Current tinderbox regression (xserver, cygwin)

2010-06-26 Thread Chris Ball
to: http://cgit.freedesktop.org/xorg/xserver/commit/?id=75536ee80595c79bba95a1fb6844126ee08486d4 -- Chris Ball c...@laptop.org One Laptop Per Child ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

[PATCH 1/3] xgi: Compile fix: guard XF86_VERSION_CURRENT with ifdef

2010-06-25 Thread Chris Ball
--- src/xgi.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/xgi.h b/src/xgi.h index 72f47d7..fd2c6fa 100755 --- a/src/xgi.h +++ b/src/xgi.h @@ -198,9 +198,11 @@ extern BOOL g_bRunTimeDebug; #define XGINEWDRI #undef XGINEWDRI2 +#ifdef XF86_VERSION_CURRENT #if

[PATCH 2/3] xgi: Compile fix: f2b97df.. incorrectly removed micmap.h instead of mibank.h

2010-06-25 Thread Chris Ball
--- src/xgi_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xgi_driver.c b/src/xgi_driver.c index ccf01a3..5d75647 100755 --- a/src/xgi_driver.c +++ b/src/xgi_driver.c @@ -52,7 +52,7 @@ #define PACKAGE_VERSION_PATCHLEVEL 6803 #include fb.h -#include

[PATCH 3/3] xgi: Compile fix: XSERVER_LIBPCIACCESS guards

2010-06-25 Thread Chris Ball
--- src/xgi_driver.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/xgi_driver.c b/src/xgi_driver.c index 5d75647..b4f83b8 100755 --- a/src/xgi_driver.c +++ b/src/xgi_driver.c @@ -2769,7 +2769,11 @@ XGIPreInit(ScrnInfoPtr pScrn, int flags)

[PATCH] glx: Prevent NULL context deref in __glXGetDrawable()

2010-06-24 Thread Chris Wilson
During a SwapBuffers request, we may end up querying an unknown drawable outside of an active context, and so need to report this error prior to attempting to dereference the NULL context. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Kristian Høgsberg k...@bitplanet.net --- glx

Tinderbox failure: xcb-util distcheck

2010-06-24 Thread Chris Ball
/test_bitmap.c:113: error: 'test_width' undeclared ../../image/test_bitmap.c:114: error: 'test_height' undeclared ../../image/test_bitmap.c:146: error: 'test_bits' undeclared Any ideas? Thanks, - Chris. -- Chris Ball c...@laptop.org One Laptop Per Child

Re: [cairo] [PATCH] Conical gradients with pixman with rotation

2010-06-23 Thread Chris Wilson
Hi Marco, as you seem to be the very first user of conical gradients, do you mind presenting your use case? It looks like we should be extending gradients to cover type 6/7 in the near future, and we may as well expose conical gradients in the Cairo API at the same time. -ickle -- Chris Wilson

Re: tinderbox configuration

2010-06-23 Thread Chris Ball
/cjb/xorg-git/xorg/lib/libXmu/libXmu-1.0.5/_build/doc/../../../doc/Xmu.xsl instead of: /home/cjb/xorg-git/xorg/lib/libXmu/libXmu-1.0.5/_build/doc/../../doc/Xmu.xsl Could someone fix? Thanks, - Chris. -- Chris Ball c...@laptop.org One Laptop Per Child

Re: [PATCH] Use new server API to find the root window.

2010-06-22 Thread Chris Ball
building on a 64-bit system. Thanks! We'll see whether it still builds on the next tinderbox run. By the way, Chris, why is the x86 tinderbox processing xcb a second time at the end? It's running libxcb's make check at that point, along with the other runtime tests. I should use a different

Re: [PATCH] Use new server API to find the root window.

2010-06-12 Thread Chris Ball
-root; +#endif if (! ValidAtom(VFB_PROP)) VFB_PROP = MakeAtom(VFB_PROP_NAME, strlen(VFB_PROP_NAME), 1); -- 1.7.0 -- Chris Ball c...@laptop.org One Laptop Per Child ___ xorg-devel@lists.x.org: X.Org development Archives

Re: [Xorg-driver-geode] [PATCH 4/7] Put the one pixel drawing work to the server to handle

2010-06-10 Thread Chris Ball
context is more important in this case. - Chris. -- Chris Ball c...@laptop.org One Laptop Per Child ___ Xorg-driver-geode mailing list Xorg-driver-geode@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-geode

Re: [Xorg-driver-geode] First patch for you review

2010-06-09 Thread Chris Ball
understand that it's better to have too many than too few. :-) - Chris. -- Chris Ball c...@laptop.org One Laptop Per Child ___ Xorg-driver-geode mailing list Xorg-driver-geode@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-geode

Re: [Xorg-driver-geode] Patches for rendering

2010-06-08 Thread Chris Ball
, with one e-mail per patch? git-send-email will send the patches in this way, if you're able to use that. - Chris. -- Chris Ball c...@laptop.org One Laptop Per Child ___ Xorg-driver-geode mailing list Xorg-driver-geode@lists.x.org http://lists.x.org/mailman

Re: Who can explain the diff between Xserver-1.6.4 version and 1.7 version about the ExaGetPixmapAddress?

2010-06-08 Thread Chris Ball
Hi, Who can explain the change? Why del the the part of sys_ptr in 1.7 version? git blame/git log shows that Maarten introduced the change, so CCing him. http://cgit.freedesktop.org/xorg/xserver/commit/?id=ac7ac913fd98ea359c05c89968ab53a3223615b4 - Chris. -- Chris Ball c

Re: [cairo] [PATCH] access: Hook in abort if we find no matching pixel/scanline accessors.

2010-05-31 Thread Chris Wilson
On 31 May 2010 19:00:43 +0200, Soeren Sandmann sandm...@daimi.au.dk wrote: (But please also copy pix...@lists.freedesktop.org on pixman patches). My apologies, I had forgotten entirely about the separate list for pixman! -ickle -- Chris Wilson, Intel Open Source Technology Centre

[PATCH] access: Hook in abort if we find no matching pixel/scanline accessors.

2010-05-30 Thread Chris Wilson
Some paranoid defense to more easily catch should not happen conditions from within gdb. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- pixman/pixman-access.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/pixman/pixman-access.c b/pixman/pixman-access.c

Re: xf86-video-intel: 2 commits - src/i830_dri.c src/i830.h src/i830_uxa.c src/i915_render.c

2010-05-29 Thread Chris Wilson
On Sat, 29 May 2010 12:20:30 +0200, Michel Dänzer mic...@daenzer.net wrote: On Sam, 2010-05-29 at 02:42 -0700, Chris Wilson wrote: commit 44d45d3fa56f121ce89ffe5b28beb48be01a95df Author: Chris Wilson ch...@chris-wilson.co.uk Date: Sat May 29 10:39:28 2010 +0100 dri: Use size

Re: xf86-video-intel: 2 commits - src/i830_dri.c src/i830.h src/i830_uxa.c src/i915_render.c

2010-05-29 Thread Chris Wilson
On Sat, 29 May 2010 13:03:40 +0200, Michel Dänzer mic...@daenzer.net wrote: On Sam, 2010-05-29 at 11:47 +0100, Chris Wilson wrote: On Sat, 29 May 2010 12:20:30 +0200, Michel Dänzer mic...@daenzer.net wrote: On Sam, 2010-05-29 at 02:42 -0700, Chris Wilson wrote: commit

[PATCH] xfree86: Unbreak autoconfig following 0abf065e38c4

2010-05-27 Thread Chris Wilson
The move of the PCI device id probing into a separate file neglected to return the number of found devices, and so the PCI devices were being overwritten by the default entries for vesa and fbdev. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Tiago Vignatti tiago.vigna...@nokia.com Cc

[PATCH] xfree86: Unbreak autoconfig following 0abf065e38c4

2010-05-26 Thread Chris Wilson
The move of the PCI device id probing into a separate file neglected to return the number of found devices, and so the PCI devices were being overwritten by the default entries for vesa and fbdev. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Tiago Vignatti tiago.vigna...@nokia.com Cc

Re: [PATCH] Re-enable RECORD extension.

2010-02-17 Thread Chris Dekter
On 12 February 2010 08:16, Tiago Vignatti vigna...@freedesktop.org wrote: On Thu, 2010-02-11 at 16:34 +1000, Peter Hutterer wrote: From: Chris Dekter cdek...@gmail.com RECORD was disabled during the switch to internal events. This patch modifies the record callback to work with internal

ATI Rage Mobility P/M - Mach64 kernel module source - is it available anywhere?

2010-01-14 Thread Chris Jones
$ lspci | grep VGA [..] ATI Technologies Inc Rage Mobility P/M AGP 2x (rev 64) I have unsuccessfully attempted to enable direct rendering for this card on a number of occasions over the last 3-4 years. I decided to give it another try last weekend and saw the following in Xorg.0.log: | [drm]

Re: ATI Rage Mobility P/M - Mach64 kernel module source - is it available anywhere?

2010-01-14 Thread Chris Jones
On Thu, Jan 14, 2010 at 04:20:14AM EST, Dave Airlie wrote: I found a couple of well-documented posts relative to this issue, which indicate that the source was recently removed from the mesa/drm tree at anongit.freedesktop.org and is now available in the kernel tree under drivers/gpu/drm

Re: tinderbox xclock checkout failure

2009-11-13 Thread Chris Ball
Hi Florian, Hi, the xclock build fails currently with a checkout failure: Fixed now: http://tinderbox.x.org/builds/2009-11-14-0001/logs/xclock/ The tinderbox build needs quite a bit of love; I'll try to make time for getting everything green again in the next few days. Thanks, - Chris

Re: [cairo] Pixman glyph performance, and beyond!

2009-10-23 Thread Chris Wilson
of performance on the client (as in be faster than the CPU!), before it becomes an intriguing prospect of pushing to the server. So in the meantime, I'm trying to work out why the EXA/UXA drivers are so slow, and see what we can do to improve the current architecture. -ickle -- Chris Wilson, Intel

[PATCH] modes: Force output modes for manually enabled heads

2009-10-08 Thread Chris Wilson
modes for explicitly enabled outputs (and skip the probing for explicitly disabled outputs). Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Keith Packard kei...@keithp.com Cc: Dave Airlie airl...@redhat.com --- hw/xfree86/modes/xf86Crtc.c | 38 -- 1

[Xorg-driver-geode] Maintainership.

2009-02-14 Thread Chris Ball
introduction to some of my interests, I also maintain the Xorg tinderbox¹, and have recently been doing MPX² and multitouch work. Thanks, - Chris. ¹: http://tinderbox.x.org/ ²: http://blog.printf.net/articles/2009/01/26/multi-pointer-remote-desktop -- Chris Ball c...@laptop.org

Accelerating TFP for R200 - texture format Voodoo?

2007-06-19 Thread Chris Rankin
-base.firstLevel]-Width + 63) ~(63); else t-pp_txpitch = ((tObj-Image[0][t-base.firstLevel]-Width * texelBytes) + 63) ~(63); t-pp_txpitch -= 32; except that it's too different for me to just take an educated guess. Thanks, Chris

<    1   2   3   4   5   6   7   >