Re: [PATCH:xscope 04/24] Convert some for loops to use C99-style inline variable declarations

2012-09-03 Thread Daniel Stone
Hi, On 3 September 2012 21:39, Mark Kettenis mark.kette...@xs4all.nl wrote: I hope you don't mind that I won't repond to Daniel's somewhat childish remarks. While there may have been a little more levity than needed, there was a serious point. The last time your compiler was updated, Boris

Re: [PATCH:xscope 04/24] Convert some for loops to use C99-style inline variable declarations

2012-09-02 Thread Daniel Stone
Hi, On 1 September 2012 10:21, Alan Coopersmith alan.coopersm...@oracle.com wrote: I do wonder though about the viability of updating some parts of your system to 2012 releases while keeping others stuck at a 2001 release. I certainly don't try to build current X.Org releases on Solaris 8

Re: [PATCH:xscope 04/24] Convert some for loops to use C99-style inline variable declarations

2012-09-01 Thread Daniel Stone
Hi, On 1 September 2012 03:33, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 31 Aug 2012 22:17:46 -0700 Please don't do this. Some OpenBSD platforms are still stuck with GCC 2.95.3. GCC 2.95.3 is almost a C99 compiler, but

Re: [PATCH evdev] add button debouncing

2012-08-23 Thread Daniel Stone
Hi, On 23 August 2012 08:40, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Aug 13, 2012 at 05:47:12PM -0400, Matt Whitlock wrote: This patch adds one configuration option, DebounceDelay, and one XInput property, Evdev Debounce Delay. They refer to the amount of time to wait after

Re: [PATCH xorg-gtest 01/11] Add Red Hat copyright notices

2012-08-16 Thread Daniel Stone
Hi, On 16 August 2012 09:13, Mark Kettenis mark.kette...@xs4all.nl wrote: index 4da49fe..2e36349 100644 --- a/COPYING +++ b/COPYING @@ -1,4 +1,5 @@ Copyright (C) 2011, 2012 Canonical, Ltd. +Copyright © 2012 Red Hat, Inc. Do you really have to pollute more source files with non-ASCII

Re: [PATCH] glx: drop GLX_LIBS from X server and workaround sdksyms.

2012-07-25 Thread Daniel Stone
://bugs.freedesktop.org/show_bug.cgi?id=52402 Signed-off-by: Dave Airlie airl...@redhat.com glx_extinit.h wants a copyright header (lame, but eh), but aside from that: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 2/3] Restore extern to the declaration of __glXDRISWRastProvider

2012-07-25 Thread Daniel Stone
by the declaration, and not the proper one from glxdriswrast.c, presumably because nothing else references anything in the object that file generates. Crap. This is obviously correct. Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg

Re: [PATCH] Cache xkbcomp output

2012-07-20 Thread Daniel Stone
Hi, On 20 July 2012 06:05, Dan Nicholson dbn.li...@gmail.com wrote: On Jul 19, 2012 3:38 PM, Daniel Stone dan...@fooishbar.org wrote: A more sensible interim strategy (IMO) would be to always fork xkbcomp once during startup, preserve the resulting XkbDescRec, then hand that back every time

Re: [PATCH] Cache xkbcomp output

2012-07-19 Thread Daniel Stone
Hi, On 19 July 2012 21:33, Adam Jackson a...@nwnk.net wrote: I think there's a combination of factors that pile on to make it worse than you'd expect. Oh no, we're talking about totally different things here. When I said with xkbcommon rather than xkbcomp, I meant that this thing:

Re: [PATCH] Cache xkbcomp output

2012-07-19 Thread Daniel Stone
Hi, On 19 July 2012 22:53, Keith Packard kei...@keithp.com wrote: Adam Jackson a...@nwnk.net writes: I think there's a combination of factors that pile on to make it worse than you'd expect. And, caching is completely free, so it seems sensible to just do it It's free to not unlink the

Re: xkbcommon in the server (was: Re: [PATCH] Cache xkbcomp output)

2012-07-19 Thread Daniel Stone
Hi, On 19 July 2012 14:07, Dan Nicholson dbn.li...@gmail.com wrote: Yeah, I remember my disappointment when I discovered all the protocol for modifying an existing keymap rather than just starting a new one. I've been coming across fresh disappointment every week for the last eight years. ;)

Re: [PATCH 0/3] Post-XAAectomy cleanup

2012-07-19 Thread Daniel Stone
, forgot about cw! The other two are varying degrees of cosmetic, but the doc fix should definitely go in. For the series: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH] Add '-xserver-keymap-dir' option to print .xkm file directory and exit

2012-07-18 Thread Daniel Stone
Oops, forgot the list ... On 18 July 2012 10:15, Daniel Stone dan...@fooishbar.org wrote: Hi, Nitpicking I know, but how about -print-xkm-cache-dir or something? -xserver is a bit redundant when you're starting the X server ... On 17 July 2012 22:41, Keith Packard kei...@keithp.com wrote

Re: [PATCH 2/2] Make indentation of dix/tables.c much more consistent and readable

2012-07-17 Thread Daniel Stone
On 17 July 2012 07:13, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Acked-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 1/2] Fix up formatting of initializers for arrays of structs

2012-07-17 Thread Daniel Stone
Hi, On 17 July 2012 07:13, Alan Coopersmith alan.coopersm...@oracle.com wrote: The indenter seems to have gotten confused by initializing arrays of structs with the struct defined inline - for predefined structs it did a better job, so match that. It'd be nice if this consistently used spaces

xkbcommon in the server (was: Re: [PATCH] Cache xkbcomp output)

2012-07-13 Thread Daniel Stone
Hi, On 13 July 2012 13:34, Dan Nicholson dbn.li...@gmail.com wrote: Not that I actually have the time to work on this, but I'd been thinking about xkbcommon lately. Do you think it's possible to build a compatibility layer around the current code? Either the compat code could live in the

Re: [PATCH] Cache xkbcomp output

2012-07-13 Thread Daniel Stone
Hi, On 13 July 2012 16:55, Keith Packard kei...@keithp.com wrote: Dan Nicholson dbn.li...@gmail.com writes: Not that I actually have the time to work on this, but I'd been thinking about xkbcommon lately. Do you think it's possible to build a compatibility layer around the current code? I

Re: [PATCH 2/2] Add script to report XKB output directory, xserver-keymap-dir

2012-07-13 Thread Daniel Stone
Hi, On 13 July 2012 21:08, Keith Packard kei...@keithp.com wrote: This can be used to clear any cache files when loading new XKB configuration files. It gets installed in $(SERVERCONFIG) (by default, $libdir/xorg) Why not make this part of xorg-server.pc, or an xorg-server --xkb-default-dir?

Re: [PATCH 1/2] Cache xkbcomp output

2012-07-13 Thread Daniel Stone
Hi, On 13 July 2012 21:08, Keith Packard kei...@keithp.com wrote: Construct a unique filename based on the display name and the RMLVO values. If that file contains valid contents, use it. Otherwise, compile the keymap to that file and don't unlink it so that it will be re-used the next time

Re: [PATCH 3/3] Restore GLX extension to XWin

2012-07-12 Thread Daniel Stone
want to create a wrapper for GlxExtensionInit that calls glxWinPushNativeProvider and then calls through to GlxExtensionInit, rather than doing it here. Other than that, for the series: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers (and sorry!), Daniel

Re: [PATCH] Cache xkbcomp output

2012-07-12 Thread Daniel Stone
Hi, On 12 July 2012 23:07, Keith Packard kei...@keithp.com wrote: Construct a unique filename based on the display name and the RMLVO values. If that file contains valid contents, use it. Otherwise, compile the keymap to that file and don't unlink it so that it will be re-used the next time

[PATCH] sdksyms: Fix build with --disable-xv

2012-07-11 Thread Daniel Stone
I hate this [redacted] script. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/sdksyms.sh |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xfree86/sdksyms.sh b/hw/xfree86/sdksyms.sh index c0398da..07372ad 100755 --- a/hw/xfree86/sdksyms.sh +++ b/hw/xfree86/sdksyms.sh

Re: [PATCH 03/54] Sync: Always initialise system counter list

2012-07-10 Thread Daniel Stone
Hi, On 10 July 2012 05:03, Alan Coopersmith alan.coopersm...@oracle.com wrote: Should the xorg_list_init in SyncExtensionInit be moved inside its if (RTCounter == 0) check then, so it doesn't reset the list back to empty after you've done this? Yes, definitely. I'll fix that up - thanks!

[PATCH 1/2] Sync: Always initialise system counter list

2012-07-10 Thread Daniel Stone
Sync is designed to let you add system counters before the extension has been initialised, which means the system counter list may well be full of bees. Make sure it's initialised before we add to it, to avoid the risk of fatal injury. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext

[PATCH 2/2] AllocDevicePair: Ensure XKB privates are initialised

2012-07-10 Thread Daniel Stone
Since we call directly into XKB and may be doing so before the extension has been initialised, make sure its privates are set up first. XTest had a hack to do this itself, but seems cleaner to just make sure we do it in AllocDevicePair. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix

[PATCH (resend) 0/2] Initialisation fixups

2012-07-10 Thread Daniel Stone
Hi, Without these two patches, initialisation is broken for me, and the server asserts (without the XKB patch) or segfaults (without the Sync patch). I'm not really sure how it's working for others, and looking at these in context they seem correct, so ... Cheers, Daniel

Re: [PATCH 02/54] Don't make failure to -nolisten fatal

2012-07-10 Thread Daniel Stone
Hi, On 10 July 2012 12:43, Michal Suchanek hramr...@gmail.com wrote: On 10 July 2012 03:02, Daniel Stone dan...@fooishbar.org wrote: If failing to disable a protocol specified by -nolisten failed, we'd throw a FatalError and bomb startup entirely. From poking at xtrans, it looks like

[PATCH evdev] Fix compilation warnings for non-multitouch builds

2012-07-09 Thread Daniel Stone
Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/evdev.c |4 1 file changed, 4 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index c273326..232e406 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1065,7 +1065,9 @@ EvdevProcessEvent(InputInfoPtr pInfo, struct input_event

[PATCH 04/54] AllocDevicePair: Ensure XKB privates are initialised

2012-07-09 Thread Daniel Stone
Since we call directly into XKB and may be doing so before the extension has been initialised, make sure its privates are set up first. XTest had a hack to do this itself, but seems cleaner to just make sure we do it in AllocDevicePair. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix

[PATCH 00/54] extmod, again (and XAA)

2012-07-09 Thread Daniel Stone
Hi, This should hopefully be the very totally final version of the extmod patches. These have all had to be rebased, and some have had to have minor tweaks, so I've sent them out again. The list of changes are below; obviously all the new patches will need review, but the changes to the rest are

[PATCH 02/54] Don't make failure to -nolisten fatal

2012-07-09 Thread Daniel Stone
a security risk. And it makes it possible to start gdm even though you've built with --disable-tcp-transport. Signed-off-by: Daniel Stone dan...@fooishbar.org --- os/utils.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/os/utils.c b/os/utils.c index 2537934..b00d38b 100644

[PATCH 03/54] Sync: Always initialise system counter list

2012-07-09 Thread Daniel Stone
Sync is designed to let you add system counters before the extension has been initialised, which means the system counter list may well be full of bees. Make sure it's initialised before we add to it, to avoid the risk of fatal injury. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext

[PATCH 01/54] Xext: Add hashtable.h to sources to fix distcheck

2012-07-09 Thread Daniel Stone
Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Xext/Makefile.am b/Xext/Makefile.am index 5929a3e..4082de7 100644 --- a/Xext/Makefile.am +++ b/Xext/Makefile.am @@ -50,7 +50,7 @@ MODULE_SRCS += $(XV_SRCS

[PATCH 05/54] Xorg: Link XKB DDX library after core server libs

2012-07-09 Thread Daniel Stone
-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am index 4d5d576..f74691b 100644 --- a/hw/xfree86/Makefile.am

[PATCH 06/54] Add a common ARRAY_SIZE macro to dix.h

2012-07-09 Thread Daniel Stone
Does what it says on the box, replacing those from Xi/ and glx/. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Cyril Brulebois k...@debian.org Reviewed-by: Jamey Sharp ja...@minilop.net Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte

[PATCH 08/54] Xinerama: Fix ExtensionInit prototype

2012-07-09 Thread Daniel Stone
Huh, so I guess INITARGS used to be int argc, char *argv then. Either way, it's now void, so fix that ... Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Cyril Brulebois k...@debian.org Reviewed-by: Jamey Sharp ja...@minilop.net Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

[PATCH 09/54] Replace INITARGS with void

2012-07-09 Thread Daniel Stone
Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Cyril Brulebois k...@debian.org Reviewed-by: Jamey Sharp ja...@minilop.net Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xext/bigreq.c|4 +- Xext

[PATCH 10/54] Reorder extension initialisation for non-Xorg

2012-07-09 Thread Daniel Stone
Reorder static extension initialisation in miinitext for non-Xorg servers to match Xorg's order. Tested with Xephyr; checked that the extension list was identical before and after. Signed-off-by: Daniel Stone dan...@fooishbar.org Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- mi

[PATCH 14/54] Add xf86ExtensionInit for DDX extension configuration

2012-07-09 Thread Daniel Stone
xf86ExtensionInit is called after configuration file parsing, so it can perform the two parts of extension initialisation currently done by extmod: enabling and disabling of extensions through an 'omit' option, and SELinux configuration. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed

[PATCH 13/54] Loader: Drop EXTERN_MODULE flag

2012-07-09 Thread Daniel Stone
EXTERN_MODULE was used to specify that we shouldn't worry about modules lacking a ModuleData object. It was also completely unused. *shrug* Signed-off-by: Daniel Stone dan...@fooishbar.org Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/xf86Module.h |3 --- hw

[PATCH 07/54] Make extension.h self-contained, remove C++ externs

2012-07-09 Thread Daniel Stone
externsion.h required bits from Xfuncproto.h and dixstruct.h, but included neither; fix that. It also had _XFUNCPROTOBEGIN and _XFUNCPROTOEND wrappers, which is a bit pointless for a server-only library, as it's only needed for C++. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed

[PATCH 18/54] Move RECORD from external module to built-in

2012-07-09 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com Rather than languishing in its own special module, move RECORD into the core server. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net Signed-off-by: Peter Hutterer

[PATCH 12/54] Move extension initialisation prototypes into extinit.h

2012-07-09 Thread Daniel Stone
Create extinit.h (and xf86Extensions.h, for Xorg-specific extensions) to hold all our extension initialisation prototypes, rather than duplicating them everywhere. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- Xext/bigreq.c

[PATCH 20/54] Move DPMS from extmod to built-in

2012-07-09 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com Always build DPMS support into the core server, rather than letting it languish in extmod. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net Signed-off-by: Peter

[PATCH 25/54] Move SELinux from extmod to built-in

2012-07-09 Thread Daniel Stone
Instead of letting it languish in extmod just because we want to configure bits of it from xf86, move XSELinux to the builtin part of Xext, and do its configuration from xf86ExtensionInit. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net Reviewed

[PATCH 36/54] GLX: Remove extension init dependencies

2012-07-09 Thread Daniel Stone
GLX was the only user of extension init order dependencies, using them to depend on Composite, which has always been built-in anyway, and DBE, which is now built-in. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/dixmods

[PATCH 16/54] miinitext: Use ARRAY_SIZE rather than sentinel

2012-07-09 Thread Daniel Stone
NULL sentinels are totally lame. Signed-off-by: Daniel Stone dan...@fooishbar.org --- mi/miinitext.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mi/miinitext.c b/mi/miinitext.c index ef20a11..c4749f5 100644 --- a/mi/miinitext.c +++ b/mi/miinitext.c

[PATCH 29/54] Remove the last remnants of extmod

2012-07-09 Thread Daniel Stone
extmod was originally a big pointless module. Now it's an empty, pointless module. This commit makes it unexist. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xext/Makefile.am

[PATCH 34/54] Move DRI2 from external module to built-in

2012-07-09 Thread Daniel Stone
Instead of keeping a tiny amount of code in an external module, just man up and build it into the core server. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net --- hw/xfree86/Makefile.am |8 +--- hw/xfree86/common/Makefile.am

[PATCH 24/54] Xv: Remove excessive module-induced indirection

2012-07-09 Thread Daniel Stone
...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Acked-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xext/xvdix.h |4 Xext/xvmain.c| 12 Xext/xvmc.c

[PATCH 21/54] Move XRes from extmod to built-in

2012-07-09 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com Always build XRes support into the core server, rather than letting it languish in extmod. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net Signed-off-by: Peter

[PATCH 35/54] Add static extensions before those in modules

2012-07-09 Thread Daniel Stone
Make sure we add static extensions before anything in a module. This is more or less a no-op at the moment, but will come in handy later when extension dependency sorting is removed. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw

[PATCH 23/54] XFree86: sdksyms: Remove unused -DXorgLoader

2012-07-09 Thread Daniel Stone
, so we can remove the define. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/sdksyms.sh |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/sdksyms.sh b/hw/xfree86/sdksyms.sh index 6d8a4d3

[PATCH 27/54] DGA: Remove excessive module-induced indirection

2012-07-09 Thread Daniel Stone
...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/dgaproc.h|5 - hw/xfree86/common/xf86DGA.c| 23 +++ hw/xfree86

[PATCH 37/54] Loader: Remove extension initialisation sorting

2012-07-09 Thread Daniel Stone
be sorted by GLX, so we no longer have any users for it. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- COPYING|2 +- hw/xfree86/common/xf86Extensions.c |4 - hw/xfree86/common/xf86Module.h |1 - hw

[PATCH 15/54] extmod: Use ARRAY_SIZE rather than sentinel

2012-07-09 Thread Daniel Stone
When the array gets down to size zero (which it does in later patches), gcc complains that the index is out of bounds. Avoid this by using ARRAY_SIZE on extensionModules instead. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/dixmods/extmod/modinit.c |8 +--- 1 file

[PATCH 38/54] Loader: Move ExtensionModule types to DIX

2012-07-09 Thread Daniel Stone
In preparation for gutting loadext.c, move the ExtensionModule struct to the DIX, and unexport ExtensionModuleList (why, why, why, why was this ever exported in the first place, tbqh). Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net --- hw/xfree86

[PATCH 40/54] Quartz: Move PseudoramiX initialisation to DDX

2012-07-09 Thread Daniel Stone
As PseudoramiX is a DDX-specific extension, move its loading and initialisation to hw/xquartz. This creates a QuartzExtensionInit() similar in spirit to xf86ExtensionInit. Signed-off-by: Daniel Stone dan...@fooishbar.org Acked-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Jeremy

[PATCH 39/54] Move the remnants of loadext.c to miinitext.c

2012-07-09 Thread Daniel Stone
There was nothing XFree86-specific or loader-specific about this, aside from using xf86MsgVerb instead of ErrorF. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net --- hw/xfree86/common/xf86Module.h |6 --- hw/xfree86/loader/Makefile.am |1 - hw

[PATCH 43/54] Replace NO_HW_ONLY_EXTS with Xorg DDX test

2012-07-09 Thread Daniel Stone
Turns out the only thing we use NO_HW_ONLY_EXTS for is to check whether or not we're building inside the Xorg DDX. Replace it with an XorgLoader test instead, and remove all its users. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/vfb/Makefile.am |2 -- hw/xnest/Makefile.am

[PATCH 42/54] Unify miinitext.c

2012-07-09 Thread Daniel Stone
Rather than having a non-Xorg and an Xorg-specific path which basically just duplicated each other for no reason, we could ... just have one. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/dixmods/Makefile.am |2 +- mi

[PATCH 48/54] GLX: Remove unused noGlxVisualInit

2012-07-09 Thread Daniel Stone
No-one ever did anything with this variable except assign its default value to it. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Adam Jackson a...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- hw/kdrive/ephyr

[PATCH 50/54] Render: Remove unused glyphDepths

2012-07-09 Thread Daniel Stone
No-one has used this since 0a71e154. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Adam Jackson a...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- render/glyph.c |2 -- 1 file changed, 2 deletions(-) diff --git a/render/glyph.c b/render/glyph.c index

[PATCH 54/54] GE: Remove unused RT_GECLIENT

2012-07-09 Thread Daniel Stone
Remove remnants of an earlier experiment which had the GE extension handling event delivery directly. Nothing's used the resource since, so purge it. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Adam Jackson a...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

[PATCH 41/54] Remove Xorg-specific extensions from non-Xorg miinitext

2012-07-09 Thread Daniel Stone
miinitext.c had a completely separate codepath for non-Xorg servers, which included tests for Xorg-specific extensions such as XFree86-VidMode, which were external even to the Xorg DDX. So we can just remove them, and the associated #undefs. Signed-off-by: Daniel Stone dan...@fooishbar.org

[PATCH 53/54] XFree86: os-support: Remove unused xf86MakeNewMapping

2012-07-09 Thread Daniel Stone
No drivers used this, so it got unexported, and now it's so unused it got culled during the link. Take the poor function out behind the shed and put it out of its misery. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Adam Jackson a...@redhat.com Acked-by: Peter Hutterer

[PATCH 52/54] Xinerama: Reset Composite request vector on close

2012-07-09 Thread Daniel Stone
Similar (identical) to how it interacts with Render and XFixes, also call PanoramiXCompositeReset() to restore the Composite dispatch table to how it was when it started, on reset. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Adam Jackson a...@redhat.com Acked-by: Peter Hutterer

[PATCH 45/54] Remove last renmants of XFree86LOADER define

2012-07-09 Thread Daniel Stone
Not to be confused with XFree86Loader or XorgLoader. Which are both now dead too. Signed-off-by: Daniel Stone dan...@fooishbar.org --- configure.ac |1 - hw/xquartz/xpr/dri.c |5 - include/xorg-server.h.in |2 +- 3 files changed, 1 insertion(+), 7 deletions

[PATCH 19/54] Move MIT-SCREEN-SAVER from extmod to built-in

2012-07-09 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com If we've built MIT-SCREEN-SAVER support, then just build it into the main binary, rather than leaving it in extmod. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net

[PATCH 17/54] Move DBE from an external module to built-in

2012-07-09 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com If DBE support is compiled in the server, just man up and build it into the server, rather than having it as an external module. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja

[PATCH 47/54] XKB: Geom: Remove unused code

2012-07-09 Thread Daniel Stone
These codepaths were never called by anyone. Shame there weren't more of them. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Adam Jackson a...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- xkb/XKBGAlloc.c | 129

[PATCH 49/54] Xi: Remove dead Device{Enter,Leave}WindowMask

2012-07-09 Thread Daniel Stone
These were an unused remnant of earlier MPX work; their only users got cleared out in dc153271, but the mask declarations remained. Remove them, and move DevicePropertyNotify's mask up to be contiguous with the rest of the range. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Adam

[PATCH 31/54] Move DRI1 from external module to built-in

2012-07-09 Thread Daniel Stone
Rather than building the tiny amount of code required for XFree86-DRI as an external module, build it in if it's enabled at configure time. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- configure.ac |7 ++- glx

[PATCH 33/54] DRI2: Remove prototype for DRI2DestroyDrawable

2012-07-09 Thread Daniel Stone
DRI2DestroyDrawable() was still being _X_EXPORTed, but hasn't existed since 1da1f33f last year. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Cyril Brulebois k...@debian.org Reviewed-by: Jamey Sharp ja...@minilop.net Reviewed-by: Ian Romanick ian.d.roman...@intel.com Signed-off

[PATCH 22/54] Move Xv and XvMC from extmod to built-in

2012-07-09 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com Always build these extensions into the core server, rather than letting them languish in extmod. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net Signed-off-by: Peter

[PATCH 32/54] XFree86: DRI: Don't use per-target CFLAGS

2012-07-09 Thread Daniel Stone
AM_CFLAGS will suffice, given we only have one target in this directory. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Cyril Brulebois k...@debian.org --- hw/xfree86/dri/Makefile.am | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/hw

Re: FOSS.in Call for Participation

2012-06-27 Thread Daniel Stone
Hi, On 27 June 2012 17:25, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 06/27/12 07:44 AM, Alan Coopersmith wrote: If someone in the region wanted to present on a topic related to the free graphics stack (X.Org, Mesa, DRI, Wayland, etc.) and the only thing stopping them was travel

Re: [PATCH 1/1] Look for ModuleData only in appropriate library

2012-06-27 Thread Daniel Stone
had the arguments that way around too. It just seems like a more logical order. That aside: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: [PATCH] xkb: fill in keycode and event type for slow keys enablement

2012-06-25 Thread Daniel Stone
to me. Acked-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] include: document _XkbErrCode2 macros

2012-06-21 Thread Daniel Stone
...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: gpu screen infrastructure patches

2012-06-13 Thread Daniel Stone
Hi, On 13 June 2012 16:14, Michal Suchanek hramr...@gmail.com wrote: I am not sure actually plugging cards is a good idea. PCIe is technically designed for hotplug but that does not mean all physical embodiments are actually hotpluggable, does it? Think USB. Cheers, Daniel

Re: Security: Absolute Client vetting or trust a remote root?

2012-06-09 Thread Daniel Stone
Hi, On 8 June 2012 23:32, Mike Mestnik cheako+xorg-de...@mikemestnik.net wrote: On 06/07/2012 11:07 PM, Alan Coopersmith wrote: No, it just redirects it into more secure channels, such as tunneling over ssh, instead of having to re-implement the encryption  authentication in the X layer that

Re: Security: Absolute Client vetting or trust a remote root?

2012-06-08 Thread Daniel Stone
On 8 June 2012 03:33, Mike Mestnik cheako+xorg-de...@mikemestnik.net wrote: I reject this concept, it shouldn't be allowed to spread any further. I reject your spamming of the list (as well as every LWN comment on the issue), and I hope to god it doesn't spread any further. This is a

Re: [PATCH] Change autogen.sh scripts to respect NOCONFIGURE

2012-06-08 Thread Daniel Stone
Hi, On 5 January 2012 17:01, Colin Walters walt...@verbum.org wrote: Hmm...but how many people 1) Build an xorg module from git A fair few. Modularisation was a huge step for us towards making X.Org less scary: we can now say 'this should be fixed in git, can you please pull?' to bug

Re: [PATCH v2 00/42] Death to extmod

2012-05-25 Thread Daniel Stone
Hi, On 25 May 2012 07:09, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 12/ 2/11 03:27 AM, Daniel Stone wrote: It's also available as a git branch: git://people.freedesktop.org/~daniels/xserver extension-cleanup So is it time to dust these off again?   As mentioned in the series I

Re: lack of reviewers

2012-05-18 Thread Daniel Stone
Hi, On 18 May 2012 20:05, Maarten Maathuis madman2...@gmail.com wrote: On Fri, May 18, 2012 at 5:56 PM, Michal Suchanek hramr...@gmail.com wrote: Of course it interferes with the existing process. If it was not used it would be of no use. You don't have to make it required, if the system is

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-05-09 Thread Daniel Stone
Hi, On 9 May 2012 16:13, Ran Benita ran...@gmail.com wrote: On Tue, May 08, 2012 at 05:35:23PM +0100, Daniel Stone wrote: Thanks a bunch for all your last changes too, I've merged everything except the DFLT_XKB_CONFIG_ROOT change and the Unicode tests.  Again for the Unicode tests I want

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-05-08 Thread Daniel Stone
- On 11 April 2012 19:58, Ran Benita ran...@gmail.com wrote: On Mon, Apr 02, 2012 at 12:04:25PM +0100, Daniel Stone wrote: Right, so allow it to call through arbitrary function pointers? I was considering doing that, but wasn't particularly feeling like dealing with the intracacies of varargs

Re: [PATCH] xv: disable reputimage hook on newer api

2012-05-01 Thread Daniel Stone
On 1 May 2012 15:34, Luc Verhaegen l...@skynet.be wrote: Didn't think i needed to do so myself. There is this split between how individual X components are being handled, apparently. I only committed to my own unichrome driver, and thought that the maintainer of apm or the X.org release

Re: [PATCH] Include strings.h on Solaris for bzero definition

2012-04-26 Thread Daniel Stone
Hi, On 25 April 2012 04:45, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 02/25/12 10:30 AM, Daniel Stone wrote: Acked-by: Daniel Stone dan...@fooishbar.org I'll push this on Monday too. Looks like it's still not in there - should I just push myself? Sorry, got lost in a rebase I

Re: [PATCH] Include strings.h on Solaris for bzero definition

2012-04-26 Thread Daniel Stone
Hi, On 26 April 2012 16:46, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 04/26/12 04:52 AM, Daniel Stone wrote: I wouldn't be too hugely concerned about porting it to Solaris though (unless you're porting Wayland too), since the amount of API we need to expose to implement the XKB

Re: [PATCH] xkb: don't setMods locking modifiers (#27903)

2012-04-22 Thread Daniel Stone
27903) +        */ This mostly seems OK to me, but breaks the LockNoLock state; I guess you'd want to directly change base_mods in the other branch. With that fixed: Acked-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org

Re: [PATCH 0/4] os/log: fixes for timestamps and malicious devices

2012-04-18 Thread Daniel Stone
Hi, On 18 April 2012 10:51, Daniel Kurtz djku...@chromium.org wrote: Input drivers like to prepend the device name to logging messages using LogVHdrMessageVerb().  The current implementation of this function used the output of a snprintf() as the format string of another snprintf().  This is a

Re: [PATCH 0/4] os/log: fixes for timestamps and malicious devices

2012-04-18 Thread Daniel Stone
Hi, On 18 April 2012 13:14, Daniel Kurtz djku...@chromium.org wrote: On Wed, Apr 18, 2012 at 7:42 PM, Daniel Stone dan...@fooishbar.org wrote: On 18 April 2012 10:51, Daniel Kurtz djku...@chromium.org wrote: Input drivers like to prepend the device name to logging messages using

Re: [PATCH v2] xfree86: after VT switching back, only enable previously enabled devices

2012-04-13 Thread Daniel Stone
On 13 April 2012 03:27, Chase Douglas chase.doug...@canonical.com wrote: Hmmm.. I'm not crazy about putting a single-function quirk inside an external record, but I can't think of anything better. Reviewed-by: Chase Douglas chase.doug...@canonical.com Reviewed-by: Daniel Stone dan

Re: [PATCH] xfree86: after VT switching back, only enable previously enabled devices

2012-04-12 Thread Daniel Stone
Hi, On 12 April 2012 07:08, Peter Hutterer peter.hutte...@who-t.net wrote: bit of a hack, we could store this in the device struct but this approach is sufficient. Note that this only affects xfree86 devices, virtual devices (master devices) are enabled anyway. Can't we add devices while

Re: [PATCH v3] os: Add -displayfd option

2012-04-05 Thread Daniel Stone
Hi, On 5 April 2012 06:19, Chase Douglas chase.doug...@canonical.com wrote: On 04/04/2012 07:18 PM, Alan Coopersmith wrote: Thanks.   (I do note that you removed the \n from the display and didn't add it to the write of the display to the fd - I don't know if that matters or not, so figured

Re: synaptics bug 31636: non-uniform horizontal and vertical acceleration

2012-04-03 Thread Daniel Stone
Hi, On 3 April 2012 17:29, Chase Douglas chase.doug...@canonical.com wrote: I have heard from a few people that they actually prefer this behavior. I think we either need to stick with what we have or make it configurable (and maybe change the default). Peter, any thoughts? I don't have any

Re: [Xcb] 7.7 katamari Release Notes draft RC1 content list

2012-04-02 Thread Daniel Stone
Hi, On 2 April 2012 11:10, Michal Suchanek hramr...@gmail.com wrote: BTW there is a several years old bug report with patches to revert this behaviour and to add an option to revert to using DDC but nobody ever bothered to review any of them. That's completely untrue. The patches to revert

Re: [PATCH libxkbcommon] Add xkb_key_get_action API

2012-04-02 Thread Daniel Stone
Hi, On 1 April 2012 17:24, Ran Benita ran...@gmail.com wrote: On Tue, Mar 27, 2012 at 02:27:49PM +0100, Daniel Stone wrote: This should be fairly straightforward for most LEDs, which only reflect the state of a single locked modifier or group.  For LEDs which reflect multiple states though

<    1   2   3   4   5   6   7   8   9   10   >