[PATCH v3 0/23] Synaptics accel changes and smooth scrolling

2011-06-23 Thread Daniel Stone
Hi, v3 addresses all review comments to date, except Peter's suggestion of making the four new filters configurable via a single property rather than one each, and Daniel's suggestion of continuing to use hw-millis everywhere rather than passing 'now'. Anything marked with 'v3' in the subject is

[PATCH v3 05/23] Fix pressure-motion property format

2011-06-23 Thread Daniel Stone
From: Derek Foreman derek.fore...@collabora.co.uk CARD32, not float. Signed-off-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org --- include/synaptics-properties.h |2 +- src/properties.c |8 2 files changed, 5

[PATCH 01/23] Adjust acceleration scheme for input ABI v14

2011-06-23 Thread Daniel Stone
v14 wants doubles, rather than floats, from acceleration schemes. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/synaptics.c b

[PATCH v3 03/23] Bump minimum xorg-server requirement to 1.7

2011-06-23 Thread Daniel Stone
This means we can also drop support for pre-ABI v7. Signed-off-by: Daniel Stone dan...@fooishbar.org --- configure.ac|2 +- src/synaptics.c | 28 +--- 2 files changed, 6 insertions(+), 24 deletions(-) v3: New. diff --git a/configure.ac b/configure.ac index

[PATCH 07/23] Give FingerState enums explicit values

2011-06-23 Thread Daniel Stone
Since we depend so heavily on ordering and numbering, just give all the enum explicit number values. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c|2 +- src/synapticsstr.h |8 2 files changed, 5

[PATCH v3 09/23] Use CARD32 for timestamps

2011-06-23 Thread Daniel Stone
As GetTimeInMillis() returns a CARD32, switch every timestamp usage to follow. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c|6 +++--- src/synapticsstr.h |2 +- src/synproto.h |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) v3: New. diff --git

[PATCH 04/23] Properties: Generalise InitTypedAtom from InitAtom

2011-06-23 Thread Daniel Stone
Add InitTypedAtom, which does exactly the same thing as InitAtom, but takes an additional type argument. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/properties.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/properties.c b/src/properties.c

[PATCH 06/23] Add HIST_DELTA macro for differences in history

2011-06-23 Thread Daniel Stone
HIST_DELTA(a, b, e) is equivalent to HIST(a).e - HIST(b).e. Replace the one user of this pattern with a HIST_DELTA call. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH v3 14/23] More accurate extrapolated fake motion events

2011-06-23 Thread Daniel Stone
-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c| 12 ++-- src/synapticsstr.h |1 + 2 files changed, 7 insertions(+), 6 deletions(-) v3: Changed last_motion_millis

[PATCH 08/23] Introduce POLL_MS for packet frequency

2011-06-23 Thread Daniel Stone
as 14ms. Having this here allows us to call back at a steady frequency to ensure that the finger motion remains steady. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c | 26 +- 1 files changed, 21 insertions(+), 5 deletions(-) diff --git a/src/synaptics.c

[PATCH v3 20/23] Scroll: Move coasting variables to priv-scroll

2011-06-23 Thread Daniel Stone
Also rename (e.g. autoscroll_x - coast_delta_x, and autoscroll_xspd - coast_speed_x) variables to clarify things a bit. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c| 78 ++-- src/synapticsstr.h | 10 +++--- 2 files

[PATCH v3 13/23] Replace the motion estimator

2011-06-23 Thread Daniel Stone
From: Derek Foreman derek.fore...@collabora.co.uk Use a smarter motion estimator that attempts to draw a best-fit line through the history where possible, including taking acceleration into account. Signed-off-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel Stone dan

[PATCH v3 10/23] Use hardware time where possible

2011-06-23 Thread Daniel Stone
...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org --- src/alpscomm.c |2 + src/eventcomm.c|1 + src/ps2comm.c |2 +- src/synaptics.c| 138 ++- src/synapticsstr.h |1 + 5 files changed, 75 insertions

[PATCH v3 15/23] Add four new motion filters

2011-06-23 Thread Daniel Stone
Distance: maximum distance a finger can move in a single report before being declared errant (xorg.conf MaxDistance) Signed-off-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org --- include/synaptics-properties.h | 12 ++ man/synaptics.man

[PATCH v3 19/23] Scroll: Add last_millis to track scroll event timing

2011-06-23 Thread Daniel Stone
Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c| 10 +++--- src/synapticsstr.h |1 + 2 files changed, 8 insertions(+), 3 deletions(-) v3: Removed get_delta() and get_delta_from_trackstick() hunks, so we now only

[PATCH 17/23] Scroll: Clarify rep_buttons assignment

2011-06-23 Thread Daniel Stone
Instead of a combined variable declaration with two ternary expressions using raw hex values, expand it to have two genuine if statements, setting with a more clear bitshift. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c

[PATCH 11/23] Don't store fake events in the motion history

2011-06-23 Thread Daniel Stone
As the subject says: don't store any synthesised events in the motion history, since we can recreate those algorithmically. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/synaptics.c b/src

[PATCH 21/23] Scroll: Modify ScrollData in repeat_scrollbuttons

2011-06-23 Thread Daniel Stone
repeat_scrollbuttons used to read the scroll repeat values and then post button events directly. Instead, make it modify ScrollData and let post_scroll_events take care of sending the scroll events, which requires moving the repeat_scrollbuttons call upwards. Signed-off-by: Daniel Stone dan

[PATCH v3 22/23] Scroll: Prepare ScrollData for smooth scrolling

2011-06-23 Thread Daniel Stone
Convert ScrollData from up/down/left/right members for button presses, to more fine-grained delta_x and delta_y members, and move these to priv-scroll. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c| 135 +++ src

[PATCH 12/23] Update count_packet_finger in store_history, not get_delta

2011-06-23 Thread Daniel Stone
Seems more sensible to update the count of packets in the history when we update the history, rather than somewhere else entirely. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/synaptics.c b

[PATCH v3 18/23] Scroll: Move scroll_[xya] into new priv-scroll struct

2011-06-23 Thread Daniel Stone
And rename them to last_x, last_y and last_a respectively, as they're used to store the values as of the last scroll event sent. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c| 54 ++-- src/synapticsstr.h |8

[PATCH v3 23/23] Scroll: Initial smooth scrolling support

2011-06-23 Thread Daniel Stone
Post smooth-scrolling events through the new X server API when available, rather than legacy jerky button events. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c| 54 +-- src/synapticsstr.h | 11 ++ 2 files

[PATCH v3 16/23] Revise palm check logic

2011-06-23 Thread Daniel Stone
From: Derek Foreman derek.fore...@collabora.co.uk Make the palm-check logic more stable and reliable, and make sure that any palms are blocked for the duration of their presses. Signed-off-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed

Re: [PATCH inputproto 2/2] Document smooth-scrolling support

2011-06-23 Thread Daniel Stone
Hi, On Fri, Jun 24, 2011 at 08:18:27AM +1000, Peter Hutterer wrote: On Thu, Jun 23, 2011 at 10:50:41AM +0100, Daniel Stone wrote: On Thu, Jun 23, 2011 at 10:44:44AM +1000, Peter Hutterer wrote: one more question: What do we do for backwards compatibility? 2.0 clients get both events

[PATCH v2 0/6] XKB debug actions and tiny patches

2011-06-22 Thread Daniel Stone
Hi, The v2 of the PrintWindowTree and debug key actions patches address all outstanding review comments, TTBOMK, and the following four are fairly trivial one-liners which do exactly what they say on the box. They're also available in convenient tree form from:

Re: [PATCH inputproto 1/2] Add XIPointerEmulated for emulated events

2011-06-22 Thread Daniel Stone
Hi, On Mon, Jun 20, 2011 at 04:29:55PM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 06:26:00PM +0100, Daniel Stone wrote: @@ -1591,6 +1591,9 @@ KeyRelease, ButtonPress, ButtonRelease, Motion. KeyRepeat means that this event is for repeating purposes

[PATCH 6/6] Test: Ensure libxservertest gets relinked when necessary

2011-06-22 Thread Daniel Stone
Similar to how we link Xorg, make sure that whenever any of the component libraries changes, we relink libxservertest and the tests. Not much use testing anything other than the actual source in your tree. Signed-off-by: Daniel Stone dan...@fooishbar.org --- test/Makefile.am |1 + 1 files

[PATCH 4/6] DMX: Remove useless miPointerUpdateSprite call

2011-06-22 Thread Daniel Stone
miPointerUpdateSprite is already called from mieqProcessInputEvents, so calling it by hand immediately after isn't massively helpful. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/dmx/input/dmxinputinit.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/dmx

[PATCH v2 1/6] DIX: Make PrintWindowTree actually useful

2011-06-22 Thread Daniel Stone
Rewrite PrintWindowTree to make it actually tell you what you want to know. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/window.c | 139 -- include/window.h |2 + 2 files changed, 115 insertions(+), 26 deletions(-) v2

Re: [PATCH xkbcomp v2] Print version number on -version.

2011-06-22 Thread Daniel Stone
On Wed, Jun 22, 2011 at 11:03:17AM +1000, Peter Hutterer wrote: This commit isn't playing the WARN/M/M1 macro game. Version numbers to to stdout, full stop. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org

Re: [PATCH 2/2] XKB: Add debug key actions for grabs window tree

2011-06-22 Thread Daniel Stone
Hi, On Wed, Jun 22, 2011 at 05:04:47PM +1000, Peter Hutterer wrote: On Tue, Jun 21, 2011 at 12:04:27PM +0100, Daniel Stone wrote: While looking at this, I found something that confused me further still. [ ... hooray for grabs ... ] With the [...] being TryClientEvents and setting

[PATCH 5/6] KDrive: Remove useless miPointerUpdateSprite call

2011-06-22 Thread Daniel Stone
miPointerUpdateSprite is already called from mieqProcessInputEvents, so calling it by hand immediately after isn't massively helpful. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/kdrive/src/kinput.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/kdrive/src

[PULL inputproto] smooth-scrolling (was: Re: [PATCH inputproto 2/2] Document smooth-scrolling support)

2011-06-22 Thread Daniel Stone
Hi, On Mon, Jun 20, 2011 at 04:28:17PM +1000, Peter Hutterer wrote: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net otherwise though Thanks for this, I've fixed your comments from both patches, added your Reviewed-by, and pushed to my p.fd.o smooth-scrolling branch, which is on top of your

[PATCH 3/6] XWin: Remove executable bit from headers

2011-06-22 Thread Daniel Stone
Headers don't really need to be mode 0755. Signed-off-by: Daniel Stone dan...@fooishbar.org --- 0 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 = 100644 hw/xwin/xlaunch/resources/resources.h mode change 100755 = 100644 hw/xwin/xlaunch/window/dialog.h mode change 100755

[PATCH v2 2/6] XKB: Add debug key actions for grabs window tree

2011-06-22 Thread Daniel Stone
1.2.3. At the moment, this only works if the grabbing client continues to call AllowEvents, as the server does no event processing at all when a device is frozen. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/grabs.c | 112 +++ hw

Re: [PATCH] dix: Fill in errorValue in ChangeGC for tile/stipple/clip BadMatch

2011-06-21 Thread Daniel Stone
On Mon, Jun 20, 2011 at 06:50:47PM -0400, Adam Jackson wrote: The caveat here is that unused data in errors isn't guaranteed to be 0, which means you'd have to know to only look for extra BadMatch info for either a particular server version or (better) protocol version. You could reasonably

Re: [PATCH 4/7] dix: Extend initial connection handshake for forwarding proxies

2011-06-21 Thread Daniel Stone
Hi, On Fri, Jun 17, 2011 at 07:22:43PM -0700, Alan Coopersmith wrote: Sounds like a protocol change that should be documented in the core protocol spec. (Maybe even finally bump the protocol version from R6 to R7.) Yeah, this is definite 11.1 fodder, but bearing in mind the caveat from the

Re: [PATCH 2/2] XKB: Add debug key actions for grabs window tree

2011-06-21 Thread Daniel Stone
Hi, On Mon, Jun 20, 2011 at 02:12:56PM +1000, Peter Hutterer wrote: On Fri, Jun 17, 2011 at 05:36:09PM +0100, Daniel Stone wrote: On Thu, Jun 16, 2011 at 11:01:58AM +1000, Peter Hutterer wrote: +if (dev-deviceGrab.grab-deviceMask) +DebugF( xi1 event mask 0x%lx

Re: Problem in AllowSome() function in Xorg

2011-06-21 Thread Daniel Stone
Hi, On Mon, Apr 11, 2011 at 07:08:42PM +0900, Park Sung-Jin wrote: If I touch(=press) on a window of a client with two fingers(id=9, 10) and release very quickly, the grab of the button(id=9) was not removed even if I released the button. According to my observation, though Xorg server tries

Re: [PATCH] dix: Fill in errorValue in ChangeGC for tile/stipple/clip BadMatch

2011-06-21 Thread Daniel Stone
Hi, On Tue, Jun 21, 2011 at 09:14:30AM -0700, Alan Coopersmith wrote: On 06/21/11 02:52 AM, Daniel Stone wrote: On Mon, Jun 20, 2011 at 06:50:47PM -0400, Adam Jackson wrote: The caveat here is that unused data in errors isn't guaranteed to be 0, which means you'd have to know to only look

Re: [PATCH 1/2] DIX: Make PrintWindowTree actually useful

2011-06-19 Thread Daniel Stone
Hi, On Thu, Jun 16, 2011 at 10:35:13AM +1000, Peter Hutterer wrote: sorry, hit the wrong key and the other email got sent too early Fixed all of these, thanks. Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 7/7] dix: Fix types in WindowOptRec

2011-06-19 Thread Daniel Stone
boundingShape; /* default: NULL */ RegionPtrclipShape; /* default: NULL */ RegionPtrinputShape;/* default: NULL */ Shouldn't these be CARD32? That aside, I love the entire series, so: Reviewed-by: Daniel Stone dan

Re: [PATCH v2 3/3] xfree86: Remove libxorg convenience library to speed up build

2011-06-19 Thread Daniel Stone
On Fri, Jun 17, 2011 at 11:31:45AM -0700, Dan Nicholson wrote: So, it saves a few seconds for me. However, the case that Daniel has to cope with is the dirtying case where you're just making a couple changes but have to wait for libxorg to get rebuilt. For me, the time is almost cut in half.

Re: [PATCH 1/2] DIX: Make PrintWindowTree actually useful

2011-06-19 Thread Daniel Stone
Hi, On Wed, Jun 15, 2011 at 10:31:05PM -0700, Alan Coopersmith wrote: On 06/15/11 05:35 PM, Peter Hutterer wrote: I don't seem to have a single window with a name. Can't spot the bug at a glance though fwiw, xprop lists WM_NAME(STRING) = xeyes with WM_NAME being XA_WM_NAME Shouldn't

Re: [PATCH x11proto] Add two more symbols for printing grab and window trees

2011-06-19 Thread Daniel Stone
LogWindowTree and LogGrabInfo if possible. Is this OK with you? If so, we should get an xproto out with these ASAP, and either way: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 2/2] XKB: Add debug key actions for grabs window tree

2011-06-19 Thread Daniel Stone
Hi, On Thu, Jun 16, 2011 at 11:01:58AM +1000, Peter Hutterer wrote: On Tue, Jun 14, 2011 at 07:30:49PM +0100, Daniel Stone wrote: Add four new private XKB actions for debugging: * PrGrbs: print active grabs to the log file * DeaGrb: deactivate active grabs compat/xfree86 still

Re: [PATCH xserver] Fix UTF-8 encoding

2011-06-17 Thread Daniel Stone
$FILE fi done report Signed-off-by: Matěj Cepl mc...@redhat.com Reviewed-by: Daniel Stone dan...@fooishbar.org Merged into my 1.11 tree, thanks. Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: [PATCH v2 3/3] xfree86: Remove libxorg convenience library to speed up build

2011-06-17 Thread Daniel Stone
request for 1.11 when a couple of smaller changes have been reviewed, including a dependencies patch for test/ which makes sure it gets rebuilt as well. With that, for the series: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel diff --git a/hw/xfree86/Makefile.am b/hw/xfree86

Re: [PATCH 09/15] Add four new motion filters

2011-06-14 Thread Daniel Stone
Hi, On Tue, Jun 14, 2011 at 03:22:25PM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 08:57:30PM +0100, Daniel Stone wrote: Attempt to decrease the possibility of errant motion as much as possible by adding three new configurable filters, disabled by default: - Synaptics Max Jerk

Re: [PATCH 07/15] Replace the motion estimator

2011-06-14 Thread Daniel Stone
Hi, On Fri, Jun 10, 2011 at 09:39:23PM +0200, Simon Thum wrote: On 06/09/2011 09:57 PM, Daniel Stone wrote: +/* + * Fit a line through the three most recent points in the motion + * history and return relative co-ordinates. + * + * Three forms of filtering are present

Re: [PATCH 07/15] Replace the motion estimator

2011-06-14 Thread Daniel Stone
Hi, On Tue, Jun 14, 2011 at 02:59:43PM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 08:57:28PM +0100, Daniel Stone wrote: +/* Determine the best fit line through the 3 most recent history entries */ +for (i = 0; i MIN(priv-count_packet_finger, 3); i++) { + ym += HIST

Re: [PATCH 01/15] Fix pressure-motion property format

2011-06-14 Thread Daniel Stone
On Tue, Jun 14, 2011 at 02:11:42PM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 08:57:22PM +0100, Daniel Stone wrote: From: Derek Foreman derek.fore...@collabora.co.uk UINT32, not float. not that a negative value would make sense here but the driver (and your code) uses int

Re: [PATCH 04/15] Introduce POLL_MS for packet frequency

2011-06-14 Thread Daniel Stone
Hi, On Tue, Jun 14, 2011 at 02:15:36PM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 08:57:25PM +0100, Daniel Stone wrote: +#define POLL_MS 14 please add a comment for this define, the commit message is a good template here. Sure, done. also, why 14, not 13? 13ms * 80 packets

Re: [PATCH 06/15] Use hardware time where possible

2011-06-14 Thread Daniel Stone
Hi, On Tue, Jun 14, 2011 at 02:25:32PM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 08:57:27PM +0100, Daniel Stone wrote: -if (newDelay) +if (newDelay) { +priv-timer_time = GetTimeInMillis(); priv-timer = TimerSet(priv-timer, 0, delay, timerFunc, pInfo

Re: [PATCH 12/15] Clarify rep_buttons assignment

2011-06-14 Thread Daniel Stone
Hi, On Tue, Jun 14, 2011 at 03:32:27PM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 08:57:33PM +0100, Daniel Stone wrote: +if (para-updown_button_repeat) +rep_buttons |= (1 (4 - 1) | (1 5 - 1)); +if (para-leftright_button_repeat) +rep_buttons |= (1 (6

Re: [PATCH 15/15] Initial smooth scrolling support

2011-06-14 Thread Daniel Stone
Hi, On Tue, Jun 14, 2011 at 03:44:44PM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 08:57:36PM +0100, Daniel Stone wrote: -#include synaptics.h -#include synapticsstr.h -#include synaptics-properties.h - #if GET_ABI_MAJOR(ABI_XINPUT_VERSION) = 7 #include X11/Xatom.h

[PATCH synaptics v2 00/21] Predictable motion/accel, smooth scrolling

2011-06-14 Thread Daniel Stone
Hi, The attached v2 patchset (changed/new patches are marked with 'v2' in the subject line) should take care of pretty much all the review comments from Peter Simon, thanks. Patches #2, #3, #4, #8, #10, #11, #12, #13, #16, and #21 still need review. Cheers, Daniel

[PATCH synaptics 01/21] Adjust acceleration scheme for input ABI v14

2011-06-14 Thread Daniel Stone
v14 wants doubles, rather than floats, from acceleration schemes. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/synaptics.c b

[PATCH synaptics v2 02/21] Shuffle include order around

2011-06-14 Thread Daniel Stone
Group X protocol/server includes together, and synaptics-internal includes together. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c |8 1 files changed, 4 insertions(+), 4 deletions(-) v2: New. diff --git a/src/synaptics.c b/src/synaptics.c index 8f4bca1

[PATCH synaptics v2 04/21] Fix pressure-motion property format

2011-06-14 Thread Daniel Stone
From: Derek Foreman derek.fore...@collabora.co.uk UINT32, not float. Signed-off-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org --- src/properties.c |8 1 files changed, 4 insertions(+), 4 deletions(-) v2: Use the new InitTypedAtom

[PATCH synaptics v2 03/21] Properties: Generalise InitTypedAtom from InitAtom

2011-06-14 Thread Daniel Stone
Add InitTypedAtom, which does exactly the same thing as InitAtom, but takes an additional type argument. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/properties.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) v2: New. diff --git a/src/properties.c b/src

[PATCH synaptics v2 11/21] Add from_timer argument to HandleState

2011-06-14 Thread Daniel Stone
from_timer denotes whether HandleState was invoked from a timeout (e.g. to generate fake motion, or for the tap-to-click state machine), or from a genuine motion event. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c | 14 ++ 1 files changed, 10 insertions

[PATCH synaptics v2 12/21] Don't store fake events in the motion history

2011-06-14 Thread Daniel Stone
As the subject says: don't store any synthesised events in the motion history, since we can recreate those algorithmically. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) v2: New; split out from regress() addition

[PATCH synaptics v2 08/21] Introduce POLL_MS for packet frequency

2011-06-14 Thread Daniel Stone
as 14ms. Having this here allows us to call back at a steady frequency to ensure that the finger motion remains steady. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c | 26 +- 1 files changed, 21 insertions(+), 5 deletions(-) v2: Fairly extensive

[PATCH synaptics 07/21] Give FingerState enums explicit values

2011-06-14 Thread Daniel Stone
Since we depend so heavily on ordering and numbering, just give all the enum explicit number values. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c|2 +- src/synapticsstr.h |8 2 files changed, 5

[PATCH synaptics 05/21] Use unsigned long for historical time, not int

2011-06-14 Thread Daniel Stone
Since we get time in unsigned longs rather than int, truncating just seems a bit silly. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c|2 +- src/synapticsstr.h |2 +- 2 files changed, 2 insertions(+), 2

[PATCH synaptics v2 13/21] Update count_packet_finger in store_history, not get_delta

2011-06-14 Thread Daniel Stone
Seems more sensible to update the count of packets in the history when we update the history, rather than somewhere else entirely. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) v2: New; split out from regress

[PATCH synaptics v2 09/21] Add last_scroll_millis to track scroll event timing

2011-06-14 Thread Daniel Stone
...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c| 14 +- src/synapticsstr.h |1 + 2 files changed, 10 insertions(+), 5 deletions(-) v2: Include HandleScrolling hunks which inexplicably crept into another

[PATCH synaptics v2 21/21] Initial smooth scrolling support

2011-06-14 Thread Daniel Stone
Post smooth-scrolling events through the new X server API when available, rather than legacy jerky button events. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c| 54 +-- src/synapticsstr.h | 11 ++ 2 files

[PATCH synaptics 06/21] Add HIST_DELTA macro for differences in history

2011-06-14 Thread Daniel Stone
HIST_DELTA(a, b, e) is equivalent to HIST(a).e - HIST(b).e. Replace the one user of this pattern with a HIST_DELTA call. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH synaptics v2 14/21] Replace the motion estimator

2011-06-14 Thread Daniel Stone
From: Derek Foreman derek.fore...@collabora.co.uk Use a smarter motion estimator that attempts to draw a best-fit line through the history where possible, including taking acceleration into account. Signed-off-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel Stone dan

[PATCH 19/21] Modify ScrollData in repeat_scrollbuttons

2011-06-14 Thread Daniel Stone
repeat_scrollbuttons used to read the scroll repeat values and then post button events directly. Instead, make it modify ScrollData and let post_scroll_events take care of sending the scroll events, which requires moving the repeat_scrollbuttons call upwards. Signed-off-by: Daniel Stone dan

[PATCH synaptics 20/21] Prepare ScrollData for smooth scrolling

2011-06-14 Thread Daniel Stone
Convert ScrollData from up/down/left/right members for button presses, to more fine-grained x and y members. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c | 119 ++ 1

[PATCH synaptics v2 18/21] Clarify rep_buttons assignment

2011-06-14 Thread Daniel Stone
Instead of a combined variable declaration with two ternary expressions using raw hex values, expand it to have two genuine if statements, setting with a more clear bitshift. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c

[PATCH synaptics 17/21] Revise palm check logic

2011-06-14 Thread Daniel Stone
From: Derek Foreman derek.fore...@collabora.co.uk Make the palm-check logic more stable and reliable, and make sure that any palms are blocked for the duration of their presses. Signed-off-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed

[PATCH synaptics v2 10/21] Use hardware time where possible

2011-06-14 Thread Daniel Stone
...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org --- src/alpscomm.c |2 + src/eventcomm.c|1 + src/ps2comm.c |2 +- src/synaptics.c| 133 +-- src/synapticsstr.h |1 + src/synproto.h |2 +- 6

[PATCH synaptics 15/21] More accurate extrapolated fake motion events

2011-06-14 Thread Daniel Stone
-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c| 10 +- src/synapticsstr.h |1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/synaptics.c b/src

[PATCH synaptics v2 16/21] Add four new motion filters

2011-06-14 Thread Daniel Stone
Distance: maximum distance a finger can move in a single report before being declared errant (xorg.conf MaxDistance) Signed-off-by: Derek Foreman derek.fore...@collabora.co.uk Reviewed-by: Daniel Stone dan...@fooishbar.org --- include/synaptics-properties.h | 12 +++ man/synaptics.man

Re: [PATCH input-synaptics 2/5] Do not install ChangeLog and README with documentation

2011-06-14 Thread Daniel Stone
On Tue, Jun 14, 2011 at 02:09:55PM -0400, Gaetan Nadon wrote: On Tue, 2011-06-14 at 15:53 +0200, Diego Elio Pettenò wrote: Il giorno mar, 14/06/2011 alle 09.46 -0400, Gaetan Nadon ha scritto: I had not noticed before, on my distro the README (but not ChangeLog) is installed in doc.

Re: Synaptics: a number of issues with commit 39afe69ad7d2

2011-06-14 Thread Daniel Stone
Hi, On Tue, Jun 14, 2011 at 09:26:13AM -0700, Dan Nicholson wrote: On Mon, Jun 13, 2011 at 4:44 PM, Gaetan Nadon mems...@videotron.ca wrote: With this change, the whole of the build is done non-recursively in the top-level Makefile.am. This reduces the amount of overhead due to recursing

Re: Qery on Xlib project idea on summer of code page

2011-06-14 Thread Daniel Stone
Hi, On Tue, Jun 14, 2011 at 10:22:43PM +0530, nijil yes wrote: I am interested in working on the idea mentioned on summer of code page on replacing CMS code inside libX11 with libXcm.I would be glad to get a few more details on the work involved and such things.If there is anyone already

Re: [PATCH fpit 0/5] Add .conf file distribution

2011-06-14 Thread Daniel Stone
. For the series: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 1/2] Xdmx.man: Show actual configured XKB defaults instead of old hardcoded values

2011-06-14 Thread Daniel Stone
On Sat, Jun 11, 2011 at 10:59:13AM -0700, Alan Coopersmith wrote: Passed through from configure.ac via manpages.am Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com For both patches: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel

Re: [PATCH] dri2: restore Screen-ConfigNotify on close

2011-06-14 Thread Daniel Stone
-by: Marcin Slusarz marcin.slus...@gmail.com Reviewed-by: Daniel Stone dan...@fooishbar.org Have pulled this into my tree, thanks. Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

[PATCH 0/2] Add grab debugging keyboard actions

2011-06-14 Thread Daniel Stone
Hi, Just a relatively short patchset that restores the only good thing about XFree86-Misc: the ability to shutdown currently active grabs. The first patch just makes PrintWindowTree a little more comprehensive (e.g. printing redirection status, clip list, et al), and the second patch adds four

[PATCH 2/2] XKB: Add debug key actions for grabs window tree

2011-06-14 Thread Daniel Stone
.) At the moment, this only works if the grabbing client continues to call AllowEvents, as the server does no event processing at all when a device is frozen. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/grabs.c | 132 +++ hw

[PATCH 1/2] DIX: Make PrintWindowTree actually useful

2011-06-14 Thread Daniel Stone
Rewrite PrintWindowTree to make it actually tell you what you want to know. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/window.c | 125 ++ include/window.h |2 + 2 files changed, 100 insertions(+), 27 deletions(-) diff

Re: [PATCH input-synaptics 2/5] Do not install ChangeLog and README with documentation

2011-06-14 Thread Daniel Stone
Hi, On Tue, Jun 14, 2011 at 02:32:07PM -0400, Gaetan Nadon wrote: On Tue, 2011-06-14 at 19:12 +0100, Daniel Stone wrote: On Tue, Jun 14, 2011 at 02:09:55PM -0400, Gaetan Nadon wrote: I am surprised it has never be done for so many years. I looked around in my distro and it does not seem

Re: non-recursive make (was: [PATCH input-synaptics 2/5] Do not install ChangeLog and README with documentation)

2011-06-14 Thread Daniel Stone
On Tue, Jun 14, 2011 at 04:02:45PM -0700, Dan Nicholson wrote: On Tue, Jun 14, 2011 at 12:31 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: xserver on the other hand is huge and could probably be much more parallel via a non-recursive top-level makefile, but that makefile would be

Re: [PATCH] dix: avoid calling deleted block and wakeup handlers

2011-06-14 Thread Daniel Stone
can result in the X server segfaulting after device removal, or events that result in device removal such as undocking or suspend/ resume. Signed-off-by: Scott James Remnant sc...@netsplit.com Reviewed-by: Daniel Stone dan...@fooishbar.org I've pulled this into my tree (which currently

Re: non-recursive make (was: [PATCH input-synaptics 2/5] Do not install ChangeLog and README with documentation)

2011-06-14 Thread Daniel Stone
Hi, On Tue, Jun 14, 2011 at 05:42:44PM -0700, Dan Nicholson wrote: One thing I'd note is that I don't think libxorg.la is needed at all. It just collects a bunch of other convenience libraries together. You could just as easily add them directly to the Xorg link command. Especially since

Re: [PATCH evdev 2/3] Print abs axes ranges on verbosity 6.

2011-06-14 Thread Daniel Stone
].maximum, pEvdev-absinfo[i].minimum); } } Hm, having this in decimal form is probably more useful since all the client utilities spit out decimal form only, but I can see the argument for synergy with kernel-side evdev. Either way, for the series: Reviewed-by: Daniel Stone dan

Re: [PATCH 07/15] Replace the motion estimator

2011-06-10 Thread Daniel Stone
Hi, On Fri, Jun 10, 2011 at 10:17:42AM +0200, walter harms wrote: Am 09.06.2011 21:57, schrieb Daniel Stone: From: Derek Foreman derek.fore...@collabora.co.uk Use a smarter motion estimator that attempts to draw a best-fit line through the history where possible, including taking

Re: [PATCH 27/27] Input: Add smooth-scrolling support to GetPointerEvents

2011-06-10 Thread Daniel Stone
On Fri, Jun 10, 2011 at 03:57:53PM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 04:19:14PM +0100, Daniel Stone wrote: a bit of a side-issue with this approach is that the scroll events lose valuator information. we hit that one with the wacom driver where one of my patches

Re: [PATCH:xkbcomp] Replace repeated checks for gcc with _X_ATTRIBUTE_PRINTF from xproto

2011-06-09 Thread Daniel Stone
On Tue, Jun 07, 2011 at 11:55:25PM -0700, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Daniel Stone dan...@fooishbar.org Feel free to push, ta. Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH:xkbcomp] Replace repeated checks for gcc with _X_ATTRIBUTE_PRINTF from xproto

2011-06-09 Thread Daniel Stone
Hi, On Wed, Jun 08, 2011 at 05:52:08PM -0700, Alan Coopersmith wrote: On 06/ 8/11 01:06 AM, Mark Kettenis wrote: Strangely formatted code, but that's not your fault. Yeah, xkbcomp's utils.h is rather messy all around - but as I looked at cleaning it up I saw so many things that needed

Re: [PATCH 26/27] Input: Split GetPointerEvents body into a helper function

2011-06-09 Thread Daniel Stone
Hi, On Tue, Jun 07, 2011 at 03:58:42PM +1000, Peter Hutterer wrote: getevents.c is one of the few files that is consistent with static functions being lowercase, even though they use foo_bar and fooBar style. Yay, I did something right! ;) wouldn't mind switching all of them to foo_bar at

Re: [PATCH 27/27] Input: Add smooth-scrolling support to GetPointerEvents

2011-06-09 Thread Daniel Stone
Hi, On Tue, Jun 07, 2011 at 04:29:45PM +1000, Peter Hutterer wrote: On Fri, Jun 03, 2011 at 04:00:03PM +0100, Daniel Stone wrote: @@ -60,11 +61,13 @@ #include X11/extensions/XI.h #include X11/extensions/XI2.h #include X11/extensions/XIproto.h +#include X11/extensions/XI2.h does

[PATCH xserver v2 0/27] Input cleanup and smooth-scrolling support

2011-06-09 Thread Daniel Stone
Hi, On Tue, Jun 07, 2011 at 04:29:56PM +1000, Peter Hutterer wrote: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net for patches #1, #3, #5, #6, #8, #9, #10, #11, #12, #13, #14, #17 (see comment below), #18, #19, #20, #21, #22, #23, #24, #25, #26 (given a rename) and all given the trunc()

[PATCH 04/28] Input: Reset SD remainder when copying co-ords from MD

2011-06-09 Thread Daniel Stone
In updateSlaveDeviceCoords, pDev-last.valuators was being copied from the master, but pDev-last.remainder wasn't. Make sure we copy both, to avoid minor inconsistencies. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- dix/getevents.c

<    4   5   6   7   8   9   10   11   12   13   >