Re: [PATCH xf86-input-libinput] Swap the registered input device on DEVICE_OFF when needed

udevadm trigger --type=devices --action=add Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- Changes to the RFC: - checking for the driver now src/xf86lib

Re: [PATCH RFC xf86-input-libinput] Swap the registered input device on DEVICE_OFF when needed

Hi, On 10/14/2016 09:13 AM, Peter Hutterer wrote: If we don't swap out the pInfo previously passed to xf86AddEnabledDevice(), the thread eventually calls read_input on a struct that has been deleted. Avoid this by swapping out the to-be-destroyed pInfo with the first one we find. FIXME:

Re: [PATCH xserver] inputthread: Re-add fd to the inputThreadInfo->fds pollfd set when re-added

Hi, On 10/14/2016 06:38 AM, Peter Hutterer wrote: On Wed, Oct 12, 2016 at 04:55:08PM +0200, Hans de Goede wrote: If the following call sequence happens: 1) InputThreadUnregisterDev(fd) 2) close(fd) 3) fd = open(...) /* returns same fd as just closed */ 4) InputThreadRegisterDev(fd

[PATCH xserver] inputthread: Re-add fd to the inputThreadInfo->fds pollfd set when re-added

lfd set, rather then removing it and adding the new one, causing some devices to not work after a vt-switch when using xf86-input-evdev. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=97880 Reported-and-tested-by: Mihail Konev <k@ya.ru> Signed-off-by: Hans de Goede <hdego..

Re: [PATCH] inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal

Hi, On 10/09/2016 11:52 PM, Mihail Konev wrote: Hello. On Wed, 5 Oct 2016 14:45:20 +0200, Hans de Goede wrote: When a fd is removed dev->state gets set to device_state_removed, if the fd then gets re-added before InputThreadDoWork() deals with the removal, the InputThreadDevice struct g

[xserver PULL for 1.19] Various fixes

) Hans de Goede (1): inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal Michel Dänzer (2): xf86Cursor: Use PRIME master xf86CursorScreenRec::HotX/Y for slaves xf86Cursor: Take the input lock in xf86Set/MoveCursor

Re: [PATCH xf86-input-libinput] Fix crash when using threaded input and the first device goes away

Hi, On 10/10/2016 11:10 AM, Emil Velikov wrote: Hi Hans, On Wednesday, 5 October 2016, Hans de Goede <hdego...@redhat.com <mailto:hdego...@redhat.com>> wrote: When the xserver uses threaded input, it keeps a pointer to the InputInfo passed into xf86AddEnabledDevice and c

Null pointer deref in FlushAllOutput with 1.19-rc1 ?

Hi All, Multiple Fedora 25 users running 1.19-rc1 are reporting a backtrace related to an InitFonts -> SendErrorToClient -> FlushAllOutput call chain. Since there is no trivial reproducer this is somewhat hard to debug, hence this mail. Anyone have a clue / hint ? See:

Re: [xserver] input: fix VT switch disabling devices

Hi, On 24-09-16 19:55, Mihail Konev wrote: Make sure device removes are processed before doing a VT switch, so that no removes are "overwritten" with attachments afterwards (before the main thread releases the input lock, letting them be processed), which would leave affected devices disabled.

Re: [PATCH xserver v2 1/2] xf86Cursor: Use PRIME master xf86CursorScreenRec::HotX/Y for slaves

be NULL (Hans de Goede) Signed-off-by: Michel Dänzer <michel.daen...@amd.com> v2 series looks good to me, both patches are: Reviewed-by: Hans de Goede <hdego...@redhat.com> REgards, Hans --- hw/xfree86/ramdac/xf86HWCurs.c | 20 1 file changed, 16 i

Re: [PATCH xf86-input-libinput] Fix crash when using threaded input and the first device goes away

Hi, On 05-10-16 15:31, Hans de Goede wrote: When the xserver uses threaded input, it keeps a pointer to the InputInfo passed into xf86AddEnabledDevice and calls pointer->read_input on events. But when the first enabled device goes away the pInfo we've passed into xf86AddEnabledDevice g

[PATCH xf86-input-libinput] Fix crash when using threaded input and the first device goes away

t gets overwritten (or pInfo points to unmapped memory) leading to a segfault. This commit fixes this by replacing the pInfo passed into xf86AddEnabledDevice with a pointer to a global InputInfo stored inside the driver_context struct. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/xf

[PATCH] inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal

ork() run, resulting in a non functioning input device. This commit fixes this by (re-)setting dev->state to device_state_running when a InputThreadDevice struct gets reused. This fixes input devices sometimes no longer working after a vt-switch. Signed-off-by: Hans de Goede <hdego...@r

Re: [PATCH xserver 0/3] xf86Cursor: Fix HW cursor positioning issues

Hi, On 05-10-16 11:45, Hans de Goede wrote: Hi, On 05-10-16 11:41, Michel Dänzer wrote: From: Michel Dänzer <michel.daen...@amd.com> I wanted to enable HW cursors on PRIME slave screens in our drivers, but noticed that a few things aren't quite right yet. The series is ordered from th

Re: [PATCH xserver 0/3] xf86Cursor: Fix HW cursor positioning issues

d-by: Hans de Goede <hdego...@redhat.com> Regards, Hans Michel Dänzer (3): xf86Cursor: Use CursoreRec::bits->x/yhot in xf86MoveCursor xf86Cursor: Use CursoreRec::bits->x/yhot in xf86SetCursor xf86Cursor: Take the input lock in xf86Set/MoveCursor hw/xfree86/ra

Re: [PATCH xserver] glamor: Use eglGetPlatformDisplayEXT not eglGetDisplay

of display it is. The explicit call to eglGetProcAddress is to work around a bug in libepoxy 1.3, which does not understand EGL client extensions and so its resolver code will crash. Signed-off-by: Adam Jackson <a...@redhat.com> Patch looks good to me and is: Reviewed-by: Hans de Goede

PATCH v2: Add xorg-xserver 1.19 support to tigervnc

Hi, Here is the promised v2 of my patch to add 1.19 support to tigervnc, this time with code to properly request write-ready notification when necessary. As mentioned in the original thread, I believe that there is a bug in tigervnc-1.7.0/common/rdr/FdOutStream.cxx: FdOutStream::flush(). When

Re: [tigervnc-devel] PATCH: Add xorg-xserver 1.19 support to tigervnc

Hi, On 10/04/2016 04:45 PM, Pierre Ossman wrote: On 03/10/16 17:59, Hans de Goede wrote: Hello tigervnc devs, As part of updating Fedora to xserver 1.19 I've written a tiger vnc patch to make tigervnc work with xserver 1.19. Nice, Thanks. :) Since xserver 1.19 switches from select

[PATCH xf86-video-qxl] Fix crash caused by attempting to access the screen pixmap before it is created

irtual(). This commit fixes this. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1381045 Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/qxl.h| 1 + src/qxl_driver.c | 6 +++--- src/qxl_kms.c| 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a

Re: [Spice-devel] [PATCH xf86-video-qxl] Adjust xspice_wakeup_handler() prototype for building xspice with server 1.19

Hi, On 03-10-16 12:04, Christophe Fergeau wrote: On Thu, Sep 29, 2016 at 01:03:01PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/spiceqxl_main_loop.c | 4 1 file changed, 4 insertions(+) diff --git a/src/spiceqxl_main_loop.c

Re: PATCH: Add xorg-xserver 1.19 support to tigervnc

Hi, On 03-10-16 18:57, Eric Engestrom wrote: On Mon, Oct 03, 2016 at 05:59:33PM +0200, Hans de Goede wrote: Hello tigervnc devs, As part of updating Fedora to xserver 1.19 I've written a tiger vnc patch to make tigervnc work with xserver 1.19. Since xserver 1.19 switches from select to poll

PATCH: Add xorg-xserver 1.19 support to tigervnc

Hello tigervnc devs, As part of updating Fedora to xserver 1.19 I've written a tiger vnc patch to make tigervnc work with xserver 1.19. Since xserver 1.19 switches from select to poll the changes are non trivial and require some #ifdef-s. The new code is a lot cleaner then the old code though,

Re: [PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5

allers. Signed-off-by: Michael Thayer <michael.tha...@oracle.com> Series looks good to me and is: Reviewed-by: Hans de Goede <hdego...@redhat.com> As discussed this will need to wait till we start the 1.20 cycle before it can be merged (it contains a video driver ABI change) Regards,

[PATCH 2/2] xfree86: Try harder to find atleast 1 non GPU Screen

y solution, but it is the best I can come up with without major surgery to the bus and probe code. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/common/xf86.h| 1 + hw/xfree86/common/xf86Bus.c | 26 +++--- hw/xfree86/common/xf86Gl

[PATCH 1/2] xfree86: Make adding unclaimed devices as GPU devices a separate step

ver adding a device as GPUscreen before a driver which only supports the old PCI probe method gets a chance to claim it as a normal screen. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/common/xf86Bus.c | 4 hw/xfree86/common/xf86platformBus.c | 15 +++

[PATCH] xfree86: Remove redundant ServerIsNotSeat0 check from xf86CallDriverProbe

If foundScreen is TRUE, then all the code below the removed if will not execute until we reach the return foundScreen; at the end, so this entire if block is redundant. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/common/xf86Bus.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH xf86-video-omap] Use NotifyFd for drm fd

NotifyFd is available after API 22, and must be used after API 23. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/compat-api.h | 4 src/drmmode_display.c | 25 + 2 files changed, 29 insertions(+) diff --git a/src/compat-api.h b/src/compat

[PATCH xf86-video-voodoo] Remove obsolete miInitializeBackingStore() call

Recent servers do not need this, and the latest servers do not even provide it. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/voodoo_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/voodoo_driver.c b/src/voodoo_driver.c index 6ef12ae..04b6d9c 100644 ---

[PATCH xf86-video-vmware] Adapt Block/WakeupHandler signature for ABI 23

Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/compat-api.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compat-api.h b/src/compat-api.h index 205ac59..02876c5 100644 --- a/src/compat-api.h +++ b/src/compat-api.h @@ -75,8 +75,13 @@ #define SCREEN_INIT_ARG

[PATCH xf86-video-sisusb] Adapt Block/WakeupHandler signature for ABI 23

Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/compat-api.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compat-api.h b/src/compat-api.h index 6bc946f..89976e4 100644 --- a/src/compat-api.h +++ b/src/compat-api.h @@ -75,8 +75,13 @@ #define SCREEN_INIT_ARG

[PATCH xf86-video-opentegra] Adapt Block/WakeupHandler signature for ABI 23

Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/compat-api.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compat-api.h b/src/compat-api.h index bef28ed..294876a 100644 --- a/src/compat-api.h +++ b/src/compat-api.h @@ -76,8 +76,13 @@ #define SCREEN_INIT_ARG

[PATCH xf86-video-qxl] Adjust xspice_wakeup_handler() prototype for building xspice with server 1.19

Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/spiceqxl_main_loop.c | 4 1 file changed, 4 insertions(+) diff --git a/src/spiceqxl_main_loop.c b/src/spiceqxl_main_loop.c index db89b6d..0ac1f3e 100644 --- a/src/spiceqxl_main_loop.c +++ b/src/spiceqxl_main_loop.c @@ -330,7 +

Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

Hi, On 28-09-16 16:54, Michael Thayer wrote: Hello Hans, On 28.09.2016 15:37, Hans de Goede wrote: Hi Michael, On 28-09-16 14:47, Michael Thayer wrote: [...] On 09/16/2016 06:52 PM, Michael Thayer wrote: When the X server asks us to load a hardware cursor, that request is always followed

[PATCH xserver v2] autobind GPUs to the screen

org.conf snippet. Signed-off-by: Dave Airlie <airl...@gmail.com> [hdego...@redhat.com: Make configurable, submit upstream] Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Make the default enabled instead of installing a xorg.conf snippet which enables it unconditio

Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

Hi Michael, On 28-09-16 14:47, Michael Thayer wrote: Hello, On 28.09.2016 09:58, Hans de Goede wrote: Hi, On 28-09-16 05:05, Michel Dänzer wrote: [...] On 09/16/2016 06:52 PM, Michael Thayer wrote: When the X server asks us to load a hardware cursor, that request is always followed up

Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

Hi, On 28-09-16 05:05, Michel Dänzer wrote: On 27/09/16 10:54 PM, Michael Thayer wrote: On 27.09.2016 12:06, Hans de Goede wrote: On 23-09-16 10:20, Hans de Goede wrote: On 09/16/2016 06:52 PM, Michael Thayer wrote: When the X server asks us to load a hardware cursor, that request is always

[xserver PULL for 1.19 v2] Various modesetting and other fixes

ter (2016-09-27 12:25:03 +0200) Adam Jackson (1): xephyr: Don't crash if the server advertises zero xv adaptors Daniel Martin (1): modesetting: Consume all available udev events at once David CARLIER (1): xfree86: small memory leaks fixes Hans d

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

Hi, On 25-09-16 09:51, Michel Dänzer wrote: On 23/09/16 07:48 PM, Hans de Goede wrote: On 09/23/2016 11:13 AM, Michel Dänzer wrote: On 23/09/16 03:46 PM, Hans de Goede wrote: Since this is a fallback which ideally should never get used (all drivers should call xf86HandleColormaps) I believe

Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

Hi, On 23-09-16 10:20, Hans de Goede wrote: Hi All, On 09/16/2016 06:52 PM, Michael Thayer wrote: When the X server asks us to load a hardware cursor, that request is always followed up by a request to show it if we report success, or to hide it if we report failure. Therefore it makes

Re: [xserver PULL for 1.19] Various modesetting and other fixes

Hi, On 23-09-16 15:09, Hans de Goede wrote: Hi Adam, Keith, Here is a pull-req consisting of a bunch of fixes written by me reviewed by others as well as a bunch of fixes from patchwork / the list which I've picked up and which are reviewed by me. Note there is one unreviewed patch in here v2

Re: 2 patches for glamor on OpenBSD (without DRI3/XSHM_FENCE)

/65081/ Both links seem to point to post + re-post of the same patch, so I see only 1 patch? The linked to patch LGTM and is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans ___ xorg-devel@lists.x.org: X.Org development Archives

[xserver PULL for 1.19] Various modesetting and other fixes

- Adam Jackson (1): xephyr: Don't crash if the server advertises zero xv adaptors Daniel Martin (1): modesetting: Consume all available udev events at once David CARLIER (1): xfree86: small memory leaks fixes Hans de Goede (8): modesetting: Fix reverse prime partial upd

Re: xfree86: Fix null pointer dereference

Hi, On 09/23/2016 03:33 PM, Eric Engestrom wrote: On Fri, Sep 23, 2016 at 03:12:18PM +0300, Hans de Goede wrote: Hi, On 01/13/2016 07:47 AM, Kyle Guinn wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93675 Signed-off-by: Kyle Guinn <ely...@gmail.com> Thanks for the patch

Re: [xserver] modesetting: Consume all available udev events at once

Hi, On 12/11/2015 01:05 PM, Daniel Martin wrote: From: Daniel Martin We get multiple udev events for actions like docking a laptop into its station or plugging a monitor to the station. By consuming as much events as we can, we reduce the number of output

Re: [PATCH xserver 1/2] Xext: Fix a memory leak

Hi, On 09/23/2016 03:23 PM, Emil Velikov wrote: On 23 September 2016 at 12:50, Hans de Goede <hdego...@redhat.com> wrote: Based on: https://patchwork.freedesktop.org/patch/85636/ Rewritten to also free the resources allocated by panoramix_setup_ids(). The codeflow is a bit nasty t

Re: xfree86: Fix null pointer dereference

Hi, On 01/13/2016 07:47 AM, Kyle Guinn wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93675 Signed-off-by: Kyle Guinn Thanks for the patch, I've queued this up at: https://cgit.freedesktop.org/~jwrdegoede/xserver For a 1.19 bug-fix pull-req I'm preparing at.

Re: PATCH xserver small memory leaks fixes

Hi David, On 05/05/2016 10:39 AM, David CARLIER wrote: Hi all, This is a small patch to fix couple of small memory leaks. Hope it s useful. It is thanks for your patch, I've split 2 bits out into small patches and I've dropped the os/rpcauth.c change I think that you are doing the right

[PATCH xserver 2/2] XF86VidMode: Fix free() on walked pointer

Based on: https://patchwork.freedesktop.org/patch/85636/ Rewritten to just not walk the pointer. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Xext/vidmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Xext/vidmode.c b/Xext/vidmode.c index 499a2a8..e

[PATCH xserver 1/2] Xext: Fix a memory leak

Based on: https://patchwork.freedesktop.org/patch/85636/ Rewritten to also free the resources allocated by panoramix_setup_ids(). Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Xext/shm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Xext/shm.c b/Xext

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

Hi, On 09/23/2016 11:13 AM, Michel Dänzer wrote: On 23/09/16 03:46 PM, Hans de Goede wrote: On 09/20/2016 04:58 AM, Michel Dänzer wrote: If there are other drivers which can't call xf86HandleColormaps for some reason, a better solution would be to combine the per-screen gamma set via pScrn

[PATCH xserver] modesetting: Do not call drmModeSetCursor2() twice on every cursor change

led in the mean time make drmmode_show_cursor() a no-op. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Note this patch applies on top of Michael Thayer's "modesetting: allow switching from software to hardware cursors (v4)" series --- hw/xfree86/drivers/modesetting/dr

Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans Signed-off-by: Michael Thayer <michael.tha...@oracle.com> --- Tested that both hardware and software cursors still work after applying the patch. hw/xfree86/drivers/modesetting/drmmode_display.c | 11 +--

Re: [PATCH xserver] modesetting: only fall back to drmModeSetCursor() on -EINVAL

but not cursor_set2, and in this case the call to drmModeSetCursor2() will always return -EINVAL. Specifically, a return value of -ENXIO usually means that neither are supported. Signed-off-by: Michael Thayer <michael.tha...@oracle.com> LGTM: Reviewed-by: Hans de Goede <hdego...@r

Re: [PATCH 1/1] Simplify, statement is always true.

Hi, On 09/22/2016 03:08 AM, Maya Rashish wrote: pVideo->bus is uint8_t, always less than 256. Signed-off-by: Maya Rashish <co...@sdf.org> LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- hw/xfree86/common/xf86pciBus.c | 6 +- 1 file chang

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

Hi, On 09/20/2016 04:58 AM, Michel Dänzer wrote: On 17/09/16 07:00 PM, Hans De Goede wrote: Commit b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma code") dropped the providing of a pScrn->ChangeGamma callback from the xf86RandR12 code. Leaving pScrn->ChangeGa

Re: [PATCH xserver] os: Eliminate NewOutputPending

Hi, On 09/22/2016 11:34 AM, Keith Packard wrote: By removing clients from output_pending_clients list when flushing is attempted, that list now becomes the list of clients that need flushing, which is equivalent to what NewOutputPending was used for. Clients are added to output_pending_clients

Re: [PATCH xserver v2] xwayland: Clear up x_cursor on UnrealizeCursor()

l <jad...@gmail.com> Also LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- v2: Use xorg_list_for_each_entry() instead of xorg_list_for_each_entry_safe() as suggested by Jonas and add his r-b as per his review. hw/xwayland/xwayland-cursor.c | 7 ---

Re: [PATCH xserver] os: Eliminate NewOutputPending

when data are added to their output buffer and when write blocked clients become writable. Signed-off-by: Keith Packard <kei...@keithp.com> Patch LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- os/WaitFor.c| 2 +- os/connection.c | 3

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

Hi, On 09/20/2016 03:24 AM, Michel Dänzer wrote: On 17/09/16 01:38 AM, Eric Anholt wrote: Keith Packard <kei...@keithp.com> writes: Hans de Goede <hdego...@redhat.com> writes: So it looks like we really need glFinish to ensure proper ordering here (and I've just de

[PATCH xserver v2] glx: Always enable EXT_texture_from_pixmap for DRI swrast glx

advertise EXT_texture_from_pixmap unconditionally again fixing this. Fixes: f95645c6f700 ("glx: Don't enable EXT_texture_from_pixmap unconditionally") Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Only add unconditional advertising of GLX_EXT_texture_from

[PATCH xserver 1/2] xf86RandR12: Move calculating of shift inside init_one_component

This is a preparation patch to allow easier usage of init_one_component outside of xf86RandR12CrtcInitGamma. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/modes/xf86RandR12.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/xfree86

[PATCH xserver 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

d adjusting it to work with the new combined palette / gamma code. Fixes: b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma code") Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/modes/xf86RandR12.c | 29 + 1 file changed, 29 insert

Re: [PATCH xserver] modesetting: Fix build without glamor

Hi, On 16-09-16 17:20, Olivier Fourdan wrote: Build would abort if configure without glamor: | present.c: error: implicit declaration of function | ‘ms_flush_drm_events’ [-Werror=implicit-function-declaration] | if (errno != EBUSY || ms_flush_drm_events(screen) < 0) {

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

Hi, On 16-09-16 09:58, Michel Dänzer wrote: On 16/09/16 04:18 PM, Hans de Goede wrote: On 16-09-16 04:00, Michel Dänzer wrote: On 16/09/16 06:50 AM, Eric Anholt wrote: Hans de Goede <hdego...@redhat.com> writes: When using reverse prime we do 2 copies, 1 from the primary GPU's frame

Re: [PATCH xserver] damage: Add screen func called before damage event delivery

Hi, On 16-09-16 10:59, Michel Dänzer wrote: On 16/09/16 05:37 PM, Hans de Goede wrote: On 16-09-16 08:26, Michel Dänzer wrote: On 16/09/16 01:37 PM, Keith Packard wrote: This lets the video driver flush rendering to the kernel before the client receives a damage event to a pixmap which

Re: [PATCH xserver] damage: Add screen func called before damage event delivery

Hi, On 16-09-16 08:26, Michel Dänzer wrote: On 16/09/16 01:37 PM, Keith Packard wrote: This lets the video driver flush rendering to the kernel before the client receives a damage event to a pixmap which the client has direct rendering access to. I'm afraid I'm not sure this is going in a

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors (v3).

Hi, On 15-09-16 20:53, Michael Thayer wrote: Hello, On 15.09.2016 19:18, Hans de Goede wrote: Hi, * drop the special case for loading a cursor sprite when the cursor is hidden: we set HARDWARE_CURSOR_UPDATE_UNHIDDEN, so all calls to load_cursor will be followed by calls

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

Hi, On 16-09-16 04:00, Michel Dänzer wrote: On 16/09/16 06:50 AM, Eric Anholt wrote: Hans de Goede <hdego...@redhat.com> writes: When using reverse prime we do 2 copies, 1 from the primary GPU's framebuffer to a shared pixmap and 1 from the shared pixmap to the secondary GPU's frame

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors (v3).

Hi, On 15-09-16 16:40, Michael Thayer wrote: Hello Hans, On 15.09.2016 16:12, Hans de Goede wrote: Hi, On 15-09-16 12:04, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to try

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors (v3).

Hi, On 15-09-16 12:04, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to try a hardware cursor first every time a new one is set. This is needed because hardware may be able to handle

[PATCH xserver 2/2] modesetting: Fix reverse prime update lagging on secondary GPU outputs

contents (e.g. a just closed window) for easily up to 10 seconds. This commit fixes this by setting the timeout passed into the blockhandler to 0 if any shared pixmaps were updated by the primary GPU, forcing an immediate re-run of all blockhandlers. Signed-off-by: Hans de Goede <hdego...@redhat.

[PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/driver.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modesetting/driver.c index a8e83b2..f98d6da 100644 --- a/hw/xfree86/d

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors.

Hi, On 14-09-16 15:53, Michael Thayer wrote: On 14.09.2016 12:07, Hans de Goede wrote: Hi, On 13-09-16 17:42, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to try a hardware cursor

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors.

Hi, On 13-09-16 17:42, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to try a hardware cursor first every time a new one is set. This is needed because hardware may be able to handle

Re: [xserver PULL master] Modesetting driver prime fixes (unreviewed)

Hi, On 13-09-16 17:45, Adam Jackson wrote: On Tue, 2016-09-13 at 12:53 +0200, Hans de Goede wrote: The following changes since commit 35c4e96ed1d372dd161480be8cddcd2d4549e449: randr: Fix crtc_bounds when using rotation combined with reflection (2016-09-13 10:27:30 +0200) are available

Re: [xserver PULL master] Modesetting driver prime fixes (unreviewed)

Hi, On 13-09-16 12:53, Hans de Goede wrote: Hi Adam, Keith, Here is a pull-req for 4 modesetting driver prime fixes, which I've had ready for quite a while now. I've asked various people at various time to review these, but I've failed to get anyone to look at them. So now I'm asking you

[xserver PULL master] Modesetting driver prime fixes (unreviewed)

to fetch changes up to 08cfeecd524729589cd6b7c6e6fe65211b268dae: modesetting: Fall back to primary crtc for vblank for drawables on slave outputs (2016-09-13 12:40:13 +0200) Hans de Goede (4): modesetting

[xserver PULL master] Prime hw cursor support

with reflection (2016-09-13 10:27:30 +0200) Dave Airlie (3): dix: Add dixPrivatesCreated helper function xf86Cursor: Add xf86CheckHWCursor() helper function xf86Cursor: Add hw cursor support for prime Hans de Goede (10

Re: [PATCH xf86-input-libinput] Correct the horizontal scroll property name

<peter.hutte...@who-t.net> Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- Just sending this to the list as a sort-of heads-up. include/libinput-properties.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libinput-properties.h b/incl

Re: modesetting: allow switching from software to hardware cursors.

Hi Michael, Since the posting of this patch, the underlying code has changed, e.g. the modesetting driver does use the load_cursor_argb_check hook already now. Can you check if this patch is still necessary, and if so rebase it please ? Thanks & Regards, Hans On 06-03-16 12:56, Michael

[PATCH xserver v9] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

are not used and xf86_crtc_transform_cursor_position will never get called. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v9: -Write out the cursor coordinate conversion instead of playing tricks with (ab)using xf86_crtc_rotate_coord_back. Changes in v8: -Fix reflection on ro

Re: [PATCH v8 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

Hi, On 12-09-16 10:39, Michel Dänzer wrote: On 12/09/16 05:24 PM, Hans de Goede wrote: On 12-09-16 09:47, Michel Dänzer wrote: On 09/09/16 09:50 PM, Hans De Goede wrote: When a slave-output is rotated the transformation is done on the blit from master to slave GPU, so crtc->transform_in_

[PATCH xserver] randr: Fix crtc_bounds when using rotation combined with reflection

is wrong in this case. This would lead to the cursor being constrained to a height x height area of the monitor. This commit masks out the reflection bits for the switch-case, making crtc_bounds return the correct bounds and fixing the problematic cursor constraining. Signed-off-by: Hans de Goede <hd

Re: [PATCH v8 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

Hi, On 12-09-16 10:39, Michel Dänzer wrote: On 12/09/16 05:24 PM, Hans de Goede wrote: On 12-09-16 09:47, Michel Dänzer wrote: On 09/09/16 09:50 PM, Hans De Goede wrote: When a slave-output is rotated the transformation is done on the blit from master to slave GPU, so crtc->transform_in_

Re: [PATCH v8 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

Hi, On 12-09-16 09:47, Michel Dänzer wrote: On 09/09/16 09:50 PM, Hans De Goede wrote: When a slave-output is rotated the transformation is done on the blit from master to slave GPU, so crtc->transform_in_use is not set, but we still need to adjust the mouse position for things to w

Re: [PATCH font/arabic-misc] Typo: font.dir -> fonts.dir

Hi, On 11-09-16 22:20, Alan Coopersmith wrote: Reviewed-by: Alan Coopersmith <alan.coopersm...@oracle.com> for all the fonts with this typo. Ack, also: Reviewed-by: Hans de Goede <hdego...@redhat.com> So Matthieu do you have xorg repo commit / push rights ? If not how are we g

Re: [PATCH:xserver] Fix modesetting build when glamor is disabled

Hi, On 10-09-16 20:05, Alan Coopersmith wrote: present.c: In function ‘ms_present_queue_vblank’: present.c:144:31: error: implicit declaration of function ‘ms_flush_drm_events’ [-Werror=implicit-function-declaration] if (errno != EBUSY || ms_flush_drm_events(screen) < 0) {

Re: [RESEND xserver] glx: Always enable EXT_texture_from_pixmap for DRI glx

Hi, On 09-09-16 18:31, Adam Jackson wrote: On Fri, 2016-09-09 at 16:02 +0200, Hans de Goede wrote: glx/glxdri2.c | 6 -- https://lists.freedesktop.org/archives/xorg-devel/2016-September/050853.html Ah I somehow missed that reply, sorry. I'll do a v2 with the suggested change

[RESEND xserver 0/1] glx: Always enable EXT_texture_from_pixmap for DRI glx

Hi All, I know that when this was sent before it was not liked because things should really be fixed in Mesa, but in the mean time no-one has stepped up and fixed Mesa. Without this patch 1.19 will regress users who rely on llvmpipe, e.g. people running gnome as desktop in VMs, so I believe that

[RESEND xserver] glx: Always enable EXT_texture_from_pixmap for DRI glx

advertise EXT_texture_from_pixmap unconditionally again fixing this. Fixes: f95645c6f700 ("glx: Don't enable EXT_texture_from_pixmap unconditionally") Signed-off-by: Hans de Goede <hdego...@redhat.com> --- glx/glxdri2.c | 6 -- glx/glxdriswrast.c | 3 +-- 2 files changed, 5

modesetting driver maintenance

Hi All, I've several modesetting driver patches which have been awaiting review for a while now: https://patchwork.freedesktop.org/patch/105350/ https://patchwork.freedesktop.org/patch/105351/ https://patchwork.freedesktop.org/patch/105352/ https://patchwork.freedesktop.org/patch/107096/

Re: [PATCH v7 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

Hi, On 09-09-16 03:11, Michel Dänzer wrote: On 08/09/16 07:08 PM, Hans De Goede wrote: When a slave-output is rotated the transformation is done on the blit from master to slave GPU, so crtc->transform_in_use is not set, but we still need to adjust the mouse position for things to w

[PATCH v8 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

are not used and xf86_crtc_transform_cursor_position will never get called. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v8: -Fix reflection on rotated outputs (use xf86_crtc_rotate_coord_back again) -Only call xf86_crtc_transform_cursor_position when rotating or reflecting (instead of always

[PATCH v7 xserver 7/7] xf86Cursor: Add hw cursor support for prime

nabled, and also calls set cursor and move cursor on all screens. Cc: Aaron Plattner <aplatt...@nvidia.com> Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: Ke

[PATCH v7 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

are not used and xf86_crtc_transform_cursor_position will never get called. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v7: -Do not use xf86_crtc_rotate_coord_back, it is not suitable for our purposes -Modify xf86_crtc_transform_cursor_position instead of adding a new xf86_crtc_transform_g

[PATCH v7 xserver 3/7] xf86Cursor: Add xf86CheckHWCursor() helper function

From: Dave Airlie <airl...@redhat.com> This is a preparation patch for adding prime hw-cursor support. Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v6 (Hans de Goede): -Do not remove xorg_list_is_empty(

[PATCH v7 xserver 1/7] dix: Add dixPrivatesCreated helper function

From: Dave Airlie <airl...@redhat.com> This is a preparation patch for adding prime hw-cursor support. Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> ---

[PATCH v7 xserver 4/7] xf86Cursor: Fix xf86CurrentCursor to work on slave GPU Screens

The CurrentCursor is always attached to the master GPU. Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> --- hw/xfree86/ramdac/xf86Cursor.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/xf

[PATCH v7 xserver 2/7] randr: Add RRHasScanoutPixmap helper function

This is a preparation patch for adding prime hw-cursor support. Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> --- randr/randrstr.h | 6 ++ randr/rrcrtc.c | 19 +++ 2 files changed, 25 insertions(+)

[PATCH v7 xserver 5/7] xf86Cursor: Fix xf86_crtc_rotate_coord using width/height wrongly

xf86_crtc_rotate_coord until now was only used with cursor_info->MaxWidth and cursor_info->MaxHeight, which are usally the same. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v7: -Fix xf86_crtc_rotate_coord instead of xf86_crtc_rotate_coord_back, as it actually is xf86_crtc_rotate

<    1   2   3   4   5   6   7   8   9   >