[PATCH v2 xserver] glamor: Fix crash when master gpu is using glamor and another gpu is hotplugged

we cannot use glamor_make_current() here to replace the eglMakeCurrent() call and update lastGLContext for us because glamor_make_current takes a glamor_priv struct as argument and that has not been created yet when glamor_egl_init() gets called. Signed-off-by: Hans de Goede <hdego...@redh

Re: [PATCH v5 xserver 5/7] xf86Cursor: Fix xf86_crtc_rotate_coord_back using width/height wrongly

Hi, On 08-09-16 09:24, Michel Dänzer wrote: On 08/09/16 04:18 PM, Hans de Goede wrote: On 08-09-16 07:59, Michel Dänzer wrote: On 08/09/16 02:32 PM, Hans de Goede wrote: On 08-09-16 03:10, Michel Dänzer wrote: On 08/09/16 12:43 AM, Hans de Goede wrote: [0] BTW, do we really need two

Re: [PATCH v5 xserver 5/7] xf86Cursor: Fix xf86_crtc_rotate_coord_back using width/height wrongly

Hi, On 08-09-16 07:59, Michel Dänzer wrote: On 08/09/16 02:32 PM, Hans de Goede wrote: On 08-09-16 03:10, Michel Dänzer wrote: On 08/09/16 12:43 AM, Hans de Goede wrote: xf86_crtc_rotate_coord_back() is described as "Given a cursor source coordinate, rotate to a screen coordinate&q

Re: [PATCH v5 xserver 5/7] xf86Cursor: Fix xf86_crtc_rotate_coord_back using width/height wrongly

Hi, On 08-09-16 03:10, Michel Dänzer wrote: On 08/09/16 12:43 AM, Hans de Goede wrote: /* * Given a screen coordinate, rotate back to a cursor source coordinate */ xf86_crtc_rotate_coord(...) /* * Given a cursor source coordinate, rotate to a screen coordinate

Re: [PATCH xserver] glamor: Fix crash when master gpu is using glamor and another gpu is hotplugged

Hi, On 07-09-16 20:19, Eric Anholt wrote: Hans de Goede <hdego...@redhat.com> writes: Hi, On 06-09-16 22:22, Eric Anholt wrote: Hans de Goede <hdego...@redhat.com> writes: When a GPU gets hotplugged while X is already running, glamor_egl_init() gets called and changes the

Re: [PATCH xserver 4/4] xfree86: promote one GPU screen if (NumScreens == 0 && NumGPUScreens > 0)

Hi, On 06-09-16 22:32, Laszlo Ersek wrote: On 09/06/16 14:46, Hans de Goede wrote: Hi, On 06-09-16 13:47, Laszlo Ersek wrote: Adding Matt and Ard On 09/06/16 00:32, Dave Airlie wrote: Picking different primaries on different boots sounds perfectly acceptable to me as long

Re: [PATCH xserver 4/4] xfree86: promote one GPU screen if (NumScreens == 0 && NumGPUScreens > 0)

Hi, On 07-09-16 12:20, Laszlo Ersek wrote: On 09/07/16 11:54, Hans de Goede wrote: Hi, On 06-09-16 22:32, Laszlo Ersek wrote: On 09/06/16 14:46, Hans de Goede wrote: Hi, On 06-09-16 13:47, Laszlo Ersek wrote: Adding Matt and Ard On 09/06/16 00:32, Dave Airlie wrote: Picking

[PATCH v6 xserver] autobind GPUs to the screen

com: Make configurable, submit upstream] Signed-off-by: Hans de Goede <hdego...@redhat.com> --- config/10-auto-bind-gpu.conf| 3 +++ config/Makefile.am | 4 ++-- hw/xfree86/common/xf86Config.c | 19 +++ hw/xfree86/common/xf86Globals.c | 2 ++

Re: [PATCH v6 xserver 7/7] xf86Cursor: Add hw cursor support for prime

Hi, On 07-09-16 17:38, Aaron Plattner wrote: On 09/07/2016 08:24 AM, Hans de Goede wrote: Hi, On 07-09-16 17:02, Aaron Plattner wrote: Adding Alex. On 09/07/2016 05:26 AM, Hans de Goede wrote: From: Dave Airlie <airl...@redhat.com> Currently with PRIME if we detect a secondary G

Re: [PATCH v5 xserver 5/7] xf86Cursor: Fix xf86_crtc_rotate_coord_back using width/height wrongly

Hi, On 07-09-16 17:19, Michel Dänzer wrote: On 07/09/16 08:43 PM, Hans de Goede wrote: On 07-09-16 03:21, Michel Dänzer wrote: On 06/09/16 08:31 PM, Hans De Goede wrote: xf86_crtc_rotate_coord_back should be the exact inverse operation of xf86_crtc_rotate_coord, but when calculating x / y

Re: [PATCH v6 xserver 7/7] xf86Cursor: Add hw cursor support for prime

Hi, On 07-09-16 17:02, Aaron Plattner wrote: Adding Alex. On 09/07/2016 05:26 AM, Hans de Goede wrote: From: Dave Airlie <airl...@redhat.com> Currently with PRIME if we detect a secondary GPU, we switch to using SW cursors, this isn't optimal, esp for the intel/nvidia combinations, w

Re: [PATCH xserver v2] xfree86: recognize primary BUS_PCI device in xf86IsPrimaryPlatform()

device detection code is server based, not driver based; so we might end up with a primary device which only has a PCI bus-capable driver, but was detected as primary by the platform code, or the other way around. (The above paragraph was shamelessly stolen from Hans de Goede, and customized

Re: [PATCH v5 xserver 1/7] dix: Add dixPrivatesCreated helper function

Hi, On 07-09-16 15:06, Keith Packard wrote: Hans de Goede <hdego...@redhat.com> writes: TL;DR: Yes this is not ideal, but the workaround is tiny and the improvements this patch-set brings are large, so I do not consider this a blocker. Yeah, I was reading that code and it looks po

[PATCH v6 xserver 7/7] xf86Cursor: Add hw cursor support for prime

nabled, and also calls set cursor and move cursor on all screens. Cc: Aaron Plattner <aplatt...@nvidia.com> Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> --- Changes in v6

[PATCH v6 xserver 3/7] xf86Cursor: Add xf86CheckHWCursor() helper function

From: Dave Airlie <airl...@redhat.com> This is a preparation patch for adding prime hw-cursor support. Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v6 (Hans de Goede): -Do not remove xorg_list_is_empty(

[PATCH v6 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

When a slave-output is rotated the transformation is done on the blit from master to slave GPU, so crtc->transform_in_use is not set, but we still need to adjust the mouse position for things to work. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/modes/xf86Curso

[PATCH v6 xserver 1/7] dix: Add dixPrivatesCreated helper function

From: Dave Airlie <airl...@redhat.com> This is a preparation patch for adding prime hw-cursor support. Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> ---

[PATCH v6 xserver 4/7] xf86Cursor: Fix xf86CurrentCursor to work on slave GPU Screens

The CurrentCursor is always attached to the master GPU. Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> --- hw/xfree86/ramdac/xf86Cursor.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/xf

[PATCH v6 xserver 2/7] randr: Add RRHasScanoutPixmap helper function

This is a preparation patch for adding prime hw-cursor support. Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> --- randr/randrstr.h | 6 ++ randr/rrcrtc.c | 19 +++ 2 files changed, 25 insertions(+)

Re: [PATCH v5 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

Hi, On 07-09-16 03:34, Michel Dänzer wrote: On 06/09/16 08:31 PM, Hans De Goede wrote: When a slave-output is rotated the transformation is done on the blit from master to slave GPU, so crtc->transform_in_use is not set, but we still need to adjust the mouse position for things to w

Re: [PATCH v5 xserver 5/7] xf86Cursor: Fix xf86_crtc_rotate_coord_back using width/height wrongly

Hi, On 07-09-16 03:21, Michel Dänzer wrote: On 06/09/16 08:31 PM, Hans De Goede wrote: xf86_crtc_rotate_coord_back should be the exact inverse operation of xf86_crtc_rotate_coord, but when calculating x / y for 90 / 270 degrees rotation it was using height to calculate x / width to calculate y

Re: [PATCH v5 xserver 1/7] dix: Add dixPrivatesCreated helper function

Hi, On 06-09-16 16:41, Keith Packard wrote: Hans de Goede <hdego...@redhat.com> writes: From: Dave Airlie <airl...@redhat.com> This is a preparation patch for adding prime hw-cursor support. I'm fine with this function, but the prime hw-cursor support which uses it is a pretty

Re: [PATCH xserver] glamor: Fix crash when master gpu is using glamor and another gpu is hotplugged

Hi, On 06-09-16 22:22, Eric Anholt wrote: Hans de Goede <hdego...@redhat.com> writes: When a GPU gets hotplugged while X is already running, glamor_egl_init() gets called and changes the current egl context at a point where glamor does not expect this. This causes glamor to e.g.

Re: [v5,xserver,3/7] xf86Cursor: Add xf86CheckHWCursor() helper function

Hi, On 07-09-16 02:57, Michel Dänzer wrote: On 06/09/16 08:31 PM, Hans De Goede wrote: From: Dave Airlie <airl...@redhat.com> This is a preparation patch for adding prime hw-cursor support. [...] diff --git a/hw/xfree86/ramdac/xf86Cursor.c b/hw/xfree86/ramdac/xf86Cursor.c index d

Re: [PATCH xserver 4/4] xfree86: promote one GPU screen if (NumScreens == 0 && NumGPUScreens > 0)

Hi, On 06-09-16 13:47, Laszlo Ersek wrote: Adding Matt and Ard On 09/06/16 00:32, Dave Airlie wrote: Picking different primaries on different boots sounds perfectly acceptable to me as long as: - no explicit DeviceId.BusID is specified by the user, - no primary emerges otherwise, - there

Re: [PATCH v5 xserver 3/7] xf86Cursor: Add xf86CheckHWCursor() helper function

HI, On 06-09-16 14:35, Daniel Martin wrote: Sorry for jumping in that late ... On 6 September 2016 at 13:31, Hans de Goede <hdego...@redhat.com> wrote: From: Dave Airlie <airl...@redhat.com> This is a preparation patch for adding prime hw-cursor support. Signed-off-by: Dave

[PATCH v5 xserver 1/7] dix: Add dixPrivatesCreated helper function

From: Dave Airlie <airl...@redhat.com> This is a preparation patch for adding prime hw-cursor support. Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- dix/privates.c | 9 + include/privates.h | 3 +++ 2

[PATCH v5 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

When a slave-output is rotated the transformation is done on the blit from master to slave GPU, so crtc->transform_in_use is not set, but we still need to adjust the mouse position for things to work. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/modes/xf86Curso

[PATCH v5 xserver 5/7] xf86Cursor: Fix xf86_crtc_rotate_coord_back using width/height wrongly

xf86_crtc_rotate_coord_back until now was only used with cursor_info->MaxWidth and cursor_info->MaxHeight, which are usally the same. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/modes/xf86Cursors.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/x

[PATCH v5 xserver 7/7] xf86Cursor: Add hw cursor support for prime

nabled, and also calls set cursor and move cursor on all screens. Cc: Aaron Plattner <aplatt...@nvidia.com> Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v5 (Hans de Goede): -Split out various helper functions in

[PATCH v5 xserver 4/7] xf86Cursor: Fix xf86CurrentCursor to work on slave GPU Screens

The CurrentCursor is always attached to the master GPU. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/ramdac/xf86Cursor.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/xfree86/ramdac/xf86Cursor.c b/hw/xfree86/ramdac/xf86Cursor.c index a

[PATCH v5 xserver 3/7] xf86Cursor: Add xf86CheckHWCursor() helper function

From: Dave Airlie <airl...@redhat.com> This is a preparation patch for adding prime hw-cursor support. Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/ramdac/xf86Cursor.c | 11 ++- hw/xfree86/ramda

[PATCH v5 xserver 2/7] randr: Add RRHasScanoutPixmap helper function

This is a preparation patch for adding prime hw-cursor support. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- randr/randrstr.h | 6 ++ randr/rrcrtc.c | 19 +++ 2 files changed, 25 insertions(+) diff --git a/randr/randrstr.h b/randr/randrstr.h index 1

Re: [PATCH xserver 4/4] xfree86: promote one GPU screen if (NumScreens == 0 && NumGPUScreens > 0)

Hi, On 05-09-16 14:39, Laszlo Ersek wrote: On 09/04/16 11:01, Hans de Goede wrote: If a seasoned xserver developer is interested in fixing this problem, I'd like to file an upstream bug tracker entry for it, and assign it to him/her -- I'm way out of my depth here :) I see that we've 2

Re: [PATCH xserver] cursor: add hw cursor support for prime

Hi, On 06-09-16 05:12, Keith Packard wrote: Hans de Goede <hdego...@redhat.com> writes: +if (!dixPrivatesCreated(PRIVATE_CURSOR)) +dixRegisterScreenPrivateKey(, pScreen, +PRIVATE_CURSOR, 0); + I don't understand what you're trying to d

Re: [PATCH xserver] cursor: add hw cursor support for prime

Hi, On 06-09-16 03:30, Michel Dänzer wrote: On 05/09/16 10:42 PM, Hans de Goede wrote: Hi, Subject should have contained v4, resending so that we've the right version in patchwork. Sorry. Hmm, for some reason I'm not receiving your recent patches from the mailing list, though I can see them

Re: Proposed X server 1.19 schedule

Hi, On 06-09-16 05:23, Keith Packard wrote: Hans de Goede <hdego...@redhat.com> writes: That is quick :) Fine by me, but I've a whole bunch of modesetting / prime patches (all bugfixes really) I would like to get in before then. As you can see, bug fixes are welcome until 9-2

Re: [PATCH xserver] cursor: add hw cursor support for prime

Hi, Subject should have contained v4, resending so that we've the right version in patchwork. Sorry. Regards, Hans On 05-09-16 15:37, Hans de Goede wrote: From: Dave Airlie <airl...@gmail.com> Currently with PRIME if we detect a secondary GPU, we switch to using SW cursors, this

[PATCH v4 xserver] cursor: add hw cursor support for prime

nabled, and also calls set cursor and move cursor on all screens. Cc: Aaron Plattner <aplatt...@nvidia.com> Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v4 (Hans de Goede): -Fix crash when xf86ScreenSetCursor() gets

[PATCH xserver] glamor: Fix crash when master gpu is using glamor and another gpu is hotplugged

ing glamor_egl_init() with an error, based on only usb gpu's getting hotplugged and they do not support glamor. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- glamor/glamor_egl.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c inde

[PATCH xserver] cursor: add hw cursor support for prime

nabled, and also calls set cursor and move cursor on all screens. Cc: Aaron Plattner <aplatt...@nvidia.com> Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v4 (Hans de Goede): -Fix crash when xf86ScreenSetCursor() gets

Re: Proposed X server 1.19 schedule

Hi, On 02-09-16 07:33, Keith Packard wrote: Following the 'release early and often' mantra, we should probably get 1.19 out the door and let people start using the new code. I'd like to propose that we figure out what remaining non-bug changes we'd like to get merged in the next week (or

Re: [PATCH xserver 4/4] xfree86: promote one GPU screen if (NumScreens == 0 && NumGPUScreens > 0)

HI, On 04-09-16 03:11, Laszlo Ersek wrote: Aarch64/KVM virtual machines cannot use emulated graphics cards with linear framebuffers, due to architectural cache coherency issues. (For this reason, "qemu-system-aarch64" doesn't even include the "virtio-vga" device model.) Such guests can use the

Re: [PATCH xserver 2/4] xfree86: clarify xf86CallDriverProbe()'s effect on "xf86GPUScreens"

at.com> Cc: Dave Airlie <airl...@redhat.com> Cc: Keith Packard <kei...@keithp.com> Signed-off-by: Laszlo Ersek <ler...@redhat.com> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/common/xf86Bus.c | 6 +++--- 1 file changed, 3 inse

Re: [PATCH xserver 1/4] xfree86: fix obscure bug in xf86platformProbeDev()'s retval computation

Hi, On 04-09-16 03:11, Laszlo Ersek wrote: According to the leading comment on, and the implementation of, xf86CallDriverProbe(), the xf86platformProbeDev() function is supposed to return TRUE if the driver in question succeeds to probe at least one graphics card. The assignment to

[PATCH v3 xserver] cursor: add hw cursor support for prime

nabled, and also calls set cursor and move cursor on all screens. Cc: Aaron Plattner <aplatt...@nvidia.com> Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v3: -Re-indent xf86CursorScreenCheckHW -Loop over slave

Re: Hints for debugging a weird sw-cursor issue ?

com> said: On 31 August 2016 at 22:10, Hans de Goede <hdego...@redhat.com> wrote: Hi All, I've noticed a weird sw-cursor issue when a slave-output is active (I believe this is a sw-cursor issue because show_cursor never gets called when a slave-output is active at server start). I'm see

Re: [RESEND] xfree86: prune duplicate monitor modes.

Hi, On 01-09-16 16:36, Adam Jackson wrote: On Thu, 2016-09-01 at 16:19 +0200, Hans de Goede wrote: And almost another year later. I've been going over patches stuck in patchwork today and this one stood out, I believe the problem is still valid, correct ? Why do you think this is "

Re: [RESEND,v4] xfree86: Immediately handle failure to set HW cursor

Hi, On 22-06-16 10:48, Alexandre Courbot wrote: There is currently no reliable way to report failure to set a HW cursor. Still such failures can happen if e.g. the MODE_CURSOR DRM ioctl fails (which currently happens at least with modesetting on Tegra for format incompatibility reasons). As

Re: [RESEND] xfree86: prune duplicate monitor modes.

Hi, On 11-12-15 08:43, Michel Dänzer wrote: From: Leo Liu same monitor modes added causing memory leak when looping `xrandr --prop'. Signed-off-by: Leo Liu Signed-off-by: Michel Dänzer --- More than two years later... Can somebody

Re: Hints for debugging a weird sw-cursor issue ?

Hi, On 01-09-16 01:33, Carsten Haitzler (The Rasterman) wrote: On Thu, 1 Sep 2016 06:36:32 +1000 Dave Airlie <airl...@gmail.com> said: On 31 August 2016 at 22:10, Hans de Goede <hdego...@redhat.com> wrote: Hi All, I've noticed a weird sw-cursor issue when a slave-output is activ

[PATCH xserver] modesetting: Do not use function local static variables

as in theory different crtc's could have different hw-cursor support. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 10 -- hw/xfree86/drivers/modesetting/drmmode_display.h | 2 ++ 2 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v2 xserver] modesetting: Hide cursor when initializing crtc

position + the Xorg sw cursor resulting in 2 cursors. This commit fixes this by hiding any left-over cursors when initializing the crtc. Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> --- Changes in v2: -Fix spelling error in com

Hints for debugging a weird sw-cursor issue ?

Hi All, I've noticed a weird sw-cursor issue when a slave-output is active (I believe this is a sw-cursor issue because show_cursor never gets called when a slave-output is active at server start). I'm seeing this with both 1.18 and master and with both the intel and the modesetting drivers

[PATCH xserver] modesetting: Hide cursor when initializing crtc

position + the Xorg sw cursor resulting in 2 cursors. This commit fixes this by hiding any left-over cursors when initializing the crtc. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --gi

Re: [PATCH xf86-input-libinput] conf: drop libinput to below the other drivers

. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Still not entirely happy about this (because of what this means for the distro side) but that has already been discussed, so this is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- This patch means w

[PATCH v2 xserver 1/3] modesetting: ms_covering_crtc: Remove unused arguments, make static

Remove unused arguments from ms_covering_crtc, make it static as it is only used in vblank.c. While at it also change its first argument from a ScrnInfoPtr to a ScreenPtr, this makes the next patch in this patch-set cleaner. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes

Re: [PATCH xserver 2/3] modesetting: ms_covering_crtc: Allow calling on non modesetting Screens

Hi, On 27-08-16 20:03, Peter Wu wrote: On Wed, Aug 24, 2016 at 03:30:11PM +0200, Hans de Goede wrote: 99% of the code in ms_covering_crtc is video-driver agnostic. Add a screen_is_ms parameter when when FALSE skips the one ms specific check, this will allow calling ms_covering_crtc on slave

Re: [PATCH libX11] XFree will accept NULL as argument

Hi, On 15-08-16 19:18, walter harms wrote: since Xfree is a define for free() Xlibint.h:#define Xfree(ptr) free((ptr)) Xfree will accept NULL and do nothing. the patch is also available on github.com/xtforever/libX11.git Thanks, applied. Can you next time please add a S-o-b, i.e.:

Re: [PATCH v2 xserver] modesetting: Fall back to primary crtc for vblank for drawables on slave outputs

Note subject should include 3/3 as this is a v2 of a patch from my previous set. git send-email --start-number 3 did not do what I expected ... On 25-08-16 12:44, Hans de Goede wrote: This fixes glxgears running at 1 fps when fully covering a slave-output and the modesetting driver is used

[PATCH v2 xserver] modesetting: Fall back to primary crtc for vblank for drawables on slave outputs

This fixes glxgears running at 1 fps when fully covering a slave-output and the modesetting driver is used for the master gpu. Reported-by: Peter Wu <pe...@lekensteyn.nl> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Only fallback to primary crtc if it is i

Re: [PATCH v2 xserver 1/2] glamor: Add glamor_shareable_fd_from_pixmap()

Hi, On 24-08-16 20:48, Keith Packard wrote: Hans de Goede <hdego...@redhat.com> writes: Add glamor_shareable_fd_from_pixmap function to get dma-buf fds suitable for sharing across GPUs (not using GPU specific tiling). This is necessary for the modesetting driver to correctly imp

[PATCH xserver 3/3] modesetting: Fall back to primary crtc for vblank for drawables on slave outputs

This fixes glxgears running at 1 fps when fully covering a slave-output and the modesetting driver is used for the master gpu. Reported-by: Peter Wu <pe...@lekensteyn.nl> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/vblank.c | 22 +

[PATCH xserver 1/3] modesetting: ms_covering_crtc: Remove unused arguments, make static

Remove unused arguments from ms_covering_crtc, make it static as it is only used in vblank.c. While at it also change its first argument from a ScrnInfoPtr to a ScreenPtr, this makes the next patch in this patch-set cleaner. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/x

[PATCH xserver 2/3] modesetting: ms_covering_crtc: Allow calling on non modesetting Screens

99% of the code in ms_covering_crtc is video-driver agnostic. Add a screen_is_ms parameter when when FALSE skips the one ms specific check, this will allow calling ms_covering_crtc on slave GPUs. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/vblank.

Re: modesetting: prefer primary crtc when picking over nothing

Hi, On 03-08-16 02:24, Dave Airlie wrote: So we had a bug report that epiphany was rendering slow on modesetting + DRI3, that I tracked down to the fact it was rendering offscreen to a single buffer. However due to this rendering being offscreen we were getting the fake crtc chosen by the X

[PATCH v2 xserver 1/2] glamor: Add glamor_shareable_fd_from_pixmap()

Add glamor_shareable_fd_from_pixmap function to get dma-buf fds suitable for sharing across GPUs (not using GPU specific tiling). This is necessary for the modesetting driver to correctly implement the DRI2 SharePixmapBacking callback. Signed-off-by: Hans de Goede <hdego...@redhat.

[PATCH v2 xserver 2/2] modesetting: Fix msSharePixmapBacking returning a non-linear bo

in a dual-gpu setup and running an opengl app with DRI_PRIME=1. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modes

Re: [PATCH xserver] xfree86: print the module name together with the load failure message

Hi, On 23-08-16 06:47, Peter Hutterer wrote: We're happily printing the error to the log but not which module caused it... That's in the Xorg.log but that's at least one click away. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> LGTM: Reviewed-by: Hans de Goede

Re: [PATCH xserver] Fix Xorg -configure not working anymore

Hi, On 17-08-16 16:58, Adam Jackson wrote: On Wed, 2016-08-17 at 10:01 +0900, Michel Dänzer wrote: At least longer term, maybe we should just remove Xorg -configure? Does it serve any useful purpose anymore? I know it causes quite a lot of trouble for users and those trying to help them...

Re: [PATCH xserver] modesetting: Fix msSharePixmapBacking returning a non-linear bo

Hi, On 17-08-16 16:44, Keith Packard wrote: Hans de Goede <hdego...@redhat.com> writes: Some code paths end up in msSharePixmapBacking with a pixmap which does not have its usage_hint set to sharable. This causes glamor_fd_from_pixmap() to create a non-linear bo, which is wrong for a

[PATCH xserver] modesetting: Fix msSharePixmapBacking returning a non-linear bo

tracing the DRI_PRIME case from above, but the pixmap ends up coming from a drawable passed into the server by a client. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/driver.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/xfree86/d

Re: [PATCH xserver] Fix Xorg -configure not working anymore

Hi, On 17-08-16 03:01, Michel Dänzer wrote: On 17/08/16 05:36 AM, Hans de Goede wrote: On 08/16/2016 06:36 PM, Adam Jackson wrote: On Mon, 2016-08-08 at 14:53 +0200, Hans de Goede wrote: However some users still want to use Xorg -configure to generate a template config file, this commit

Re: [PATCH synaptics] eventcomm: don't ever probe if a device is set

-by: Peter Hutterer <peter.hutte...@who-t.net> LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/eventcomm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index 9c9a036..f65d532 1006

Re: [PATCH xserver] Fix Xorg -configure not working anymore

Hi, On 08/16/2016 06:36 PM, Adam Jackson wrote: On Mon, 2016-08-08 at 14:53 +0200, Hans de Goede wrote: Adding support for the xf86Configure code to xf86platformBus.c is non trivial and since we advise users to normally run without any Xorg.conf at all not worth the trouble. I'm guessing

[PATCH xserver 2/3] modesetting: Remove some dead code

The "if (pixmap) ..." block this commit removes is inside an "if (pixmap == NULL) ..." block, so it will never execute. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/dri2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/x

[PATCH xserver 1/3] modesetting: ms_dri2_create_buffer: check screen of existing front buffers

If a frontbuffer drawable already has a pixmap, make sure it was created on the right screen. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/dri2.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/hw/xfree86/d

[PATCH xserver 3/3] modesetting: Implement DRI2InfoRec version 9 callbacks

Implement the CreateBuffer2 / DestroyBuffer2 / CopyRegion2 DRI2InfoRec version 9 callbacks, this is necessary for being an offload source provider with DRI2. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/dri2.c | 64 ++--

Re: [PATCH xf86-input-libinput] Add support for configurable tap button mapping

Hi, On 16-08-16 01:58, Peter Hutterer wrote: Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- include/libinput-properties.h | 7 ++ man/libinput.man |

Re: [PATCH libXrandr 1/2] fix: doGetScreenResources() info: redundant null check on calling free()

Hi, On 15-08-16 16:10, walter harms wrote: Am 15.08.2016 09:03, schrieb Hans de Goede: Hi, On 13-08-16 19:53, Hans de Goede wrote: Hi, On 12-08-16 18:10, walter harms wrote: Am 12.08.2016 16:36, schrieb Hans de Goede: Hi, On 12-08-16 16:09, walter harms wrote: Am 12.08.2016 12:11

Re: [PATCH libXrandr 1/2] fix: doGetScreenResources() info: redundant null check on calling free()

Hi, On 13-08-16 19:53, Hans de Goede wrote: Hi, On 12-08-16 18:10, walter harms wrote: Am 12.08.2016 16:36, schrieb Hans de Goede: Hi, On 12-08-16 16:09, walter harms wrote: Am 12.08.2016 12:11, schrieb Hans de Goede: Hi, On 28-07-16 19:31, walter harms wrote: janitorial patch

Re: [PATCH libXrandr 1/2] fix: doGetScreenResources() info: redundant null check on calling free()

Hi, On 12-08-16 16:09, walter harms wrote: Am 12.08.2016 12:11, schrieb Hans de Goede: Hi, On 28-07-16 19:31, walter harms wrote: janitorial patch: remove some unneeded if() before free() This is not free() but Xfree() and "man Xfree" states: "A NULL pointer c

Re: [PATCH xserver] dix: Avoid writing uninitialized bytes in deliverPropertyNotifyEvent

Hi, On 13-08-16 18:06, Keith Packard wrote: Make sure the whole event is initialized, instead of leaving the pad bytes unset. Signed-off-by: Keith Packard <kei...@keithp.com> LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- dix/property.c | 10 +

Re: [PATCH xf86-input-libinput] Ensure parent devices are actual parent devices

on the same already-removed parent). Avoid this by making sure the matched device is actually a parent device. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/xf86libinput.c | 28 ++-

Re: [PATCH libXrandr 1/2] fix: doGetScreenResources() info: redundant null check on calling free()

Hi, On 12-08-16 18:10, walter harms wrote: Am 12.08.2016 16:36, schrieb Hans de Goede: Hi, On 12-08-16 16:09, walter harms wrote: Am 12.08.2016 12:11, schrieb Hans de Goede: Hi, On 28-07-16 19:31, walter harms wrote: janitorial patch: remove some unneeded if() before free

Re: [PATCH libXrandr 1/2] fix: doGetScreenResources() info: redundant null check on calling free()

Hi, On 28-07-16 19:31, walter harms wrote: janitorial patch: remove some unneeded if() before free() This is not free() but Xfree() and "man Xfree" states: "A NULL pointer cannot be passed to this function." Regards, Hans --- src/XrrScreen.c | 4 ++-- 1 file changed, 2

Re: [PATCH xserver] Build glamor when Xorg or Xephyr are built.

Hi, On 12-08-16 06:39, Keith Packard wrote: Requires gbm when building Xorg so that xf86-video-modesetting will work. Signed-off-by: Keith Packard <kei...@keithp.com> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- confi

Re: [PATCH xf86-input-libinput 1/2] Block input events while creating the virtual subdevices

<peter.hutte...@who-t.net> Both patches look good to me and are: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/xf86libinput.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/xf86libinput.c b/src/xf86libinput.c index fff59b3..58

Re: [PATCH xserver 1/2] present: Make present_restore_screen_pixmap handle screen->root == NULL

Hi, On 03-08-16 03:19, Michel Dänzer wrote: From: Michel Dänzer <michel.daen...@amd.com> Easier than dealing with it in all paths that can end up here during server shutdown. Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Both patches looks good to me and are: Reviewed

Re: [PATCH xserver] xwayland: Avoid double free of RRCrtc and RROutput

updating the screen size at shutdown. Signed-off-by: Olivier Fourdan <ofour...@redhat.com> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- hw/xwayland/xwayland-output.c | 12 +--- hw/xwayland/xwayland.c| 2 +- hw/xwaylan

Re: [PATCH xserver] glx: Always enable EXT_texture_from_pixmap for DRI glx

Hi Again, On 02-07-16 12:04, Hans de Goede wrote: Hi, On 01-07-16 22:32, Adam Jackson wrote: On Fri, 2016-07-01 at 19:06 +0200, Hans de Goede wrote: Prior to commit f95645c6f700 ("glx: Don't enable EXT_texture_from_pixmap unconditionally") DRI glx would always

[PATCH xserver] Fix Xorg -configure not working anymore

CI devices by skipping the platform probe method when xf86DoConfigure is set. This has been tested on a system with integrated intel graphics, with both the intel and modesetting drivers and restores Xorg -configure functionality on both cases. Cc: Adam Jackson <a...@redhat.com> Signed-off-by: Hans

Re: [PATCH xserver] present: Only call restore_screen_pixmap once from set_abort_flip

ip may be called several times, including when screen->root is already cleared to NULL. Signed-off-by: Michel Dänzer <michel.daen...@amd.com> LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- present/present.c | 7 --- 1 file changed, 4 inser

[PATCH resend xf86-video-intel] Fix fd (and mem) leak when intel_scrn_create fails

the fallback to the modesetting driver. This commit fixes this by adding a intel_close_device() cleanup function and calling that when intel_scrn_create() fails. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/intel_device.c | 17 + src/intel_driver.h | 1

[PATCH xserver] linux: Do not try to open /dev/vc/0, fix error msg when /dev/tty0 open fails

. BugLink: https://patchwork.freedesktop.org/patch/8768/ Reported-by: Chad Versace <chad.vers...@linux.intel.com> Suggested-by: Julien Cristau <jcris...@debian.org> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/os-support/linux/lnx_init.c | 10 +- 1 fil

Re: xserver 1.18.4 coming

Hi, On 06-07-16 19:44, Adam Jackson wrote: I've merged some fixes back from master to the 1.18 branch, and plan to release 1.18.4 in the next few days. Give a shout if there's anything wrong on the branch, or if there's any other changes that should be picked up. I'm not sure the

modesetting driver does not support being an offload source, should not advertise cap ?

Hi all, Currently the modesetting driver sets a cap flag claiming that it can be an offload source, yet using DRI_PRIME=1 with the modesetting driver being the driver for slave nvidia gpu, does not work unless the master gpu driver (intel) has dri3 enabled, at which point the whole xserver no

Re: [PATCH xserver] glx: Always enable EXT_texture_from_pixmap for DRI glx

Hi, On 01-07-16 22:32, Adam Jackson wrote: On Fri, 2016-07-01 at 19:06 +0200, Hans de Goede wrote: Prior to commit f95645c6f700 ("glx: Don't enable EXT_texture_from_pixmap unconditionally") DRI glx would always advertise EXT_texture_from_pixmap. That commit moved the setting of the

[xserver PULL master] Various Modesetting fixes

ffering variables modesetting: Implement a double-buffered shadow mode Dave Airlie (1): modesetting: Implement 32->24 bpp conversion in shadow update Hans de Goede (2): modesetting: Fix swapping of provider sink / source capabilities modesetting: Load on GPU-s with 0 outp

[PATCH xserver] glx: Always enable EXT_texture_from_pixmap for DRI glx

advertise EXT_texture_from_pixmap unconditionally again fixing this. Fixes: f95645c6f700 ("glx: Don't enable EXT_texture_from_pixmap unconditionally") Signed-off-by: Hans de Goede <hdego...@redhat.com> --- glx/glxdri2.c | 6 -- glx/glxdriswrast.c | 3 +-- 2 files changed, 5

<    1   2   3   4   5   6   7   8   9   >