Re: Fatal IO Error: 11 (resource temporarily unavailable)

2013-05-19 Thread walter harms
hi, I have tried the first example an it works fine for me. (you may like to add \n for the printf() to get more readable output). re, wh Am 19.05.2013 17:35, schrieb First Last: Hi, I got this error when I try to run all example I have of xlib : Fatal IO Error: 11 (resource

Re: X11 Porting Project

2013-04-26 Thread walter harms
Am 26.04.2013 18:26, schrieb Dibyayan Chakraborty: Hi, I joined this mailing list very recently . I am actually looking for some information regarding a project that our university would like to take up. Now I provide a brief introduction about the project. Ultimate aim of the project is

Re: [PATCH v2 synaptics] Fix stack smash in clickpad_guess_clickfingers()

2013-04-26 Thread walter harms
Am 26.04.2013 02:12, schrieb Peter Hutterer: Apple Magic Trackpad can report 16 slots. In clickpad_guess_clickfingers() the array allocated on the stack contains only 10 slots. As (.num_mt_mask == .num_slots), the function writes out of the bounds of close_point. Use a size 32 bitmask

Re: [PATCH:libXxf86vm 1/4] Improve error handling in XF86VidModeGetMonitor()

2013-04-15 Thread walter harms
Am 14.04.2013 17:16, schrieb Alan Coopersmith: On 04/14/13 04:28 AM, walter harms wrote: if (rep.vendorLength) { - if (!(monitor-vendor = (char *)Xcalloc(rep.vendorLength + 1, 1))) { - _XEatData(dpy, (rep.nhsync + rep.nvsync) * 4

Re: [PATCH:libXxf86vm] When Xcalloc() returns NULL, you don't need to Xfree() it

2013-04-14 Thread walter harms
Am 14.04.2013 00:20, schrieb Alan Coopersmith: I have no words to explain how this ever happened. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/XF86VMode.c |5 - 1 file changed, 5 deletions(-) diff --git a/src/XF86VMode.c b/src/XF86VMode.c index

Re: [PATCH:libXxf86vm 1/4] Improve error handling in XF86VidModeGetMonitor()

2013-04-14 Thread walter harms
Am 14.04.2013 03:48, schrieb Alan Coopersmith: Ensure that when we return an error we unlock the display first, and NULL out any pointers we freed in error cleanup. Instead of adding these fixes to every error check, instead combine the error handling cleanup into a single copy.

Re: [PATCH synaptics 1/3] Improve readability of the soft button areas

2013-04-03 Thread walter harms
Am 03.04.2013 04:09, schrieb Peter Hutterer: Replace the hardcoded indices with enums that are somewhat expressive. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c | 78 +++-- 1 file changed, 48

Re: [PATCH 4/6] xfree86: Keep trying to set interface on drm for 2 seconds.

2013-03-21 Thread walter harms
Am 19.03.2013 20:12, schrieb Bryce Harrington: And if we've had to delay booting due to not being able to set the interface, fess up. Signed-off-by: Bryce Harrington br...@canonical.com Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86/os-support/linux/lnx_platform.c |

Re: [PATCH:libX11 7/7] Convert more sprintf calls to snprintf

2013-02-17 Thread walter harms
Am 17.02.2013 18:45, schrieb Alan Coopersmith: You could analyze most of these and quickly recognize that there was no chance of buffer overflow already, but why make everyone spend time doing that when we can just make it obviously safe? Signed-off-by: Alan Coopersmith

Re: [PATCH:libX11 7/7] Convert more sprintf calls to snprintf

2013-02-17 Thread walter harms
Am 17.02.2013 19:36, schrieb Alan Coopersmith: On 02/17/13 10:32 AM, walter harms wrote: @@ -190,7 +191,7 @@ XGetErrorDatabaseText( else tptr = Xmalloc (tlen); if (tptr) { - sprintf(tptr, %s.%s, name, type); + snprintf(tptr, tlen, %s.%s, name, type

Re: [PATCH v2] os: fix pnprintf OOB buffer read for unterminated length modifiers

2013-02-17 Thread walter harms
Am 14.02.2013 20:00, schrieb Keith Packard: walter harms wha...@bfs.de writes: why is a private snprintf needed in the first place ? Logging from a signal handler. perhaps someone can add a line like /* signal-safe snprintf() */ note: maybe it is there (i saw only the patch). re

Re: [PATCH v2] os: fix pnprintf OOB buffer read for unterminated length modifiers

2013-02-14 Thread walter harms
Am 14.02.2013 07:31, schrieb Peter Hutterer: Format strings with length modifiers but missing format specifier like %0 will one past the array size. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- sorry, had a messy tree here and the test got affected. This one will actually

Re: [PATCH 1/7] randr: fix set but unused warnings

2013-02-14 Thread walter harms
Am 14.02.2013 01:24, schrieb Peter Hutterer: rrcrtc.c: In function 'RRCrtcDetachScanoutPixmap': rrcrtc.c:366:9: warning: variable 'ret' set but not used [-Wunused-but-set-variable] rrcrtc.c: In function 'rrCheckPixmapBounding': rrcrtc.c:505:13: warning: variable 'ret' set but not used

Re: [PATCH] test/input: Replace negative architecture test by test for 64-bit

2013-02-12 Thread walter harms
Am 12.02.2013 13:40, schrieb Mark Kettenis: From: Geert Uytterhoeven ge...@linux-m68k.org Date: Tue, 12 Feb 2013 11:17:22 +0100 The test for double-aligned members in dix_valuator_alloc() currently depends on if !defined(__i386__) !defined(__sh__). This covers m68k, where it fails.

Re: XFillArc bug

2013-02-05 Thread walter harms
Am 05.02.2013 16:58, schrieb Anthony Shipman: On Mon, 4 Feb 2013 02:55:46 am Anthony Shipman wrote: Attached is a simple xlib program to draw a filled arc in a box. If I cover the window with another top level window and then gradually expose it the arc is not properly redrawn. Large

Re: [PATCH] xfree86: bail on misformed acpi strings (#73227)

2013-01-29 Thread walter harms
Am 29.01.2013 07:41, schrieb Peter Hutterer: From: Ted Felix t...@tedfelix.com If acpid sends a string in a format that we can't parse, bail out instead of potentially dereferencing a NULL-pointer. X.Org Bug 73227 http://bugs.freedesktop.org/show_bug.cgi?id=73227 Reviewed-by: Peter

Re: [PATCH:mkfontscale] Replace malloc(strlen); strcpy() calls with strdup

2013-01-20 Thread walter harms
IMHO you can replace if strdup == NULL goto fail with a strdup that does simply an exit(1) on alloc error. like: char *xstrdup(char *buf) { char *ret=strdup(buf); if (ret == NULL) exit(1); return ret; } perhaps there is already something like that. re, wh

Re: [PATCH] dix/resource: bug out if we get 0 type resource added

2012-12-04 Thread walter harms
Am 04.12.2012 06:23, schrieb Peter Hutterer: On Tue, Dec 04, 2012 at 01:06:13PM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com With the missing RRProviderInit, we were adding 0 typed resources, which crashed when xrestop hit them, we should warn before that happens so

Re: [PATCH 1/7] os: Remove any old logfile before trying to write to it

2012-11-08 Thread walter harms
Am 08.11.2012 14:41, schrieb Jon TURNEY: If we are not backing up logfiles, remove the old logfile before trying to write a new logfile, as otherwise the operation may fail if the previous logfile was created by a different user. what are the permissions of that file ? normally you can

Re: [PATCH 07/12] render: fix shadow warnings

2012-10-28 Thread walter harms
Am 28.10.2012 04:01, schrieb Yaakov (Cygwin/X): From: Yaakov Selkowitz yselkow...@users.sourceforge.net Signed-off-by: Yaakov Selkowitz yselkow...@users.sourceforge.net --- render/picturestr.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: Very bad performance on X11

2012-09-21 Thread walter harms
Am 21.09.2012 16:01, schrieb vincent esteoule: Hello, My new server is very performant in local mode, butthe response time of X11 client are very very bad. It's a 5.8 RHED server. HP gen 8 with Sandy bridge E5 2665 proc and MGA Matrix G200 EH video card. I have verify the version of

Re: [PATCH 6/7] os: Hide the Connection{In, Out}put implementation details

2012-09-21 Thread walter harms
Am 20.09.2012 22:56, schrieb Adam Jackson: Reviewed-by: Daniel Stone dan...@fooishbar.org Signed-off-by: Adam Jackson a...@redhat.com --- os/connection.c |4 ++-- os/io.c | 21 +++-- os/osdep.h | 18 ++ 3 files changed, 23

Re: [PATCH 5/7] dix: Extend initial connection handshake for forwarding proxies

2012-09-21 Thread walter harms
Am 20.09.2012 22:56, schrieb Adam Jackson: Forwarding proxies like sshd will appear to be local, even though they aren't really. This leads to weird behaviour for extensions that truly require running under the same OS services as the client, like MIT-SHM and DRI2. Add two new legal

Re: [PATCH] dix: set the device transformation matrix

2012-09-20 Thread walter harms
Am 20.09.2012 17:59, schrieb Chase Douglas: On Wed, Sep 19, 2012 at 12:56 PM, Peter Hutterer peter.hutte...@who-t.net wrote: The property handler is registered after setting the property, so dev-transform remains as all-zeros. That causes pixman_f_transform_invert() to fail (in

Re: [PATCH 2/3] xrandr: fix gamma == 1.0 sigbits != 8

2012-08-15 Thread walter harms
Am 14.08.2012 01:25, schrieb Andy Ritger: The gamma-correction lookup table managed through XRR[GS]etCrtcGamma is 2^n in size, where 'n' is the number of significant bits in the X Color. Each element in the gamma-correction lookup table is a 16:16:16 X Color (i.e., in the range [0,65536) ).

Re: Netiquette: No HTML messages please.

2012-08-13 Thread walter harms
Am 12.08.2012 10:45, schrieb Fernando Cassia: On Sun, Aug 12, 2012 at 5:24 AM, Zhigang Gong zhigang.g...@linux.intel.com wrote: On Sat, Aug 11, 2012 at 10:55:08AM +0200, Paul Menzel wrote: Dear Zhigang, thank you for the announcement message and congratulations on the release. But please

Re: X server crashes, when starting application

2012-07-31 Thread walter harms
-7918 bernie@jvncomm.com --- Original Message Subject: Re: X server crashes, when starting application From: walter harms wha...@bfs.de To: x...@lists.x.org CC: Am 27.07.2012 21:46, schrieb

Re: X server crashes, when starting application

2012-07-28 Thread walter harms
Am 27.07.2012 21:46, schrieb Bernard Day: We are having a problem using Xorg as an X host for an application we test. I am pretty sure that this is a problem with X and not an nvidia issue as we have tried many drivers and a few Xorgs. With a given X the backtrace always

Re: Xorg CPU consumption extremely high

2012-07-19 Thread walter harms
Am 18.07.2012 23:34, schrieb Nikos Kasioumis: Hello, my system is: * Debian testing, kernel kernel 3.2.0-3-rt-686-pae * Xorg server version number 11.0 (vendor version 1.12.1.902 (11201902)) * my graphics card is: NVIDIA Corporation GF119 [GeForce GT 520M] (rev a1) * I'm using the nvidia

Re: Video issue when exiting X

2012-07-14 Thread walter harms
Am 13.07.2012 04:59, schrieb David Sorkovsky: Hi all - I have an issue and I'm hoping someone knows the answer... Ubuntu Server 11.04 + xinit + new motherboad cpu = problem I have had X working on my Ubuntu Server for quite a while previously, however I had to update the motherboard

Re: [PATCH] Rename PIC to XMAN_PIC to avoid problems with -DPIC compilations.

2012-07-12 Thread walter harms
Am 12.07.2012 14:55, schrieb Thomas Klausner: Signed-off-by: Thomas Klausner w...@netbsd.org --- misc.c | 2 +- vendor.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/misc.c b/misc.c index 8818aa8..7592996 100644 --- a/misc.c +++ b/misc.c @@ -764,7 +764,7

Re: [PATCH 12/36] dix: add unattached list for attaching screens to initially.

2012-07-02 Thread walter harms
Am 02.07.2012 12:13, schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com This list is meant for attaching unbound gpu screens to initially, before the client side rebinds them. Signed-off-by: Dave Airlie airl...@redhat.com --- dix/dispatch.c | 19 +++

Re: newbie resource temporarily unavailable

2012-07-01 Thread walter harms
Am 30.06.2012 15:31, schrieb Glynn Clements: Alan Corey wrote: Well, you see, I just really dislike C++. I've tried on and off for years and I just can't get it through my head. I want a toolkit I can program in C. FLTK seems great, same with GTK, but not without C++. I'm familiar

Re: [PATCH:libX11 2/2] Convert XCreate{Pix, Bit}map...Data to use C99 designated initializers

2012-06-30 Thread walter harms
Am 30.06.2012 17:04, schrieb Alan Coopersmith: On 06/30/12 02:38 AM, walter harms wrote: -pix = XCreatePixmap(display, d, width, height, 1); -gc = XCreateGC(display, pix, (unsigned long) 0, (XGCValues *) 0); +Pixmap pix = XCreatePixmap(display, d, width, height, 1); if you

Re: [PATCH 19/19] ephyrGLXQueryServerString: Stop making an unused copy of server_string

2012-06-24 Thread walter harms
i took a look (read: not compile tested) and it look good to me. re, wh Am 24.06.2012 19:25, schrieb Alan Coopersmith: ephyrGLXQueryServerString() carefully allocated a buffer padded to the word-aligned string length for sending to the client, copied the string to it, and then forgot to use

Re: Why is XSetStandardProperties freezing?

2012-06-22 Thread walter harms
Am 21.06.2012 23:13, schrieb Myrosia Dzikovska: On Thu, Jun 21, 2012 at 3:07 PM, Adam Jackson a...@redhat.com wrote: On Thu, 2012-06-21 at 13:08 +0100, Myrosia Dzikovska wrote: TASKTYPE TASKMOD XEventThread(void *data) { XEvent xev; HEventRec r; HWin win; HThread t; do{

Re: Why is XSetStandardProperties freezing?

2012-06-22 Thread walter harms
Am 22.06.2012 16:52, schrieb Myrosia Dzikovska: You are quiet advanced with that, you should setup a bugreport at opensuse: https://bugzilla.novell.com/index.cgi there is also a special mailinglist for opensuse: opensuse-x...@opensuse.org OK, will do that. I assume your suggestion means

Re: [PATCH 2/3] Fix pseudoramiX.c compilation without darwin.h

2012-06-22 Thread walter harms
Am 22.06.2012 15:56, schrieb Jon TURNEY: Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk --- hw/xquartz/pseudoramiX.c | 56 -- 1 files changed, 39 insertions(+), 17 deletions(-) diff --git a/hw/xquartz/pseudoramiX.c

Re: [PATCH v2] os: print newline after printing display name

2012-06-21 Thread walter harms
Am 21.06.2012 07:30, schrieb Peter Hutterer: Much easier for scripts that try to read the display value off the file descriptor. Plus, this restores the behaviour we had for this patch in Fedora since server 1.6 (April 2009). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---

Re: [PATCH 02/14] screen: split out screen init code.

2012-06-14 Thread walter harms
Am 14.06.2012 16:43, schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com This is a precursor for reusing this code to init gpu screens. Signed-off-by: Dave Airlie airl...@redhat.com --- dix/dispatch.c | 44 +++- 1 file changed, 27

Re: [PATCH 08/11] xfree86: add framework for provider support in ddx.

2012-06-13 Thread walter harms
Am 13.06.2012 15:53, schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com This adds the framework for DDX provider support. Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/common/xf86str.h|4 +++ hw/xfree86/modes/xf86Crtc.c| 46

Re: [PATCH evdev 1/6] Use xf86IDrvMsg in emuMB.c instead of ErrorF

2012-06-07 Thread walter harms
I guess the message should read ?! replacing ErrorF() with xf86IDrvMsg() to make ErrorF obsolete re, wh Am 07.06.2012 03:36, schrieb Peter Hutterer: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/emuMB.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: XSetBackgroundPixmap question

2012-05-20 Thread walter harms
Am 20.05.2012 05:30, schrieb Keith Packard: Glynn Clements gl...@gclements.plus.com writes: That seems to imply that the X server makes a copy of the pixmap data rather than keeping a reference to the original pixmap. However, I don't believe that's how the X.org server actually implements

Re: lack of reviewers

2012-05-18 Thread walter harms
Am 18.05.2012 01:14, schrieb Peter Hutterer: On Thu, May 17, 2012 at 10:39:55AM +0200, Ernst Sjöstrand wrote: Hi, (sorry for jumping in from the outside and breaking the thread!) I read about this problem and wanted to offer a suggestion! What if you set up a Gerrit server for

Re: Hello World: Error

2012-05-02 Thread walter harms
-x86-64.so.2 (0x0033ed60) bash-3.2$ -jerrold On Tue, May 1, 2012 at 1:23 AM, walter harms wha...@bfs.de wrote: Am 30.04.2012 22:15, schrieb Jerrold Clint Balansi: Hi wh, I did your instruction and it compiled. Here's what I got. [root@vizwall jcX Files]# make cc -Wall

Re: Hello World: Error

2012-05-02 Thread walter harms
Am 02.05.2012 22:24, schrieb Jerrold Clint Balansi: Hello, I created a new user. Here's what I got. [jcx@vizwall jcX Files]$ ldd ./HelloX libX11.so.6 = /usr/lib64/libX11.so.6 (0x0033efe0) libc.so.6 = /lib64/libc.so.6 (0x0033eda0) libXau.so.6 =

Re: [PATCH libXau] Free XauFileName() static buffer at exit

2012-04-26 Thread walter harms
Am 20.04.2012 23:18, schrieb Chase Douglas: XauFileName() may allocate and return a static buffer. The only way to ensure it is freed is to deallocate it when the program exits. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- AuFileName.c | 17 - 1 files

Re: libXaw vs libXaw3d

2012-04-03 Thread walter harms
Am 02.04.2012 23:34, schrieb Matt Turner: On Mon, Apr 2, 2012 at 5:13 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 04/ 2/12 03:21 AM, Marty Jack wrote: Unknown if you might have meant to add libXaw3d 1.6.2 I did not, as nothing else in the katamari depends on it, and if

Re: [PATCH libXaw3d] Fix ... ?

2012-04-02 Thread walter harms
Am 02.04.2012 00:45, schrieb Jeremy Huddleston: Reviewed-by: Jeremy Huddleston jerem...@apple.com FWIW, we're including this already in MacPorts and XQuartz. --Jeremy Does this mean there are other differences ? re, wh On Mar 29, 2012, at 10:24 AM, Markus Steinborn

Re: [PATCH evdev 2/3] Move axis labels up in the source file.

2012-03-29 Thread walter harms
Am 29.03.2012 02:09, schrieb Peter Hutterer: Simple move, no functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 320 +- 1 files changed, 160 insertions(+), 160 deletions(-) diff --git

Re: solution in the house , kind of synergy, but only X to X ?

2012-03-28 Thread walter harms
Am 28.03.2012 03:33, schrieb Sérgio Basto: Hi, has you may know synergy http://synergy-foss.org/ lets you easily share your mouse and keyboard between multiple computers. As I only use X between multiple computers, I do the same with x11vnc on remote X and with x2vnc , I control remote and

Re: Key rate limit

2012-03-26 Thread walter harms
I am not sure but xset has a [r rate delay [rate]], would that be any help ? re, wh Am 26.03.2012 17:27, schrieb tsuraan: In GNOME, it's in the Keyboard Accessibility preferences panel. Other desktops with accessibility support should have something similar. Hm, so no ideas for a

Re: x forwarding?

2012-03-14 Thread walter harms
Am 14.03.2012 16:24, schrieb gene heskett: On Wednesday, March 14, 2012 11:11:14 AM Adam Jackson did opine: On Wed, 2012-03-14 at 03:27 -0400, gene heskett wrote: ssh -Y first machine works, and uses Display:10:0, ssh -Y second machine doesn't, tries fails to use Display 0:0. Where

Re: [PATCH] xfree86: always switch console to raw mode on vt switch (#41146)

2012-03-08 Thread walter harms
Am 08.03.2012 05:21, schrieb Peter Hutterer: Alt+SysReq+R sets the console to raw mode. Re-enable raw mode when VT-switching back to the server. X.Org Bug 41146 http://bugs.freedesktop.org/show_bug.cgi?id=41146 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---

Re: Suggestion of patch for libXaw3d-1.6.1

2012-03-06 Thread walter harms
Am 05.03.2012 23:00, schrieb Jean-Pierre Demailly: On Mon, Mar 05, 2012 at 05:25:13PM +0100, walter harms wrote: This looks interessting, did you try this with Xaw also ? No I didn't. However, the patch doesn't really use the specific features of Xaw3d, so it shouldn't be too hard

Re: Suggestion of patch for libXaw3d-1.6.1

2012-03-05 Thread walter harms
This looks interessting, did you try this with Xaw also ? re, wh Am 04.03.2012 22:51, schrieb Jean-Pierre Demailly: Hi: Please find enclosed a suggestion of patch for libXaw3d-1.6.1 (actually for the current git version that has an additional one line bug fix), along with two new files

Re: [PATCH libxkbcommon 3/4] makekeys: Receive the keysym files as arguments

2012-02-26 Thread walter harms
Am 25.02.2012 23:25, schrieb Ran Benita: This integrates part of libX11 commit 00175397480b76d32bf82b0c7c94c91a2a95954e makekeys: Scan vendor keysyms as well as core Since we can't really live without vendor keysyms, scan them all in to generate ks_tables.h, rather than

Re: [PATCH libxkbcommon 09/11] Fix an incorrect sizeof

2012-02-26 Thread walter harms
Am 25.02.2012 11:13, schrieb Ran Benita: Signed-off-by: Ran Benita ran...@gmail.com --- src/xkbcomp/geometry.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xkbcomp/geometry.c b/src/xkbcomp/geometry.c index fb5eef2..18f41e6 100644 ---

Re: [PATCH libxkbcommon 08/11] Fix all constness warnings

2012-02-26 Thread walter harms
Am 25.02.2012 11:13, schrieb Ran Benita: These are all trivial/obvious fixes which clear a bunch of warnings. Signed-off-by: Ran Benita ran...@gmail.com --- src/keysym.c |2 +- src/maprules.c | 44 src/text.c

Re: [PATCH libXi] Fix bus error on MIPS N32 for bug #38331.

2012-02-21 Thread walter harms
Am 20.02.2012 23:47, schrieb Michał Masłowski: XIValuatorClassInfo and XIScrollClassInfo might have an address of 4 bytes modulo 8, while they contain doubles which needs 8 byte alignment. This is fixed by adding extra padding before instances of these structure in size_classes and

Re: [PATCH xf86-input-synaptics 07/10] Add touch valuator mask to hw state structure

2012-02-09 Thread walter harms
Am 09.02.2012 18:22, schrieb Chase Douglas: On 02/09/2012 03:27 PM, Peter Hutterer wrote: On Wed, Feb 08, 2012 at 06:35:16PM -0800, Chase Douglas wrote: Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/synaptics.c| 78

Re: [PATCH xf86-input-synaptics v3 1/3] Don't emit touch sequences if only one touch is active

2012-02-07 Thread walter harms
Am 06.02.2012 17:40, schrieb Chase Douglas: When a second touch begins, emit a touch begin for the first touch with the current valuator values. When a touch ends and we are going from two touches down to one touch, end both touches. This ensures we don't send a touch sequence at the same

Re: [PATCH libpciaccess] Use correct type for pci_id file accessor functions

2012-02-07 Thread walter harms
Am 07.02.2012 09:36, schrieb Mathias Krause: On 31.01.2012 11:46, Mathias Krause wrote: This fixes the compiler warning of using the wrong type for gzgets() and gzclose() as they want a gzFile argument, not a pointer to gzFile. The abstraction layer pci_id_file should just abstract the full

Re: [PATCH 3/5] Check for proper window ID when processing touch allow requests

2012-02-03 Thread walter harms
Am 03.02.2012 01:57, schrieb Chase Douglas: From: Chase Douglas chase.doug...@ubuntu.com Signed-off-by: Chase Douglas chase.doug...@canonical.com --- Xi/xiallowev.c |2 +- dix/touch.c | 18 -- include/input.h |2 +- 3 files changed, 14 insertions(+), 8

Re: [PATCH synaptics 1/5] Don't emit touch sequences if only one touch is active

2012-02-02 Thread walter harms
Am 02.02.2012 00:50, schrieb Chase Douglas: When a second touch begins, emit a touch begin for the first touch with the current valuator values. When a touch ends and we are going from two touches down to one touch, end both touches. This ensures we don't send a touch sequence at the same

Re: [PATCH xorg-gtest 1/3] Added --xorg-logfile option.

2012-01-30 Thread walter harms
Am 30.01.2012 18:32, schrieb Daniel d'Andrada: And by default point to a location that doesn't require root privileges to be used. This is an enabler to make it possible to run Xorg without being root. Signed-off-by: Daniel d'Andrada daniel.dandr...@canonical.com diff --git

Re: KeySym to Unicode?

2012-01-28 Thread walter harms
Am 28.01.2012 00:48, schrieb Troy Watson: Because Unicode was invented years after Xlib and no one ever went back to add such a thing? Most of the Xlib API is codeset independent since it was written in the days when every locale used a different character set (ISO 8859-*, Big5, JIS,

Re: [PATCH edid-decode 1/3] Do the EDID version parsing before anything else

2011-12-21 Thread walter harms
Am 20.12.2011 22:17, schrieb Tormod Volden: From: Tormod Volden debian.tor...@gmail.com So that the version conformance flags can be used in other code. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- edid-decode.c | 38 +++--- 1 files

Re: [PATCH:xmag] Use lrint() from math library if available

2011-12-21 Thread walter harms
Am 21.12.2011 05:58, schrieb Alan Coopersmith: Moves -lm from being hardcoded in Makefile.am to being added via AC_SEARCH_LIBS in configure.ac setting it in $(LIBS) Using lrint() [returns long int] instead of rint() [returns double] clears a bunch of gcc warnings of the form: cast from

Re: [PATCH edid-decode 1/3] Do the EDID version parsing before anything else

2011-12-21 Thread walter harms
Am 21.12.2011 11:40, schrieb Tormod Volden: On Wed, Dec 21, 2011 at 10:23 AM, walter harms wha...@bfs.de wrote: Am 20.12.2011 22:17, schrieb Tormod Volden: From: Tormod Volden debian.tor...@gmail.com So that the version conformance flags can be used in other code. Signed-off-by: Tormod

Re: [PATCH v2 23/42] dix: add touch event history helper functions

2011-12-20 Thread walter harms
Am 20.12.2011 04:22, schrieb Peter Hutterer: If touch client has not registered for ownership events and a grab above that client is rejected, the client needs to receive the complete event history. The history currently doesn't really do fancy overflow handling. We assume that the first

Re: [PATCH] xauth: improve to handle FamilyWild necessary for GDM/XDMCP/SSH. #43425

2011-12-19 Thread walter harms
Am 19.12.2011 10:23, schrieb Dr. Tilmann Bubeck: Hello xorg, I sent you the mail below a few days ago with a patch for xauth. According to http://www.x.org/wiki/Development/Documentation/SubmittingPatches I am now pinging the list again. I do not know any maintainer to CC, so I only

Re: [PATCH 06/42] tests: update for touch support

2011-12-16 Thread walter harms
Am 15.12.2011 04:01, schrieb Peter Hutterer: Touch event mask must be set for all three event types. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/xi2/protocol-xipassivegrabdevice.c |2 +- test/xi2/protocol-xiselectevents.c | 38 --

Re: [PATCH 10/42] Xi: process raw touch events

2011-12-16 Thread walter harms
Am 15.12.2011 04:01, schrieb Peter Hutterer: No-one can generated them yet, but if they could, we'd be processing them like there was no tomorrow. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xi/exevents.c |3 +++ Xi/extinit.c |3 +++ Xi/xiselectev.c

Re: [PATCH 06/42] tests: update for touch support

2011-12-16 Thread walter harms
Am 16.12.2011 12:12, schrieb Peter Hutterer: On 16/12/11 20:56 , walter harms wrote: Am 15.12.2011 04:01, schrieb Peter Hutterer: Touch event mask must be set for all three event types. Signed-off-by: Peter Huttererpeter.hutte...@who-t.net --- test/xi2/protocol-xipassivegrabdevice.c

Re: [PATCH] dix: add a MAXEVENTS define for the number of core + extension events

2011-12-11 Thread walter harms
looks good for me but not compile tested ntl Reviewed-by: wharms wha...@bfs.de Am 11.12.2011 03:55, schrieb Peter Hutterer: Not including GenericEvents Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/events.c |6 +++--- dix/extension.c |3 +--

Re: [REMINDER libX11] XIM: Allow modifier releases in compose sequences (#26705)

2011-12-11 Thread walter harms
hi, i am not a XIM or XKB expert but for me the code looks reasonable. @Andreas Wettstein could you please add a line or two how to test the function ? what does not work (what keys to press) what works after the patch ? re, wh Am 10.12.2011 18:36, schrieb Alan Coopersmith: On 12/10/11

Re: [PATCH 3/5] dix: move storing last.valuators into a helper function

2011-12-10 Thread walter harms
Am 10.12.2011 08:54, schrieb Peter Hutterer: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/getevents.c | 38 ++ 1 files changed, 26 insertions(+), 12 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index bc532ca..3b3194d

Re: [PATCH 5/5] dix: move event filter retrieval helpers to inpututils.c

2011-12-10 Thread walter harms
Am 10.12.2011 08:54, schrieb Peter Hutterer: No functional changes Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/events.c | 24 ++-- dix/inpututils.c | 19 +++ include/input.h |1 - include/inpututils.h |

Re: [PATCH] Add Solaris support to DetermineClientCmd

2011-12-04 Thread walter harms
hi alan, to make that more readable could you make two function DetermineClientCmd() ? something like #ifdef sun #include errno.h #include procfs.h void DetermineClientCmd(pid_t pid, const char **cmdname, const char **cmdargs) { } #else void DetermineClientCmd(pid_t pid, const char

Re: [PATCH 5/5] Add dummy return 0 to Xnest Xephyr io error handler for Sun compilers

2011-12-03 Thread walter harms
Hi, perhaps you can call it DUMMY_RETURN or so ? Other compilers may have the same idea. Otherwise ... will gcc complain ? If not something like: return 0; /* make SUNPRO C happy */ would sufficent. re, wh Am 02.12.2011 19:48, schrieb Alan Coopersmith: Required in order to build with

Re: [PATCH:xsm] Add size limit to scanf string specifier

2011-11-29 Thread walter harms
Am 29.11.2011 03:56, schrieb Alan Coopersmith: While it's tempting to just switch to fgets(), that would require implementing our own whitespace stripping to match the current scanf behavior. Fixes parfait static analysis warning: Error: Buffer overrun Buffer overflow (CWE 120): Use

Re: [PATCH] Fix segfault when there's no config dir

2011-11-28 Thread walter harms
Am 28.11.2011 17:09, schrieb przan...@gmail.com: From: Paulo Zanoni paulo.r.zan...@intel.com Also, call AddConfigDirFiles only if we found a file, protecting ourselves from future changes to the AddConfigDirFiles function. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com ---

Re: [PATCH 1/3] InitRootWindow: Use ChangeWindowAttributes instead of duplicating it.

2011-11-20 Thread walter harms
Am 20.11.2011 12:48, schrieb Jamey Sharp: The protocol requires ChangeWindowAttributes to be able to set the root window's background and cursor to their defaults. So let's just use that when InitRootWindow needs to set up the defaults in the first place. This guarantees that using

Re: [PATCH libdri2] dri2video support

2011-11-16 Thread walter harms
Am 15.11.2011 23:49, schrieb Rob Clark: --- Makefile.am | 16 ++- include/X11/extensions/dri2.h | 52 +++- src/Makefile.am |2 +- src/dri2.c| 324 - test/Makefile.am |

Re: [PATCH] Save major/minor opcodes in ClientRec for RecordAReply

2011-11-14 Thread walter harms
Am 14.11.2011 18:04, schrieb Keith Packard: On Tue, 8 Nov 2011 10:47:44 -0800, Jamey Sharp ja...@minilop.net wrote: And can I persuade you to just inline this directly into its only call site, below, in Dispatch? I don't think factoring it out enhances clarity in this case, especially

Re: [PATCH:xmodmap 3/3] Replace chk_malloc + sprintf with asprintf

2011-11-14 Thread walter harms
Am 13.11.2011 18:27, schrieb Alan Coopersmith: On 11/12/11 01:14, walter harms wrote: Exit(-1); translates into exit(-1); (Why ?) this does not work as intended. maybe 1 or EXIT_FAILURE is better here. It's what the original code had and I didn't think about changing

Re: [PATCH:xmodmap 3/3] Replace chk_malloc + sprintf with asprintf

2011-11-12 Thread walter harms
Am 12.11.2011 06:27, schrieb Alan Coopersmith: Includes local private copy of asprintf for OS'es without it in libc. Removes chk_malloc as no callers remain anymore. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- xmodmap.c| 69

Re: [PATCH:libICE 6/6] Remove ancient workaround for System V/386 Release 4.2 compiler bug

2011-11-10 Thread walter harms
I love this part, UNIX System V/386 Release 4.2 Version 1 Reviewed-by: walter wha...@bfs.de Am 10.11.2011 07:19, schrieb Alan Coopersmith: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/process.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-)

Re: [PATCH 7/7] Fix gcc -Wwrite-strings warnings in xf86Modes code

2011-11-09 Thread walter harms
jus 2 minor remarks, re, wh Am 08.11.2011 21:42, schrieb Alan Coopersmith: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/modes/xf86Crtc.c |8 hw/xfree86/modes/xf86Crtc.h |2 +- hw/xfree86/modes/xf86EdidModes.c |2 +-

Re: [PATCH 11/12] Add a new XI2Mask struct and a few helper functions.

2011-11-09 Thread walter harms
Am 09.11.2011 05:04, schrieb Peter Hutterer: On Tue, Nov 08, 2011 at 11:00:21AM +0100, walter harms wrote: Am 07.11.2011 22:39, schrieb Peter Hutterer: The current XI2 mask handling is handy for copying (fixed size arrays) but a pain to deal with otherwise. Add a struct for XI2 masks

Re: [PATCH 07/12] dix: add AllocGrab helper function

2011-11-08 Thread walter harms
Am 07.11.2011 22:39, schrieb Peter Hutterer: Not needed since the GrabRec is a self-contained struct but will be needed for the xi2 input mask rework. FreeGrab already exists, make it available to other callers. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/grabs.c

Re: [PATCH 11/12] Add a new XI2Mask struct and a few helper functions.

2011-11-08 Thread walter harms
Am 07.11.2011 22:39, schrieb Peter Hutterer: The current XI2 mask handling is handy for copying (fixed size arrays) but a pain to deal with otherwise. Add a struct for XI2 masks and the required accessors. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/inpututils.c |

Re: Get the snapshot of a window , save the image to file ?

2011-11-08 Thread walter harms
Am 08.11.2011 01:43, schrieb Aaron Lewis: Hi, How can i get a snapshot of a window , and save the image to a file ? (i mean to program , not to run a command) Thanks ! take a look at xwd.c re, wh ___

Re: [PATCH evdev] Don't crop long value from EvdevBitIsSet.

2011-11-02 Thread walter harms
Am 02.11.2011 00:52, schrieb Peter Hutterer: Introduced in xf86-input-evdev-2.6.0-26-g4969389 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Cutting long to int for the return value loses us some values, notably in the ABS_MT ranges. src/evdev.c |2 +- 1 files

Re: [PATCH 1/7] Convert a bunch of sprintf to snprintf calls

2011-11-02 Thread walter harms
looks ok to me, some minor comments inside. re, wh Am 01.11.2011 23:42, schrieb Alan Coopersmith: This batch is the straightforward set - others are more complex and need more analysis to determine right size to pass. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---

Re: [PATCH 4/7] Convert glx/single2.c:DoGetString() to use asprintf()

2011-11-02 Thread walter harms
Am 01.11.2011 23:42, schrieb Alan Coopersmith: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- glx/single2.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/glx/single2.c b/glx/single2.c index 9884f40..9f8254b 100644 --- a/glx/single2.c +++

Re: [PATCH evdev] Don't crop long value from EvdevBitIsSet.

2011-11-02 Thread walter harms
Am 02.11.2011 14:15, schrieb Chase Douglas: On 11/02/2011 07:29 AM, walter harms wrote: Am 02.11.2011 00:52, schrieb Peter Hutterer: Introduced in xf86-input-evdev-2.6.0-26-g4969389 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Cutting long to int for the return value loses

Re: [PATCH joystick 1/2] Fix option type for option duplication

2011-10-31 Thread walter harms
Am 31.10.2011 05:41, schrieb Peter Hutterer: xf86OptionListDuplicate() duplicates an XF86Option list, not an InputOption list. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/jstk_key.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff

Re: [PATCH joystick 2/2] Deal with opaque input option types.

2011-10-31 Thread walter harms
Am 31.10.2011 07:18, schrieb Jeremy Huddleston: You need to declare InputOption tmp; in input_option_free_list. With that, both are Reviewed-by: Jeremy Huddleston jerem...@apple.com On Oct 30, 2011, at 21:41, Peter Hutterer wrote: ABI 14 made the InputOption type opaque, move the

<    1   2   3   4   5   6   >