2018 Election voting OPEN

2018-03-21 Thread Rob Clark
To all X.Org Foundation Members: The X.Org Foundation's annual election is now open and will remain open until 23:59 UTC on 5 April 2018. Four of the eight director seats are open during this election, with the four nominees receiving the highest vote totals serving as directors for two year

Re: [PATCH xserver] present: cap the version returned to the client

2018-03-21 Thread Adam Jackson
On Wed, 2018-03-21 at 09:02 -0600, Keith Packard wrote: > Julien Cristau writes: > > > Doesn't this break when e.g. client supports 2.2 and server supports > > 1.4, where we'll return 2.2 instead of 1.4? i.e. it seems to me this > > should be > > > > if (rep.majorVersion >

Re: [PATCH xserver 2/5] Remove always true GLAMOR_HAS_DRM_* guards

2018-03-21 Thread Louis-Francis Ratté-Boulianne
Hi, Sorry, I've initially missed this email and only saw your request for follow-up. On Wed, 2018-03-07 at 18:45 +, Emil Velikov wrote: > From: Emil Velikov > > With earlier commit the required version was bumped to 2.4.89, thus > the > guards always evaluate to

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-21 Thread Mario Kleiner
Thanks. However, seems we may have one more problem with the new code on slightly older < gen 9 Intel hw. Either that, or something is botched on my system atm., after pulling in all kind of updates to xorg-proto and xcb-proto and libdrm and stuff to make the server and mesa compile again. Using

Re: [PATCH xserver] exa: promise not to touch the data when swapping pointers

2018-03-21 Thread Adam Jackson
On Wed, 2018-03-21 at 16:37 +, Eric Engestrom wrote: > Hmm, forgot to reply, sorry about that: > I've had the patch locally for just about forever, so I don't remember > exactly, but I think I hit some issue with one of the callers and when > I looked at the implementations I noticed this. I

Re: [PATCH xserver] present: cap the version returned to the client

2018-03-21 Thread Julien Cristau
On Mon, Mar 19, 2018 at 16:04:43 +, Emil Velikov wrote: > From: Emil Velikov > > As per the protocol, the server should not return version greater than > the one supported by the client. > > Add a spec quote and tweak the numbers accordingly. > > Fixes:

2018 Election voting OPEN

2018-03-21 Thread Rob Clark
To all X.Org Foundation Members: The X.Org Foundation's annual election is now open and will remain open until 23:59 UTC on 5 April 2018. Four of the eight director seats are open during this election, with the four nominees receiving the highest vote totals serving as directors for two year

Re: [PATCH xserver 1/5] configure: remove libdrm version check

2018-03-21 Thread Adam Jackson
On Tue, 2018-03-20 at 16:41 +, Emil Velikov wrote: > Humble ping? > > Patch 2 might need a respin based on the feedback from Daniel/Louis. > Although the rest of the series should be pretty trivial. Said feedback appears not to be in my mailbox? The XXX bits should be cleaned up but this is

Re: [PATCH xserver] present: cap the version returned to the client

2018-03-21 Thread Keith Packard
Julien Cristau writes: > Doesn't this break when e.g. client supports 2.2 and server supports > 1.4, where we'll return 2.2 instead of 1.4? i.e. it seems to me this > should be > > if (rep.majorVersion > stuff->majorVersion || > (rep.majorVersion == stuff->majorVersion

Re: [PATCH xserver v2 0/4] Improve elevated priv check, honor LIBGL_DRIVERS_PATH

2018-03-21 Thread Adam Jackson
On Tue, 2018-03-13 at 17:46 -0400, Ben Crocker wrote: > Submit Nicolai Hähnle's four-patch series improving the checks for > elevated privileges and culminating in using the runtime environmental > control LIBGL_DRIVERS_PATH when searching for driver .so's, as > Mesa, and hence Glamor, already do.

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-21 Thread Adam Jackson
On Mon, 2018-03-12 at 17:11 +, Daniel Stone wrote: > On 12 March 2018 at 16:57, Mario Kleiner wrote: > > The check for "no modifier specified" in drmmode_is_format_supported() > > should check for DRM_FORMAT_MOD_INVALID, not for zero, as zero actually > > means

Re: [PATCH xserver] present: cap the version returned to the client

2018-03-21 Thread Emil Velikov
On 21 March 2018 at 08:02, Julien Cristau wrote: > On Mon, Mar 19, 2018 at 16:04:43 +, Emil Velikov wrote: > >> From: Emil Velikov >> >> As per the protocol, the server should not return version greater than >> the one supported by the client.

Re: [PATCH xserver 1/5] configure: remove libdrm version check

2018-03-21 Thread Emil Velikov
On 21 March 2018 at 14:12, Adam Jackson wrote: > On Tue, 2018-03-20 at 16:41 +, Emil Velikov wrote: > >> Humble ping? >> >> Patch 2 might need a respin based on the feedback from Daniel/Louis. >> Although the rest of the series should be pretty trivial. > > Said feedback

Re: [PATCH xserver] Xext/shm: Downgrade from error to debug log output about success

2018-03-21 Thread Adam Jackson
On Mon, 2018-03-12 at 15:12 +0300, Alexander Volkov wrote: > Signed-off-by: Alexander Volkov remote: I: patch #209879 updated using rev d36128a72acac4d54813c52c93efefad2dc9af41. remote: I: 1 patch(es) updated to state Accepted. To

Re: [PATCH xserver] exa: promise not to touch the data when swapping pointers

2018-03-21 Thread Adam Jackson
On Wed, 2018-03-14 at 15:37 +, Emil Velikov wrote: > On 13 March 2018 at 10:55, Eric Engestrom wrote: > > exa/exa.c:525:10: warning: initialization discards ‘const’ qualifier from > > pointer target type [-Wdiscarded-qualifiers] > > swap(pExaGC, pGC, funcs); >

Re: [PATCH xserver] exa: promise not to touch the data when swapping pointers

2018-03-21 Thread Eric Engestrom
On Wednesday, 2018-03-21 11:24:50 -0400, Adam Jackson wrote: > On Wed, 2018-03-14 at 15:37 +, Emil Velikov wrote: > > On 13 March 2018 at 10:55, Eric Engestrom wrote: > > > exa/exa.c:525:10: warning: initialization discards ‘const’ qualifier from > > > pointer