[PATCH xserver 1/2] modesetting: Ignore alpha channel when importing BOs for modesetting

2018-03-28 Thread Louis-Francis Ratté-Boulianne
Fixes a regression caused by modifiers support. For some hw to continue working even if not supporting ARGB and ARGB2101010 formats, we assume that all imported BOs are opaque. Signed-off-by: Louis-Francis Ratté-Boulianne ---

[PATCH xserver 2/2] modesetting: Fix reported size when using atomic modesetting

2018-03-28 Thread Louis-Francis Ratté-Boulianne
The framebuffer can include multiple CRTCs in multi-monitors setup. So we shouldn't use the buffer size but the CRTC size instead. Rotated displays are shadowed, so we don't need to worry about it there. Signed-off-by: Louis-Francis Ratté-Boulianne ---

Re: [PATCH xserver] modesetting: Fix up some XXX from removing GLAMOR_HAS_DRM_*

2018-03-28 Thread Mario Kleiner
A new crasher, this time while trying to play with the non-desktop property. On Thu, Mar 22, 2018 at 7:47 PM, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- > hw/xfree86/drivers/modesetting/drmmode_display.c | 75 > +--- >

Re: [ANNOUNCE] xorg-server 1.19.99.902

2018-03-28 Thread Thomas Klausner
I see a new compilation error compared to the previous beta release (on NetBSD): gmake[4]: Entering directory '/scratch/wip/modular-xorg-server-devel/work/xorg-server-1.19.99.902/hw/xfree86' CC sdksyms.o sdksyms.c:1773:15: error: expected expression before ',' token (void *) &,

[ANNOUNCE] xorg-server 1.19.99.902

2018-03-28 Thread Adam Jackson
This merges the DRI3 1.2 support (with an asterisk) and per-window flips for Xwayland, along with the usual collection of miscellaneous fixes. In particular the meson build is much closer to production- ready. The asterisk for DRI3 is that the modesetting driver has some known issues still, so the

[ANNOUNCE] xorg-server 1.19.99.902

2018-03-28 Thread Adam Jackson
This merges the DRI3 1.2 support (with an asterisk) and per-window flips for Xwayland, along with the usual collection of miscellaneous fixes. In particular the meson build is much closer to production- ready. The asterisk for DRI3 is that the modesetting driver has some known issues still, so the

Re: [PATCH xserver 2/2] glamor: Hide new DRI for behind Option "Debug" "dmabuf_capable"

2018-03-28 Thread Adam Jackson
On Wed, 2018-03-28 at 13:40 -0400, Adam Jackson wrote: > On Wed, 2018-03-28 at 12:46 -0400, Adam Jackson wrote: > > > @@ -960,7 +961,8 @@ glamor_egl_init(ScrnInfoPtr scrn, int fd) > > "EGL_EXT_image_dma_buf_import") && > >

Re: [PATCH xserver v2] fixing -logfile when used with -displayfd

2018-03-28 Thread Adam Jackson
On Sun, 2018-03-25 at 21:09 -0700, Alan Coopersmith wrote: > Reviewed-by: Alan Coopersmith Patchwork hated this patch, for whatever reason. Applied by hand and fixed up the commit message a bit, thanks: remote: E: failed to find patch for rev

Re: [PATCH xserver] automake: Fix 'make dist'

2018-03-28 Thread Adam Jackson
On Wed, 2018-03-28 at 14:08 +0200, Thierry Reding wrote: > On Wed, Mar 28, 2018 at 12:17:48PM +0200, Olivier Fourdan wrote: > > Automake would skip a few meson files that would prevent to build with > > meson a dist file previously generated by automake. > > > > Signed-off-by: Olivier Fourdan

Re: [PATCH xserver] Don't delete GLX's extensionInitCallback list during a reset.

2018-03-28 Thread Adam Jackson
On Fri, 2018-03-02 at 17:58 -0700, Kyle Brenneman wrote: > When a callback list is initialized using CreateCallbackList via AddCallback, > the list gets added to the listsToCleanup array, and as a result the list gets > deleted at the end of the server generation. > > But, vendor libraries add

Re: [PATCH xserver 0/3] Use DRM GetFB2 ioctl

2018-03-28 Thread Adam Jackson
On Fri, 2018-03-23 at 13:50 +, Daniel Stone wrote: > Hi, > This short patchset makes modesetting use the shiny, new, and completely > not at all merged GetFB2 DRM ioctl: > https://lists.freedesktop.org/archives/dri-devel/2018-March/170512.html > > When starting Xorg with -background none, it

Re: [PATCH xserver v3 23/24] xwayland: Cut off upper 32bit of queued vblank delay

2018-03-28 Thread Adam Jackson
On Wed, 2018-03-14 at 11:02 +0100, Michel Dänzer wrote: > However, since I've been unable to reproduce the issue you described > with Steam, despite kind of going out of my way to do so, I'm really > reluctant to add this workaround without getting more information about > the problem from

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-28 Thread Mario Kleiner
The approach in the patch looks good to me, same as we use in weston. I'll test in a few hours and let you know. thanks, -mario On Wed, Mar 28, 2018 at 5:58 AM, Louis-Francis Ratté-Boulianne wrote: > Hi Mario, > > Could you try with the following patch and let me know how

Re: [PATCH xserver 2/2] glamor: Hide new DRI for behind Option "Debug" "dmabuf_capable"

2018-03-28 Thread Adam Jackson
On Wed, 2018-03-28 at 12:46 -0400, Adam Jackson wrote: > @@ -960,7 +961,8 @@ glamor_egl_init(ScrnInfoPtr scrn, int fd) > "EGL_EXT_image_dma_buf_import") && > epoxy_has_egl_extension(glamor_egl->display, >

[PATCH xserver 2/2] glamor: Hide new DRI for behind Option "Debug" "dmabuf_capable"

2018-03-28 Thread Adam Jackson
... for xfree86, at least for now. Things appear to work for Xwayland but not yet for modesetting. Hopefully we can fix that before 1.20 but in the meantime this makes testing both paths easier than a rebuild. Signed-off-by: Adam Jackson --- glamor/glamor_egl.c | 4

[PATCH xserver 1/2] xfree86: Add Option "Debug" to ServerFlags

2018-03-28 Thread Adam Jackson
This provides a generic way to control obscure runtime behavior knobs without making interface promises. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86Config.c | 5 + hw/xfree86/common/xf86Privstr.h | 1 + hw/xfree86/man/xorg.conf.man| 4 3 files changed,

Re: [PATCH 7/7] meson: Properly extract ABI versions for xorg-server.pc

2018-03-28 Thread Adam Jackson
On Wed, 2018-03-28 at 14:04 +0200, Thierry Reding wrote: > From: Thierry Reding > > The newline in the middle of the awk expression confuses Meson and > causes it to pass only the string before the newline to awk, which will > subsequently fail because it encounters an

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-28 Thread Olivier Fourdan
Hi, On Wed, Mar 28, 2018 at 2:59 PM, Olivier Fourdan wrote: > > It definitely improves the situation yet there is probably more to it > because with this added on top of the current git master, only the laptop > output works, the external monitor connected to the docking

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-28 Thread Olivier Fourdan
Hi, On Wed, Mar 28, 2018 at 9:03 AM, Olivier Fourdan wrote: > On Wed, Mar 28, 2018 at 5:58 AM, Louis-Francis Ratté-Boulianne < > l...@collabora.com> wrote: > >> Could you try with the following patch and let me know how things are >> working out: >> >>

Re: [PATCH xserver] automake: Fix 'make dist'

2018-03-28 Thread Thierry Reding
On Wed, Mar 28, 2018 at 12:17:48PM +0200, Olivier Fourdan wrote: > Automake would skip a few meson files that would prevent to build with > meson a dist file previously generated by automake. > > Signed-off-by: Olivier Fourdan > --- > Makefile.am | 3 +++ > 1 file changed,

[PATCH 2/7] xorg: Remove unused definitions from xorg-server.h.in

2018-03-28 Thread Thierry Reding
From: Thierry Reding There is no code around that will ever define values for the XLOADABLE, WORKING_UNALIGNED_INT or XORG_RELEASE symbols, so they will always end up commented out and are therefore completely useless. Signed-off-by: Thierry Reding ---

[PATCH 4/7] meson: Generate xorg-server.h

2018-03-28 Thread Thierry Reding
From: Thierry Reding Some drivers (such as xf86-input-libinput) require the xorg-server.h to build. Generate it and install it so that it can be used by users. Signed-off-by: Thierry Reding --- include/Makefile.am| 1 + include/meson.build

[PATCH 1/7] meson: Fix build if Xdmcp is missing

2018-03-28 Thread Thierry Reding
From: Thierry Reding Xdmcp is an optional dependency, so make sure the build succeeds if it is missing. Signed-off-by: Thierry Reding --- include/meson.build | 4 ++-- meson.build | 8 +++- 2 files changed, 9 insertions(+), 3 deletions(-)

[PATCH 7/7] meson: Properly extract ABI versions for xorg-server.pc

2018-03-28 Thread Thierry Reding
From: Thierry Reding The newline in the middle of the awk expression confuses Meson and causes it to pass only the string before the newline to awk, which will subsequently fail because it encounters an unterminated string. One fix would be to escape the newlines ('\\n'),

[PATCH 6/7] meson: Fix generation of xorg-server.pc

2018-03-28 Thread Thierry Reding
From: Thierry Reding Meson stores relative paths for includedir, libdir and friends. These have to be concatenated with the ${prefix} or ${exec_prefix} variables to create a working pkg-config file. While at it, set a default value for the module_dir option so that it points

[PATCH 5/7] meson: Fill in missing data for xorg-server.h

2018-03-28 Thread Thierry Reding
From: Thierry Reding Provide more values for the definitions in xorg-server.h for Meson builds. The only missing defines left after this are _BSD_SOURCE, _POSIX_SOURCE and _XOPEN_SOURCE, but Meson seems to already define these via the command-line if necessary.

[PATCH 3/7] dix: Remove unused definitions from dix-config.h.in

2018-03-28 Thread Thierry Reding
From: Thierry Reding There is no code around that will ever define values for the WORKING_UNALIGNED_INT or XORG_RELEASE symbols, so they will always end up commented out and are therefore completely useless. Signed-off-by: Thierry Reding ---

[PATCH xserver] automake: Fix 'make dist'

2018-03-28 Thread Olivier Fourdan
Automake would skip a few meson files that would prevent to build with meson a dist file previously generated by automake. Signed-off-by: Olivier Fourdan --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile.am b/Makefile.am index

Re: [PATCH xserver] meson: Add the x(org)proto headers to the include path

2018-03-28 Thread Thierry Reding
On Tue, Mar 20, 2018 at 02:00:33PM -0400, Adam Jackson wrote: > Without this meson won't properly use headers installed into a > non-default location. > > Signed-off-by: Adam Jackson > --- > meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meson.build

Re: [Xcb] [PATCH xcb/proto] screensaver: Use CARD32 encoding for ScreenSaverSuspend 'suspend'

2018-03-28 Thread Uli Schlachter
Ah, that explains why Keith pushed a patch on 14th that was never on the mailing list. (= This patch is already merged.) Oh and while we are at it: I cannot find the exact definition of the struct that the X server uses for this, but it definitely only compares the "suspend" member of the

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-28 Thread Olivier Fourdan
Hi, On Wed, Mar 28, 2018 at 5:58 AM, Louis-Francis Ratté-Boulianne < l...@collabora.com> wrote: > Could you try with the following patch and let me know how things are > working out: > > https://gitlab.collabora.com/lfrb/xserver/commit/d26b45afc19547ab3ff689 > 581db2b01abb4e1ed2 > That requires