Re: ANN: xterm-335
On 08/14/2018 10:03 PM, Thomas Dickey wrote: Files: ftp://ftp.invisible-island.net/xterm/current/xterm-335.tgz ftp://ftp.invisible-island.net/xterm/current/xterm-335.tgz.asc ftp://ftp.invisible-island.net/xterm/patches/xterm-335.patch.gz ftp://ftp.invisible-island.net/xterm/patches/xterm-335.patch.gz.asc ftp://ftp.invisible-island.net/xterm/xterm-335.tgz ftp://ftp.invisible-island.net/xterm/xterm-335.tgz.asc Patch #335 - 2018/08/14 * add colorInnerBorder resource to make a change from patch #334 configurable (reports by H Merijn Brand, Gabriele Balducci). That was fast ... I had not yet even unpacked 334 from this weekend ;-) Dennis ___ xorg@lists.x.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: https://lists.x.org/mailman/listinfo/xorg Your subscription address: %(user_address)s
ANN: xterm-335
Files: ftp://ftp.invisible-island.net/xterm/current/xterm-335.tgz ftp://ftp.invisible-island.net/xterm/current/xterm-335.tgz.asc ftp://ftp.invisible-island.net/xterm/patches/xterm-335.patch.gz ftp://ftp.invisible-island.net/xterm/patches/xterm-335.patch.gz.asc ftp://ftp.invisible-island.net/xterm/xterm-335.tgz ftp://ftp.invisible-island.net/xterm/xterm-335.tgz.asc Patch #335 - 2018/08/14 * add colorInnerBorder resource to make a change from patch #334 configurable (reports by H Merijn Brand, Gabriele Balducci). -- Thomas E. Dickey https://invisible-island.net ftp://ftp.invisible-island.net signature.asc Description: Digital signature ___ xorg@lists.x.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: https://lists.x.org/mailman/listinfo/xorg Your subscription address: %(user_address)s
Re: [PATCH xserver] randr: rrCheckPixmapBounding should only increase screen size
Alex Goins writes: > Instead, this change simply > makes it so that rrCheckPixmapBounding() will only resize the fb to be larger > than it already is, preventing it from stepping on prior requests to increase > the size of the fb. Seems like a fine plan to me. Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
[PATCH xserver] randr: rrCheckPixmapBounding should only increase screen size
The purpose of rrCheckPixmapBounding() is to make sure that the fb is large
enough to accommodate the region scanned out by a GPU screen. Currently,
however,
it will actually shrink the fb if it's larger than it needs to be.
This is a problem when combining PRIME output slaving with arbitrary transforms
with xrandr.
Although arbitrary transforms are not supposed to constrain the size of the fb
(https://lists.freedesktop.org/archives/xorg-devel/2018-January/055563.html),
xrandr will use RRSetScreenSize to resize the desktop to accommodate scaling
transforms, e.g. scaling a 1920x1080 display to 3840x2160 will result in a
desktop size of 3840x2160.
In the case of PRIME, rrCheckPixmapBounding() will be called after
RRSetScreenSize() and it will resize the fb back down to what it would be
without the scaling transform, e.g. 1920x1080. This represents divergence in
behavior between PRIME and non-PRIME outputs.
I had originally made rrCheckPixmapBounding() account for arbitrary transforms,
but realized that the fb being large enough to accommodate arbitrary transforms
is not a hard requirement enforced in the server. Instead, this change simply
makes it so that rrCheckPixmapBounding() will only resize the fb to be larger
than it already is, preventing it from stepping on prior requests to increase
the size of the fb.
Signed-off-by: Alex Goins
---
randr/rrcrtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c
index 74dc5a2..cdc7bed 100644
--- a/randr/rrcrtc.c
+++ b/randr/rrcrtc.c
@@ -702,8 +702,8 @@ rrCheckPixmapBounding(ScreenPtr pScreen,
if (new_height < screen_pixmap->drawable.height)
new_height = screen_pixmap->drawable.height;
-if (new_width == screen_pixmap->drawable.width &&
-new_height == screen_pixmap->drawable.height) {
+if (new_width <= screen_pixmap->drawable.width &&
+new_height <= screen_pixmap->drawable.height) {
} else {
pScrPriv->rrScreenSetSize(pScreen, new_width, new_height, 0, 0);
}
--
2.7.4
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[ANNOUNCE] xf86-video-v4l 0.3.0
This long overdue release features build compatibility with newer X servers and support for v4l2 devices. Adam Jackson (6): Remove call to LoaderGetOS Remove a bogus memset Fix distcheck v4l 0.3.0 Alan Coopersmith (2): Remove xorgconfig & xorgcfg from See Also list in man page Update Sun license notices to current X.Org standard form Cyril Brulebois (1): Bump version for development. Gaetan Nadon (18): .gitignore: use common defaults with custom section # 24239 .gitignore: use common defaults with custom section # 24239 Several driver modules do not have a ChangeLog target in Makefile.am #23814 INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206 INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206 Makefile.am: add ChangeLog and INSTALL on MAINTAINERCLEANFILES configure.ac: remove unused sdkdir=$(pkg-config...) statement config: header files are part of the source not in EXTRA_DIST config: upgrade to util-macros 1.8 for additional man page support config: update AC_PREREQ statement to 2.60 config: remove AC_PROG_CC as it overrides AC_PROG_C_C99 config: remove unrequired AC_HEADER_STDC config: remove unrequired AC_SUBST([XORG_CFLAGS]) config: complete AC_INIT m4 quoting config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS config: replace deprecated AC_HELP_STRING with AS_HELP_STRING config: replace deprecated use of AC_OUTPUT with AC_CONFIG_FILES config: add comments for main statements Hans de Goede (1): Fix build post xserver 1.17 Julien Cristau (1): Add missing includes. Mauro Carvalho Chehab (8): Port xf86-video-v4l driver to V4L2 Coding style Cleanup Use the fourcc header instead of redefining it inside the code Fix Get/Set Port Attribute logic Return BadMatch if a Port Attribute is not found Provide a more consistent message if FBUF fails Fix arguments for v4l_check_yuv Fix standard video size detection Mihail Konev (1): autogen: add default patch prefix git tag: xf86-video-v4l-0.3.0 https://xorg.freedesktop.org/archive/individual/driver/xf86-video-v4l-0.3.0.tar.bz2 MD5: 167b82a486859dafd076ec0ab12d7d40 xf86-video-v4l-0.3.0.tar.bz2 SHA1: e29308282fd2f12626e2582d07f9c932804b25d3 xf86-video-v4l-0.3.0.tar.bz2 SHA256: e5fcb23bc1f51d883f9ab1f371af892990c1599cdbda2deaabe2f8adc8259d20 xf86-video-v4l-0.3.0.tar.bz2 SHA512: ec39b2fa70143b8662c3bd8ec094afdfa245687072d19164eb6b6c3e96aaf39a4d7708af60be975fcd07927cc9055812a67abb611a98cd27b3d548d8c2249955 xf86-video-v4l-0.3.0.tar.bz2 PGP: https://xorg.freedesktop.org/archive/individual/driver/xf86-video-v4l-0.3.0.tar.bz2.sig https://xorg.freedesktop.org/archive/individual/driver/xf86-video-v4l-0.3.0.tar.gz MD5: ac562e4d955b74e91a8ef22d8c87e605 xf86-video-v4l-0.3.0.tar.gz SHA1: abdd3450552137998a196fb6c1efcca1e496c8a3 xf86-video-v4l-0.3.0.tar.gz SHA256: cbaa8ba208b62da0b6da7f463ee80fefe239ec9e31949ef08b6677734a9a319e xf86-video-v4l-0.3.0.tar.gz SHA512: f695417f80339845708edd13a3fa997953bf8559f2b288b56e27ce32cc6efc511f59bc73d17b50457136d734ec993e728cf7311d34d6fd6dfa856381c799e242 xf86-video-v4l-0.3.0.tar.gz PGP: https://xorg.freedesktop.org/archive/individual/driver/xf86-video-v4l-0.3.0.tar.gz.sig - ajax signature.asc Description: This is a digitally signed message part ___ xorg@lists.x.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: https://lists.x.org/mailman/listinfo/xorg Your subscription address: %(user_address)s
Re: [PATCH xcb] don't flag extra reply in xcb_take_socket
On Ätvrtek 9. srpna 2018 0:20:01 CEST Erik Kurzinger wrote: > In practice, this has been causing intermittent KWin crashes when > used in combination with the proprietary NVIDIA driver such as > https://bugs.kde.org/show_bug.cgi?id=386370 since when Xlib fails to > retrieve one of these incorrectly discarded replies it triggers > an IO error. There is a downstream bug with the same issue: https://bugzilla.opensuse.org/show_bug.cgi?id=1101560 I have let the reporter try libxcb with this patch and reportedly it fixed the issue for him. Not sure if it can be used as Tested-by, but positive feedback nevertheless! Michal ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xcb] don't flag extra reply in xcb_take_socket
+xcb@
On 08/09/2018 12:20 AM, Erik Kurzinger wrote:
> If any flags are specified in a call to xcb_take_socket,
> they should only be applied to replies for requests sent
> after that function returns (and until the socket is
> re-acquired by XCB).
>
> Previously, they would also be incorrectly applied to the
> reply for the last request sent before the socket was taken.
> For instance, in this example program the reply for the
> GetInputFocus request gets discarded, even though it was
> sent before the socket was taken. This results in the
> call to retrieve the reply hanging indefinitely.
>
> static void return_socket(void *closure) {}
>
> int main(void)
> {
> Display *dpy = XOpenDisplay(NULL);
> xcb_connection_t *c = XGetXCBConnection(dpy);
>
> xcb_get_input_focus_cookie_t cookie = xcb_get_input_focus_unchecked(c);
> xcb_flush(c);
>
> uint64_t seq;
> xcb_take_socket(c, return_socket, dpy, XCB_REQUEST_DISCARD_REPLY, );
>
> xcb_generic_error_t *err;
> xcb_get_input_focus_reply(c, cookie, );
> }
>
> In practice, this has been causing intermittent KWin crashes when
> used in combination with the proprietary NVIDIA driver such as
> https://bugs.kde.org/show_bug.cgi?id=386370 since when Xlib fails to
> retrieve one of these incorrectly discarded replies it triggers
> an IO error.
>
> Signed-off-by: Erik Kurzinger
> ---
> src/xcb_in.c | 21 +++--
> src/xcb_out.c | 10 --
> 2 files changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/src/xcb_in.c b/src/xcb_in.c
> index 73209e0..4333ad3 100644
> --- a/src/xcb_in.c
> +++ b/src/xcb_in.c
> @@ -958,8 +958,25 @@ void _xcb_in_replies_done(xcb_connection_t *c)
> pend = container_of(c->in.pending_replies_tail, struct
> pending_reply, next);
> if(pend->workaround == WORKAROUND_EXTERNAL_SOCKET_OWNER)
> {
> -pend->last_request = c->out.request;
> -pend->workaround = WORKAROUND_NONE;
> +if (XCB_SEQUENCE_COMPARE(pend->first_request, <=,
> c->out.request)) {
> +pend->last_request = c->out.request;
> +pend->workaround = WORKAROUND_NONE;
> +} else {
> +/* The socket was taken, but no requests were actually sent
> + * so just discard the pending_reply that was created.
> + */
> +struct pending_reply *prev_pend = c->in.pending_replies;
> +if (prev_pend == pend) {
> +c->in.pending_replies = NULL;
> +c->in.pending_replies_tail = >in.pending_replies;
> +} else {
> +while (prev_pend->next != pend)
> +prev_pend = prev_pend->next;
> +prev_pend->next = NULL;
> +c->in.pending_replies_tail = _pend->next;
> +}
> +free(pend);
> +}
> }
> }
> }
> diff --git a/src/xcb_out.c b/src/xcb_out.c
> index 3601a5f..c9593e5 100644
> --- a/src/xcb_out.c
> +++ b/src/xcb_out.c
> @@ -387,8 +387,14 @@ int xcb_take_socket(xcb_connection_t *c, void
> (*return_socket)(void *closure), v
> {
> c->out.return_socket = return_socket;
> c->out.socket_closure = closure;
> -if(flags)
> -_xcb_in_expect_reply(c, c->out.request,
> WORKAROUND_EXTERNAL_SOCKET_OWNER, flags);
> +if(flags) {
> +/* c->out.request + 1 will be the first request sent by the
> external
> + * socket owner. If the socket is returned before this request
> is sent
> + * it will be detected in _xcb_in_replies_done and this
> pending_reply
> + * will be discarded.
> + */
> +_xcb_in_expect_reply(c, c->out.request + 1,
> WORKAROUND_EXTERNAL_SOCKET_OWNER, flags);
> +}
> assert(c->out.request == c->out.request_written);
> *sent = c->out.request;
> }
>
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
