Re: [PATCH 2/2] Make sure XFixes invisible cursor gets freed on server reset

2010-05-03 Thread Adam Jackson
as the privates layout may well be different on subsequent generations. Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 1/4] dix: Update element count in FreeResourceByType()

2010-05-03 Thread Adam Jackson
On Sun, 2010-05-02 at 16:48 -0700, Keith Packard wrote: On Sun, 2 May 2010 17:26:58 -0400, Kristian Høgsberg k...@bitplanet.net wrote: I guess they don't do it either... bad assumption on my part. But it *is* a bug, right? I can fix those too and resend, but I'm just still surprised

Re: [PATCH 2/4] glxdri2: Hard-code the extension version we need

2010-05-03 Thread Adam Jackson
a too high version of the extension. The right approach is to just hard-code the version we need instead of using the #defines. Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part

Re: [PATCH 3/4] list.h: Add list_for_each_entry_safe()

2010-05-03 Thread Adam Jackson
On Sat, 2010-05-01 at 13:31 -0400, Kristian Høgsberg wrote: Signed-off-by: Kristian Høgsberg k...@bitplanet.net Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel

Re: [PATCH 09/10] xfree86: remove xf86EnableAccess

2010-05-03 Thread Adam Jackson
On Mon, 2010-05-03 at 00:43 +0300, Tiago Vignatti wrote: Not necessarily your driver will want to use the VGA arbitration. The patch only cares about the removal of this unused API. BTW, is the driver that you care open-source? If yes, as I pointed on the cover letter, it's pretty easy to

Re: Per-output DPMS?

2010-05-03 Thread Adam Jackson
On Mon, 2010-05-03 at 17:33 +0200, Michel Dänzer wrote: On Mon, 2010-05-03 at 16:26 +0100, Matthew Garrett wrote: On Mon, May 03, 2010 at 03:55:23PM +0100, Richard Hughes wrote: Ideally I could set a per-output DPMS setting, although I guess the same affect could be done with XRandr and

[PATCH 0/2] Composite window resize performance tweaks

2010-05-05 Thread Adam Jackson
We're doing the backfill for initial window contents more than we need to. Resize of bg=None windows will just leave trails of the old window decorations, which can't be what any app wants. Resize and map of backgrounded windows will paint the background in the exposed areas. It's a little

[PATCH 1/2] composite: Don't backfill non-bg-None windows

2010-05-05 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- composite/compalloc.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/composite/compalloc.c b/composite/compalloc.c index 73adc72..d21b41d 100644 --- a/composite/compalloc.c +++ b/composite/compalloc.c @@ -486,7

[PATCH 2/2] composite: Don't backfill non-MapWindow allocations

2010-05-05 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- composite/compalloc.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/composite/compalloc.c b/composite/compalloc.c index d21b41d..d5cde58 100644 --- a/composite/compalloc.c +++ b/composite/compalloc.c @@ -472,7

Re: RFC: getting rid of Xalloc/Xfree/... in server

2010-05-05 Thread Adam Jackson
On Thu, 2010-05-06 at 02:27 +0700, Mikhail Gusarov wrote: There is RFC patchset which gets rid of Xalloc/Xfree/... wrappers in X server while retaining the API and ABI. URL: git://anongit.freedesktop.org/~dottedmag/xserver no-xalloc Thanks for taking this on. Have you compared x11perf runs

Re: [PATCH 0/2] Composite window resize performance tweaks

2010-05-06 Thread Adam Jackson
On Wed, 2010-05-05 at 16:25 -0400, Adam Jackson wrote: Uncomposited: 1.8 sec Composited, unpatched:12.4 sec Composited, patched: 9.3 sec Which is decent. Note that the uncomposited number is actually kind of depressing, 9ms for a synchronous resize is rather a lot

Re: [PATCH 2/2] composite: Don't backfill non-MapWindow allocations

2010-05-06 Thread Adam Jackson
On Wed, 2010-05-05 at 17:20 -0700, Aaron Plattner wrote: Just to make sure I understand this right, does this work because the compReallocPixmap callers always go through the compCopyWindow path and use CopyArea to initialize the new pixmap? It would be nice if that were described in the

Re: [PATCH] xf86: allow for no outputs connected at startup operation.

2010-05-06 Thread Adam Jackson
On Thu, 2010-05-06 at 13:18 +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com When nothing is connected at startup and we canGrow, allow the server to start with a 1024x768 framebuffer, and when the drivers send hotplug events this will expand to the correct size dynamically.

Re: [PATCH 2/2] composite: Don't backfill non-MapWindow allocations

2010-05-06 Thread Adam Jackson
On Thu, 2010-05-06 at 10:47 -0700, Aaron Plattner wrote: On Thu, May 06, 2010 at 07:34:58AM -0700, Adam Jackson wrote: On Wed, 2010-05-05 at 17:20 -0700, Aaron Plattner wrote: Just to make sure I understand this right, does this work because the compReallocPixmap callers always go through

Re: [PATCH resend] trivial unreviewed patches

2010-05-06 Thread Adam Jackson
On Thu, 2010-05-06 at 11:00 -0700, Jamey Sharp wrote: I found these cleanups while trying to simplify the use of dixLookupResourceByType, but I think they stand on their own and I thought they'd be easy to review. Anyone? Reviewed-by: Adam Jackson a...@redhat.com for the series. - ajax

[PATCH] modes: Combine xf86DefaultModes and DMTModes

2010-05-06 Thread Adam Jackson
DMTModes is what xf86DefaultModes was always meant to be. Smash the two together, leaving aliases in place for the old names to make it easy on external modules. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/common/Makefile.am| 10 +--- hw/xfree86/common/extramodes | 27

[PATCH] mi: Delete wide ellipse arc cache

2010-05-06 Thread Adam Jackson
5370.0 ( 0.33) 100-pixel wide double-dashed ellipse But no one cares, and it's a modest size win: textdata bss dec hex filename 1773824 69552 59288 1902664 1d0848 hw/vfb/Xvfb.before 1773112 69552 58648 1901312 1d0300 hw/vfb/Xvfb Signed-off-by: Adam Jackson

Re: Proposal for per-CRTC pixmaps in RandR

2010-05-07 Thread Adam Jackson
On Thu, 2010-05-06 at 15:12 -0700, Keith Packard wrote: +┌─── +RRCreateScanoutPixmap + pixmap: PIXMAP + window: WINDOW + width, height: CARD16 + format: PICTFORMAT + rotations: SETofROTATION +└─── + Errors: Window, Match, Value + + Creates a pixmap which

Re: [PATCH 08/10] xfree86: bus: remove SetSIGIOForState and simplify the code

2010-05-07 Thread Adam Jackson
On Fri, 2010-05-07 at 15:44 +0300, Tiago Vignatti wrote: + /* + * This is a good place to block SIGIO during SETUP state. SIGIO should be + * blocked in SETUP state otherwise (u)sleep() might get interrupted + * early. We take care not to call xf86BlockSIGIO() twice. +

Re: [PATCH 10/10] xfree86: remove PCI dependency from InitOutput

2010-05-07 Thread Adam Jackson
On Fri, 2010-05-07 at 15:44 +0300, Tiago Vignatti wrote: +Bool +xf86CallDriverProbe( DriverPtr drv, Bool detect_only ) +{ +Bool foundScreen = FALSE; + +if ( drv-PciProbe != NULL ) { +if ( xf86DoConfigure xf86DoConfigurePass1 ) { +assert( detect_only ); +

Re: Proposal for per-CRTC pixmaps in RandR

2010-05-07 Thread Adam Jackson
On Fri, 2010-05-07 at 11:46 -0700, Keith Packard wrote: On Fri, 07 May 2010 10:30:16 -0400, Adam Jackson a...@nwnk.net wrote: I can _almost_ see the justification for this, but it sure feels like it belongs in Composite not RANDR. Yeah, it could go in Composite too. The whole reason I

Re: RFC: getting rid of Xalloc/Xfree/... in server

2010-05-07 Thread Adam Jackson
On Sat, 2010-05-08 at 01:44 +0700, Mikhail Gusarov wrote: MG * X* functions are marked as deprecated. There is one additional question that came into my mind: is there modular (in a sense that it uses loadable modules which in turn use Xfree/Xalloc) server under Windows? No, there is not,

Re: [PATCH 2/5] Kill ChangeGC in favor of dixChangeGC.

2010-05-10 Thread Adam Jackson
; Here, though, I'm not sure. We do run the security check before we get here so it's probably okay. At any rate, you're certainly not changing any semantics by leaving them all as NullClient, so this patch can't be more wrong than before. Reviewed-by: Adam Jackson a...@redhat.com - ajax

Re: [PATCH 05/14] miPolyPoint bugfix: Check memory allocation before changing the GC.

2010-05-10 Thread Adam Jackson
On Mon, 2010-05-10 at 11:41 -0700, Jamey Sharp wrote: On Mon, May 10, 2010 at 8:18 AM, Adam Jackson a...@nwnk.net wrote: On Sat, 2010-05-08 at 16:39 -0700, Jamey Sharp wrote: miPolyPoint ought to leave the GC unchanged even if it fails. We have a new winner for the oldest-bug competition

Re: [PATCH] xserver/Xext/sync.c: Fix wrong bracket values when startOver = FALSE (Bug 27023)

2010-05-10 Thread Adam Jackson
On Fri, 2010-03-12 at 10:45 -0800, David James wrote: Currently, the SyncComputeBracketValues function in xserver/Xext/sync.c calculates bracket values incorrectly when startOver = FALSE. I have attached a patch to fix this. Man, this code is subtle. Reviewed-by: Adam Jackson a...@redhat.com

[PATCH] render: Avoid infinite loops in alpha map handling (#23581)

2010-05-11 Thread Adam Jackson
If setting alpha map to a picture that already has one, use that instead. (Transitively, although that should never happen.) If setting alpha map picture to the picture itself, act as though None were given. Signed-off-by: Adam Jackson a...@redhat.com --- render/picture.c | 74

Re: [PATCH] render: Avoid infinite loops in alpha map handling (#23581)

2010-05-11 Thread Adam Jackson
On Tue, 2010-05-11 at 09:25 -0700, Keith Packard wrote: On Tue, 11 May 2010 11:30:06 -0400, Adam Jackson a...@redhat.com wrote: If setting alpha map to a picture that already has one, use that instead. (Transitively, although that should never happen.) If setting alpha map picture

Re: [PATCH] render: Avoid infinite loops in alpha map handling (#23581)

2010-05-12 Thread Adam Jackson
On Wed, 2010-05-12 at 10:19 -0700, Keith Packard wrote: Is there somewhere in the server that is recursing through the alphaMap? fb doesn't, and I don't know of any acceleration code that deals with alphaMap. Using the testcase in the bug on an Xvfb: (gdb) bt #0 _int_malloc

Re: Dealing with the xalloc-malloc change

2010-05-13 Thread Adam Jackson
On Wed, 2010-05-12 at 15:51 -0700, Keith Packard wrote: Here's a script I wrote to switch allocator calls around: #!/bin/sh sed -i \ -e 's/\[Xx]alloc\ *(/malloc(/' \ -e 's/\[Xx]free\ *(/free(/' \ -e 's/\[Xx]realloc\ *(/realloc(/' \ -e 's/\[Xx]calloc\ *(/calloc(/' \ $@

Re: [PATCH:x11proto] Add Sun cc 5.9 later to compilers supporting noreturn attribute

2010-05-18 Thread Adam Jackson
On Mon, 2010-05-17 at 20:57 -0700, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel

[PATCH] dix: Remove a large pile of backing store leftovers

2010-05-18 Thread Adam Jackson
Since we're breaking ScreenRec, might as well break it good and hard. Signed-off-by: Adam Jackson a...@redhat.com --- fb/wfbrename.h |1 - hw/vfb/InitOutput.c |5 --- hw/xfree86/loader/sdksyms.sh |2 - hw/xfree86/xaa/xaa.h |2 - hw

Re: [PATCH] dix: Remove a large pile of backing store leftovers

2010-05-19 Thread Adam Jackson
On Tue, 2010-05-18 at 15:27 -0700, Keith Packard wrote: On Tue, 18 May 2010 17:57:31 -0400, Adam Jackson a...@redhat.com wrote: Since we're breaking ScreenRec, might as well break it good and hard. Looking good to me. Should change backStorage into a boolean instead of a pointer now too

Re: [PATCH] Enable configuration of the MONOTONIC_CLOCK when cross-compiling.

2010-05-19 Thread Adam Jackson
On Tue, 2010-05-18 at 15:17 -0700, David James wrote: When xorg-xserver is being cross-compiled, there is currently no way for us to detect whether the monotonic clock is available on the target system. Currently, in this situation, we default to not use the monotonic clock. One problem with

Re: [PATCH:libXt] Move sm from Requires to Requires.private in xt.pc

2010-05-19 Thread Adam Jackson
Coopersmith alan.coopersm...@oracle.com Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

RE: Do not display the screensaver

2010-05-19 Thread Adam Jackson
On Wed, 2010-05-19 at 17:07 +0200, Kai-Uwe Behrmann wrote: I know more the client side of the API. DisplayPort can serve up to 16-bit per channel. Three one dimensional look up tables (LUT) each of 8-bit resolution would not make much sense in this scenario. Strictly, so can DVI and HDMI. -

Re: [PATCH] Add configuration option to disable default modes on an output

2010-05-19 Thread Adam Jackson
...@onelan.com This is missing an xorg.conf.man.pre patch, but otherwise: Acked-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: review requests

2010-05-19 Thread Adam Jackson
of at callers. Use WriteEventsToClient rather than TryClientEvents where possible. The bit for fake client no-op is a little sketchy, since we should really never be in the event generation path when we're operating as the server client. But meh, no harm. Reviewed-by: Adam Jackson a...@redhat.com

Re: [PATCH] dix: Reshuffle ScreenRec to pack holes

2010-05-19 Thread Adam Jackson
On Wed, 2010-05-19 at 12:23 -0700, Jamey Sharp wrote: On Wed, May 19, 2010 at 11:31 AM, Adam Jackson a...@redhat.com wrote: typedef struct _Screen { intmyNum; /* index of this instance in Screens[] */ -ATOM id; +unsigned int rgf

Re: [PATCH] dix: Reshuffle ScreenRec to pack holes

2010-05-19 Thread Adam Jackson
On Wed, 2010-05-19 at 12:56 -0700, Keith Packard wrote: On Wed, 19 May 2010 14:31:19 -0400, Adam Jackson a...@redhat.com wrote: This eliminates the unused 'id' field (what the eff), and reorders the other data fields to fit packed on both ILP32 and LP64. ScreenRec shrinks by 64 bytes

Re: [PATCH v2 0/2] Add configuration option to disable default modes on an output

2010-05-20 Thread Adam Jackson
in this set is all you need; if not, please consider applying both patches. Reviewed-by: Adam Jackson a...@redhat.com for the series. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development

Re: Scratch GC performance (was Re: [PATCH] dix: Reshuffle ScreenRec to pack holes)

2010-05-21 Thread Adam Jackson
On Thu, 2010-05-20 at 11:27 -0700, Jamey Sharp wrote: On Thu, May 20, 2010 at 11:17 AM, Adam Jackson a...@nwnk.net wrote: The numbers, sadly, are pretty clear: 717000.0 518000.0 ( 0.72) Map window via parent (4 kids) That's not really a performance hit I'm willing to take. A 7

Re: [PATCH] Replace screen-rgf scratch GC flags with a bit in each GC.

2010-05-21 Thread Adam Jackson
Packard kei...@keithp.com Purple is the new black. Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH] vbe.h: Use __attribute__((packed)) on Sun cc 5.9 later as well as gcc

2010-05-21 Thread Adam Jackson
On Thu, 2010-05-20 at 17:56 -0700, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel

Re: [PATCH] Solaris: Use VT_SET_CONSUSER ioctl to set Console User rights profile

2010-05-21 Thread Adam Jackson
devices. Also adds a Solaris-specific -C flag to force starting on /dev/console instead of /dev/vt*, allowing programs like xterm -C to access the console device. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Curious API. Reviewed-by: Adam Jackson a...@redhat.com - ajax

Re: [PATCH 03/11] xfree86: bus: move IOADDRESS definition to a common header file

2010-05-21 Thread Adam Jackson
On Fri, 2010-05-21 at 07:38 -0700, Keith Packard wrote: On Fri, 21 May 2010 14:43:16 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: -extern _X_EXPORT IOADDRESS xf86MapLegacyIO(struct pci_device *dev); +extern _X_EXPORT unsigned long xf86MapLegacyIO(struct pci_device *dev);

Yet another reason window pictures suck

2010-05-21 Thread Adam Jackson
Context: https://bugzilla.redhat.com/show_bug.cgi?id=533879 If you've got a 24bpp framebuffer, you poor misguided soul you, then you have a conundrum. Pixmaps are 32bpp but Windows aren't. Suppose you make a Picture out of a Window. You would think you'd be required to use one of the Formats

Re: [PATCH] vfb: Remove dead variable and header file

2010-05-21 Thread Adam Jackson
On Mon, 2010-05-10 at 11:48 -0400, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com Resend, trivial dead code deletion. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 2/6] xfree86: Drop DDC1 support

2011-12-02 Thread Adam Jackson
On 12/2/11 12:01 PM, Mark Kettenis wrote: However, rather than breaking drivers, can we just replace xf86DoEDID_DDC1() with a dummy version that prints a warning message and just returns NULL? That should keep drivers from breaking. I'm completely fine with patching the drivers to only call

Re: [PATCH 6/6] xfree86: Remove most of EDID printing

2011-12-02 Thread Adam Jackson
On 12/1/11 5:51 PM, Michal Suchanek wrote: On 1 December 2011 22:51, Adam Jacksona...@redhat.com wrote: The important part of this is the mode list, which we already print in another form. Everything else is cosmetic and better done in the session. Where is this information available if

Re: [PATCH 2/2] PropertyNotify filters

2011-12-02 Thread Adam Jackson
On 12/2/11 12:09 AM, Peter Hutterer wrote: On Thu, Dec 01, 2011 at 03:53:41PM -0500, Adam Jackson wrote: +RemovePropertyFilter + + window: WINDOW + property: LISTofATOM + + This request modifies the property filter for the named

Re: [PATCH 0/2 RFC] Fixes version 6

2011-12-02 Thread Adam Jackson
On 12/2/11 5:19 AM, Daniel Stone wrote: Sounds good to me: I don't suppose I could convince you to take a look at https://bugs.freedesktop.org/show_bug.cgi?id=41784 as well? Sure. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 02/37] Make extension.h self-contained, remove C++ externs

2011-12-02 Thread Adam Jackson
On 6/28/11 3:27 PM, Daniel Stone wrote: externsion.h required bits from Xfuncproto.h and dixstruct.h, but included neither; fix that. ^ typo, s/ern/en/ - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 26/37] Loader: Remove extension initialisation sorting

2011-12-02 Thread Adam Jackson
On 6/28/11 3:27 PM, Daniel Stone wrote: Extensions could previously declare initialisation dependencies on other extensions, which would then get nicely sorted by the loader. We only had one user for this, GLX, which had one pointless (Composite) and one possibly useful dependency (DBE). As

[PATCH 1/4] dmx: Drop ShadowFB support

2011-12-05 Thread Adam Jackson
This has been listed as deprecated since it was merged. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac |2 +- hw/dmx/Makefile.am |2 - hw/dmx/dmx.h |9 -- hw/dmx/dmxinit.c | 15 --- hw/dmx/dmxpict.c |6 +- hw/dmx

[PATCH 2/4] dix: Drop CopyClip from GCFuncs

2011-12-05 Thread Adam Jackson
Nobody was doing anything special with this. Xnest had the most complicated version, but it appears to be functionally equivalent to miCopyClip. Move miCopyClip to dix code and drop the slot from GCFuncs. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/panoramiX.c

[PATCH 0/4] Move GC clip management to ScreenRec

2011-12-05 Thread Adam Jackson
None of the GC wrappers do anything particularly interesting with clip management. I think in theory this was meant to allow the driver to flatten the clip to a bitmap and/or keep track of a window ID, but the only example I can find of anything remotely like that in open code is Xprint's

[PATCH 3/4] dix: Move DestroyClip from GCFuncs to ScreenRec

2011-12-05 Thread Adam Jackson
Strictly this is more of a DDX than Screen method, but close enough. fb will fill this in for you, Xnest gets to roll its own. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/panoramiX.c | 11 +-- dix/gc.c |2 +- exa/exa.c

[PATCH 4/4] dix: Move ChangeClip from GCFuncs to ScreenRec

2011-12-05 Thread Adam Jackson
Same deal as DestroyClip. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/panoramiX.c | 14 -- dix/gc.c | 14 +++--- exa/exa.c | 19 --- fb/fbgc.c

Re: [Mesa-dev] [PATCH 0/7] Fix GLX files generated by Mesa for the server

2011-12-13 Thread Adam Jackson
With these two branches, I observer no piglit regressions on Intel Ironlake hardware. I have not tested other hardware, but I would expect any regressions to be hardware independent. Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message

[PATCH 0/4] Minor performance tuning

2011-12-13 Thread Adam Jackson
Found these in an old work branch. The first two are only relevant if you're using XACE or dtrace, the second two apply unconditionally. The total series is good for about 13% speedup on x11perf's 10x10 PutImage and ShmPutImage tests, and should be a win across the board. Alan, I assume the

[PATCH 1/4] xace: ricer tuning for XaceHook

2011-12-13 Thread Adam Jackson
@ 0.0009 msec (1087458.5/sec): PutImage 10x10 square 6000 trep @ 0.0005 msec (2012238.6/sec): ShmPutImage 10x10 square Signed-off-by: Adam Jackson a...@redhat.com --- Xext/xace.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/Xext/xace.c b/Xext/xace.c index

[PATCH 2/4] dix: Tune dtrace hooks around Dispatch

2011-12-13 Thread Adam Jackson
square 6000 trep @ 0.0005 msec (2072652.2/sec): ShmPutImage 10x10 square Signed-off-by: Adam Jackson a...@redhat.com --- dix/dispatch.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/dix/dispatch.c b/dix/dispatch.c index b39271f..bb95368 100644 --- a/dix

[PATCH 3/4] dix: Tune dixLookupDrawable for success

2011-12-13 Thread Adam Jackson
@ 0.0009 msec (1148346.9/sec): PutImage 10x10 square 6000 trep @ 0.0005 msec (2091666.1/sec): ShmPutImage 10x10 square Signed-off-by: Adam Jackson a...@redhat.com --- dix/dixutils.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/dix/dixutils.c b/dix

[PATCH 4/4] miext/damage: Only wrap into the GC ops chain if there's a listener

2011-12-13 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- miext/damage/damage.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/miext/damage/damage.c b/miext/damage/damage.c index d791211..dd4026b 100644 --- a/miext/damage/damage.c +++ b/miext/damage/damage.c @@ -437,9 +437,13

[PATCH] Document the r/R semantics for initial connection handshake

2011-12-14 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- specs/sect1-9.xml | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/specs/sect1-9.xml b/specs/sect1-9.xml index edc2971..7e5896c 100644 --- a/specs/sect1-9.xml +++ b/specs/sect1-9.xml @@ -1157,10 +1157,17

Re: [PULL] misc cleanups

2011-12-14 Thread Adam Jackson
On Wed, 2011-12-14 at 20:33 +0100, Julien Cristau wrote: On Wed, Dec 14, 2011 at 11:30:37 -0800, Keith Packard wrote: On Thu, 01 Dec 2011 17:42:40 -0500, Adam Jackson a...@redhat.com wrote: The following changes since commit fb22a408c69a84f81905147de9e82cf66ffb6eb2: Save major

[PATCH] make Xephyr resizeable

2011-12-15 Thread Adam Jackson
From: Vic Lee ll...@163.com Modified from Vic's original patch to make Xephyr always be resizeable, instead of only if embedded in something else. https://bugs.freedesktop.org/show_bug.cgi?id=25804 Reviewed-by: Adam Jackson a...@redhat.com Signed-off-by: Vic Lee ll...@163.com --- hw/kdrive

Re: [PATCH V4] xserver: check for elevated privileges not uid=0

2011-12-16 Thread Adam Jackson
of that, this looks at least as correct as what was there before. Reviewed-by: Adam Jackson a...@redhat.com - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

[PATCH] xaa: Always install SDK headers even with built with --disable-xaa

2011-12-16 Thread Adam Jackson
The drivers know to fall back at runtime, but the build will fail, which is kind of senseless. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/Makefile.am |2 -- hw/xfree86/xaa/Makefile.am |3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/xfree86

Re: [PATCH] xaa: Always install SDK headers even with built with --disable-xaa

2011-12-16 Thread Adam Jackson
On 12/16/11 3:42 PM, Julien Cristau wrote: So I looked at mga, and it has some kind of support for conditional build of the xaa stuff, except that's not hooked up to anything so it's always enabled. And if it fails to load xaa at runtime, it returns false from preinit instead of falling back

Re: [PATCH 4/4] miext/damage: Only wrap into the GC ops chain if there's a listener

2011-12-20 Thread Adam Jackson
On 12/17/11 8:03 PM, Aaron Plattner wrote: I think this needs to be accompanied by a change to DamageRegister (or miDamageRegister) to bump the drawable's serial number, or else creating a Damage object on a drawable won't cause GCs that are already validated against it to have the damage ops

Re: [xproto: PATCH] Xmd.h: amd64-x32 ABI defines sizeof(long) == sizeof (void*) == 4

2011-12-20 Thread Adam Jackson
On 12/20/11 11:41 AM, Alan Coopersmith wrote: On 12/20/11 08:37, Sergei Trofimovich wrote: + (defined(__amd64__) defined(__LP64__)) /* skip x32 */ || \ + defined(amd64) || \ Really? Someone defined __amd64__ on a non LP64 platform and didn't expect to break tons of software? Amazing...

Re: [PATCH 01/21] include: add GetXI2MaskByte and GetXI2EventFilterMask to headers

2011-12-20 Thread Adam Jackson
On 12/8/11 10:36 PM, Peter Hutterer wrote: @@ -414,7 +414,7 @@ GetEventFilterMask(DeviceIntPtr dev, int evtype) return filters[dev ? dev-id : 0][evtype]; } -static inline Mask +inline Mask GetXI2EventFilterMask(int evtype) { return (1 (evtype % 8)); This reads strangely to

Re: [PATCH] Always install xaa sdk headers

2012-01-03 Thread Adam Jackson
On 1/3/12 2:18 PM, Julien Cristau wrote: On Tue, Jan 3, 2012 at 16:22:24 +1000, Peter Hutterer wrote: From: Adam Jacksona...@redhat.com Always install XAA SDK headers so drivers still build even with --disable-xaa Signed-off-by: Peter Huttererpeter.hutte...@who-t.net ---

Re: [xproto: PATCH] Xmd.h: amd64-x32 ABI defines sizeof(long) == sizeof (void*) == 4

2012-01-03 Thread Adam Jackson
On 12/28/11 3:29 PM, Lu, Hongjiu wrote: __LP64__ isn't the part of x86-64 psABI while GCC always define __LP64__ for 64bit long on x86. I can check if other compilers do the same. In most cases, __amd64__ is checked for 64bit instructions and we have ported those we have found so far to x32 so

[PATCH] vgahw: Fix DACDelay() macro to use the driver's vtable

2012-01-04 Thread Adam Jackson
We don't want to unconditionally use I/O routines here, since if the driver is using mmap'd VGA ports then the I/O handle won't be set up. Tested-by: Jeff Chua jeff.chua.li...@gmail.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/vgahw/vgaHW.h |8 1 files changed, 4

Re: [Intel-gfx] linux intel and xorg status on i915GM hardware

2012-01-06 Thread Adam Jackson
On 1/6/12 2:45 AM, Knut Petersen wrote: 1: Xorg.0.log is full of (besides timestamp) identical EDID entries: == [ 2502.358] (II) intel(0): EDID vendor ENC, prod id 5769 [ 2502.358] (II) intel(0): Using EDID range info for horizontal sync [

[PATCH] miext/damage: Only wrap into the GC ops chain if there's a listener (v2.1)

2012-01-06 Thread Adam Jackson
include the above change. Reviewed-by: Eric Anholt e...@anholt.net Signed-off-by: Adam Jackson a...@redhat.com --- miext/damage/damage.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/miext/damage/damage.c b/miext/damage/damage.c index d791211..37599dd 100644

[PATCH] miext/damage: Only wrap into the GC ops chain if there's a listener (v2)

2012-01-06 Thread Adam Jackson
-by: Eric Anholt e...@anholt.net Signed-off-by: Adam Jackson a...@redhat.com --- miext/damage/damage.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/miext/damage/damage.c b/miext/damage/damage.c index d791211..dd4026b 100644 --- a/miext/damage/damage.c +++ b/miext/damage

Re: [PATCH] shape: Report empty region correctly

2012-01-06 Thread Adam Jackson
the problem XShapeGetRectangles has to check if there is no rectangles in region and return sane values instead of no rectangles. Reviewed-by: Adam Jackson a...@redhat.com I've merged this into my 1.12 queue, which I'll be sending a pull request for shortly. - ajax

Re: [PATCH] linux: Use K_OFF VT KB mode over K_RAW if available.

2012-01-06 Thread Adam Jackson
Reviewed-by: Adam Jackson a...@redhat.com Merged in my 1.12 tree. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 1/2] dix: Return BadWindow rather than BadMatch from dixLookupWindow

2012-01-06 Thread Adam Jackson
On 1/4/12 8:22 PM, Christopher James Halse Rogers wrote: dixLookupWindow uses dixLookupDrawable internally, which returns BadMatch when the XID matches a non-Window drawable. Users of dixLookupWindow don't care about this, just that it's not a valid Window. This is a generalised version of the

Re: [PATCH] mi/mibitblt: Fix an overflow bug of bit shift.

2012-01-06 Thread Adam Jackson
the corresponding failures. Signed-off-by: Zhigang Gongzhigang.g...@linux.intel.com Reviewed-by: Adam Jackson a...@redhat.com Merged in my 1.12 tree. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: [PATCH] Add OpenBSD support to DetermineClientCmd()

2012-01-06 Thread Adam Jackson
On 1/2/12 8:23 AM, Matthieu Herrb wrote: Uses kvm_getargv() from libkvm. Signed-off-by: Matthieu Herrbmatthieu.he...@laas.fr Reviewed-by: Adam Jackson a...@redhat.com Merged in my 1.12 tree. - ajax ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH v2] UnloadSubModule(): accept pointer value '1' and ignore it.

2012-01-06 Thread Adam Jackson
On 1/2/12 8:11 AM, Matthieu Herrb wrote: Some driver modules try to unload submodules that are now built-in. Signed-off-by: Matthieu Herrbmatthieu.he...@laas.fr Reviewed-by: Julien Cristaujcris...@debian.org Reviewed-by: Adam Jackson a...@redhat.com Merged in my 1.12 tree. - ajax

Re: [PATCH] miext/damage: Only wrap into the GC ops chain if there's a listener (v2.1)

2012-01-09 Thread Adam Jackson
On Mon, 2012-01-09 at 10:21 -0800, Aaron Plattner wrote: I think these need to be pDrawable-serialNumber = NEXT_SERIAL_NUMBER. Otherwise, creating two pixmaps, validating a GC for the second one, creating a damage object on the first, and then trying to use the second GC on the first

Re: [PULL] 1.12 fix queue

2012-01-09 Thread Adam Jackson
On 1/9/12 5:42 PM, Keith Packard wrote: On Mon, 9 Jan 2012 14:07:27 -0800, Aaron Plattneraplatt...@nvidia.com wrote: Keith, this merge includes some major ABI breakers (e.g. changes to ClientRec). Whatever happened to the ABI is frozen at RC1 policy? Ajax? Was this sequence intended for

Re: [PATCH xquartz 1/2] os: Build Fix for io.c's redefinition of

2012-01-10 Thread Adam Jackson
On 1/10/12 3:55 AM, Jeremy Huddleston wrote: Regression from: 48e7a2ef574c8b38c4f8f07b45f54c8bfd02552b Found-by: Tinderbox CC: Daniel Stonedan...@fooishbar.org CC: Adam Jacksona...@redhat.com Signed-off-by: Jeremy Huddlestonjerem...@apple.com This patch (and the next one) are correct as far

Re: [PATCH 5/7] os: Hide the Connection{In, Out}put implementation details

2012-01-12 Thread Adam Jackson
On Thu, 2012-01-12 at 13:12 +1000, Peter Hutterer wrote: This one introduces a regression for me. Firefox hangs if tabs are opened or closed, and Thunderbird tends to lock up the whole shell. Doesn't always happen immediately, but usually within 3 tabs being opened/closed. The server

[PATCH] int10: Fix unmapping of the BIOS scratch area

2012-01-24 Thread Adam Jackson
342f3eac8460fc48cfad1f1d7be939d671e6e1cd introduced a bug, 'base' is incremented before use. The old code corrected this when unmapping, so the new code should too. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/int10/helper_exec.c |2 +- 1 files changed, 1 insertions(+), 1

Re: Slow XQueryPointer?

2012-01-26 Thread Adam Jackson
On Thu, 2012-01-26 at 17:51 +0200, Lauri Kasanen wrote: For this particular call, my app called XQueryPointer at 1327592221.398620 and reported the call took 12177 usec. The relevant portion of the strace is attached. I'm not fully confident in my ability to grok strace, but to me it looks

Re: Slow XQueryPointer?

2012-01-26 Thread Adam Jackson
On Thu, 2012-01-26 at 11:58 -0500, Adam Jackson wrote: I think a more complete solution would involve changing the main loop's logic slightly: if we get to the end of requests for a single client within a single timeslice, start pulling requests from any other clients that have pending

Re: Slow XQueryPointer?

2012-01-26 Thread Adam Jackson
On Thu, 2012-01-26 at 19:34 +0200, Lauri Kasanen wrote: Hi ajax Thanks for taking the time to look into this. Trying -schedInterval 5 had slight improvement - the skips weren't as high, the highest was 7ms. But the skips still happen about just as often. That's about what I'd expect.

Re: Slow XQueryPointer?

2012-01-27 Thread Adam Jackson
On 1/27/12 10:55 AM, Matt Turner wrote: On Fri, Jan 27, 2012 at 5:32 AM, Lauri Kasanenc...@gmx.com wrote: You don't have to convert the entire app to XCB to be able to use it for just one or two calls, for example, most of xdpyinfo uses libX11 calls still, but the loop to list extensions uses

[PATCH] randr: Fix up yet another corner case in preferred mode selection

2012-02-22 Thread Adam Jackson
of either the physical aspect ratio or 4:3. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/modes/xf86Crtc.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c index da9db34..a9265cf 100644 --- a/hw

Re: libpciaccess-0.13

2012-02-24 Thread Adam Jackson
On Fri, 2012-02-24 at 13:52 -0800, Jeremy Huddleston wrote: Alan's commit to libpciaccess reminded me that we should tag and release 0.13 soon so a stable version is available to coincide with the stable 1.12.0 server release. Does anyone have anything pending in libpciaccess? If not, I'll

Re: libpciaccess-0.13

2012-02-27 Thread Adam Jackson
On Fri, 2012-02-24 at 14:17 -0800, Jeremy Huddleston wrote: I puked in my mouth, but: Reviewed-by: Jeremy Huddleston jerem...@apple.com Yeah, it felt pretty awful to have to write. Pushed (without the O_CLOEXEC fix, which wants further generalization), thanks. - ajax signature.asc

[PATCH] Use O_CLOEXEC for internal file descriptors

2012-02-27 Thread Adam Jackson
Well, almost all of them. zlib doesn't support e in the mode string in gzopen() though it will silently accept and ignore it, and Solaris appears not to support e in the mode string at all. Signed-off-by: Adam Jackson a...@redhat.com --- src/common_device_name.c | 22

Re: [PATCH] Use O_CLOEXEC for internal file descriptors

2012-02-27 Thread Adam Jackson
On Mon, 2012-02-27 at 18:11 +0100, Mark Kettenis wrote: Neither does OpenBSD. And POSIX doesn't seem to mention it either. So this smells like a Linux-specific extension. Or perhaps more accurately, a glibc-specific extension. http://netbsd.gw.com/cgi-bin/man-cgi?fopen++NetBSD-current I

Re: [PATCH] Use O_CLOEXEC for internal file descriptors

2012-02-27 Thread Adam Jackson
On Mon, 2012-02-27 at 10:41 -0800, Alan Coopersmith wrote: On 02/27/12 08:35 AM, Adam Jackson wrote: +#if defined(linux) !defined(__GNU_SOURCE) +#define __GNU_SOURCE +#endif Wouldn't AC_USE_SYSTEM_EXTENSIONS in configure.ac cover this, as well as making it more likely to enable non

<    2   3   4   5   6   7   8   9   10   11   >