Re: [PATCH xserver 3/7] hw/xfree86: add suid wrapper to uninstall target

2017-04-03 Thread Emil Velikov
On 1 April 2017 at 07:52, Mihail Konev wrote: > Signed-off-by: Mihail Konev > --- > Not that this matters, but makes the distcheck not to fail. > > hw/xfree86/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/xfree86/Makefile.am

Re: [PATCH xserver 2/7] sdksyms: fix export word indexing

2017-04-03 Thread Emil Velikov
Hi Mihail, On 1 April 2017 at 07:52, Mihail Konev wrote: > Introduced-in: b1dac41fb3853ca8182048ea57b88b6e84ecceb3 > Releaved-in: 3dad57b121fdf001e75fffa7e3007a9a0a154f67 Neither of these tags is used xserver. Perhaps it's worth changing them to something more common? You also want

Re: [PATCH rendercheck v3 4/4] Explain how to build using meson in the README.

2017-03-31 Thread Emil Velikov
On 31 March 2017 at 15:47, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 31 March 2017 at 14:25, Eric Engestrom <eric.engest...@imgtec.com> wrote: >> On Wednesday, 2017-03-29 13:19:35 -0700, Eric Anholt wrote: >>> Signed-off-by: Eric Anholt <e...@an

Re: [PATCH rendercheck v3 4/4] Explain how to build using meson in the README.

2017-03-31 Thread Emil Velikov
On 31 March 2017 at 14:25, Eric Engestrom wrote: > On Wednesday, 2017-03-29 13:19:35 -0700, Eric Anholt wrote: >> Signed-off-by: Eric Anholt >> --- >> README | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/README b/README >> index

Re: [PATCH xserver] xf86: dri2: Use va_gl as vdpau_driver for Intel i965 GPUs

2017-03-24 Thread Emil Velikov
Hi Hans, On 23 March 2017 at 12:31, Hans de Goede wrote: > The modesetting driver (which now often is used with Intel GPUs), > relies on dri2_probe_driver_name() to get the dri and vdpau driver > names, before this commit it would always assign the same name to > the 2

Re: [PATCH xserver v2] edid: Prune duplicates after adding modes from DDC

2017-03-21 Thread Emil Velikov
Monitor->Modes list to keep growing larger and using up more memory. > > Fix this by calling xf86PruneDuplicateModes after adding the modes > returned by xf86DDCGetModes. This makes sure there's only one instance > of each unique mode in the list. > > v2: > * Replace semicolon wit

Re: [PATCH xserver] sdksyms: Tighten up the symbols we add to the magic table

2017-03-15 Thread Emil Velikov
On 13 March 2017 at 17:07, Adam Jackson <a...@nwnk.net> wrote: > On Fri, 2017-03-10 at 23:23 +0000, Emil Velikov wrote: >> > On 10 March 2017 at 16:32, Adam Jackson <a...@nwnk.net> wrote: >> > I neither expect nor want this to happen. dummy might have some minor &g

Re: [PATCH xserver] sdksyms: Tighten up the symbols we add to the magic table

2017-03-10 Thread Emil Velikov
On 10 March 2017 at 16:32, Adam Jackson wrote: > On Wed, 2017-03-08 at 17:44 +, Jon Turney wrote: >> On 06/03/2017 22:20, Adam Jackson wrote: >> > On Mon, 2017-03-06 at 18:23 +, Jon Turney wrote: >> > >> > > Unfortunately, one of the possible definitions of _X_EXPORT in >>

Re: [PATCH v2 util-modular] release.sh: create a worktree structure that's out of reach of libtool

2017-03-08 Thread Emil Velikov
e path to release/$section/, section is the only thing we have > available this early > Thanks for the update. For a second I was wondering about $version and remembers that we get it after make dist{,check}. Reviewed-by: Emil Velikov <emil.veli...@collabora.com> -Emil _

Re: [PATCH util-modular] release.sh: create a worktree structure that's out of reach of libtool

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 20:50, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Wed, Mar 08, 2017 at 02:18:23PM +0000, Emil Velikov wrote: >> On 8 March 2017 at 08:21, Peter Hutterer <peter.hutte...@who-t.net> wrote: >> > The comment in the diff says it all, we

Re: [PATCH app/xkbcomp] Add xkboutputdir to xkbcomp.pc

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 16:51, Adam Jackson <a...@redhat.com> wrote: > On Wed, 2017-03-08 at 13:45 +0000, Emil Velikov wrote: > >> > >> Right, so I was confused. The "compiled" xkb path and README.compiled >> are provided by Xorg, but what's not obvious

Re: [PATCH util-modular] release.sh: create a worktree structure that's out of reach of libtool

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 08:21, Peter Hutterer wrote: > The comment in the diff says it all, we need to put our worktree root at least > two directories away from our normal checkout. > > This fixes the issue of release.sh failing in git trees that haven't been git > cleaned:

Re: [PATCH xf86-video-dummy] Add glamor acceleration which enables native OpenGL support

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 01:04, Yu, Qiang wrote: > >> You want to AC_MSG_ERROR if the the option is set to "yes" and it's >> not available. Currently one silently ignores it, which is not good. > Right, so I need to make it "auto" by default? > If you change the current default to

Re: [PATCH app/xkbcomp] Add xkboutputdir to xkbcomp.pc

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 05:08, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Mar 07, 2017 at 09:31:54PM +0000, Emil Velikov wrote: >> HI Adam, >> >> On 7 March 2017 at 17:42, Adam Jackson <a...@redhat.com> wrote: >> > The X server (and everybod

Re: [PATCH xf86-video-dummy] Add glamor acceleration which enables native OpenGL support

2017-03-07 Thread Emil Velikov
On 7 March 2017 at 03:53, Qiang Yu wrote: > Enable glamor acceleration in xorg.conf by: > Section "Device" > ... > Driver "dummy" > Option "Render" "/dev/dri/renderD128" > ... > EndSection > > GPU is chosen by the Render option which specifies the render > node of the

Re: [PATCH app/xkbcomp] Add xkboutputdir to xkbcomp.pc

2017-03-07 Thread Emil Velikov
HI Adam, On 7 March 2017 at 17:42, Adam Jackson wrote: > The X server (and everybody else, really) wants to know where to put > xkbcomp's output, so xkbcomp.pc should say. This should be under > localstatedir, since the output is architecture-dependent (as the note > in

Re: [ANNOUNCE] xorg-server 1.19.2

2017-03-05 Thread Emil Velikov
On 3 March 2017 at 16:50, Adam Jackson wrote: > On Thu, 2017-03-02 at 18:13 -0500, Adam Jackson wrote: >> A collection of stability fixes here across glamor, Xwayland, input, >> and Prime support. Also a security fix for CVE-2017-2624, a timing >> attack which can brute-force

Re: [PATCH 1/3] Use timingsafe_memcmp() to compare MIT-MAGIC-COOKIES CVE-2017-2624

2017-03-01 Thread Emil Velikov
On 28 February 2017 at 22:52, Matthieu Herrb <matth...@herrb.eu> wrote: > > On Tue, Feb 28, 2017 at 10:41:29PM +, Emil Velikov wrote: >> Hi Matthieu, >> >> On 28 February 2017 at 18:18, Matthieu Herrb <matth...@herrb.eu> wrote: >> > Provide the fu

Re: [PATCH 1/3] Use timingsafe_memcmp() to compare MIT-MAGIC-COOKIES CVE-2017-2624

2017-02-28 Thread Emil Velikov
Hi Matthieu, On 28 February 2017 at 18:18, Matthieu Herrb wrote: > Provide the function definition for systems that don't have it. > > Signed-off-by: Matthieu Herrb > Reviewed-by: Alan Coopersmith > --- > configure.ac

Re: [PATCH util-modular 5/9] build.sh: add the remaining xorg lib(s)

2017-02-27 Thread Emil Velikov
On 27 February 2017 at 21:54, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Feb 27, 2017 at 12:09:38PM +0000, Emil Velikov wrote: >> On 27 February 2017 at 02:10, Peter Hutterer <peter.hutte...@who-t.net> >> wrote: >> > On Tue, Feb 14, 2017 at

Re: [PATCH util-modular 5/9] build.sh: add the remaining xorg lib(s)

2017-02-27 Thread Emil Velikov
On 27 February 2017 at 02:10, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Feb 14, 2017 at 10:11:09PM +0000, Emil Velikov wrote: >> Thanks for having a look Alan. >> >> On 14 February 2017 at 16:31, Alan Coopersmith >> <alan.coopersm...@oracle.co

Re: [PATCH util-modular] release.sh: Also update srv_path for older Mesa releases.

2017-02-27 Thread Emil Velikov
On 27 February 2017 at 01:50, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Feb 24, 2017 at 04:09:06PM +0000, Emil Velikov wrote: >> On 14 February 2017 at 11:39, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> > From: Emil Velikov <emil.veli...@c

Re: [PATCH util-modular] release.sh: Also update srv_path for older Mesa releases.

2017-02-24 Thread Emil Velikov
On 14 February 2017 at 11:39, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Otherwise we'll be missing the "$version" directory and the files > will be uploaded the the wrong location. > > Fixes: f1647

Re: [PATCH xserver] edid: Prune duplicates after adding modes from DDC

2017-02-24 Thread Emil Velikov
On 24 February 2017 at 01:08, Michel Dänzer <mic...@daenzer.net> wrote: > On 24/02/17 05:21 AM, Emil Velikov wrote: >> P.s. Sending from my phone - pardon the html formatting. > > It could have waited until you got access to a decent mailer? :) > Considering how badly

Re: [PATCH xserver] edid: Prune duplicates after adding modes from DDC

2017-02-23 Thread Emil Velikov
On Wednesday, 22 February 2017, Michel Dänzer wrote: > From: Michel Dänzer > > > Multiple calls to xf86EdidMonitorSet (which can be triggered e.g. by > running xrandr) would potentially keep adding the same modes, causing > the

Re: [PATCH util-modular 5/9] build.sh: add the remaining xorg lib(s)

2017-02-14 Thread Emil Velikov
Thanks for having a look Alan. On 14 February 2017 at 16:31, Alan Coopersmith wrote: > This one seems useful/important: >> +build lib libXpresent > > Are you using the github version for this since it moved off fd.o? >> +build lib libxkbcommon > > I don't

[PATCH util-modular 0/9] En route to testing $WORLD

2017-02-14 Thread Emil Velikov
(unmaintained/moved). It would be better to add a (file?) tag to annotate those, letting build.sh check it and act accordingly. Both of these are tasks for another day ;-) Thanks Emil Emil Velikov (9): build.sh: honour when NOAUTOGEN (-a) is set build.sh: mention when autogen/configure is omitted

[PATCH util-modular 9/9] build.sh: add the remaining xorg util(s)

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- build.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/build.sh b/build.sh index 2a46f35..06507e3 100755 --- a/build.sh +++ b/build.sh @@ -1405,6 +1405,9 @@ build

[PATCH util-modular 6/9] build.sh: add the remaining xorg driver(s)

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- build.sh | 44 1 file changed, 44 insertions(+) diff --git a/build.sh b/build.sh index 0af2fc0..437b15f 100755 --- a/build.sh ++

[PATCH util-modular 1/9] build.sh: honour when NOAUTOGEN (-a) is set

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Do what the help string says - do not run autogen/configure when set. If one is cloning a fresh repo, that is no reason to effectively ignore the user requirement. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- build.sh

[PATCH util-modular 3/9] build.sh: add NOMAKE configure option

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Used alongside with -a and --clone (optionally -p) one can fetch/sync the whole collection of projects w/o executing anything in those. One example usecase is to test any direct or indirect (for example xorg-macros) changes to release

[PATCH util-modular 7/9] build.sh: add the remaining xorg proto(s)

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- build.sh | 11 +++ 1 file changed, 11 insertions(+) diff --git a/build.sh b/build.sh index 437b15f..402b8d4 100755 --- a/build.sh +++ b/build.sh @@ -99

[PATCH util-modular 8/9] build.sh: add the remaining xorg font

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/build.sh b/build.sh index 402b8d4..2a46f35 100755 --- a/build.sh +++ b/build.sh @@ -1379,6 +1379,7 @@ build

[PATCH util-modular 5/9] build.sh: add the remaining xorg lib(s)

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- build.sh | 17 + 1 file changed, 17 insertions(+) diff --git a/build.sh b/build.sh index 7cd08c2..0af2fc0 100755 --- a/build.sh +++ b/build.sh @@ -107

[PATCH util-modular 4/9] build.sh: add the remaining xorg app(s)

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> With this and follow-up patches we'll add all the outstanding repos from xorg/ Ideally we'll get everything inside build.sh so that a simple script (like below) can easily flag differences. Obviously deprecated/obsolete projects won't be

[PATCH util-modular 2/9] build.sh: mention when autogen/configure is omitted

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- build.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/build.sh b/build.sh index 9ef6302..c83ff5e 100755 --- a/build.sh +++ b/build.sh @@ -680,6 +680,

[PATCH util-modular] x-driver-screen-scrn-conv.sh: add shebang

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- x-driver-screen-scrn-conv.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/x-driver-screen-scrn-conv.sh b/x-driver-screen-scrn-conv.sh index e41cf7a..f805424 100755 --

[PATCH util-modular] release.sh: Also update srv_path for older Mesa releases.

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Otherwise we'll be missing the "$version" directory and the files will be uploaded the the wrong location. Fixes: f16477858bc "release.sh: remove $MESA_VERSION from the destination location" Signed-off-by: Emil Velikov &

[PATCH util/macros 1/2] Rework CHANGELOG_CMD to touch/echo >&2 only as needed

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Currently CHANGELOG_CMD issues a touch ChangeLog; echo "Scary message" >&2 even if the file is already present. For example, when running `make distcheck' the following is observed: " /bin/sh: ../../.changelo

[PATCH util/macros 2/2] Rework INSTALL_CMD to touch/echo >&2 only as needed

2017-02-14 Thread Emil Velikov
From: Emil Velikov <emil.vel...@collabora.com> Analogous to previous commit. With this commit we no longer get the following erroneous messages during `make distcheck'. " failed to copy INSTALL from util-macros: installing possibly empty INSTALL. ... failed to copy INSTALL from

Re: [PATCH util/macros] Add new script xorg-prepare-git-repo.sh

2017-02-03 Thread Emil Velikov
On 2 February 2017 at 22:04, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Jan 31, 2017 at 10:24:55AM +0000, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> New script invoked by the project's autogen.sh to facilitate bas

Re: [PATCH util-modular] release.sh: run autogen.sh instead of manual autoreconf + configure

2017-02-01 Thread Emil Velikov
hy isn't xkeyboard-config under xorg/data or alike ? > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > --- > Sending this out so Sergey can use it now, I haven't tested this on all > repos yet. But I think w

[PATCH util/macros] Rework stderr messages for the _CMD macros

2017-01-31 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Redirect stderr from git, sh and cp to /dev/null to cut down the 'spam' and reword the error messages to be less misleading. Why ? Currently CHANGELOG_CMD can fail for any of the following reasons: - git executable is missing - .git is m

[PATCH util/macros] Add new script xorg-prepare-git-repo.sh

2017-01-31 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> New script invoked by the project's autogen.sh to facilitate basic git config setup and likely others in the future. Ensure that all of output is redirected to /dev/null and the script is bundled + installed. Cc: Peter Hutterer <peter.hut

Re: [PATCH util/macros 1/2] Create CHANGELOG/INSTALL_CMD .tmp files in builddir

2017-01-30 Thread Emil Velikov
Hi Gaetan, Thanks for the extensive answer. I hope with my replies below things should be much clearer. On 30 January 2017 at 15:18, Gaetan Nadon wrote: > I no longer have a development environment so I cannot try anything. > > Maybe I missed the core idea of the patches.

Re: [PATCH util/macros 1/2] Create CHANGELOG/INSTALL_CMD .tmp files in builddir

2017-01-30 Thread Emil Velikov
On 30 January 2017 at 00:28, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Jan 27, 2017 at 02:32:48PM +0000, Emil Velikov wrote: >> On 27 January 2017 at 04:53, Peter Hutterer <peter.hutte...@who-t.net> wrote: >> > On Thu, Jan 26, 2017 at 05:53:

Re: [PATCH util/macros 1/2] Create CHANGELOG/INSTALL_CMD .tmp files in builddir

2017-01-30 Thread Emil Velikov
[adding back the xorg-devel ML] On 28 January 2017 at 18:35, Gaetan Nadon <mems...@videotron.ca> wrote: > On 01/27/2017 09:32 AM, Emil Velikov wrote: > > aren't you still trying to create files in srcdir here? or is there > something outside the context that makes it

Re: [PATCH util/macros 2/2] autogen.sh: set sendemail.to as applicable

2017-01-27 Thread Emil Velikov
On 27 January 2017 at 04:50, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Thu, Jan 26, 2017 at 05:48:10PM +0000, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Similar to the patch subject prefix we might as well handle t

Re: [PATCH util/macros 1/2] Create CHANGELOG/INSTALL_CMD .tmp files in builddir

2017-01-27 Thread Emil Velikov
On 27 January 2017 at 04:53, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Thu, Jan 26, 2017 at 05:53:19PM +0000, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Under normal build rules one should consider srcdir as RO,

Re: [PATCH util-modular 4/4] release.sh: implement around git worktree

2017-01-26 Thread Emil Velikov
On 23 January 2017 at 12:51, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 23 January 2017 at 04:03, Peter Hutterer <peter.hutte...@who-t.net> wrote: >> On Fri, Jan 20, 2017 at 02:19:06PM +, Emil Velikov wrote: >>> On 20 January 2017 at 02:49, Peter Hutt

[PATCH util/macros 1/2] Create CHANGELOG/INSTALL_CMD .tmp files in builddir

2017-01-26 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Under normal build rules one should consider srcdir as RO, thus creating files in srcdir is going to fail. This was flagged with a recent work in release.sh Cc: Peter Hutterer <peter.hutte...@who-t.net> Cc: Gaetan Nadon <mems.

[PATCH util/macros 2/2] Use mv -f in the INSTALL_CMD rule

2017-01-26 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Otherwise we'll get a lovely warning about permissions mismatch. Not 100% sure if this is the correct thing, but everything seems to work as expected and the files in the generated tarball have the correct permissions. Cc: Peter Hu

[PATCH util/macros 1/2] autogen.sh: run git config in srcdir

2017-01-26 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Current code seems to work only for cases where builddir is a subdirectory of the src one. So if one has builddir in a separate folder (say in $srcdir/../) and the parent directory is a git repository we'll incorrectly set the git config.

[PATCH util/macros 2/2] autogen.sh: set sendemail.to as applicable

2017-01-26 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Similar to the patch subject prefix we might as well handle the sendemail setting. Cc: Peter Hutterer <peter.hutte...@who-t.net> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Here is another couple of patches

Re: [PATCH 0/3 all repositories] autogen.sh: sync with server

2017-01-24 Thread Emil Velikov
On 25 January 2017 at 02:26, Michel Dänzer wrote: > On 24/01/17 11:32 PM, Adam Jackson wrote: >> On Tue, 2017-01-24 at 10:40 +1000, Peter Hutterer wrote: >>> Heads up: I'll be pushing the following three patches into all xorg >>> repositories that need it in the next few days.

Re: [PATCH xserver 00/19] Module loader cleanup

2017-01-24 Thread Emil Velikov
On 23 January 2017 at 19:32, Adam Jackson wrote: > I'd like to move the module loader up to dix. In preparation for that, here's > a bunch of cleanup patches. The first three aren't mine, I just think they're > neat. > s/three/four/ and thank you. I'll try to re-spin my

Re: [PATCH xserver 11/19] xfree86: Remove DriverRec1 compat struct

2017-01-24 Thread Emil Velikov
(as mentioned in the original series) and noticed that some drivers do not use/set the HaveDriverFuncs flag. Although looking at it now, we should be safe. Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> -Emil ___ xorg-devel@lists.

Re: [PATCH xserver 10/19] loader: Remove silly "unspecified" version handling

2017-01-24 Thread Emil Velikov
LogMessageVerb(X_WARNING, 2, "%s: module major version (%d) " > + "doesn't match required major version (%d)\n", > + module, data->majorversion, req->majorversion); > +return

Re: [PATCH util-modular 4/4] release.sh: implement around git worktree

2017-01-23 Thread Emil Velikov
On 24 January 2017 at 01:14, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Jan 23, 2017 at 12:51:31PM +0000, Emil Velikov wrote: >> On 23 January 2017 at 04:03, Peter Hutterer <peter.hutte...@who-t.net> wrote: >> > On Fri, Jan 20, 2017 at 02:19:

Re: [PATCH v2 xserver 3/4] dri2: refine dri2_probe_driver_name (v2)

2017-01-23 Thread Emil Velikov
On 23 January 2017 at 06:30, Yu, Qiang wrote: > > Hi, > > If no further comments, can this patch be merged? > It's up-to our maintainers to pull the series. They might be a bit busy with other atm. -Emil ___ xorg-devel@lists.x.org:

Re: [PATCH 3/3 all repositories] autogen: Set a default subject prefix for patches

2017-01-23 Thread Emil Velikov
all with all the patches. From a quick skim things seem ok - don't see anything wrong and/or missing. Fwiw I'd go with that one. The rest of the series is (fwiw) Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Thanks ! Emil ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH util-modular v3] release.sh: remove $MESA_VERSION from the destination location

2017-01-23 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Requested by a number of distribution maintainers. Used starting with the 17.0 series. v2: Keep things conditional based on the version. v3: Also update srv_path, to create the correct path Signed-off-by: Emil Velikov <emil.veli...@coll

[PATCH util-modular] WIP: HACK: invoke configure from a subdir

2017-01-23 Thread Emil Velikov
--- Educated guess since I cannot reproduce it. If you're seing any of the install/changelog issues mentioned in my email, just drop the relevant lines from Makefile.am release.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/release.sh b/release.sh index

Re: [PATCH util-modular 4/4] release.sh: implement around git worktree

2017-01-23 Thread Emil Velikov
On 23 January 2017 at 04:03, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Jan 20, 2017 at 02:19:06PM +0000, Emil Velikov wrote: >> On 20 January 2017 at 02:49, Peter Hutterer <peter.hutte...@who-t.net> wrote: >> > On Thu, Jan 19, 2017 at 07:30:

Re: [PATCH libdrm v3 3/5] xf86drm: Add platform and host1x bus support

2017-01-22 Thread Emil Velikov
On 21 January 2017 at 11:07, walter harms wrote: +if (fetch_deviceinfo) { +ptr += sizeof(drmHost1xBusInfo); +dev->deviceinfo.host1x = (drmHost1xDeviceInfoPtr)ptr; + +ret = drmParseHost1xDeviceInfo(maj, min,

Re: [PATCH util-modular 4/4] release.sh: implement around git worktree

2017-01-20 Thread Emil Velikov
On 20 January 2017 at 02:49, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Thu, Jan 19, 2017 at 07:30:10PM +0000, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Months ago, before my work in here there the scri

[PATCH util-modular v2] release.sh: remove $MESA_VERSION from the destination location

2017-01-20 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Requested by a number of distribution maintainers. Used starting with the 17.0 series. v2: Keep things conditional based on the version. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- release.sh | 19 +++

Re: [PATCH libdrm v3 3/5] xf86drm: Add platform and host1x bus support

2017-01-20 Thread Emil Velikov
On 18 January 2017 at 09:02, Thierry Reding wrote: > From: Thierry Reding > > ARM SoCs usually have their DRM/KMS devices on the platform bus, so add > support for that to enable these devices to be used with the drmDevice > infrastructure. > >

[PATCH util-modular 4/4] release.sh: implement around git worktree

2017-01-19 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Months ago, before my work in here there the script had a number of assumptions: - autoreconf or alike is ran by the user - slight nuisance esp. when releasing multiple packages. - the generated files were compatible with the ones on the

[PATCH util-modular 2/4] release.sh: remove stray echo "$full_module_url"

2017-01-19 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Seemingly a debug leftover from commit cc5c629163c. Does not provide any value, afaict. Cc: Alan Coopersmith <alan.coopersm...@oracle.com> Cc: Gaetan Nadon <mems...@videotron.ca> Signed-off-by: Emil Velikov <emil.

[PATCH util-modular 3/4] release.sh: remove $MESA_VERSION from the destination location

2017-01-19 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Requested by a number of distribution maintainers. Used starting with the 17.0 series. To keep things sane one should revert this locally when doing the 13.0 or older series. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> -

[PATCH util-modular 1/4] release.sh: move remote name/branch parsing further up

2017-01-19 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Would be required with next commit as we'll be checking out (indirectly via git worktree) another branch. Regardless of that it makes sense that we parse the config before making any local changes. Signed-off-by: Emil Velikov <

Re: [PATCH util-modular] release.sh: print the builddir path with the announce email location

2017-01-17 Thread Emil Velikov
uded. Especially since we jump out of that directory on completion. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> I have a similar patch locally. Pardon for not sending it out. Reviewed-by: Emil Velikov <emil.veli...@collabora.com> -Emil _

Re: [PATCH libdrm v2 2/4] xf86drm: Add USB support

2017-01-16 Thread Emil Velikov
ng -EINVAL on non-Linux > platforms for usb and host1x should be fine. > Nicely spotted. Thierry with the above the series is Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Can you land these in the next few days - I would love to have a libdrm release and use drmGetDevice[s]2

Re: [PATCH xserver 03/10] tests: Convert test/xi2/ to single binary

2017-01-13 Thread Emil Velikov
Hi Mihail, On 30 December 2016 at 08:30, Mihail Konev wrote: > Instead of multiple test binaries, use a single one which executes > a test depending on the command-line argument being passed. > > For testsuite, emulate multiple binaries with shell scripts > that pass an appropriate

Re: [PATCH libpciaccess 1/2] linux sysfs: retrieve vendor, device... info via separate sysfs files

2017-01-11 Thread Emil Velikov
On 11 January 2017 at 15:59, Adam Jackson <a...@redhat.com> wrote: > On Wed, 2017-01-11 at 11:16 +0000, Emil Velikov wrote: >> Anyone ? > > Merged 1/2: > > remote: I: patch #125069 updated using rev > 73db249c4b1eb91e0df27a1045bea344371dd2ca. > remote: I: 1 pa

Re: [PATCH libpciaccess 1/2] linux sysfs: retrieve vendor, device... info via separate sysfs files

2017-01-11 Thread Emil Velikov
On 16 December 2016 at 19:10, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 1 December 2016 at 18:17, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Currently the kernel does not expose the revi

Re: [PATCH v2 xserver 3/4] dri2: refine dri2_probe_driver_name (v2)

2017-01-11 Thread Emil Velikov
driver_name(ScreenPtr pScreen, DRI2InfoPtr info) > { > -ScrnInfoPtr pScrn = xf86ScreenToScrn(pScreen); > -EntityInfoPtr pEnt = xf86GetEntityInfo(pScrn->entityList[0]); > -struct pci_device *pdev = NULL; > +#ifdef WITH_LIBDRM Nicely spotted ! I wonder if/how things were bui

Re: [PATCH xserver 3/4] dri2: refine dri2_probe_driver_name

2017-01-10 Thread Emil Velikov
Hi Yu, Qiang, Can I interest you in fixing your email client or using one that supports inline quoting ? On 10 January 2017 at 14:07, Yu, Qiang wrote: > > Hi Emil, > >> /* For non-PCI devices, just assume that the 3D driver is named >> * the same as the kernel

Re: [PATCH xserver 3/4] dri2: refine dri2_probe_driver_name

2017-01-10 Thread Emil Velikov
On 10 January 2017 at 10:51, Qiang Yu wrote: > Get PCI information from info->fd with drmGetDevice instead of > assuming the info->fd is the first entity of scrn which is not > true for multi entities scrn. > IIRC you want to bump the libdrm version in configure to one that

Re: [PATCH libpciaccess 1/2] linux sysfs: retrieve vendor, device... info via separate sysfs files

2016-12-16 Thread Emil Velikov
On 1 December 2016 at 18:17, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Currently the kernel does not expose the revision file. With that about > to change (due in 4.10) we can read all the information requir

Re: [PATCH xf86-video-dummy 2/6] Delete XV stuff

2016-12-16 Thread Emil Velikov
On 10 December 2016 at 02:35, Bob Terek wrote: > > On 01/24/2015 03:08 PM, Aaron Plattner wrote: >> >> As far as I can tell, this was never implemented or used. >> >> Signed-off-by: Aaron Plattner > > > Applied patch to current dummy driver, built,

Re: [PATCH xf86-video-dummy 0/4] Cleanups Redux

2016-12-16 Thread Emil Velikov
Hi Bob, On 9 December 2016 at 22:25, Bob Terek <x...@esoterek.com> wrote: > > On 12/09/2016 03:13 AM, Emil Velikov wrote: > >> On 6 December 2016 at 22:41, Bob Terek <x...@esoterek.com> wrote: >>> >>> Resubmitting some of Aaron Plattner's cleanup pat

Re: [edid-decode] [PATCH 2/2] Calculate DisplayID checksums. Refactor do_checksum.

2016-12-16 Thread Emil Velikov
Hi Mark, I haven't looked at the code in detail, I'm afraid. There's a general suggestion, which should be useful. As the commit summary indicates, this should be two separate patches. On 9 December 2016 at 17:39, Mark Ferry wrote: > --- > edid-decode.c | 40

Re: Xorg glx module: GLVND, EGL, or ... ?

2016-12-15 Thread Emil Velikov
On 15 December 2016 at 08:15, Michel Dänzer wrote: > > Hi Adam, Andy, Kyle, > > > even with GLVND in place and used by Mesa and other GL implementations, > one remaining issue preventing peaceful coexistence of Mesa based and > other GLX implementations is that other GLX

Re: [PATCH xserver 0/5] Remove (most) 24bpp support

2016-12-09 Thread Emil Velikov
On 8 December 2016 at 19:23, Mark Kettenis wrote: > The KMS drivers in question are unfortunately GPL'ed, which for some > non-Linux OSes is a bit of an issue. I've mentioned this on dri-devel@ so mostly repeating it here - consider reaching out to driver

Re: [PATCH xf86-video-dummy 0/4] Cleanups Redux

2016-12-09 Thread Emil Velikov
Hi Bob, On 6 December 2016 at 22:41, Bob Terek wrote: > Resubmitting some of Aaron Plattner's cleanup patches to xf86-video-dummy: > > https://lists.x.org/archives/xorg-devel/2015-January/045395.html > > This series contains Aaron's patches numbered 2 - 5, as patch 1 has

[PATCH libpciaccess 1/2] linux sysfs: retrieve vendor, device... info via separate sysfs files

2016-12-01 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Currently the kernel does not expose the revision file. With that about to change (due in 4.10) we can read all the information required from separate files and avoid opening the config one. The latter has the [negative] side effect of wak

[PATCH libpciaccess 2/2] Revert "linux_sysfs: include for PATH_MAX"

2016-12-01 Thread Emil Velikov
This reverts commit 8ea3af620a2d4ad5648917b4a0ef2b23ff566774. The include was added with 6bd2f7f92eae713663f4e13f6e2cb23526607b8c Cc: Adam Jackson --- src/linux_sysfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/linux_sysfs.c b/src/linux_sysfs.c index

Re: [PATCH util-modular 6/6] release.sh: run ./configure within the release.sh

2016-11-25 Thread Emil Velikov
On 25 November 2016 at 01:38, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Nov 11, 2016 at 03:45:29PM +0000, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> At the moment one has to run autogen.sh/configure in their chec

Re: [Mesa-dev] UDL & Modeset with Mesa 13.0.1 - Segmentation fault

2016-11-18 Thread Emil Velikov
On 17 November 2016 at 20:15, poma wrote: > > Airlie solved everything concerning the kernel, > so it seems, now it's user space turn. > > = mesa-libgbm-12.0.3 - works OK > ... > [ 714.429] (II) Loading sub module "glamoregl" > [ 714.429] (II) LoadModule:

Re: [PATCH util-modular 6/6] release.sh: run ./configure within the release.sh

2016-11-15 Thread Emil Velikov
On 14 November 2016 at 20:54, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Nov 14, 2016 at 03:39:18PM +0000, Emil Velikov wrote: >> On 13 November 2016 at 22:24, Peter Hutterer <peter.hutte...@who-t.net> >> wrote: >> > On Fri, Nov 11, 2016 at

Re: [PATCH util-modular 2/6] release.sh: add a couple more info messages

2016-11-15 Thread Emil Velikov
On 14 November 2016 at 20:55, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Nov 14, 2016 at 03:42:04PM +0000, Emil Velikov wrote: >> On 13 November 2016 at 22:11, Peter Hutterer <peter.hutte...@who-t.net> >> wrote: >> > On Fri, Nov 11, 2016 at

Re: [PATCH util-modular 2/6] release.sh: add a couple more info messages

2016-11-14 Thread Emil Velikov
On 13 November 2016 at 22:11, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Nov 11, 2016 at 03:45:25PM +0000, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> This way one can relate the exact stage they are and the possib

Re: [PATCH util-modular 6/6] release.sh: run ./configure within the release.sh

2016-11-14 Thread Emil Velikov
On 13 November 2016 at 22:24, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Nov 11, 2016 at 03:45:29PM +0000, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> At the moment one has to run autogen.sh/configure in their chec

[PATCH util-modular 1/6] release.sh: check for local changes while in the git root directory

2016-11-11 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Current approach relies that the builddir will be nested within the git root directory. While this is true [currently] it's not a wise thing to do. We want to check if there are any changes whist we're in the git (root) directory. Sign

[PATCH util-modular 6/6] release.sh: run ./configure within the release.sh

2016-11-11 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> At the moment one has to run autogen.sh/configure in their checkout prior to using release.sh We can "spare" that by folding it into the script. As a side effect this gives us a number of nice benefits: - We can check/error out if

[PATCH util-modular 0/6] Misc releas.sh polish and Mesa support

2016-11-11 Thread Emil Velikov
no longer needs to run ./configure before using release.sh. This simplifies the releasing workflow and allow us to catch issues, as mentioned in the patch. Please review and don't be shy ;-) Emil Emil Velikov (6): release.sh: check for local changes while in the git root directory release.sh

[PATCH util-modular 4/6] release.sh: add support for git worktree

2016-11-11 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> With git worktree(s) .git is a file rather than a directory. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- release.sh | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/release.sh b/release.sh i

[PATCH util-modular 3/6] release.sh: add --gpgkey option

2016-11-11 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> To allow users with multiple keys to select the appropriate one. v2: - Change GPGKEY to include -u if valid key is provided (Julien). - Keep the help screen sorted alphabetically. Signed-off-by: Emil Velikov <emil.veli...@coll

<    1   2   3   4   5   6   >