Re: [PATCH] mi: sprite: SaveUnderCursor2

Hi, On 3/9/21 5:34 PM, Madhurkiran Harikrishnan wrote: > From: Hyun Kwon > > There is cursor bleeding for the devices which try to acclerate the > Desktop environment using low powered ARM Mali GPUs. The area under > the cusrsor is not updated for every swap call within the armsoc, > resulting

Re: [PATCH] mi: sprite: SaveUnderCursor2

Hi, On 3/8/21 11:09 PM, Madhurkiran Harikrishnan wrote: > From: Hyun Kwon There should be a block of text here explaining what this new function does, why it is needed, etc. Please submit a new version with an actual commit message describing the what and why of this patch. Regards, Hans

Re: USB GPU bugs

Hi, On 11-10-2019 12:13, Pekka Paalanen wrote: On Thu, 10 Oct 2019 09:40:30 +0200 Hans de Goede wrote: Hi, On 09-10-2019 12:23, Pekka Paalanen wrote: On Wed, 9 Oct 2019 09:59:29 +0200 Hans de Goede wrote: I think I might also be seeing some variant of your "not enough hotplug e

Re: USB GPU bugs

Hi, On 09-10-2019 12:23, Pekka Paalanen wrote: On Wed, 9 Oct 2019 09:59:29 +0200 Hans de Goede wrote: I think I might also be seeing some variant of your "not enough hotplug events" bug. With the gm12u320 projector when hotplugged it is listed as "unknown" in gnom

Re: USB GPU bugs

Hi, On 09-10-2019 12:23, Pekka Paalanen wrote: On Wed, 9 Oct 2019 09:59:29 +0200 Hans de Goede wrote: Let's keep each other updated, so we don't do duplicate effort. :-) Ack I will drop you a mail when I find / make time to look into this. Regards, Hans

Re: USB GPU bugs

Hi Pekka, On 09-10-2019 09:47, Pekka Paalanen wrote: On Tue, 8 Oct 2019 22:19:45 +0200 Hans de Goede wrote: My main reason for suggesting either one is that I personally am aware of at least 2 issues (both related to secondary USB GPUs handling) which are only present in master

Re: xserver release process

Hi, On 08-10-2019 18:28, Adam Jackson wrote: In short, releases need to happen, and we have CI, so let's just pop a release out on scheduled dates assuming CI passes. Given that the Xorg xserver has a lot of hw interaction, we are never going to catch everything with CI, so this seems a

Xorg's software-cursor support + mutter results in a mess

Hi All, Note I've also filed an issue for tracking this: https://gitlab.freedesktop.org/xorg/xserver/issues/828 but this seems like something to discuss on the list. When Xorg fallsback to software cursor support, for example because of using a DisplayLink USB2 device (udl kernel driver) or

Re: xorg-server: logind support requires --enable-udev, however works without udev running, is udev really needed?

Hi, On 3/20/19 4:26 PM, Piotr Karbowski wrote: Hi, On 20/03/2019 12.32, Hans de Goede wrote: I'm surprised that this works at all, but regardless using the logind integration without the udev integration is definitely not something which we want to support, sorry. What do you mean

Re: xorg-server: logind support requires --enable-udev, however works without udev running, is udev really needed?

Hi, On 19-03-19 22:01, Piotr Karbowski wrote: Hi, Today I've been integrating a elogind, a drop-in replacement for systemd-logind and I came across a hard dependency of --enable-systemd-logind on --enable-config-udev. configure: error: systemd-logind is only supported in combination with udev

Re: [PATCH] XF86keysym: Add XF86XK_RotationLockToggle

Hi, On 22-01-19 09:22, Walter Harms wrote: Hans de Goede hat am 21. Januar 2019 um 20:23 geschrieben: Add XF86XK_RotationLockToggle keysym, to be used as mapping for evdev's KEY_ROTATE_LOCK_TOGGLE. I've a Point of View P1006W-232 Windows tablet which actually has a rotate-lock toggle

Re: [PATCH] XF86keysym: Add XF86XK_RotationLockToggle

Hi, On 22-01-19 03:47, Jian-Hong Pan wrote: Peter Hutterer 於 2019年1月22日 週二 上午9:03寫道： On Mon, Jan 21, 2019 at 08:23:08PM +0100, Hans de Goede wrote: Add XF86XK_RotationLockToggle keysym, to be used as mapping for evdev's KEY_ROTATE_LOCK_TOGGLE. I've a Point of View P1006W-232 Windows tablet

[PATCH] XF86keysym: Add XF86XK_RotationLockToggle

support for it through all the higher layers. Signed-off-by: Hans de Goede --- include/X11/XF86keysym.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/X11/XF86keysym.h b/include/X11/XF86keysym.h index 9ad8948..dd287e2 100644 --- a/include/X11/XF86keysym.h +++ b/include/X11/XF86keysym.h

Re: [PATCH xorgproto] XF86keysym: Add XF86XK_MonBrightnessCycle

ping. Any additional information for this patch is required? No extra info required. Just waiting for someone to get around to it. I needed to do some XF86keysym.h myself anyways, so I've taken a look and this looks good to me: Reviewed-by: Hans de Goede I've commit rights, so I've added

[PATCH xkeyboard-config 0/2] 2 evdev/inet mapping fixes

Hi All, I'm not sure what the prefered method of patch-review for xkeyboard-config is. I've submitted a merge-req for this here: https://gitlab.freedesktop.org/jwrdegoede/xkeyboard-config/merge_requests/1 I'm also sending these out by email in case no-one is looking at the merge-req. If I can

[PATCH xkeyboard-config 1/2] Add evdev mappings for KEY_SOUND

KEY_SOUND is used on actual devices and recent xproto versions defines the AudioPreset keysym for this key. Signed-off-by: Hans de Goede --- symbols/inet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/symbols/inet b/symbols/inet index bc4aaa3..5a8d180 100644 --- a/symbols

[PATCH xkeyboard-config 2/2] evdev/int: Fix KEY_KEYBOARD mapping

was used instead of the X scancode and then 8 was subtracted for the wrong "// #define KEY_KEYBOARD 366" comment. This commit corrects the comment to say 374 and corrects the X scancode being mapped to 382. Cc: Christian Kellner Signed-off-by: Hans de Goede --- keycodes

Re: Smooth gdm -> GNOME3 session transition broken with 1.20 modesetting driver

Hi, On 05-09-18 20:35, Daniel Stone wrote: Hi Hans, On Wed, 5 Sep 2018 at 19:23, Hans de Goede wrote: Under Fedora 29 (xserver-1.20) the transition from GDM to the GNOME3 session is no longer smooth, it seems that the screen is cleared to black when the Xserver starts instead of inheriting

Smooth gdm -> GNOME3 session transition broken with 1.20 modesetting driver

Hi All, Under Fedora 29 (xserver-1.20) the transition from GDM to the GNOME3 session is no longer smooth, it seems that the screen is cleared to black when the Xserver starts instead of inheriting the framebuffer contents from GDM as before. Changing the DDX driver from modesetting to intel

Re: Xorg-1.20.1 crashes when using glamor on top of llvmpipe

, Hans Ray On Thu, Aug 30, 2018, 5:00 PM Hans de Goede mailto:hdego...@redhat.com>> wrote: Hi, On 30-08-18 22:48, Hans de Goede wrote: > HI all, > > I've been debugging some strange crashes with Xorg-1.20.1 inside > a virtualbox guest and I

Re: Xorg-1.20.1 crashes when using glamor on top of llvmpipe

Hi, On 30-08-18 22:48, Hans de Goede wrote: HI all, I've been debugging some strange crashes with Xorg-1.20.1 inside a virtualbox guest and I can use some help with this. At first Xorg completely failed to start, running it under gdbserver showed a backtrace pointing to a lazy symbol lookup

Xorg-1.20.1 crashes when using glamor on top of llvmpipe

HI all, I've been debugging some strange crashes with Xorg-1.20.1 inside a virtualbox guest and I can use some help with this. At first Xorg completely failed to start, running it under gdbserver showed a backtrace pointing to a lazy symbol lookup failure triggered by: drmmode_display.c:905:

Re: [PATCH xserver] Xorg.wrap: Ensure correct ordering of post-install hook

.com> Looks good to me: Acked-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- hw/xfree86/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am index b876b79ab..458720052 100644 --- a/hw/xfree8

Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

Hi, On 09-11-17 02:34, Alex Goins wrote: Thanks both for the quick feedback. Replies inline. On Wed, 8 Nov 2017, Hans de Goede wrote: https://lists.x.org/archives/xorg-devel/2016-September/050973.html implies that xf86CursorScreenPtr is part of the ABI. Mark xf86CursorPriv.h as such. I'm

Re: [PATCH] modesetting: fail PreInit() if the device has zero connectors

Hi, On 03-11-17 17:56, Giuseppe Bilotta wrote: On Fri, Nov 3, 2017 at 10:09 AM, Hans de Goede <hdego...@redhat.com> wrote: Weird, on my XPS15 9550 where the nvidia GPU does not have/drives any outputs I do get 2 devices in xrandr --listproviders as expected. You may want to start with fi

Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

Hi, On 08-11-17 05:15, Alex Goins wrote: Change 7b634067 added HW cursor support for PRIME by removing the pixmap_dirty_list check from xf86CursorSetCursor() and making the requisite cursor functions set/check the cursor both on master and slave. However, before this change, drivers that did

Re: [PATCH xserver 2/3] ramdac: Add xf86CursorPriv.h to ABI

Hi, On 08-11-17 05:15, Alex Goins wrote: https://lists.x.org/archives/xorg-devel/2016-September/050973.html implies that xf86CursorScreenPtr is part of the ABI. Mark xf86CursorPriv.h as such. I'm not sure if exporting this is a good idea. I assume you are just after

Re: [PATCH xserver 1/3] ramdac: Fix formatting in xf86CheckHWCursor()

Hi, On 08-11-17 05:15, Alex Goins wrote: xf86CheckHWCursor() has spacing that is inconsistent with the rest of the file. Correct this in preparation for subsequent changes. Signed-off-by: Alex Goins <ago...@nvidia.com> LGTM: Acked-by: Hans de Goede <hdego...@redhat.com> Re

Re: [PATCH] modesetting: fail PreInit() if the device has zero connectors

works, it will also powerdown the GPU properly. Regards, Hans With best wishes, Tobias Hans de Goede wrote: Hi, On 20-10-17 19:08, tobias.jako...@uni-bielefeld.de wrote: On laptop systems with a dedicated (powerful) GPU A, you usually have all connectors routed to another (less-powerful) G

Re: [PATCH] modesetting: fail PreInit() if the device has zero connectors

Hi, On 20-10-17 19:08, tobias.jako...@uni-bielefeld.de wrote: On laptop systems with a dedicated (powerful) GPU A, you usually have all connectors routed to another (less-powerful) GPU B. With my setup (GPU A = Nvidia, GPU B = Intel) I keep GPU A switched off by not loading the nouveau kernel

Re: [PATCH xkeyboard-config] Add evdev mappings for KEY_SOUND, KEY_UWB, KEY_WWAN and KEY_RFKILL

Goede <hdego...@redhat.com <mailto:hdego...@redhat.com>> wrote: Hi, On 15-05-17 03:06, Peter Hutterer wrote: adding svu to CC: On Fri, May 12, 2017 at 04:18:42PM +0200, Hans de Goede wrote: KEY_SOUND, KEY_WWAN and KEY_RFKILL are used on ac

[PATCH v2 xkeyboard-config] Add evdev mappings for KEY_SOUND, KEY_UWB, KEY_WWAN and KEY_RFKILL

ink: https://bugs.freedesktop.org/show_bug.cgi?id=100970 Cc: Bastien Nocera <had...@hadess.net> Cc: Benjamin Berg <bb...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> --- Changes in v2: -Improve commit message --- keycode

Re: [PATCH xkeyboard-config] Add evdev mappings for KEY_SOUND, KEY_UWB, KEY_WWAN and KEY_RFKILL

Hi, On 15-05-17 03:06, Peter Hutterer wrote: adding svu to CC: On Fri, May 12, 2017 at 04:18:42PM +0200, Hans de Goede wrote: KEY_SOUND, KEY_WWAN and KEY_RFKILL are used on actual devices and current xproto master defines keysyms for these. Add mappings for these keys. The XF86UWB keysm

Re: [PATCH xkeyboard-config] Add evdev mappings for KEY_SOUND, KEY_UWB, KEY_WWAN and KEY_RFKILL

Hi, On 15-05-17 08:50, Bastien Nocera wrote: Hey, Comments inline. On Mon, 2017-05-15 at 08:36 +0200, Hans de Goede wrote: KEY_SOUND, KEY_WWAN and KEY_RFKILL are used on actual devices and current xproto master defines keysyms for these. Add mappings for these keys. The XF86UWB keysm exists

[PATCH xkeyboard-config] Add evdev mappings for KEY_SOUND, KEY_UWB, KEY_WWAN and KEY_RFKILL

c: Bastien Nocera <had...@hadess.net> Cc: Benjamin Berg <bb...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> --- keycodes/evdev | 2 ++ symbols/inet | 7 --- 2 files changed, 6 insertions(+), 3 deletions

[PATCH resend xkeyboard-config] Add evdev mappings for KEY_SOUND, KEY_UWB, KEY_WWAN and KEY_RFKILL

Hi, This is a resend with the Cc to Bastien fixed up at his request as he has some remarks. Regards, Hans ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

[PATCH xkeyboard-config] Add evdev mappings for KEY_SOUND, KEY_UWB, KEY_WWAN and KEY_RFKILL

c: Bastien Nocera <bnoc...@redhat.com> Cc: Benjamin Berg <bb...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- keycodes/evdev | 2 ++ symbols/inet | 7 --- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/keycodes/evdev b/keycodes/evdev i

Re: [PATCH xproto v2 1/2] Add XF86XK_WWAN and XF86XK_Rfkill

Hi, On 12-05-17 01:02, Peter Hutterer wrote: On Wed, May 10, 2017 at 05:53:53PM +0200, Hans de Goede wrote: Add Keysyms corresponding to the evdev WWAN and RFKILL keys, we already have Keysyms for WLAN and UWB from linux/input-event-codes.h: #define KEY_WLAN238 #define

[PATCH xproto v2 1/2] Add XF86XK_WWAN and XF86XK_Rfkill

gt; Cc: Benjamin Berg <bb...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Define XF86XK_WWAN instead of XF86XK_WiMAX, as KEY_WIMAX is an alias for KEY_WWAN, I intended to do this for v1 before submitting, but I forgot --- XF86keysym.h | 3 +++ 1 file cha

[PATCH xproto v2 2/2] Add XF86XK_AudioPreset

Add XF86XK_AudioPreset keysym, to be used as mapping for evdev's KEY_SOUND keycode which is generated on some devices by a button which on windows selects equalizer presets switching between settings such as e.g. theatre-mode / game-mode / voice-mode. Signed-off-by: Hans de Goede <hd

[PATCH xproto 2/2] Add XF86XK_AudioPreset

Add XF86XK_AudioPreset keysym, to be used as mapping for evdev's KEY_SOUND keycode which is generated on some devices by a button which on windows selects equalizer presets switching between settings such as e.g. theatre-mode / game-mode / voice-mode. Signed-off-by: Hans de Goede <hd

[PATCH xproto 1/2] Add XF86XK_WiMAX and XF86XK_Rfkill

gt; Cc: Benjamin Berg <bb...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- XF86keysym.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/XF86keysym.h b/XF86keysym.h index 89d40b8..809f386 100644 --- a/XF86keysym.h +++ b/XF86keysym.h @@ -199,6 +199,9 @@ #defi

Re: [xproto] Add XF86XK_Keyboard

Hi, On 19-04-17 15:26, Christian Kellner wrote: From: Christian Kellner The 2017 Thinkpad models have a new hotkey with a keyboard symbols on it, which is mapped to KEY_KEYBOARD in the kernel. Signed-off-by: Christian Kellner Since Peter said he

[PATCH xserver resend] xf86: dri2: Use va_gl as vdpau_driver for Intel i965 GPUs

and fixing it falls outside of the scope of this commit. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1413733 Cc: kwiz...@gmail.com Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/dri2/dri2.c | 31 +++-- hw/xfree86/dri2/p

[PATCH xserver] xf86: dri2: Use va_gl as vdpau_driver for Intel i965 GPUs

and fixing it falls outside of the scope of this commit. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1413733 Cc: kwiz...@gmail.com Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/dri2/dri2.c | 31 +++-- hw/xfree86/dri2/p

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

Hi, On 20-09-16 03:58, Michel Dänzer wrote: On 17/09/16 07:00 PM, Hans De Goede wrote: Commit b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma code") dropped the providing of a pScrn->ChangeGamma callback from the xf86RandR12 code. Leaving pScrn->ChangeGamma NU

Re: [PATCH xserver] modesetting: Honor xorg.conf for 16bpp

Hi, On 21-03-17 20:57, Adam Jackson wrote: The 32->24 support patch messed this up. Bugzilla: https://bugs.freedesktop.org/100246 Bugzilla: https://bugs.freedesktop.org/100295 Signed-off-by: Adam Jackson <a...@redhat.com> LGTM: Acked-by: Hans de Goede <hdego...@redhat.com>

[PATCH xdriinfo] Fix xdriinfo not working with glvnd

For glx calls to work on libglvnd as glx provider we must first call glXGetClientString. This also means that we can no longer take the shortcut to not open the Display when a driver name is past to options. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- xdriinfo.

Re: [PATCH 1/3] Use timingsafe_memcmp() to compare MIT-MAGIC-COOKIES CVE-2017-2624

Hi, On 28-02-17 23:52, Matthieu Herrb wrote: On Tue, Feb 28, 2017 at 10:41:29PM +, Emil Velikov wrote: Hi Matthieu, On 28 February 2017 at 18:18, Matthieu Herrb wrote: Provide the function definition for systems that don't have it. Signed-off-by: Matthieu Herrb

Re: [PATCH xserver 4/4] modesetting: cleanup pci device open

Hi, On 10-01-17 11:51, Qiang Yu wrote: Signed-off-by: Qiang Yu <qiang...@amd.com> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- hw/xfree86/drivers/modesetting/driver.c | 24 +++- hw/xfree86/drivers/modesett

Re: [PATCH xserver 2/4] randr: fix xserver crash when xrandr setprovideroutputsource

Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- randr/rrprovider.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/randr/rrprovider.c b/randr/rrprovider.c index f9df67e..e4bc2bf 100644 --- a/randr/rrprovider.c +++ b/randr/rrprovider.c @

Re: [PATCH xserver 1/4] xfree86: fix wrong usage of xf86optionListMerge

Hi, On 10-01-17 11:51, Qiang Yu wrote: Signed-off-by: Qiang Yu <qiang...@amd.com> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- hw/xfree86/common/xf86Option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [tigervnc-devel] PATCH: Add xorg-xserver 1.19 support to tigervnc

Hi, On 09-01-17 18:12, Alan Coopersmith wrote: On 01/ 9/17 07:57 AM, Hans de Goede wrote: close(2); +/* Avoid xserver >= 1.19's epoll-fd becoming fd 2 / stderr only to be + replaced by /dev/null by OsInit() because the pollfd is not + writable, breaking ospoll_w

Re: [tigervnc-devel] PATCH: Add xorg-xserver 1.19 support to tigervnc

the patch or v1.19 itself. https://bugzilla.redhat.com/show_bug.cgi?id=1408724 Urgh. I have no 1.19 system yet, so hopefully someone else can have a look. Attached is a patch fixing this :) Regards, Hans >From 372ff9d6754cd1b375836e5d4559061fb7be3496 Mon Sep 17 00:00:00 2001 From: Hans

Re: [tigervnc-devel] PATCH: Add xorg-xserver 1.19 support to tigervnc

Hi, On 09-01-17 10:00, Pierre Ossman wrote: On 05/01/17 17:44, ipilc...@redhat.com wrote: On Wednesday, October 5, 2016 at 4:13:48 AM UTC-5, Pierre Ossman wrote: Alright. I'll have a look at doing the finishing touches. Thanks for the patch. :) FYI, there seems to be an issue with either

Re: [PATCH v2 xserver 00/11] modesetting: MS_ALL_IN_ONE

Hi, On 08-01-17 15:04, Yu, Qiang wrote: Hi Hans, Thanks for your info, I give it a quick try: Section "OutputClass" Identifier "amd" MatchDriver "amdgpu" Driver "modesetting" Option "PrimaryGPU" "yes" EndSection Section "OutputClass" Identifier "intel" MatchDriver

Re: [PATCH v2 xserver 00/11] modesetting: MS_ALL_IN_ONE

Hi, On 07-01-17 09:01, Qiang Yu wrote: V2: add PATCH 11 to support GPUScreen capable of display This is for hybrid drm device use case that one drm device is only capable of display and the other is only capable of rendering. Usage: start xserver with MS_ALL_IN_ONE=1, and configure both the

[PATCH xserver] glamor: glamor_egl_get_display: Return NULL if eglGetPlatformDisplayEXT returns NULL

() sometimes. Cc: Adam Jackson <a...@redhat.com> Cc: Eric Anholt <e...@anholt.net> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- glamor/glamor_egl.c | 4 glamor/glamor_egl.h | 4 +--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/glamor/gla

Re: [PATCH xf86-input-libinput] Ignore LED updates for disabled devices

by then. In the legacy drivers this would've simply caused a write to an invalid fd (-1), not a crash. Here we need to be more careful. https://bugs.freedesktop.org/show_bug.cgi?id=98464 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch LGTM: Reviewed-by: Hans de Goede

Re: Xorg glx module: GLVND, EGL, or ... ?

Hi, On 15-12-16 17:08, Emil Velikov wrote: On 15 December 2016 at 08:15, Michel Dänzer wrote: Hi Adam, Andy, Kyle, even with GLVND in place and used by Mesa and other GL implementations, one remaining issue preventing peaceful coexistence of Mesa based and other GLX

Re: [qxl] Xspice: Replace malloc/strdup use with xnfalloc/xnfstrdup

on failure). Signed-off-by: Christophe Fergeau <cferg...@redhat.com> LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/spiceqxl_audio.c| 2 +- src/spiceqxl_main_loop.c| 4 ++-- src/spiceqxl_spice_server.c | 12 ++-- 3 files changed,

Re: [qxl] xspice: Adjust to X.org 1.19 changes

to that new API, which removes the need for RegisterBlockAndWakeupHandlers(). Thank you for doing this, one small comment inline, otherwise looks good: Reviewed-by: Hans de Goede <hdego...@redhat.com> (with the comment fixed). --- I've lightly (xeyes/rxvt) tested this on f25, and

[PATCH xserver 5/6] xfree86: Allow overriding primary GPU detection from an OutputClass section

e enumerated becomes the primary GPU. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/common/xf86platformBus.c | 19 +++ hw/xfree86/man/xorg.conf.man| 12 +++- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/comm

[PATCH xserver 6/6] xfree86: Add ModulePath support for OutputClass config Sections

h the glvnd work done recently, this allows the nouveau + mesa and nvidia-binary userspace stacks to co-exist on the same system without any ldconfig / xorg.conf tweaking and the xserver will automatically do the right thing depending on which kernel driver (nouveau or nvidia) is loaded. Signe

[PATCH xserver 3/6] xfree86: Add options support for OutputClass Options

Add support for setting options in OutputClass Sections and having these applied to any matching output devices. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/common/xf86Option.c | 5 - hw/xfree86/common/xf86platformBus.

[PATCH xserver 0/6] xfree86: Extend OutputClass config sections

Hi All, This patch series main goal (*) is to allow the nvidia binary driver to install a xorg.conf snippet with the following contents: Section "OutputClass" Identifier "nvidia" MatchDriver "nvidia-drm" Driver "nvidia" Option "AllowEmptyInitialConfiguration" Option

[PATCH xserver 4/6] xfree86: xf86platformProbe: split finding pci-info and setting primary GPU

This is a preparation patch for allowing an OutputClass section to override the default primary GPU device selection. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/common/xf86platformBus.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-)

[PATCH xserver 2/6] xfree86: Make OutputClassMatches take a xf86_platform_device

Make OutputClassMatches directly take a xf86_platform_device as argument, rather then an index into xf86_platform_devices. This makes things easier for callers which already have a xf86_platform_device pointer. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/

[PATCH xserver 1/6] xfree86: Free devlist returned by xf86MatchDevice

xf86MatchDevice returns a dynamically allocated list of GDevPtr-s, free this when we're done with it. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/common/xf86platformBus.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/xfree86/common/xf86platformBus.c

Re: [xserver PULL master] randr fixes + primary GPU fallback

Hi, On 06-12-16 19:06, Adam Jackson wrote: On Tue, 2016-12-06 at 15:22 +0100, Hans de Goede wrote: Hi, On Mon Dec 5 16:54:51 UTC 2016, Adam Jackson wrote: > Not a fan of the autobind patch in terms of upstreaming, I feel like we > really should be able to do better. We've had years

[PATCH xserver v3] autobind GPUs to the screen

org.conf snippet. Signed-off-by: Dave Airlie <airl...@gmail.com> [hdego...@redhat.com: Make configurable, fix with nvidia, submit upstream] Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Make the default enabled instead of installing a xorg.conf snippet which enable

Re: [xserver PULL master] randr fixes + primary GPU fallback

Hi, On Mon Dec 5 16:54:51 UTC 2016, Adam Jackson wrote: > Not a fan of the autobind patch in terms of upstreaming, I feel like we > really should be able to do better. We've had years to do better and carried this patch in both Fedora and RHEL for years and nothing better materialized, I think

[xserver PULL master] randr fixes + primary GPU fallback

:49 +0100) -------- Hans de Goede (5): randr: rrCheckPixmapBounding: Do not substract crtc non 0 x,y from screen size randr: rrCheckPixmapBounding: do not shrink the screen_pixmap xfree86: Remove redundant ServerIsNotSeat0 check from xf86CallDriverProbe

Re: [PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5

Hi, On 05-12-16 10:25, Michael Thayer wrote: Hello Hans, Polite ping on this one. I've already given this series my: Reviewed-by: Hans de Goede <hdego...@redhat.com> There is not much else I can do, from here on it is up to the xserver maintainers to pick up the series. Regards,

Re: [PATCH xf86-input-libinput] Fix default scroll button number

Hi, On 05-12-16 05:35, Peter Hutterer wrote: Was exposing the evdev code rather than the xorg code. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/xf86libinput.c | 1 + 1 fil

Re: [PATCH xf86-input-libinput 1/3] Add a comment regarding scroll dist default values

Hi, On 29-11-16 00:25, Peter Hutterer wrote: Changed this during development because I forgot that the value actually matters (for touchpads anyway). Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Series looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com&

Re: [PATCH xserver 1/2] randr: rrCheckPixmapBounding: Do not substract crtc non 0 x, y from screen size

Hi, On 22-11-16 20:41, Dave Airlie wrote: On 23 November 2016 at 00:28, Hans de Goede <hdego...@redhat.com> wrote: The purpose of rrCheckPixmapBounding is to make sure that the screen_pixmap is large enough for the slave-output which crtc is being configured. This should include c

Re: [PATCH xserver 2/2] randr: rrCheckPixmapBounding: do not shrink the screen_pixmap

Hi, On 22-11-16 15:28, Hans de Goede wrote: The purpose of rrCheckPixmapBounding is to make sure that the screen_pixmap is *large* enough for the slave-output which crtc is being configured. However until now rrCheckPixmapBounding would also shrink the screen_pixmap in certain scenarios

[PATCH xserver 1/2] randr: rrCheckPixmapBounding: Do not substract crtc non 0 x, y from screen size

n when determining the new screen_pixmap size. Cc: Nikhil Mahale <nmah...@nvidia.com> Cc: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- randr/rrcrtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/randr/rrcrtc.c b/rand

[PATCH xserver 2/2] randr: rrCheckPixmapBounding: do not shrink the screen_pixmap

map in the above example, which seems undesirable. Cc: Nikhil Mahale <nmah...@nvidia.com> Cc: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- randr/rrcrtc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/randr/rrcrtc.c b/randr/r

Re: [Spice-devel] [PATCH xf86-video-qxl] Adjust xspice_wakeup_handler() prototype for building xspice with server 1.19

Hi, On 18-11-16 14:04, Timo Aaltonen wrote: On 04.10.2016 14:41, Hans de Goede wrote: Hi, On 03-10-16 12:04, Christophe Fergeau wrote: On Thu, Sep 29, 2016 at 01:03:01PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/spiceqxl_main_loop

Re: [PATCH xf86-input-libinput] If the parent libinput_device is unavailable, create a new one

Hi, On 18-11-16 07:47, Peter Hutterer wrote: On Tue, Nov 15, 2016 at 10:35:31AM +0100, Hans de Goede wrote: Hi, On 15-11-16 05:37, Peter Hutterer wrote: The parent device ref's the libinput device during pre_init and unref's it during DEVICE_INIT, so the copy is lost. During DEVICE_ON

Re: [PATCH xf86-input-libinput] If the parent libinput_device is unavailable, create a new one

Hi, On 15-11-16 05:37, Peter Hutterer wrote: The parent device ref's the libinput device during pre_init and unref's it during DEVICE_INIT, so the copy is lost. During DEVICE_ON, the libinput device is re-added and ref'd, this one stays around now. But the takeaway is: unless the device is

Re: [PATCH xf86-input-libinput] Link the left-handed property between the tools

Hi, On 11-11-16 04:36, Peter Hutterer wrote: The property is tablet-wide, not just per tool. So when one tool is updated, run through all other devices that share the same underlying device. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> LGTM: Reviewed-by: Hans de Goede

Re: [PATCH xf86-input-libinput] Use __attribute__((cleanup)) for most of the xf86SetStrOption handling

Hi, On 11-11-16 02:08, Peter Hutterer wrote: Code was already clean, but this removes error path handling. Signed-off-by: Peter Hutterer --- Somewhat in two minds about it because it doesn't gain us that much in this codebase. I want to start using this more because

Re: [PATCH xserver] glamor: restore vfunc handlers on init failure

requirements, so that if any of the requirement is not met we don't leave the CloseScreen() and DestroyPixmap() from glamor handlers in place. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1390018 Signed-off-by: Olivier Fourdan <ofour...@redhat.com> Patch looks good to me: Reviewed-by: H

Re: [PATCH xserver] dix: Make sure client is not in output_pending chain after closed (RH 1382444)

to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- dix/dispatch.c | 2 +- include/dixstruct.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dix/dispatch.c b/dix/dispatch.c index e111377..3d0fe26 100644 --- a/dix/dispatch.c +++ b/di

Re: [ANNOUNCE] xorg-server 1.18.99.902

Hi, On 02-11-16 16:50, Keith Packard wrote: Michel Dänzer writes: Somebody still needs to come up with a fix for the FlushAllOutput crashes, right? That would sure be nice; can anyone reproduce them at all? Judging from the amount of people filing bugs in Fedora's

Re: [PATCH xserver] dix: Use 'output_pending_clear' instead of open-coding it in CloseDownClient

Hi, On 28-10-16 18:25, Keith Packard wrote: Signed-off-by: Keith Packard <kei...@keithp.com> Patch LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- dix/dispatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dix/dispatch.c b/di

Re: [PATCH xserver] os: Recompute whether any clients are ready after ProcessWorkQueue() (bug 98030)

-off-by: Keith Packard <kei...@keithp.com> Patch LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- os/WaitFor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/os/WaitFor.c b/os/WaitFor.c index 7d5aa32..ff1c85e 100644 --- a/os/WaitFo

Re: [xserver PULL for 1.19 ] Various small fixes for 1.19

Hi, On 26-10-16 12:26, Hans de Goede wrote: Hi Adam, Keith, Here is a pull-req with various small fixes (all with at least 1 Reviewed-by) which I've collected for merging into 1.19: I just realized I forgot to add this one: https://patchwork.freedesktop.org/patch/117894/ It would be good

[xserver PULL for 1.19 ] Various small fixes for 1.19

) Hans de Goede (1): xfree86: Xorg.wrap: Do not require root rights for cards with 0 outputs Michel Dänzer (1): DRI2: Sync radeonsi_pci_ids.h from Mesa Mihail Konev (2): xwin: make glx optional again modesetting: fix glamor ifdef

[PATCH xserver v2] inputthread: On Linux leave the main thread's name as-is

; Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2 (hdegoede): -Only leave the main thread as-is in Linux, naming it is not an issue on other platforms --- os/inputthread.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/os/inputthread.c b/os/inputthread.c index ddafa

Re: [PATCH] ramdac: Check sPriv != NULL in xf86CheckHWCursor()

eviewed-by: Andy Ritger <arit...@nvidia.com> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- hw/xfree86/ramdac/xf86HWCurs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/ramdac/xf86HWCurs.c b/hw/xfree

Re: [PATCH xserver] modesetting: unifdef MODESETTING_OUTPUT_SLAVE_SUPPORT

to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- hw/xfree86/drivers/modesetting/drmmode_display.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/xfree86/drivers/modesetting/drmmode_display.c index 61a0e27..6e

Re: [PATCH xserver] xwayland: Activate and enable touch devices

the device but not activate it. Make sure we do activate and enable touch devices just like we do for other input devices such as keyboard and pointer. Signed-off-by: Olivier Fourdan <ofour...@redhat.com> Patch LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans

Re: [PATCH evdev] Fix off-by-one error counting axes

Hi, On 21-10-16 01:55, Peter Hutterer wrote: We stopped counting one too early, but still initialized that axis later, leading to a bug macro to trigger. https://bugs.freedesktop.org/show_bug.cgi?id=97956 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> LGTM: Reviewed-by: H

Re: [PATCH xserver 3/3] ddx: add new call to purge input devices that weren't added

es_list.next == NULL && +new_input_devices_list.prev == NULL) +xorg_list_init(_input_devices_list); This bit is unnecessary, as you already initialize new_input_devices_list when you declare it at the top of the file. With these 3 lines dropped the entire series looks good to me and is: Revie

[PATCH xf86-video-amdgpu] amdgpu_probe: Do not close server managed drm fds

-by: Hans de Goede <hdego...@redhat.com> --- src/amdgpu_probe.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/amdgpu_probe.c b/src/amdgpu_probe.c index 213d245..5d17fe5 100644 --- a/src/amdgpu_probe.c +++ b/src/amdgpu_probe.c @@ -142,6 +142,15 @@ stat

[PATCH] xfree86: Xorg.wrap: Do not require root rights for cards with 0 outputs

and thus root) and kms capable cards. Some hybrid gfx laptops have 0 output connectors on one of their 2 GPUs, resulting in Xorg needlessly running as root. This commits removes the res.count_connectors > 0 check, fixing this. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfr

  1   2   3   4   5   6   7   8   9   >