Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Lionel Landwerlin
On 28/02/2020 13:46, Michel Dänzer wrote: On 2020-02-28 12:02 p.m., Erik Faye-Lund wrote: On Fri, 2020-02-28 at 10:43 +, Daniel Stone wrote: On Fri, 28 Feb 2020 at 10:06, Erik Faye-Lund wrote: On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote: Yeah, changes on vulkan drivers

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Lionel Landwerlin
On 28/02/2020 11:28, Erik Faye-Lund wrote: On Fri, 2020-02-28 at 13:37 +1000, Dave Airlie wrote: On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote: Hi all, You might have read the short take in the X.org board meeting minutes already, here's the long version. The good news: gitlab.fd.o has

Re: [PATCH xserver v3] xwayland: Remove xwl_present_window from privates on cleanup

2018-09-05 Thread Lionel Landwerlin
On 05/09/2018 11:44, Olivier Fourdan wrote: Hi, On Wed, Sep 5, 2018 at 12:05 PM Lionel Landwerlin wrote: On 05/09/2018 09:49, Olivier Fourdan wrote: [...] This is because `xwl_present_cleanup()` frees the memory but does not remove it from the window's privates, and `xwl_present_abort_vblank

Re: [PATCH xserver v3] xwayland: Remove xwl_present_window from privates on cleanup

2018-09-05 Thread Lionel Landwerlin
On 05/09/2018 09:49, Olivier Fourdan wrote: Xwayland's `xwl_destroy_window()` invokes `xwl_present_cleanup()` before the common `DestroyWindow()`. But then `DestroyWindow()` calls `present_destroy_window()` which will possibly end up in `xwl_present_abort_vblank()` which will try to access data

Re: [PATCH v2] present: fix freed pointer access

2018-09-04 Thread Lionel Landwerlin
Oh well... I'm sure you'll be able to fix it faster than me :) - Lionel On 04/09/2018 16:27, Roman Gilg wrote: Ok, I just got a failing assert in xwl_present_flips_stop with the patch when opening a context menu in Steam. Seems the xwl_present_flips_stop call is coming in too late now after

[PATCH] xwayland: fix access to invalid pointer

2018-08-28 Thread Lionel Landwerlin
CCA: xwl_read_events (xwayland.c:814) ==5331==by 0x2AC0D0: ospoll_wait (ospoll.c:651) ==5331==by 0x2A5322: WaitForSomething (WaitFor.c:208) Signed-off-by: Lionel Landwerlin --- hw/xwayland/xwayland-output.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/xwayl

[PATCH v2] present: fix freed pointer access

2018-08-26 Thread Lionel Landwerlin
==by 0x279945: dix_main (main.c:276) ==5331==by 0x633AB16: (below main) (libc-start.c:310) v2: Still notify aborted flips (Roman) Signed-off-by: Lionel Landwerlin Reviewed-by: Daniel Stone Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107314 --- present/present_wnmd.c | 3 ++- 1

Re: [PATCH] present: fix freed pointer access

2018-08-25 Thread Lionel Landwerlin
On 25/08/2018 17:50, Roman Gilg wrote: The Valgrind backtrace is very similar to the gdb backtraces in: https://bugs.freedesktop.org/show_bug.cgi?id=106620 The patch could be a fix for this bug as well, which would be awesome. Yeah, I believe that's the same bug. We should probably mark that

Re: [PATCH] present: fix freed pointer access

2018-08-24 Thread Lionel Landwerlin
I've noticed at least another bug report which seems to abort on corrupted memory. This could be the source of it (I'm still running the Xwayland that produced this backtrace... YOLO). - Lionel On 24/08/2018 22:27, Lionel Landwerlin wrote: When a vblank has been marked as aborted, it's going

[PATCH] present: fix freed pointer access

2018-08-24 Thread Lionel Landwerlin
==by 0x279945: dix_main (main.c:276) ==5331==by 0x633AB16: (below main) (libc-start.c:310) Signed-off-by: Lionel Landwerlin Reviewed-by: Daniel Stone Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107314 --- present/present_wnmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion