System hangs when using VirtualBox with VMgfx emulation and 3D pass-through

2018-11-14 Thread Michael Thayer
this. Regards Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deu

Re: [ANNOUNCE] xf86-video-vboxvideo 1.0.0

2017-12-01 Thread Michael Thayer
Sorry, now visible on pgp.mit.edu. Regards Michael 01.12.2017 04:22, Somchai Smythe wrote: > What public keyserver has the key for AA9B2D1A308B5859? > > > On 11/29/17, Michael Thayer <michael.tha...@oracle.com> wrote: >> The first release of vboxvideo in upstream X.Or

Re: [ANNOUNCE] xf86-video-vboxvideo 1.0.0

2017-12-01 Thread Michael Thayer
Hello Matt, 30.11.2017 00:53, Matt Turner wrote: > On Wed, Nov 29, 2017 at 1:08 AM, Michael Thayer > <michael.tha...@oracle.com> wrote: >> The first release of vboxvideo in upstream X.Org. Enjoy! > > Very glad to see this! Thank you. Obviously it is mainly for

[ANNOUNCE] xf86-video-vboxvideo 1.0.0

2017-11-29 Thread Michael Thayer
The first release of vboxvideo in upstream X.Org. Enjoy! Regards Michael -- Michael Thayer (2): Initial commit. vboxvideo 1.0.0 git tag: xf86-video-vboxvideo-1.0.0 https://xorg.freedesktop.org/archive/individual/driver/xf86-video-vboxvideo-1.0.0.tar.bz2 MD5

[ANNOUNCE] xf86-video-vboxvideo 1.0.0

2017-11-29 Thread Michael Thayer
The first release of vboxvideo in upstream X.Org. Enjoy! Regards Michael -- Michael Thayer (2): Initial commit. vboxvideo 1.0.0 git tag: xf86-video-vboxvideo-1.0.0 https://xorg.freedesktop.org/archive/individual/driver/xf86-video-vboxvideo-1.0.0.tar.bz2 MD5

Re: Xwayland fatal error when Wayland output disappears

2017-10-27 Thread Michael Thayer
Hello Pekka, On 27.10.2017 08:01, Pekka Paalanen wrote: On Thu, 26 Oct 2017 15:40:13 +0200 Michael Thayer <michael.tha...@oracle.com> wrote: [ Discussion of a global Wayland object disappearing triggering a fatal error in xwl_log_handler in Xwayland.] there is a known race around W

Re: Xwayland fatal error when Wayland output disappears

2017-10-26 Thread Michael Thayer
and gnome-shell) wl_registry_bind() occurs when actually binding to an interface, which in the case of wl_output occurs when adding a new output, not removing it. Cheers, Olivier On 26 October 2017 at 15:40, Michael Thayer <michael.tha...@oracle.com <mailto:michael.tha...@oracle.com&g

Xwayland fatal error when Wayland output disappears

2017-10-26 Thread Michael Thayer
ds Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschl

Re: [PATCH 2/2 v2] Add keyboard shortcuts inhibitor

2017-03-31 Thread Michael Thayer
ard + focus or when the user restores the keyboard shortcuts using any + mechanism offered by the compositor. + + + + + + + + + ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archi

Re: [xserver PULL master] modesetting HW cursor patches

2017-02-09 Thread Michael Thayer
Thanks Adam! Regards Michael 08.02.2017 18:05, Adam Jackson wrote: On Thu, 2017-02-02 at 11:43 +0100, Michael Thayer wrote: Respectful but rather frustrated ping. Is it still worth my trying to get these changes in or should I just give up? Sorry for the delay. The cursor code

Re: [xserver PULL master] modesetting HW cursor patches

2017-02-02 Thread Michael Thayer
Respectful but rather frustrated ping. Is it still worth my trying to get these changes in or should I just give up? Regards Michael 27.01.2017 17:51, Michael Thayer wrote: Hello Adam and Keith, These patches have been hanging around for a while (since October in fact), and never made

Re: [xserver PULL master] modesetting HW cursor patches

2017-01-28 Thread Michael Thayer
Hello Adam and Keith, For some reason you got left off CC on that message. No idea why, you are still there in the copy in my "sent" folder... Regards Michael 27.01.2017 17:51, Michael Thayer wrote: Hello Adam and Keith, These patches have been hanging around for a while (sin

[xserver PULL master] modesetting HW cursor patches

2017-01-27 Thread Michael Thayer
The following changes since commit 7617a0a180a2cd3427a8ffa9534152df6a8fecbf: dri2: refine dri2_probe_driver_name (v2) (2017-01-25 15:13:33 -0500) are available in the git repository at: https://github.com/michael-thayer/xserver.git for you to fetch changes up

Re: [PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5

2016-12-05 Thread Michael Thayer
Hello Hans, Polite ping on this one. Regards and thanks Michael 01.10.2016 12:01, Hans de Goede wrote: Hi, On 30-09-16 17:55, Michael Thayer wrote: Based on v4 by Alexandre Courbot <acour...@nvidia.com> There is currently no reliable way to report failure to set a HW cursor.

Re: [PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5

2016-10-05 Thread Michael Thayer
Hello Adam, On 05.10.2016 21:33, Adam Jackson wrote: On Fri, 2016-09-30 at 17:55 +0200, Michael Thayer wrote: v5: Updated the patch to apply to current git HEAD, split up into two patches (server and modesetting driver) and adjusted the code slightly to match surrounding code. I also

[PATCH xserver 3/3] modesetting: allow switching from software to hardware cursors (v5).

2016-09-30 Thread Michael Thayer
to load_cursor_argb_check * keep the permanent software cursor fall-back if -ENXIO is returned * move parts of v3 into separate patches Signed-off-by: Michael Thayer <michael.tha...@oracle.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 30 ++-- hw/xfree86/drivers/modes

[PATCH xserver 2/3] modesetting: Immediately handle failure to set HW cursor, v5

2016-09-30 Thread Michael Thayer
c21ea1. - Adjusted code slightly to match surrounding code. - Effectively reverted af916477 which is made unnecessary by this patch. Signed-off-by: Michael Thayer <michael.tha...@oracle.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 15 +-- hw/xfree86/drivers

[PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5

2016-09-30 Thread Michael Thayer
to two patches (server and modesetting driver) and adjusted the code slightly to match surrounding code. I also removed the new exported function ShowCursorCheck(), as instead just changing ShowCursor() to return Bool should not affect its current callers. Signed-off-by: Michael Thayer <mi

Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

2016-09-30 Thread Michael Thayer
Hello Hans, On 29.09.2016 09:56, Hans de Goede wrote: Hi, On 28-09-16 16:54, Michael Thayer wrote: Hello Hans, On 28.09.2016 15:37, Hans de Goede wrote: Hi Michael, On 28-09-16 14:47, Michael Thayer wrote: [...] On 09/16/2016 06:52 PM, Michael Thayer wrote: When the X server asks us

Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

2016-09-28 Thread Michael Thayer
Hello Hans, On 28.09.2016 15:37, Hans de Goede wrote: Hi Michael, On 28-09-16 14:47, Michael Thayer wrote: [...] On 09/16/2016 06:52 PM, Michael Thayer wrote: When the X server asks us to load a hardware cursor, that request is always followed up by a request to show it if we report success

Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

2016-09-28 Thread Michael Thayer
Hello, On 28.09.2016 09:58, Hans de Goede wrote: Hi, On 28-09-16 05:05, Michel Dänzer wrote: [...] On 09/16/2016 06:52 PM, Michael Thayer wrote: When the X server asks us to load a hardware cursor, that request is always followed up by a request to show it if we report success, or to hide

Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

2016-09-27 Thread Michael Thayer
Hello, On 27.09.2016 12:06, Hans de Goede wrote: Hi, On 23-09-16 10:20, Hans de Goede wrote: Hi All, On 09/16/2016 06:52 PM, Michael Thayer wrote: When the X server asks us to load a hardware cursor, that request is always followed up by a request to show it if we report success, or to hide

Re: [PATCH xserver] modesetting: Do not call drmModeSetCursor2() twice on every cursor change

2016-09-23 Thread Michael Thayer
did not make it to my mailbox. Looks good to me, but if you like I can apply it when I have time and check in gdb that it does what it says on the box. Otherwise, Reviewed-by: Michael Thayer <michael.tha...@oracle.com> Regards, Michael --- hw/xfree86/drivers/modesetting/drmmode_displa

Re: modesetting: allow switching from software to hardware cursors (v4)

2016-09-22 Thread Michael Thayer
On 16.09.2016 17:49, Michael Thayer wrote: Split this up into the three following patches as suggested by Hans. Many thanks for your patience! Polite ping. Regards, Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt OR

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors (v4).

2016-09-16 Thread Michael Thayer
On 16.09.2016 17:52, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to only permanently switch to a software cursor if -ENXIO is returned (which means hardware cursors not supported

[PATCH xserver] modesetting: allow switching from software to hardware cursors (v4).

2016-09-16 Thread Michael Thayer
to load_cursor_argb_check * keep the permanent software cursor fall-back if -ENXIO is returned * move parts of v3 into separate patches Signed-off-by: Michael Thayer <michael.tha...@oracle.com> --- Tested switching from a hardware to a software cursor and back. hw/xfree86/drivers/modesetting/drmmode_display.

[PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

2016-09-16 Thread Michael Thayer
When the X server asks us to load a hardware cursor, that request is always followed up by a request to show it if we report success, or to hide it if we report failure. Therefore it makes no sense to suppress the request if the cursor is not currently visible. Signed-off-by: Michael Thayer

[PATCH xserver] modesetting: only fall back to drmModeSetCursor() on -EINVAL

2016-09-16 Thread Michael Thayer
to drmModeSetCursor2() will always return -EINVAL. Specifically, a return value of -ENXIO usually means that neither are supported. Signed-off-by: Michael Thayer <michael.tha...@oracle.com> --- 1) Tested that hardware cursors still work with the patch applied. 2) Tested in gdb that the expected path is

modesetting: allow switching from software to hardware cursors (v4)

2016-09-16 Thread Michael Thayer
Split this up into the three following patches as suggested by Hans. Many thanks for your patience! Regards, Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstra

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors (v3).

2016-09-15 Thread Michael Thayer
Hello, On 15.09.2016 19:18, Hans de Goede wrote: Hi, On 15-09-16 16:40, Michael Thayer wrote: Hello Hans, On 15.09.2016 16:12, Hans de Goede wrote: Hi, On 15-09-16 12:04, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors (v3).

2016-09-15 Thread Michael Thayer
Hello Hans, On 15.09.2016 16:12, Hans de Goede wrote: Hi, On 15-09-16 12:04, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to try a hardware cursor first every time a new one is set

[PATCH xserver] modesetting: allow switching from software to hardware cursors (v3).

2016-09-15 Thread Michael Thayer
by calls to show_cursor unless the load fails (when a call to hide_cursor should follow) Signed-off-by: Michael Thayer <michael.tha...@oracle.com> --- I hope that you are happy with the change I made to remove the set_cursor1 fall-back (it does rather simplify the code!); if not I will s

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors.

2016-09-15 Thread Michael Thayer
On 14.09.2016 12:07, Hans de Goede wrote: Hi, On 13-09-16 17:42, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to try a hardware cursor first every time a new one is set

Re: [PATCH xserver] modesetting: allow switching from software to hardware cursors.

2016-09-14 Thread Michael Thayer
On 14.09.2016 12:07, Hans de Goede wrote: Hi, On 13-09-16 17:42, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to try a hardware cursor first every time a new one is set

[PATCH xserver] modesetting: allow switching from software to hardware cursors.

2016-09-13 Thread Michael Thayer
not, or virtual hardware may be able to handle hardware cursors at some times and not others. Signed-off-by: Michael Thayer <michael.tha...@oracle.com> --- Checked the current git source and this change is still needed. This is an updated patch which takes into account changes in the driver source

Re: [PATCH xserver] modesetting: resubmit dirty rects on EINVAL (v2)

2016-07-19 Thread Michael Thayer
) Signed-off-by: Adam Jackson <a...@redhat.com> Reviewed-by: Michael Thayer <michael.tha...@oracle.com> Went ahead and merged this: remote: I: patch #99393 updated using rev 4b311d23e84356bd0e9e736aeed7448dd6382118. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.

Re: [PATCH xserver] modesetting: resubmit dirty rects on EINVAL

2016-07-16 Thread Michael Thayer
x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung

Re: [PATCH xserver] modesetting: resubmit dirty rects on EINVAL

2016-07-16 Thread Michael Thayer
Reviewed-by: Michael Thayer <michael.tha...@oracle.com> And successfully tested by one user who experienced buggy behaviour without the patch. On 15.07.2016 17:28, Adam Jackson wrote: This error code can mean we're submitting more rects at once than the driver can handle. If that h

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-16 Thread Michael Thayer
On 15.07.2016 17:33, Adam Jackson wrote: On Tue, 2016-07-12 at 15:56 +0200, Michael Thayer wrote: I know it has just been two days, but still, a polite ping. I would also generally be interested in the question of what I can do to get this sort of patch moving. Would reviewing other people's

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-12 Thread Michael Thayer
On 10.07.2016 12:23, Michael Thayer wrote: Hello Adam, On 05.07.2016 20:40, Adam Jackson wrote: On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote: When submitting dirty rectangles to the kernel driver, modesetting checks the return value, and if it gets ENOSYS (driver does not support

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-10 Thread Michael Thayer
Hello Adam, On 05.07.2016 20:40, Adam Jackson wrote: On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote: When submitting dirty rectangles to the kernel driver, modesetting checks the return value, and if it gets ENOSYS (driver does not support reporting) or EINVAL (invalid data submitted

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-05 Thread Michael Thayer
On 05.07.2016 22:15, Michael Thayer wrote: On 05.07.2016 20:40, Adam Jackson wrote: On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote: When submitting dirty rectangles to the kernel driver, modesetting checks the return value, and if it gets ENOSYS (driver does not support reporting

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-05 Thread Michael Thayer
On 05.07.2016 20:40, Adam Jackson wrote: On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote: When submitting dirty rectangles to the kernel driver, modesetting checks the return value, and if it gets ENOSYS (driver does not support reporting) or EINVAL (invalid data submitted to the kernel

[PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-04 Thread Michael Thayer
been seen to trigger in practice when the X server submits more rectangles at once to the VirtualBox kernel driver than the kernel will accept. I would expect this too affect most or all other drivers for virtual graphics devices and some others. Signed-off-by: Michael Thayer <michael.

Re: Disabling kernel dirty updates, not required.

2016-06-27 Thread Michael Thayer
elieve this is an Xorg problem and have analysed it on that ticket. Regards, Michael <1> https://www.virtualbox.org/ticket/15511 -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltun

Modesetting patch still awaiting review

2016-04-06 Thread Michael Thayer
to handle some cursors in hardware and others not, or virtual hardware may be able to handle hardware cursors at some times and not others. Thanks and regards, Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutsch

Re: [PATCH xserver v2] xfree86: Immediately handle failure to set HW cursor

2016-04-05 Thread Michael Thayer
On 04.04.2016 22:09, Michael Thayer wrote: Hello, Please excuse the top posting. Tested this in a dual-head non-mirrored virtual machine and hit the following problem: xf86CursorSetCursor() in hw/xfree86/ramdac/xf86Cursor.c calls xf86SetCursor() which fails because the cursor is not visible

Re: [PATCH xserver v2] xfree86: Immediately handle failure to set HW cursor

2016-04-04 Thread Michael Thayer
CursorPtr pCurs, int x, int y) (*infoPtr->SetCursorPosition) (infoPtr->pScrn, x, y); -(*infoPtr->ShowCursor) (infoPtr->pScrn); -return TRUE; +return xf86ShowCursor(infoPtr); + } void @@ -184,7 +194,7 @@ xf86SetTransparentCursor(ScreenPtr pScreen) xf86D

Re: Modesetting driver and cursor hot-spot

2016-04-03 Thread Michael Thayer
On 01.04.2016 22:22, Michael Thayer wrote: On 01.04.2016 22:12, Michael Thayer wrote: I have just been adjusting the cursor handling code in the VirtualBox kernel driver and realised that the modesetting user space driver is still adjusting the reported cursor position to take the hot-spot

Re: Modesetting driver and cursor hot-spot

2016-04-01 Thread Michael Thayer
On 01.04.2016 22:12, Michael Thayer wrote: I have just been adjusting the cursor handling code in the VirtualBox kernel driver and realised that the modesetting user space driver is still adjusting the reported cursor position to take the hot-spot into account, even though it also reports

Modesetting driver and cursor hot-spot

2016-04-01 Thread Michael Thayer
-spot information in modesetting. Does anyone have a good idea about how to deal with this? My best so far is for my driver to intercept DRM_IOCTL_MODE_CURSOR2 and just -EINVAL it to force fall-back. Regards, Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co

Re: [PATCH xserver] xfree86/modes: Make sure the HW cursor is hidden when it should be

2016-03-24 Thread Michael Thayer
scrn->ModeSet(scrn); + +/* Make sure the HW cursor is hidden if it's supposed to be, in case + * it was hidden while the CRTC was disabled + */ +if (!xf86_config->cursor_on) +xf86_hide_cursors(scrn); } else { crtc->x = saved

Re: [PATCH xserver] xfree86: Immediately handle failure to set HW cursor

2016-03-23 Thread Michael Thayer
0644 --- a/hw/xfree86/ramdac/xf86HWCurs.c +++ b/hw/xfree86/ramdac/xf86HWCurs.c @@ -161,8 +161,7 @@ xf86SetCursor(ScreenPtr pScreen, CursorPtr pCurs, int x, int y) (*infoPtr->SetCursorPosition) (infoPtr->pScrn, x, y); -(*infoPtr->ShowCursor) (infoPtr->pScrn); -return TRUE

Re: [PATCH xserver] Switch to SW cursor right after HW cursor failure

2016-03-19 Thread Michael Thayer
Hello Alex, On 18.03.2016 10:42, Alexandre Courbot wrote: Hello Michael, On 03/18/2016 06:09 PM, Michael Thayer wrote: In that context, see this patch to Modesetting which I send a couple of weeks ago, which should incidentally also fix your issue: https://patchwork.freedesktop.org/patch

Re: [PATCH xserver] Switch to SW cursor right after HW cursor failure

2016-03-19 Thread Michael Thayer
ere, the cursor will +* remain invisible until the next call to this function, which +* may not happen before a while */ +if (!(infoPtr->MaxWidth == 0 || infoPtr->MaxHeight == 0)) +return; } } -- Michael Thayer

Re: [PATCH] modesetting: allow switching from software to hardware cursors.

2016-03-12 Thread Michael Thayer
. We sort-of tried this in Weston for something else (we rendered certain windows in overlays) and had to turn it off and go to always SW because of the obnoxious flickering, at least until atomic landed. On Sat, Mar 12, 2016 at 3:54 AM, Michael Thayer <michael.tha...@oracle.com> wrote: Hel

Re: [PATCH] modesetting: allow switching from software to hardware cursors.

2016-03-12 Thread Michael Thayer
might have twenty minutes to review it? Regards, Michael On 06.03.2016 12:56, Michael Thayer wrote: Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to try a hardware cursor first every time a new one is set

Re: Re-send: [PATCH] modesetting: allow switching from software to hardware cursors.

2016-03-10 Thread Michael Thayer
message source- (or any other MUA for that matter) that can break the patch formatting and confuse git. Indeed, I sent the original with g-s-e and the re-send with Thunderbird. Thanks again. Regards, Michael HTH, Cheers, Olivier -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co

Re-send: [PATCH] modesetting: allow switching from software to hardware cursors.

2016-03-09 Thread Michael Thayer
not, or virtual hardware may be able to handle hardware cursors at some times and not others. Signed-off-by: Michael Thayer <michael.tha...@oracle.com> --- Re-sending as this did not seem to get noticed much the first time. hw/xfree86/drivers/modesetting/drmmode_display.c | 47 ++

[PATCH] modesetting: allow switching from software to hardware cursors.

2016-03-06 Thread Michael Thayer
not, or virtual hardware may be able to handle hardware cursors at some times and not others. Signed-off-by: Michael Thayer <michael.tha...@oracle.com> --- Made the commit message more verbose on Emil's request. hw/xfree86/drivers/modesetting/drmmode_display.c | 47 ++-- 1 file chang

Re: Modesetting can't switch back from a software to a hardware cursor (patch to follow)

2016-03-06 Thread Michael Thayer
On 05.03.2016 09:42, Michael Thayer wrote: [...] On 05.03.2016 00:19, Emil Velikov wrote: -EINVAL is interpreted by most/all of us as not supported (too old of a kernel). Although another thing was at the back of my mind - why are you removing the use_set_cursor2 static boolean. In all fairness

Re: Modesetting can't switch back from a software to a hardware cursor (patch to follow)

2016-03-05 Thread Michael Thayer
Hello Emil, On 05.03.2016 00:19, Emil Velikov wrote: On 4 March 2016 at 19:02, Michael Thayer <michael.tha...@oracle.com> wrote: [...] On 04.03.2016 19:52, Emil Velikov wrote: [...] On 4 March 2016 at 14:26, Michael Thayer <michael.tha...@oracle.com> wrote: On 02.03.2016 18

Re: Modesetting can't switch back from a software to a hardware cursor (patch to follow)

2016-03-04 Thread Michael Thayer
Hello Emil, On 04.03.2016 19:52, Emil Velikov wrote: Hi Michael, On 4 March 2016 at 14:26, Michael Thayer <michael.tha...@oracle.com> wrote: On 02.03.2016 18:43, Michael Thayer wrote: At present if modesetting ever fails to set a hardware cursor it switches back to a software one and

Re: Modesetting can't switch back from a software to a hardware cursor (patch to follow)

2016-03-04 Thread Michael Thayer
On 02.03.2016 18:43, Michael Thayer wrote: At present if modesetting ever fails to set a hardware cursor it switches back to a software one and stays that way until it is unloaded. The following patch should fix that. I say "should" because I had difficulties testing it - the cur

[PATCH] modesetting: allow switching from software to hardware cursors.

2016-03-02 Thread Michael Thayer
Currently if modesetting ever fails to set a hardware cursor it will switch to using a software cursor and never go back. Change this to try a hardware cursor first every time a new one is set. Signed-off-by: Michael Thayer <michael.tha...@oracle.com> --- hw/xfree86/drivers/modes

Modesetting can't switch back from a software to a hardware cursor (patch to follow)

2016-03-02 Thread Michael Thayer
th in case some one else immediately has an idea. Note that I did my testing against Ubuntu's 1.17.2 server. Regards, Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Ries

Re: Unplugging the main graphics device

2016-02-23 Thread Michael Thayer
On 22.02.2016 21:29, Dave Airlie wrote: On 22 February 2016 at 22:20, Michael Thayer <michael.tha...@oracle.com> wrote: On 19.02.2016 16:16, Michael Thayer wrote: I have been experimenting a bit with plugging and unplugging of graphics devices (using a dummy KMS driver which is udl st

Re: Unplugging the main graphics device

2016-02-22 Thread Michael Thayer
On 19.02.2016 16:16, Michael Thayer wrote: I have been experimenting a bit with plugging and unplugging of graphics devices (using a dummy KMS driver which is udl stripped of the actual hardware poking) and how the X server copes with that. It seems to cope well with a secondary device being

Unplugging the main graphics device

2016-02-19 Thread Michael Thayer
write to the list before that in case anyone else has thoughts, ideas or fixes (potenially including how I could better handle the driver update). Regards, Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland

Re: [PATCH] shadowfb: Fix initialization

2014-05-21 Thread Michael Thayer
On 21/05/14 15:23, Adam Jackson wrote: This has to run at initial CreateWindow time, at CreateScreenResources the root window doesn't actually exist yet. Tested-by: Michael Thayer michael.tha...@oracle.com Signed-off-by: Adam Jackson a...@redhat.com I'm not an expert in that area of the code

Re: [PATCH] Add a return value to set_cursor_position() to allow it to report failure

2014-05-05 Thread Michael Thayer
On 30/04/14 19:23, Keith Packard wrote: Michael Thayer michael.tha...@oracle.com writes: On 22/04/14 07:00, Keith Packard wrote: Michael Thayer michael.tha...@oracle.com writes: set_cursor_position() may need to be able to fail and have the server fall back to a software cursor in at least

[PATCH] Bump ABI_VIDEODRV_VERSION for commit 4c39326

2014-04-28 Thread Michael Thayer
ABI version 18 introduces load_cursor_image_check, load_cursor_argb_check, LoadCursorImageCheck and LoadCursorARGBCheck. Signed-off-by: Michael Thayer michael.tha...@oracle.com --- hw/xfree86/common/xf86Module.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86

Re: [PATCH] hw/xfree86: Restore API compatibility for cursor loading functions

2014-04-28 Thread Michael Thayer
-- ORACLE Deutschland B.V. Co. KG Michael Thayer Werkstrasse 24 VirtualBox engineering 71384 Weinstadt, Germany mailto:michael.tha...@oracle.com Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz

Re: [PATCH] hw/xfree86: Restore API compatibility for cursor loading functions

2014-04-25 Thread Michael Thayer
-ShowCursor) (infoPtr-pScrn); } -- ORACLE Deutschland B.V. Co. KG Michael Thayer Werkstrasse 24 VirtualBox engineering 71384 Weinstadt, Germany mailto:michael.tha...@oracle.com Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München

Re: how to turn source code into debian compatible driver

2014-04-24 Thread Michael Thayer
/+archive/ppa/+index?batch=75memo=75start=75 Regards, Michael -- ORACLE Deutschland B.V. Co. KG Michael Thayer Werkstrasse 24 VirtualBox engineering 71384 Weinstadt, Germany mailto:michael.tha...@oracle.com Hauptverwaltung: Riesstr. 25, D-80992 München

[PATCH xf86-input-mouse] Make absolute input reporting in Solaris aware of resolution changes

2014-04-24 Thread Michael Thayer
Currently on Solaris absolute input reporting only takes resolution changes into account when the video driver is using the pre-RandR 1.2 APIs, and there it uses the physical resolution, not the virtual. This patch fixes those two things. Signed-off-by: Michael Thayer michael.tha...@oracle.com

[PATCH] Add a return value to set_cursor_position() to allow it to report failure

2014-04-24 Thread Michael Thayer
driver build breaks as the return type change will only trigger warnings otherwise. Signed-off-by: Michael Thayer michael.tha...@oracle.com --- hw/xfree86/common/xf86Module.h | 2 +- hw/xfree86/modes/xf86Crtc.h| 4 ++-- hw/xfree86/modes/xf86Cursors.c | 18 -- hw

[PATCH] Fix commit 901fbfb by renaming load_cursor_argb() etc to force build breaks

2014-04-23 Thread Michael Thayer
Commit 901fbfb changed the return value of load_cursor_argb() and other APIs which caused silent breakage of drivers. Rename the changed APIs to make the breakage visible. The ABI version was already bumped with the original commit. Signed-off-by: Michael Thayer michael.tha...@oracle.com

Re: [PATCH xf86-input-mouse] Make absolute input reporting in Solaris aware of resolution changes

2014-04-23 Thread Michael Thayer
getting the latest versions of everything building in my Solaris VM, though I thought I had submitted my forward-port to master. I will check that tomorrow and re-submit. Regards, Michael On 04/10/14 11:21 AM, Michael Thayer wrote: Currently on Solaris absolute input reporting only takes

Adding a return value to set_cursor_position() to allow it to report failure

2014-04-10 Thread Michael Thayer
to load_cursor_argb() makes the UseHWCursor*() call-backs irrelevant and that I should perhaps submit a patch to remove them. And on similar lines, is xf86ForceHWCursor() still useful? The only user seems to be the R128 DRI1 code. Regards, Michael -- ORACLE Deutschland B.V. Co. KG Michael Thayer

[PATCH] Add a return value to set_cursor_position() to allow it to report failure

2014-04-10 Thread Michael Thayer
set_cursor_position() may need to be able to fail and have the server fall back to a software cursor in at least the situation in which we are running on virtual hardware and using the host cursor as a hardware cursor for the guest but cannot change its position. Signed-off-by: Michael Thayer

Re: [PATCH xf86-input-mouse] Do not drop the result of protocol detection

2014-04-10 Thread Michael Thayer
No response on this yet. Who would be the right person for looking at patches to xf86-input-mouse? I do realise that it is no longer as widely used as it once was... Regards, Michael On 31/03/14 11:21, Michael Thayer wrote: In MousePickProtocol() with protocol PROT_AUTO we probe

[PATCH xf86-input-mouse] Make absolute input reporting in Solaris aware of resolution changes

2014-04-10 Thread Michael Thayer
Currently on Solaris absolute input reporting only takes resolution changes into account when the video driver is using the pre-RandR 1.2 APIs, and there it uses the physical resolution, not the virtual. This patch fixes those two things. Signed-off-by: Michael Thayer michael.tha...@oracle.com

Re: [PATCH] Add a return value to load_cursor_argb() to allow it to report failure

2014-04-04 Thread Michael Thayer
) Virtual hardware may not wish to pass through a cursor to the host at a particular time but may wish to accept the same cursor at another time. This patch adds a return value to the API and makes the server do the software fall-back on failure. Signed-off-by: Michael Thayer michael.tha...@oracle.com I

Re: [PATCH] Add a return value to load_cursor_argb() to allow it to report failure

2014-04-04 Thread Michael Thayer
On 04/04/14 20:46, Jasper St. Pierre wrote: For qemu, this is handled at the kernel modesetting level with QXL. See drmModeSetCursor2. On Fri, Apr 4, 2014 at 3:30 AM, Michael Thayer michael.tha...@oracle.com mailto:michael.tha...@oracle.com wrote: And my question about whether a similar patch

Re: Re-send of patches

2014-04-02 Thread Michael Thayer
Hello, On 31/03/14 11:16, Michael Thayer wrote: I currently have three patches in the air waiting for review and hopefully integration. It would be great if someone found time to go over them. Trying again here. I was hoping to get these into 1.16, but I am getting more and more doubtful

[PATCH] Set a flag property on the root window to say if the X server VT is active

2014-03-31 Thread Michael Thayer
An X11 client may need to know whether the X server virtual terminal is currently the active one. This change adds a root window property which provides that information. Intended interface user: the VirtualBox Guest Additions. Signed-off-by: Michael Thayer michael.tha...@oracle.com

[PATCH xf86-input-mouse] Do not drop the result of protocol detection

2014-03-31 Thread Michael Thayer
and OS- specific detection, but that only the first case was implemented at the time. Now that only the second is needed dropping the result to keep the protocol as PROT_AUTO is presumably no longer useful and seems to actively breaking things. Signed-off-by: Michael Thayer michael.tha...@oracle.com

[PATCH] Add a return value to load_cursor_argb() to allow it to report failure

2014-03-31 Thread Michael Thayer
to the host at a particular time but may wish to accept the same cursor at another time. This patch adds a return value to the API and makes the server do the software fall-back on failure. Signed-off-by: Michael Thayer michael.tha...@oracle.com --- I would also be interested in having

[PATCH] Set a flag property on the root window to say if the X server VT is active

2014-03-25 Thread Michael Thayer
An X11 client may need to know whether the X server virtual terminal is currently the active one. This change adds a root window property which provides that information. Intended interface user: the VirtualBox Guest Additions. Signed-off-by: Michael Thayer michael.tha...@oracle.com

Re: Switching between a software and a hardware mouse cursor

2014-03-25 Thread Michael Thayer
On 18/03/14 11:17, Michael Thayer wrote: On 05/03/14 19:45, Adam Jackson wrote: On Thu, 2014-02-27 at 15:46 +0100, Michael Thayer wrote: Another would be to add a return value to the DDX CRTC functions load_cursor_argb, so that if the KMS driver failed to set the cursor, modesetting could

[PATCH xf86-input-mouse] do not drop the result of protocol detection

2014-03-24 Thread Michael Thayer
and OS- specific detection, but that only the first case was implemented at the time. Now that only the second is needed dropping the result to keep the protocol as PROT_AUTO is presumably no longer useful and seems to actively breaking things. Signed-off-by: Michael Thayer michael.tha...@oracle.com

Re: Switching between a software and a hardware mouse cursor

2014-03-18 Thread Michael Thayer
On 05/03/14 19:45, Adam Jackson wrote: On Thu, 2014-02-27 at 15:46 +0100, Michael Thayer wrote: Another would be to add a return value to the DDX CRTC functions load_cursor_argb, so that if the KMS driver failed to set the cursor, modesetting could pass this on to the X server. Actually we

Re: Detecting whether the X server VT is the active one

2014-03-17 Thread Michael Thayer
On 05/03/14 19:50, Adam Jackson wrote: On Thu, 2014-02-27 at 16:01 +0100, Michael Thayer wrote: Another problem that I am running into is that the X11 client part of our Guest Additions needs to know whether or not the X server VT is currently the active one, for example so that it can disable

[PATCH] Set a flag property on the root window when the server VT is not active as some clients need to know this.

2014-03-17 Thread Michael Thayer
Signed-off-by: Michael Thayer michael.tha...@oracle.com --- hw/xfree86/common/xf86Events.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/xfree86/common/xf86Events.c b/hw/xfree86/common/xf86Events.c index 06af739..a1b43bb 100644 --- a/hw/xfree86

Switching between a software and a hardware mouse cursor

2014-02-27 Thread Michael Thayer
. Neither of these feel quite satisfactory of course; any better suggestions are welcome. Thanks in advance. Regards, Michael -- ORACLE Deutschland B.V. Co. KG Michael Thayer Werkstrasse 24 VirtualBox engineering 71384 Weinstadt, Germany mailto:michael.tha

Detecting whether the X server VT is the active one

2014-02-27 Thread Michael Thayer
. Regards, Michael -- ORACLE Deutschland B.V. Co. KG Michael Thayer Werkstrasse 24 VirtualBox engineering 71384 Weinstadt, Germany mailto:michael.tha...@oracle.com Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603

Re: [PATCH 2/4] xserver: limit the kernel subsystems we look for devices in

2011-08-03 Thread Michael Thayer
On Wed, 2011-08-03 at 09:00 +1000, Peter Hutterer wrote: On Mon, Aug 01, 2011 at 11:18:48PM +0200, Michael Thayer wrote: On Thu, 2011-07-21 at 09:40 +1000, Peter Hutterer wrote: On Wed, Jul 20, 2011 at 05:52:16AM -0700, Dan Nicholson wrote: On Mon, Jul 18, 2011 at 12:17 PM, Lennart

Re: [PATCH 2/4] xserver: limit the kernel subsystems we look for devices in

2011-08-01 Thread Michael Thayer
could add the misc subsystem for the sake of the VirtualBox mouse integration. Regards, Michael -- ORACLE Deutschland B.V. Co. KG Michael Thayer Werkstrasse 24 VirtualBox engineering 71384 Weinstadt, Germany mailto:michael.tha...@oracle.com Hauptverwaltung

Re: Resend: [PATCH xev] Show RandR events.

2011-03-03 Thread Michael Thayer
On Thu, 2011-03-03 at 11:37 -0800, Aaron Plattner wrote: On Wed, Feb 16, 2011 at 04:00:25AM -0800, Michael Thayer wrote: +if (rr_major = 1 rr_minor = 2) This check seems wrong, since it will include these event masks for RandR version 2.2 but not 2.1 if we ever have a RandR 2

  1   2   >