Re: Xorg crashing in pci_device_vgaarb_set_target
On Fri, Oct 13, 2017 at 11:46:08AM +0200, Michel Dänzer wrote: > Looks like https://patchwork.freedesktop.org/patch/170077/ should fix this. Thanks for the tip! I've applied the patch and I had no crashes since. -- Best Regards, Peter Kasza http://www.itinsight.hu peter.ka...@itinsight.hu () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments ___ xorg@lists.x.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: https://lists.x.org/mailman/listinfo/xorg Your subscription address: %(user_address)s
Re: Xorg crashing in pci_device_vgaarb_set_target
On 13/10/17 08:59 AM, Peter Kasza wrote: > On Tue, Oct 10, 2017 at 06:30:03PM +, Peter Kasza wrote: >> On Tue, Oct 10, 2017 at 05:19:05PM +, Adam Jackson wrote: >>> On Mon, 2017-10-09 at 13:07 +0200, Peter Kasza wrote: Hi all, I'm getting itermittent crashes on a vfio enabled machine. I'm not able to recreate it on purpose, but it seems to be occurring when virtualbox VMs and Firefox are running. From the backtrace I suspect that some bogus parameter is passed to the snprintf call, but other than that I'm not sure. The crash occurs in libpciaccess - pci_device_vgaarb_set_target. I have the latest release installed (0.13.5). Program terminated with signal SIGSEGV, Segmentation fault. #0 0x7f17082667a3 in __GI__IO_default_xsputn () from /usr/lib/libc.so.6 [Current thread is 1 (Thread 0x7f170aa11940 (LWP 491))] (gdb) bt #0 0x7f17082667a3 in __GI__IO_default_xsputn () at /usr/lib/libc.so.6 #1 0x7f1708259b2d in __GI__IO_padn () at /usr/lib/libc.so.6 #2 0x7f1708239938 in vfprintf () at /usr/lib/libc.so.6 #3 0x7f17082efcbb in __vsnprintf_chk () at /usr/lib/libc.so.6 #4 0x7f17082efbe5 in __snprintf_chk () at /usr/lib/libc.so.6 #5 0x7f1709a966b8 in pci_device_vgaarb_set_target () at /usr/lib/libpciaccess.so.0 #6 0x5616427d1fc8 in () >>> >>> Any chance you can (install debuginfo and) see the rest of this call >>> trace? I suspect the value of 'dev' being passed into >>> pci_device_vgaarb_set_target is just bogus, but without the call trace >>> up through Xorg it's hard to see how that could happen. >>> >>> - ajax >> >> Hey, >> >> Thanks for the suggestion. I've compiled a debug version of X. I'll >> reply back once I've reproduced the issue with more info. > > Ok, it seems to have crashed again. I've attached the trace with debug > symbols. Looks like https://patchwork.freedesktop.org/patch/170077/ should fix this. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg@lists.x.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: https://lists.x.org/mailman/listinfo/xorg Your subscription address: %(user_address)s
Re: Xorg crashing in pci_device_vgaarb_set_target
On Tue, Oct 10, 2017 at 05:19:05PM +, Adam Jackson wrote: > On Mon, 2017-10-09 at 13:07 +0200, Peter Kasza wrote: > > Hi all, > > > > I'm getting itermittent crashes on a vfio enabled machine. I'm not > > able to recreate it on purpose, but it seems to be occurring when > > virtualbox VMs and Firefox are running. > > > > From the backtrace I suspect that some bogus parameter is passed to > > the snprintf call, but other than that I'm not sure. > > > > The crash occurs in libpciaccess - pci_device_vgaarb_set_target. I > > have the latest release installed (0.13.5). > > > > Program terminated with signal SIGSEGV, Segmentation fault. > > #0 0x7f17082667a3 in __GI__IO_default_xsputn () from /usr/lib/libc.so.6 > > [Current thread is 1 (Thread 0x7f170aa11940 (LWP 491))] > > (gdb) bt > > #0 0x7f17082667a3 in __GI__IO_default_xsputn () at /usr/lib/libc.so.6 > > #1 0x7f1708259b2d in __GI__IO_padn () at /usr/lib/libc.so.6 > > #2 0x7f1708239938 in vfprintf () at /usr/lib/libc.so.6 > > #3 0x7f17082efcbb in __vsnprintf_chk () at /usr/lib/libc.so.6 > > #4 0x7f17082efbe5 in __snprintf_chk () at /usr/lib/libc.so.6 > > #5 0x7f1709a966b8 in pci_device_vgaarb_set_target () at > > /usr/lib/libpciaccess.so.0 > > #6 0x5616427d1fc8 in () > > Any chance you can (install debuginfo and) see the rest of this call > trace? I suspect the value of 'dev' being passed into > pci_device_vgaarb_set_target is just bogus, but without the call trace > up through Xorg it's hard to see how that could happen. > > - ajax Hey, Thanks for the suggestion. I've compiled a debug version of X. I'll reply back once I've reproduced the issue with more info. -- Best Regards, Peter Kasza http://www.itinsight.hu peter.ka...@itinsight.hu () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments ___ xorg@lists.x.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: https://lists.x.org/mailman/listinfo/xorg Your subscription address: %(user_address)s
Re: Xorg crashing in pci_device_vgaarb_set_target
On Mon, 2017-10-09 at 13:07 +0200, Peter Kasza wrote: > Hi all, > > I'm getting itermittent crashes on a vfio enabled machine. I'm not > able to recreate it on purpose, but it seems to be occurring when > virtualbox VMs and Firefox are running. > > From the backtrace I suspect that some bogus parameter is passed to > the snprintf call, but other than that I'm not sure. > > The crash occurs in libpciaccess - pci_device_vgaarb_set_target. I > have the latest release installed (0.13.5). > > Program terminated with signal SIGSEGV, Segmentation fault. > #0 0x7f17082667a3 in __GI__IO_default_xsputn () from /usr/lib/libc.so.6 > [Current thread is 1 (Thread 0x7f170aa11940 (LWP 491))] > (gdb) bt > #0 0x7f17082667a3 in __GI__IO_default_xsputn () at /usr/lib/libc.so.6 > #1 0x7f1708259b2d in __GI__IO_padn () at /usr/lib/libc.so.6 > #2 0x7f1708239938 in vfprintf () at /usr/lib/libc.so.6 > #3 0x7f17082efcbb in __vsnprintf_chk () at /usr/lib/libc.so.6 > #4 0x7f17082efbe5 in __snprintf_chk () at /usr/lib/libc.so.6 > #5 0x7f1709a966b8 in pci_device_vgaarb_set_target () at > /usr/lib/libpciaccess.so.0 > #6 0x5616427d1fc8 in () Any chance you can (install debuginfo and) see the rest of this call trace? I suspect the value of 'dev' being passed into pci_device_vgaarb_set_target is just bogus, but without the call trace up through Xorg it's hard to see how that could happen. - ajax ___ xorg@lists.x.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: https://lists.x.org/mailman/listinfo/xorg Your subscription address: %(user_address)s
Xorg crashing in pci_device_vgaarb_set_target
Hi all,
I'm getting itermittent crashes on a vfio enabled machine. I'm not
able to recreate it on purpose, but it seems to be occurring when
virtualbox VMs and Firefox are running.
From the backtrace I suspect that some bogus parameter is passed to
the snprintf call, but other than that I'm not sure.
The crash occurs in libpciaccess - pci_device_vgaarb_set_target. I
have the latest release installed (0.13.5).
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x7f17082667a3 in __GI__IO_default_xsputn () from /usr/lib/libc.so.6
[Current thread is 1 (Thread 0x7f170aa11940 (LWP 491))]
(gdb) bt
#0 0x7f17082667a3 in __GI__IO_default_xsputn () at /usr/lib/libc.so.6
#1 0x7f1708259b2d in __GI__IO_padn () at /usr/lib/libc.so.6
#2 0x7f1708239938 in vfprintf () at /usr/lib/libc.so.6
#3 0x7f17082efcbb in __vsnprintf_chk () at /usr/lib/libc.so.6
#4 0x7f17082efbe5 in __snprintf_chk () at /usr/lib/libc.so.6
#5 0x7f1709a966b8 in pci_device_vgaarb_set_target () at
/usr/lib/libpciaccess.so.0
#6 0x5616427d1fc8 in ()
From common_vgaarb.c:
int
pci_device_vgaarb_set_target(struct pci_device *dev)
{
int len;
char buf[BUFSIZE + 1]; /* reading BUFSIZE characters, + 1 for NULL */
int ret;
if (!dev)
dev = pci_sys->vga_default_dev;
if (!dev)
return -1;
// Crash is here:
len = snprintf(buf, BUFSIZE, "target PCI:%04x:%02x:%02x.%x",
dev->domain, dev->bus, dev->dev, dev->func);
ret = vgaarb_write(pci_sys->vgaarb_fd, buf, len);
if (ret)
return ret;
...
}
Other people seem to get the same error too:
https://bbs.archlinux.org/viewtopic.php?id=224824
https://www.redhat.com/archives/vfio-users/2017-July/msg1.html
Any help is appreciated.
--
Best Regards,
Peter Kasza
http://www.itinsight.hu
peter.ka...@itinsight.hu
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
___
xorg@lists.x.org: X.Org support
Archives: http://lists.freedesktop.org/archives/xorg
Info: https://lists.x.org/mailman/listinfo/xorg
Your subscription address: %(user_address)s
