On Thu, 2009-10-01 at 08:26 -0700, Daniel Stone wrote:
On Thu, Oct 01, 2009 at 10:14:23AM +0200, Michel Dänzer wrote:
On Thu, 2009-10-01 at 11:59 +1000, Dave Airlie wrote:
So I feel locking down master is going to get messy fast, I agree
all major developments should be done on
On Thu, Oct 01, 2009 at 10:50:09AM -0700, Ian Romanick wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Dave Airlie wrote:
From: Dave Airlie airl...@linux.ie
I think this is what the original author wanted.
Signed-off-by: Dave Airlie airl...@redhat.com
Acked-by: Ian
On Fri, Oct 02, 2009 at 01:18:22PM +0200, Luc Verhaegen wrote:
On Thu, Oct 01, 2009 at 10:50:09AM -0700, Ian Romanick wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Dave Airlie wrote:
From: Dave Airlie airl...@linux.ie
I think this is what the original author wanted.
On Fri, Oct 02, 2009 at 04:28:54PM +0200, Luc Verhaegen wrote:
Ok, thinking about this a bit further, and noticing that i overlooked
the imho gratuitous version bump, i came up with the attached patch.
Wrong, this was not a gratuitous version bump, the version in the
unified protocol header
On Fri, 02 Oct 2009 13:18:38 +0200
Michel Dänzer mic...@daenzer.net wrote:
What're your concerns?
First of all, surely the onus is on those who want to move the drivers
into the xserver tree to present convincing arguments in support of
it.
I think you've been present at some of the
2009/10/2 Michel Dänzer mic...@daenzer.net
On Thu, 2009-10-01 at 08:26 -0700, Daniel Stone wrote:
There were a couple of different motivations for this, one was to make
building things a great deal easier
Would it really? IME complications have mostly been due to things like
protos, not
The xserver source uses type declarations and #defines from Xtransint.h in
source files where the rest of the Xtrans source is not included. These
static function declarations result in warnings on GCC when the function
body isn't subsequently provided. Moving the prototypes out of the header
On Thu, 2009-10-01 at 20:58 +0200, Mark Kettenis wrote:
Date: Thu, 1 Oct 2009 11:50:42 -0700
From: Jamey Sharp ja...@minilop.net
xf86OpenConsole fails as non-root, at least on Linux. Since the
xf86-video-dummy driver works fine without root privileges or console
access, just don't
On Thu, 2009-10-01 at 10:47 -0700, Jamey Sharp wrote:
---
I didn't test my previous patch right. Sorry. This version doesn't seem
to crash the server at startup. :-)
Review would still be greatly appreciated.
Thanks for jumping in! Comments inline.
Xext/shm.c | 67
On Friday 02 of October 2009, Ping wrote:
I think moving drivers into xserver tree benefits both driver and xserver
developers as well as distro maintainers.
As distro maintainer I hated monolitic X. It's was nightmare to patch it and
fix some build issues. Modular drivers are very nice for
On Thu, 01 Oct 2009 14:21:22 -0700
Eric Anholt e...@anholt.net wrote:
On Thu, 2009-10-01 at 20:58 +0200, Mark Kettenis wrote:
Date: Thu, 1 Oct 2009 11:50:42 -0700
From: Jamey Sharp ja...@minilop.net
xf86OpenConsole fails as non-root, at least on Linux. Since the
xf86-video-dummy
- Don't warn for references to deprecated functions in xorg_symbols.
- Ignore functions generated by gl_apitemp.py that are never used.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
glx/glapi.c |7 ++-
hw/xfree86/loader/sdksyms.sh |1 +
2 files changed, 7
miPointerCurrentScreen is deprecated. This patch amounts to inlining its
new implementation.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
hw/xfree86/common/xf86RandR.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common/xf86RandR.c
In both functions, answer was uninitialized if compsize was 0, but in
that case __GLX_SEND_VOID_ARRAY(compsize) results in a call to
WriteToClient for 0 bytes, which returns immediately without examining the
answer argument. So initializing to a null pointer is as good as
anything else.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
hw/xfree86/int10/helper_exec.c | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/hw/xfree86/int10/helper_exec.c b/hw/xfree86/int10/helper_exec.c
index 6ba647f..38b0adf 100644
---
On 64-bit systems, int and pointers don't have the same size, so GCC gives
warnings about casts between int and pointer types. However, in the cases
covered by this patch, it's always a value that fits in int being stored
temporarily as a pointer and then converted back later, which is safe.
GCC warns about casting a double return value to int.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
hw/xfree86/i2c/fi1236.c | 10 +-
hw/xfree86/parser/Flags.c |2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/xfree86/i2c/fi1236.c
Hi friends,
i run cppcheck (a static code analysis tool;
http://sourceforge.net/projects/cppcheck/) against the sources of xorg-server
1.7.0. I created a patch to clean up the following issues (see attachments):
../xfree86/os-support/linux/lnx_apm.c,183,Error,Resource leak: fd
Thanks for review, Eric!
On Thu, Oct 01, 2009 at 01:53:15PM -0700, Eric Anholt wrote:
On Thu, 2009-10-01 at 10:47 -0700, Jamey Sharp wrote:
+drawables = xcalloc(screenInfo.numScreens, sizeof(DrawablePtr));
Seems like this drawable pointer should be part of the screen private.
That
Le 02/10/2009 22:42, Jamey Sharp a écrit :
In both functions, answer was uninitialized if compsize was 0, but in
that case __GLX_SEND_VOID_ARRAY(compsize) results in a call to
WriteToClient for 0 bytes, which returns immediately without examining the
answer argument. So initializing to a null
In both functions, answer was uninitialized if compsize was 0, but in
that case __GLX_SEND_VOID_ARRAY(compsize) results in a call to
WriteToClient for 0 bytes, which returns immediately without examining the
answer argument. So initializing to a null pointer is as good as
anything else.
On Fri, 02 Oct 2009 16:07:31 +0200, Soeren Sandmann sandm...@daimi.au.dk
wrote:
Kim Woelders k...@woelders.dk writes:
Commit 128cd03eecacc6d5c5903d59a11966dcf3697bf1 causes trouble with
clip regions in the e16 WM composite manager (e.g. during fade-out).
This marks the second recorded
On Fri, Oct 2, 2009 at 13:42:48 -0700, Jamey Sharp wrote:
diff --git a/hw/xfree86/common/xf86RandR.c b/hw/xfree86/common/xf86RandR.c
index 02dcc34..807ce79 100644
--- a/hw/xfree86/common/xf86RandR.c
+++ b/hw/xfree86/common/xf86RandR.c
@@ -307,7 +307,7 @@ xf86RandRSetConfig (ScreenPtr
On Fri, 02 Oct 2009 23:32:31 +0200, Kim Woelders k...@woelders.dk wrote:
On Fri, 02 Oct 2009 16:07:31 +0200, Soeren Sandmann
sandm...@daimi.au.dk
wrote:
Kim Woelders k...@woelders.dk writes:
Commit 128cd03eecacc6d5c5903d59a11966dcf3697bf1 causes trouble with
clip regions in the e16 WM
On Fri, Oct 02, 2009 at 11:36:34PM +0200, Julien Cristau wrote:
On Fri, Oct 2, 2009 at 13:42:48 -0700, Jamey Sharp wrote:
@@ -307,7 +307,7 @@ xf86RandRSetConfig (ScreenPtr pScreen,
/*
* Move the cursor back where it belongs; SwitchMode repositions it
*/
-
Martin Ettl wrote:
diff --git a/hw/xfree86/dixmods/extmod/xf86vmode.c
b/hw/xfree86/dixmods/extmod/xf86vmode.c
index 4920115..b07810a 100644
--- a/hw/xfree86/dixmods/extmod/xf86vmode.c
+++ b/hw/xfree86/dixmods/extmod/xf86vmode.c
@@ -120,7 +120,7 @@ static int XF86VidModeEventBase = 0;
Signed-off-by: Jamey Sharp ja...@minilop.net
---
Changes since v2:
- Free screen-private data in a CloseScreen hook. (Thanks keithp!)
- Name locals screen_priv instead of priv. (Thanks anholt!)
I couldn't move private fetching into the variable declaration in the
remaining cases without using
On Fri, 2009-10-02 at 23:10 +0200, Martin Ettl wrote:
diff --git a/exa/exa_classic.c b/exa/exa_classic.c
index 1eff570..c9c7534 100644
--- a/exa/exa_classic.c
+++ b/exa/exa_classic.c
@@ -144,14 +144,14 @@ Bool
exaModifyPixmapHeader_classic(PixmapPtr pPixmap, int width, int
height, int
This one might be good instead or in addition:
Either way,
Reviewed-by: Jeremy Huddleston jerem...@apple.com
diff --git a/configure.ac b/configure.ac
index 46421fd..22e42c5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1244,7 +1244,7 @@ AC_DEFINE(XSYNC, 1, [Support XSync extension])
Currently, you can't build other DDXs parallel to XQuartz because we
need a bunch of #ifdef XQUARTZ / #ifdef ROOTLESS magic sprinkled in
various locations...
Either way you want to push it is fine with me. I'll hopefully be
able to clean that all up eventually.
On Oct 2, 2009, at
30 matches
Mail list logo
