Re: Bell confusion with master vs. slave devices in Xorg 1.7.6

2010-04-17 Thread Jeremy Huddleston
Yeah... I was seeing this as well. I brought it up last month: http://lists.x.org/archives/xorg-devel/2010-March/006265.html And ended up just letting core ring it (DDXRingBell): http://cgit.freedesktop.org/~jeremyhu/xserver/commit/?id=eac7cdabecafb7c505795207182ab2578d672c06 I don't have a

Re: [PATCH] xfree86: fix not reached code in parser

2010-04-17 Thread Dan Nicholson
On Fri, Apr 16, 2010 at 7:24 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com ---  hw/xfree86/parser/read.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/parser/read.c b/hw/xfree86/parser/read.c

Re: [PATCH] Xi: fix not reached code in XSendExtensionEvent

2010-04-17 Thread Dan Nicholson
On Fri, Apr 16, 2010 at 7:24 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: Error was introduced in 31a7994a. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com ---  Xi/sendexev.c |    3 ++-  1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Xi/sendexev.c

Re: [PATCH] Xi: check for NULL pointer before dereferences it in DeviceFocusEvent

2010-04-17 Thread Dan Nicholson
On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: Both mouse and mouse-button are already used before their checking were being performed. So check on the beginning. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com ---  Xi/exevents.c |    4 +++-  1 files

Re: [PATCH] xkb: check for NULL pointer before dereferences it in XkbWriteXKBSymbols

2010-04-17 Thread Dan Nicholson
On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Looking at the xkb coding style again makes me want to drink bleach. Reviewed-by: Dan Nicholson dbn.li...@gmail.com

Re: [PATCH] mi: check for NULL pointer before dereferences it in miPointerSetPosition

2010-04-17 Thread Dan Nicholson
On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Dan Nicholson dbn.li...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH] exa: check for NULL pointer before dereferences it

2010-04-17 Thread Dan Nicholson
On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Dan Nicholson dbn.li...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH] exa: don't need to check for NULL pointer if we already assumed it has a value

2010-04-17 Thread Dan Nicholson
On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: the alternative would be to check ps in the beginning of the function. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com ---  exa/exa.c |    2 --  1 files changed, 0 insertions(+), 2 deletions(-) diff

Re: Merged proto package

2010-04-17 Thread olafBuddenhagen
Hi, On Tue, Apr 06, 2010 at 06:43:22PM -0700, Keith Packard wrote: This isn't a git super-module, Well, why not? -antrik- ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Live builds (was: Merged proto package)

2010-04-17 Thread olafBuddenhagen
Hi, On Wed, Apr 07, 2010 at 11:32:21AM -0500, Donnie Berkholz wrote: On 23:14 Tue 06 Apr , Keith Packard wrote: The people we're trying to reach with this are those people building From source. For people like me, who really can't rely on a distribution to be up to date enough, I

[PATCH] xkb: Fix omissions in geometry initialization #27679

2010-04-17 Thread Dirk Wallenstein
_XkbCopyGeom did not copy all of the data from the source geometry. This resulted in failures when trying to obtain the keymap from a server where the default geometry has not been replaced by a custom configuration. Signed-off-by: Dirk Wallenstein hals...@t-online.de --- xkb/xkbUtils.c | 41

Re: Bell confusion with master vs. slave devices in Xorg 1.7.6

2010-04-17 Thread Mark Hills
On Fri, 16 Apr 2010, Alan Coopersmith wrote: Several users have complained to me about their X server bells on recent builds of OpenSolaris - definitely with Xorg 1.7.x releases, I don't know if it affected Xorg 1.6.x before that as well. The complaints I've gotten are two-fold: the bell

[PATCH input-evdev 00/10] Configuration upgrades

2010-04-17 Thread Gaetan Nadon
Patch #1 concept has been reviewed but code is different Patch #7 is a change that has not been reviewed in other patches yet. Other changes have been reviewed in other patches Gaetan Nadon (10): config: remove AH_TOP autoheader statement config: update AC_PREREQ statement to 2.60 replace

[PATCH input-evdev 01/10] config: remove AH_TOP autoheader statement

2010-04-17 Thread Gaetan Nadon
The generated config.h does not need to include xorg-server.h for the content it provides. Add #include xorg-server.h in .[hc] files as needed. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |1 - src/evdev.c |1 + 2 files changed, 1 insertions(+), 1 deletions(-)

[PATCH input-evdev 02/10] config: update AC_PREREQ statement to 2.60

2010-04-17 Thread Gaetan Nadon
Unrelated to the previous patches, the new value simply reflects the reality that the minimum level for autoconf to configure all x.org modules is 2.60 dated June 2006. ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |2

[PATCH input-evdev 03/10] replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS

2010-04-17 Thread Gaetan Nadon
Regroup AC statements at the top. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 2e894cd..9bce2f0 100644 --- a/configure.ac +++ b/configure.ac @@ -27,9 +27,10 @@

[PATCH input-evdev 04/10] config: remove unrequired AC_HEADER_STDC

2010-04-17 Thread Gaetan Nadon
Autoconf says: This macro is obsolescent, as current systems have conforming header files. New programs need not use this macro. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/configure.ac

[PATCH input-evdev 05/10] config: refactor and comment the sdkdir distcheck workaround

2010-04-17 Thread Gaetan Nadon
Seperate legitimate sdkdir usage from distcheck workaround. Comment this non obvious workaround. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Makefile.am |2 +- configure.ac | 14 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/Makefile.am

[PATCH input-evdev 06/10] config: replace deprecated INCLUDES with AM_CPPFLAGS

2010-04-17 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon mems...@videotron.ca --- src/Makefile.am |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 4f0937e..a5c89ac 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -26,13 +26,12 @@ # TODO:

[PATCH input-evdev 07/10] config: optional extension check for inputproto not required

2010-04-17 Thread Gaetan Nadon
The check should be in PKG_CHECK_MODULES permanently. The XORG_DRIVER_CHECK_EXT will add inputproto to PKG_CHECK_MODULES only if the extension is available. By definition, this extension is always available and the evdev driver cannot function without it. This is evidenced by the absence of

[PATCH input-evdev 08/10] config: fix warnings, m4 quoting and layout

2010-04-17 Thread Gaetan Nadon
Fix some m4 quoting Fix some autoconf warnings remove AC_PROG_CC as it overrides AC_PROG_C_C99 from XORG_DEFAULT_OPTIONS Regroup statements per section Add comments Upgrade X.Org macros to 1.4 for INSTALL file copying Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac | 43

[PATCH input-evdev 09/10] include: EXTRA_DIST is not required for header files.

2010-04-17 Thread Gaetan Nadon
The sdk_HEADERS is sufficient as the sdk prefix matches the dir suffix in the sdkdir variable. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- include/Makefile.am |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/Makefile.am b/include/Makefile.am index

[PATCH input-evdev 10/10] man: Use Autoconf provided $(AM_V_GEN)$(SED)

2010-04-17 Thread Gaetan Nadon
Enables silent rule and use platform appropriate version of sed. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- man/Makefile.am |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/man/Makefile.am b/man/Makefile.am index 66c207f..4edafaa 100644 --- a/man/Makefile.am

Re: [PATCH] xfree86: check for NULL pointer before dereferences it in parser code

2010-04-17 Thread Keith Packard
On Fri, 16 Apr 2010 18:42:19 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: - if (!name || name[0] == '.' || len = suflen) + if (!name) + return 0; + + name = de-d_name; You might want to assign name before testing it. -- keith.pack...@intel.com

Re: Live builds (was: Merged proto package)

2010-04-17 Thread Dave Airlie
On Sun, Apr 18, 2010 at 2:17 PM, Keith Packard kei...@keithp.com wrote: On Fri, 16 Apr 2010 21:57:47 +0200, olafbuddenha...@gmx.net wrote: I don't see why other distributions can't provide something similar. Even without true live bulids, IMHO this makes the whole point about xserver being