On Wed, Jul 21, 2010 at 09:27:48AM +0300, Micki Balanga wrote:
> Hi All,
> My name is Micki , I works at N-trig.
> I am responsible on the Linux development at N-trig.
> I would like to participle the discussion of adapting multi-touch protocol
> into Xorg server and share my knowledge regards t
Fernando Carrijo wrote:
> The file dixutils.c has grown into an incohesive and bloated beast. The time
> has
> come to refactor some of its routines to their own files. This patch gives a
> new
> home for all of those which deal with work queues.
> ---
> dix/Makefile.am |3 +-
> dix/dixuti
The file dixutils.c has grown into an incohesive and bloated beast. The time has
come to refactor some of its routines to their own files. This patch gives a new
home for all of those which deal with work queues.
---
dix/Makefile.am |3 +-
dix/dixutils.c | 80 -
dix/
The file dixutils.c has grown into an incohesive and bloated beast. The time has
come to refactor some of its routines to their own files. This patch gives a new
home for all of those which deal with sleeping clients.
---
dix/Makefile.am |1 +
dix/dixutils.c | 84 -
The file dixutils.c has grown into an incohesive and bloated beast. The time has
come to refactor some of its routines to their own files. This patch gives a new
home for all of those which deal with resource lookup.
---
dix/Makefile.am |1 +
dix/dixutils.c | 92 ---
The file dixutils.c has grown into an incohesive and bloated beast. The time has
come to refactor some of its routines to their own files. This patch gives a new
home for all of those which deal with callback management.
---
dix/Makefile.am |1 +
dix/callback.c | 333
The file dixutils.c has grown into an incohesive and bloated beast. The time has
come to refactor some of its routines to their own files. This patch gives a new
home for all of those which deal with block and wake up handlers.
---
dix/Makefile.am|1 +
dix/blockhandler.c | 243 +++
My humble attempt to put some order in dix. For lack of inspiration
(or knowledge, if you prefer) I didn't touch the original copyright
notices, and simply copied them verbatim to the new files; exactly
like I did to headers. Ugly, I presume. But just a first try.
Do people see any value in things
After copying the unused_classes into the device, reset the original
pointer. Otherwise we have two pointers pointing to the same field and both
get freed on device removal.
Some classes already have this behaviour since 51c8fd69.
Signed-off-by: Peter Hutterer
---
Xi/exevents.c |6 ++
1
On Fri, Jul 16, 2010 at 09:21:19AM -0400, Chase Douglas wrote:
> The XI2 protocol supports per-axis modes, but the server so far does
> not. This change adds support in the server.
>
> A complication is the fact that XI1 does not support per-axis modes.
> The solution provided here is to set a per
Mark argument to DDC_checksum as const too.
Signed-off-by: Matt Turner
---
hw/xfree86/ddc/ddc.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/ddc/ddc.c b/hw/xfree86/ddc/ddc.c
index 7379e95..2d9d4dc 100644
--- a/hw/xfree86/ddc/ddc.c
+++ b/hw/xfree86/ddc
On Tue, Jul 27, 2010 at 3:56 AM, Masatake YAMATO wrote:
> EDID_block is allocated dynamically and attached to xf86MonPtr object in
> the function where the object is initialized.
> When the initilization fails, EDID_block should be freed.
>
> Signed-off-by: Masatake YAMATO
> ---
> hw/xfree86/ddc
Have a question to ask:
We want to support some wide-screen resolutions in our platform under
linux. And we hope that can be recognized in the applet
Preferences->Display->Resolution.
Can you tell me what the mechanism in that? That is to say, how the
application under desktop can recognize the res
Reviewed-by: Patrick E. Kane
The lines of context appear to show that both hsize and vsize are being
changed, could include a comment to explain why only HSync* needs to
be adjusted?
In any event, thanks for the patch.
Pat
---
On Tue, Jul 27, 2010 at 4:34 PM, Adam Jackson wrote:
> Simple typo
On Tue, Jul 27, 2010 at 03:09:41PM +0300, Pauli Nieminen wrote:
> Here is punch of small fixes for bugs reported by static analyzer.
>
> Some of bugs aren't possible in runtime but it is still nice to have
> correct code even for currently unused code paths.
Reviewed-by: Peter Hutterer for the p
On Tue, Jul 27, 2010 at 03:09:56PM +0300, Pauli Nieminen wrote:
> Source and destination have well defined size so use memcpy instead of
> strncpy. strncpy tryes to add NULL to end of destination but it is not
> possible if source doesn't have NULL.
same argument as for the other patch.
> memcpy
On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote:
> Source and destination have well defined size so use memcpy instead of
> strncpy. strncpy tryes to add NULL to end of destination but it is not
^ "tries"
> possible if source doesn't have NULL.
my strncpy man page
On Tue, Jul 27, 2010 at 03:09:53PM +0300, Pauli Nieminen wrote:
> prop->name is allocated in code but check is for parameter name that
> can't be NULL.
>
> Signed-off-by: Pauli Nieminen
> ---
> xkb/XKBGAlloc.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/xkb/XK
On Tue, Jul 27, 2010 at 03:09:51PM +0300, Pauli Nieminen wrote:
> If search for device failed sli is NULL. In that case we have to protect
> dereference to prevent server crash.
>
> Signed-off-by: Pauli Nieminen
> ---
> xkb/ddxLoad.c |6 +-
> xkb/xkbLEDs.c | 10 ++
> 2 files ch
On Tue, Jul 27, 2010 at 03:09:50PM +0300, Pauli Nieminen wrote:
> Caller quarantines that pAction pointer is valid.
^^ "guarantees"?
same applies here as well as for the other patch, it's not the caller
guaranteeing that pAction is non-NULL, it's that we dereferernce it later
uncondition
On Tue, Jul 27, 2010 at 03:09:49PM +0300, Pauli Nieminen wrote:
> Caller quarantines that changes pointer is valid.
^^ "guarantees"?
this is a bad description IMO. for better or worse,
XkbUpdateKeyTypesFromCore is _X_EXPORT and could thus be called from a
module, not just from the sing
On Tue, Jul 27, 2010 at 03:09:46PM +0300, Pauli Nieminen wrote:
> This prevents validation code from using unitialized values.
>
> Signed-off-by: Pauli Nieminen
> ---
> xkb/xkb.c |8
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/xkb/xkb.c b/xkb/xkb.c
> index 9
Simple typo, should have been adjusting the horizontal timings
consistently since we're not trying to mangle vertical at all.
Signed-off-by: Adam Jackson
---
hw/xfree86/modes/xf86EdidModes.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/modes/xf86EdidMode
On Tue, 2010-07-27 at 22:47 +0200, Mark Kettenis wrote:
> > From: Adam Jackson
> > Some of them are... nontrivial.
>
> Which makes me seriously doubt that these bugs can be found and fixed
> fast enough such that users won't be affected.
Perhaps they can consider running an older X server.
- aj
> From: Adam Jackson
> Date: Tue, 27 Jul 2010 15:46:59 -0400
>
> On Tue, 2010-07-27 at 20:23 +0200, Mark Kettenis wrote:
> > > Date: Tue, 27 Jul 2010 17:57:01 +0100
> > > From: Matthew Garrett
> > > On Wed, Jul 14, 2010 at 04:15:56PM +0300, Tiago Vignatti wrote:
> > > > On Tue, Jul 13, 2010 at 1
On Tue, 2010-07-27 at 20:23 +0200, Mark Kettenis wrote:
> > Date: Tue, 27 Jul 2010 17:57:01 +0100
> > From: Matthew Garrett
> > On Wed, Jul 14, 2010 at 04:15:56PM +0300, Tiago Vignatti wrote:
> > > On Tue, Jul 13, 2010 at 11:32:54PM +0200, ext Adam Jackson wrote:
> > > > vm86 has been defaulted of
> Date: Tue, 27 Jul 2010 17:57:01 +0100
> From: Matthew Garrett
>
> On Wed, Jul 14, 2010 at 04:15:56PM +0300, Tiago Vignatti wrote:
> > On Tue, Jul 13, 2010 at 11:32:54PM +0200, ext Adam Jackson wrote:
> > > vm86 has been defaulted off since 1.6, and is still a terrible idea to
> > > actually use
On Tue, 2010-07-27 at 18:47 +0200, Julien Cristau wrote:
> The GL one is more annoying.
>
glproto includes gl.h which is in the mesa source. The mesa package
depends on glproto.
This will become a circular dependency if glproto is fixed to depend on
gl. I was surprised to see a protocol
includin
On Wed, Jul 14, 2010 at 04:15:56PM +0300, Tiago Vignatti wrote:
> On Tue, Jul 13, 2010 at 11:32:54PM +0200, ext Adam Jackson wrote:
> > vm86 has been defaulted off since 1.6, and is still a terrible idea to
> > actually use. Time to say goodbye.
>
> My empirical evidences say that we can't do thi
EDID_block is allocated dynamically and attached to xf86MonPtr object in
the function where the object is initialized.
When the initilization fails, EDID_block should be freed.
Signed-off-by: Masatake YAMATO
---
hw/xfree86/ddc/ddc.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
On Tue, 27 Jul 2010 17:39:11 +0100
Daniel Stone wrote:
> On Tue, Jul 27, 2010 at 09:34:01AM -0700, Jesse Barnes wrote:
> > On Tue, 27 Jul 2010 17:00:28 +0100
> > Daniel Stone wrote:
> > > On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote:
> > > > On Tue, Jul 27, 2010 at 08:25:13 -07
On Tue, Jul 27, 2010 at 17:39:11 +0100, Daniel Stone wrote:
> > In file included from /usr/include/xorg/scrnintstr.h:58:0,
> > from /usr/include/xorg/xf86str.h:39,
> > from /usr/include/xorg/xf86.h:46,
> > from uxa-priv.h:37,
> >
On Tue, Jul 27, 2010 at 09:34:01AM -0700, Jesse Barnes wrote:
> On Tue, 27 Jul 2010 17:00:28 +0100
> Daniel Stone wrote:
> > On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote:
> > > On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:
> > > > Apparently MeeGo does automatic pac
On Tue, 27 Jul 2010 17:00:28 +0100
Daniel Stone wrote:
> Hi,
>
> On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote:
> > On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:
> > > Apparently MeeGo does automatic packaging based on configure.ac, so
> > > Arjan requested that th
On Tue, 27 Jul 2010 17:00:28 +0100
Daniel Stone wrote:
> Hi,
>
> On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote:
> > On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:
> > > Apparently MeeGo does automatic packaging based on configure.ac, so
> > > Arjan requested that th
Hi,
On Tue, Jul 27, 2010 at 05:44:39PM +0200, Julien Cristau wrote:
> On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:
> > Apparently MeeGo does automatic packaging based on configure.ac, so
> > Arjan requested that these be added to make that easier.
>
> So we're adding fictional depe
On Tue, Jul 27, 2010 at 08:25:13 -0700, Jesse Barnes wrote:
> Apparently MeeGo does automatic packaging based on configure.ac, so
> Arjan requested that these be added to make that easier.
So we're adding fictional dependencies based on meego brokenness?
Do you have more details on the issues the
On Tue, 27 Jul 2010 10:50:24 -0400
Gaetan Nadon wrote:
> On Tue, 2010-07-27 at 15:41 +0200, Julien Cristau wrote:
>
> > > +PKG_CHECK_MODULES(XI, [xi >= 1.3])
> > > +PKG_CHECK_MODULES(GL, [gl >= 7.7.0])
> > >
> > > sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
> > >
> >
> > May I ask w
On Tue, 27 Jul 2010 15:41:35 +0200
Julien Cristau wrote:
> On Mon, Jul 26, 2010 at 16:44:47 -0700, Jesse Barnes wrote:
>
> > configure.ac |2 ++
> > 1 file changed, 2 insertions(+)
> >
> > New commits:
> > commit d580fa82a1cf339d2d1fd1055d137c0b23cd04f3
> > Author: Jesse Barnes
> > Date:
On Tue, 2010-07-27 at 15:41 +0200, Julien Cristau wrote:
> > +PKG_CHECK_MODULES(XI, [xi >= 1.3])
> > +PKG_CHECK_MODULES(GL, [gl >= 7.7.0])
> >
> > sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
> >
>
> May I ask why? None of these seem necessary…
>
Jesse,
Will the --disable-dri opti
On Mon, Jul 26, 2010 at 16:44:47 -0700, Jesse Barnes wrote:
> configure.ac |2 ++
> 1 file changed, 2 insertions(+)
>
> New commits:
> commit d580fa82a1cf339d2d1fd1055d137c0b23cd04f3
> Author: Jesse Barnes
> Date: Mon Jul 26 16:44:19 2010 -0700
>
> configure.ac: add xi and gl require
Source and destination have well defined size so use memcpy instead of
strncpy. strncpy tryes to add NULL to end of destination but it is not
possible if source doesn't have NULL.
memcpy will initialize whole array/structure so memset is redurant and
can be removed.
Signed-off-by: Pauli Nieminen
Source and destination have well defined size so use memcpy instead of
strncpy. strncpy tryes to add NULL to end of destination but it is not
possible if source doesn't have NULL.
Signed-off-by: Pauli Nieminen
---
xkb/XKBGAlloc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
dif
If search for device failed sli is NULL. In that case we have to protect
dereference to prevent server crash.
Signed-off-by: Pauli Nieminen
---
xkb/ddxLoad.c |6 +-
xkb/xkbLEDs.c | 10 ++
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/xkb/ddxLoad.c b/xkb/ddxLoa
Signed-off-by: Pauli Nieminen
---
xkb/xkb.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/xkb/xkb.c b/xkb/xkb.c
index 452bf2c..618d0bc 100644
--- a/xkb/xkb.c
+++ b/xkb/xkb.c
@@ -224,7 +224,8 @@ ProcXkbSelectEvents(ClientPtr client)
masks = XkbFindClientResourc
prop->name is allocated in code but check is for parameter name that
can't be NULL.
Signed-off-by: Pauli Nieminen
---
xkb/XKBGAlloc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/xkb/XKBGAlloc.c b/xkb/XKBGAlloc.c
index d1adea3..7143e7a 100644
--- a/xkb/XKBGAlloc.c
++
Caller quarantines that changes pointer is valid.
Signed-off-by: Pauli Nieminen
---
xkb/xkbUtils.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/xkb/xkbUtils.c b/xkb/xkbUtils.c
index 14dc784..31aff93 100644
--- a/xkb/xkbUtils.c
+++ b/xkb/xkbUtils.c
@@ -223,7 +223,6
Signed-off-by: Pauli Nieminen
---
xkb/ddxList.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/xkb/ddxList.c b/xkb/ddxList.c
index 39bd739..c1ada5c 100644
--- a/xkb/ddxList.c
+++ b/xkb/ddxList.c
@@ -202,8 +202,7 @@ chartmpname[PATH_MAX];
}
if (!in)
Fixes warning that strncpy is not able to append NULL to the end
of destination.
Signed-off-by: Pauli Nieminen
---
xkb/xkmread.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/xkb/xkmread.c b/xkb/xkmread.c
index 814bb1d..9eb8601 100644
--- a/xkb/xkmread.c
+++ b/xkb/xk
sli is null beofre allocation assigment so deference t osli has to be
protected.
Signed-off-by: Pauli Nieminen
---
xkb/xkbLEDs.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/xkb/xkbLEDs.c b/xkb/xkbLEDs.c
index 1682671..515e9b7 100644
--- a/xkb/xkbLEDs.c
+++ b/xkb/xk
Caller quarantines that pAction pointer is valid.
Signed-off-by: Pauli Nieminen
---
xkb/xkbActions.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/xkb/xkbActions.c b/xkb/xkbActions.c
index eea3d4a..ddab882 100644
--- a/xkb/xkbActions.c
+++ b/xkb/xkbActions.c
@@ -340,7
map is allocated but not freed if reply length and data don't match.
Signed-off-by: Pauli Nieminen
---
xkb/xkb.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/xkb/xkb.c b/xkb/xkb.c
index 9a5d5b3..452bf2c 100644
--- a/xkb/xkb.c
+++ b/xkb/xkb.c
@@ -3027,6 +3027,7 @@ regi
calloc already initializes allocated memory to zero.
Signed-off-by: Pauli Nieminen
---
xkb/xkbEvents.c |9 -
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/xkb/xkbEvents.c b/xkb/xkbEvents.c
index 8028502..c020e5e 100644
--- a/xkb/xkbEvents.c
+++ b/xkb/xkbEvents.c
@@ -
This prevents validation code from using unitialized values.
Signed-off-by: Pauli Nieminen
---
xkb/xkb.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/xkb/xkb.c b/xkb/xkb.c
index 935f5ea..9a5d5b3 100644
--- a/xkb/xkb.c
+++ b/xkb/xkb.c
@@ -2366,6 +2366,14 @@ _Xkb
xkb->names is dereferenced in else path too.
Signed-off-by: Pauli Nieminen
---
xkb/xkmread.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/xkb/xkmread.c b/xkb/xkmread.c
index 9eb8601..b564195 100644
--- a/xkb/xkmread.c
+++ b/xkb/xkmread.c
@@ -686,7 +686,11 @@ int
If fopen fails pointer in buf would be overwriten with a new pointer.
Signed-off-by: Pauli Nieminen
---
xkb/ddxList.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/xkb/ddxList.c b/xkb/ddxList.c
index 2256424..39bd739 100644
--- a/xkb/ddxList.c
+++ b/xkb/ddxList.c
@@ -
Hi,
Here is punch of small fixes for bugs reported by static analyzer.
Some of bugs aren't possible in runtime but it is still nice to have
correct code even for currently unused code paths.
Pauli
___
xorg-devel@lists.x.org: X.Org development
Archives
On Mon, Jul 26, 2010 at 9:41 PM, Gaetan Nadon wrote:
> On Mon, 2010-07-26 at 17:38 -0400, Trevor Woerner wrote:
>
> File "/usr/lib/python2.6/site-packages/xcbgen/state.py", line 94, in
> resolve
> item.resolve(self)
>
> You need the package xcb-proto-1.2 or later which has an xcbgen sub
> di
58 matches
Mail list logo
