[PULL] input fixes for 1.9, unloved.

2010-07-29 Thread Peter Hutterer
Keith, please pull and/or review the patches below. They are all fixes for 1.9. xkb: post-fix PointerKeys button events with a DeviceChangedEvent. exposed by 14327858391ebe929b806efb53ad79e789361883, devices with more valuators than the XTEST pointer device now skip events. xkb: if the

[PATCH 17/19] xfree86: Fix xf86 backend-specific input initialization

2010-07-29 Thread Peter Hutterer
From: Simon Thum Instead of shoving it in rather unrelated places, move acceleration init into xf86NewInputDevice. Caveat: It's not clear atm how relevant other callers of ActivateDevice (like OpenDevice) actually are. Signed-off-by: Simon Thum Reviewed-by: Peter Hutterer Signed-off-by: Peter

[PATCH 19/19] input: Purge AddOtherInputDevices DDX hook.

2010-07-29 Thread Peter Hutterer
This hook wasn't used by any DDX. Device addition and removal is handled by the config backend, so we don't need to do anything special that during the ListInputDevices request processing. Signed-off-by: Peter Hutterer --- Xi/listdev.c |3 -- Xi/stubs.c

[PATCH 18/19] input: remove OpenInputDevice and CloseInputDevice DDX hooks.

2010-07-29 Thread Peter Hutterer
In theory, these hooks were to be used for DDX-specific device enablement. None of the DDXs however did anything here. Now we call DEVICE_INIT on all devices when they are added, so the xfree86 DDX as the only one with real code didn't do anything here. kdrive checked for device validity but that'

[PATCH 16/19] xfree86: purge superfluous includes from xf86Xinput.c

2010-07-29 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86Xinput.c | 16 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c index defb83a..a6b0b58 100644 --- a/hw/xfree86/common/xf86Xinput.c +++ b/hw/xfr

[PATCH 15/19] xfree86: remove unused DeviceAssocRec struct.

2010-07-29 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86Config.c |1 - hw/xfree86/common/xf86Xinput.h |6 -- 2 files changed, 0 insertions(+), 7 deletions(-) diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c index 28786ba..76d820b 100644 --- a/hw/xfree86/co

[PATCH 14/19] xfree86: remove LocalDeviceRec/Ptr definition.

2010-07-29 Thread Peter Hutterer
Two names pointing to the same struct for over 7 years now. Remove the define, if drivers don't want to change they can always do the typedef themselves. Rename all "LocalDevicePtr local" to "InputInfoPtr pInfo". Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86Helper.c | 10 ++-- hw/x

[PATCH 13/19] xfree86: add xf86IDrvMsg and friends for input driver logging.

2010-07-29 Thread Peter Hutterer
Input driver messages are only standardised by convention, with the drivers prefixing the device name to most messages. This makes it rather hard to grep on "evdev" for example when looking for the evdev ouput. This patch adds three new logging functions, modeled after xf86DrvMsg(), the logging fu

[PATCH 12/19] xfree86: move xf86AllocateInput and xf86DeleteInput to xf86Xinput.c

2010-07-29 Thread Peter Hutterer
Make xf86AllocateInput static in the process, this function is only called from one location. Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86Helper.c | 90 hw/xfree86/common/xf86Xinput.c | 89 +++ hw/xfree8

[PATCH 11/19] xfree86: return the device from xf86ActivateDevice.

2010-07-29 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86Xinput.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c index 1ee1e71..b4ef200 100644 --- a/hw/xfree86/common/xf86Xinput.c +++ b/hw/xfree86/com

[PATCH 10/19] input: set XKB extension for all new devices, not just xfree86 ones.

2010-07-29 Thread Peter Hutterer
Right now, Xephyr and others don't get to use XKB on the slave devices. Which works given that no-one cares about SDs just yet but event processing is different if the ProcessInputProc isn't wrapped properly. Signed-off-by: Peter Hutterer --- dix/devices.c |1 + hw/xfree86/c

[PATCH 09/19] xfree86: purge SendDragEvents support.

2010-07-29 Thread Peter Hutterer
>From the documentation: "This is mainly to allow a touch screen to be used with netscape and other browsers which do strange things if the mouse moves between button down and button up." CLOSED - NOTOURBUG Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86Xinput.c | 25 +-

[PATCH 08/19] xfree86: remove XI86_CONFIGURED flag.

2010-07-29 Thread Peter Hutterer
PreInit returns a status code. Let's use that instead of having it report Success in some cases but not set the XI86_CONFIGURED flag and thus signal an init failure. Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86Xinput.c | 52 --- hw/xfree86/common

[PATCH 07/19] xfree86: purge some unused defines.

2010-07-29 Thread Peter Hutterer
These defines have been write-only for a while now. Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86Xinput.h |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/common/xf86Xinput.h b/hw/xfree86/common/xf86Xinput.h index 3c1a147..1b71c64 100644 --- a/hw

[PATCH 06/19] input: Purge Register*Device() functions.

2010-07-29 Thread Peter Hutterer
RegisterPointerDevice() and RegisterKeyboardDevice() were already mapped to RegisterOtherDevice() and obsolete. RegisterOtherDevice() was called for all devices and the two assignments can simply be moved into AddInputDevice(). Purge RegisterOtherDevice() and pretend it never happened. *lalalalal

[PATCH 05/19] xfree86: remove superflous assignments.

2010-07-29 Thread Peter Hutterer
ActivateGrab and DeactivateGrab are set in AddInputDevice() already. Signed-off-by: Peter Hutterer --- hw/kdrive/src/kinput.c |4 hw/xfree86/common/xf86Xinput.c |2 -- 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/kdrive/src/kinput.c b/hw/kdrive/src/kinpu

[PATCH 04/19] xfree86: make xf86ActivateDevice static.

2010-07-29 Thread Peter Hutterer
No-one but the joystick driver uses it and that one should be using NIDR instead. Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86InPriv.h |3 --- hw/xfree86/common/xf86Xinput.c |2 +- hw/xfree86/common/xf86Xinput.h |1 - 3 files changed, 1 insertions(+), 5 deletions(-) diff

[PATCH 03/19] config: expose config_info as an input option.

2010-07-29 Thread Peter Hutterer
config_info is the only reliable indicator we have in the server for duplicate devices (drivers can test for maj/min on fds as well). Don't set this after the device has been initialized but assume it's important enough to set during NIDR. This makes the option "config_info" available to the drive

[PATCH 02/19] xfree86: rework driver PreInit API - XInput ABI 12

2010-07-29 Thread Peter Hutterer
The main change introduced in this patch is the removal of the back-and-forth between DDX and the driver. The DDX now allocates the InputInfoRec and fills it with default values. The DDX processes common options (and module-specific default options, if appropriate) before passing the initialised st

[PATCH 01/19] xfree86: fix compiler warning about implicied decl of DuplicateModule.

2010-07-29 Thread Peter Hutterer
../../../../hw/xfree86/common/xf86Xinput.c: In function ‘xf86AllocateInput’: ../../../../hw/xfree86/common/xf86Xinput.c:722: warning: implicit declaration of function ‘DuplicateModule’ ../../../../hw/xfree86/common/xf86Xinput.c:722: warning: nested extern declaration of ‘DuplicateModule’ ../../../.

[PATCH 00/19] Input driver API rework and cleanup

2010-07-29 Thread Peter Hutterer
As I have mentioned in the past, the input driver API is in need of a cleanup. For those easily amused, I recommend going through the input device addition process where one can find gimmicks such as the DIX calling the DDX which calls the driver to call back into the DDX to allocate a struct then

Re: [PATCH] Xserver-spec: Update ChangeGC prototype, add ChangeGCXIDs

2010-07-29 Thread Keith Packard
On Thu, 29 Jul 2010 21:44:50 -0700, Jamey Sharp wrote: > I didn't notice those had documentation. Good catch! > Reviewed-by: Jamey Sharp I'm gonna merge this to master tomorrow unless someone thinks that's a bad idea. -- keith.pack...@intel.com pgpUvahNXtMEr.pgp Description: PGP signature _

Re: [PATCH] Xserver-spec: Update ChangeGC prototype, add ChangeGCXIDs

2010-07-29 Thread Jamey Sharp
I didn't notice those had documentation. Good catch! Reviewed-by: Jamey Sharp On Thu, Jul 29, 2010 at 8:24 PM, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- >  doc/xml/Xserver-spec.xml |   13 ++--- >  1 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/d

Re: Implementing RandR support in xf86 video driver

2010-07-29 Thread Alex Deucher
On Thu, Jul 29, 2010 at 8:15 PM, sid baral wrote: > Dear All, > I am pretty new to X development. > I am trying to implement rotation and reflection of window using RandR in > xf86 video driver for our own chipset. We have our existing xf86 driver but > that does not do anything for r

[PATCH] Xserver-spec: Update ChangeGC prototype, add ChangeGCXIDs

2010-07-29 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- doc/xml/Xserver-spec.xml | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/doc/xml/Xserver-spec.xml b/doc/xml/Xserver-spec.xml index c5fd191..563705f 100644 --- a/doc/xml/Xserver-spec.xml +++ b/doc/xml/Xserver-spec.xml @@ -37

Re: [RFC] Refactoring of dix/dixutils.c

2010-07-29 Thread Fernando Carrijo
Peter Hutterer wrote: > Fernando Carrijo wrote: > > > > Would you guys mind if I chose /dix/core and /dix as the new homes for files > > related to the core protocol and the protocol support routines, > > respectively? > > Whenever possible, I prefer to avoid the names "utils" or "misc" for I

RE: How to add the screen resoution support in driver?

2010-07-29 Thread Huang, FrankR
Ajax, Very professional explanation to the question which I want. After looking at the Xorg.0.log and using xrandr to get the resolutions our driver supports, I know that EDID info is the primary source for the gnome-display-properfites applet. And after a look at the Xserver code

Re: [RFC] Refactoring of dix/dixutils.c

2010-07-29 Thread Peter Hutterer
On Thu, Jul 29, 2010 at 10:34:27PM -0300, Fernando Carrijo wrote: > Vignatti Tiago wrote: > > > Jamey Sharp wrote: > > > > > > The proposed "lookup.c" is mostly about protocol implementation, though, > > > and I'd be happy to see another patch after this series that reorganizes > > > dix/ to high

Re: [RFC] Refactoring of dix/dixutils.c

2010-07-29 Thread Fernando Carrijo
Vignatti Tiago wrote: > Jamey Sharp wrote: > > > > The proposed "lookup.c" is mostly about protocol implementation, though, > > and I'd be happy to see another patch after this series that reorganizes > > dix/ to highlight the protocol implementation bits. Perhaps a separate > > top-level proto/

Implementing RandR support in xf86 video driver

2010-07-29 Thread sid baral
Dear All, I am pretty new to X development. I am trying to implement rotation and reflection of window using RandR in xf86 video driver for our own chipset. We have our existing xf86 driver but that does not do anything for rotation or reflection. I studied some existing drivers(like t

[PATCH] os: Turn off the scheduler alarm after an arbitrary length of time

2010-07-29 Thread Adam Jackson
If we're stuck in some difficult bit of processing, there's no point in punishing the client too strongly. Worse, the continuous stream of SIGALRM shows up in strace and thus people report "infinite stream of SIGALRM" rather than whatever the bug actually is. So if we're more than 10x past the ma

Re: [PATCH] edid: Fix the HDTV sync pulse adjustment

2010-07-29 Thread Pat Kane
... and the excellent commit message at https://patchwork.kernel.org/patch/89095/ answers all my questions. On Thu, Jul 29, 2010 at 4:09 PM, Pat Kane wrote: > On Thu, Jul 29, 2010 at 12:25 PM, Adam Jackson wrote: > ... >> The corresponding kernel code is a bit cleaner, in that the math is all >>

Re: [PATCH] edid: Fix the HDTV sync pulse adjustment

2010-07-29 Thread Pat Kane
On Thu, Jul 29, 2010 at 12:25 PM, Adam Jackson wrote: ... > The corresponding kernel code is a bit cleaner, in that the math is all > in one place: > > http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=blob;f=drivers/gpu/drm/drm_edid.c;h=f87bf104df7a4cc79b2991759c88e00246cf64d4;hb=a4

Re: [PATCH v2] dix: Better document Dispatch(), WaitForSomething() and alike

2010-07-29 Thread Fernando Carrijo
Fernando Carrijo wrote: > Changelog for v3: Sorry, I meant v2, for sure. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] nls: Switch one of the interrobang sequences to gnaborretni

2010-07-29 Thread James Cloos
Makes sense. Reviewed-by: James Cloos -JimC -- James Cloos OpenPGP: 1024D/ED7DAEA6 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 2/2] dix: Fix indentation of code in WaitForSomething()

2010-07-29 Thread Fernando Carrijo
Reviewed-by: Jamey Sharp Signed-off-by: Fernando Carrijo --- os/WaitFor.c | 55 --- 1 files changed, 28 insertions(+), 27 deletions(-) diff --git a/os/WaitFor.c b/os/WaitFor.c index 66f67e5..14f9719 100644 --- a/os/WaitFor.c +++ b/os/WaitFo

[PATCH v2] dix: Better document Dispatch(), WaitForSomething() and alike

2010-07-29 Thread Fernando Carrijo
Changelog for v3: Amendments as suggested by Jamey and Tiago. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 1/2] dix: Better document Dispatch(), WaitForSomething() and alike

2010-07-29 Thread Fernando Carrijo
Wrote this patch more as an exercise than anything else. And while I realize that there's a thin line between what people consider benign and pernicious commenting styles, I tend to believe that in case of intricate code such as this, we better sin for verbiage than laconism. Some words I took str

Re: [PATCH xclock] Fix a crash on sparc64

2010-07-29 Thread Michael
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On Jul 29, 2010, at 3:54 PM, Alan Coopersmith wrote: Matthieu Herrb wrote: From 017b77fa3323f34f7cf09efbe0e3358a3ea733f8 Mon Sep 17 00:00:00 2001 From: David Coppa Date: Thu, 29 Jul 2010 21:46:11 +0200 Subject: [PATCH xclock] Fix a crash

Re: [PATCH xclock] Fix a crash on sparc64

2010-07-29 Thread Alan Coopersmith
Matthieu Herrb wrote: > From 017b77fa3323f34f7cf09efbe0e3358a3ea733f8 Mon Sep 17 00:00:00 2001 > From: David Coppa > Date: Thu, 29 Jul 2010 21:46:11 +0200 > Subject: [PATCH xclock] Fix a crash on sparc64. > > The pid variable that is passed to XChangeProperty() is not a long. > The libX11 code de

[PATCH xclock] Fix a crash on sparc64

2010-07-29 Thread Matthieu Herrb
>From 017b77fa3323f34f7cf09efbe0e3358a3ea733f8 Mon Sep 17 00:00:00 2001 From: David Coppa Date: Thu, 29 Jul 2010 21:46:11 +0200 Subject: [PATCH xclock] Fix a crash on sparc64. The pid variable that is passed to XChangeProperty() is not a long. The libX11 code deferences the variable as a long and

Re: Should _XIOError really exit() ?

2010-07-29 Thread Peter Harris
On 2010-07-29 14:37, Jeremy Huddleston wrote: > Should _XIOError in libX11 really exit() even if the developer > provides their own io error handler? That seems extreme and prevents > recovery. It took me quite a while to actually discover that I was > exiting at this point: The docs do say that

Re: Should _XIOError really exit() ?

2010-07-29 Thread Keith Packard
On Thu, 29 Jul 2010 11:37:12 -0700, Jeremy Huddleston wrote: > Should _XIOError in libX11 really exit() even if the developer > provides their own io error handler? That seems extreme and prevents > recovery. It took me quite a while to actually discover that I was > exiting at this point: We

[PULL] One more (hopefully last) XQuartz pull for 1.9

2010-07-29 Thread Jeremy Huddleston
This is a one-liner to properly exit the server. As it was before, the pbproxy thread (an X11 client) would exit() while the server was shutting down preventing cleanup of lockfiles and sockets in /tmp The following changes since commit 98f90145d786695ecbc02a667c6ffe7c619dc67e: XQuartz: GLX:

Should _XIOError really exit() ?

2010-07-29 Thread Jeremy Huddleston
Should _XIOError in libX11 really exit() even if the developer provides their own io error handler? That seems extreme and prevents recovery. It took me quite a while to actually discover that I was exiting at this point: (gdb) bt #0 0x7fff8673d3e3 in exit () #1 0x00010040c006 in _XI

Re: Resolution revert on application crash

2010-07-29 Thread Alan Coopersmith
Luke Benstead wrote: > I see. Who's in charge of adding to the RandR specification? Developers who submit patches to xorg-devel and get them accepted. -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System

Re: Resolution revert on application crash

2010-07-29 Thread Alex Deucher
On Thu, Jul 29, 2010 at 1:49 PM, Luke Benstead wrote: > > > On 29 July 2010 18:02, Alan Coopersmith wrote: >> >> Luke Benstead wrote: >> > Hi all, >> > >> > I did bring this issue up for discussion about a year ago here: >> > http://www.mail-archive.com/xorg-devel@lists.x.org/msg00832.html >> > >

Re: [PATCH] int10: Remove the vm86 and stub backends

2010-07-29 Thread Adam Jackson
On Wed, 2010-07-28 at 11:35 -0400, Alex Deucher wrote: > On Wed, Jul 28, 2010 at 11:29 AM, Alan Coopersmith > wrote: > > Isn't vm86 even further limited to just those machines running the Linux > > kernel, not BSD or Solaris or anything else? (Okay, maybe that doesn't > > take a huge chunk out o

Re: Resolution revert on application crash

2010-07-29 Thread Luke Benstead
On 29 July 2010 18:02, Alan Coopersmith wrote: > Luke Benstead wrote: > > Hi all, > > > > I did bring this issue up for discussion about a year ago here: > > http://www.mail-archive.com/xorg-devel@lists.x.org/msg00832.html > > > > But that thread sort of died, and this is still an issue. There is

Re: [PATCH] ddc: Fix memory leak in GetEDID_DDC1

2010-07-29 Thread Adam Jackson
On Tue, 2010-07-27 at 23:32 -0400, Matt Turner wrote: > Mark argument to DDC_checksum as const too. > > Signed-off-by: Matt Turner Not that anyone should ever hit the DDC1 path, but: Reviewed-by: Adam Jackson - ajax signature.asc Description: This is a digitally signed message part

Re: How to add the screen resoution support in driver?

2010-07-29 Thread Adam Jackson
On Wed, 2010-07-28 at 09:09 +0800, Huang, FrankR wrote: > Have a question to ask: > We want to support some wide-screen resolutions in our platform under > linux. And we hope that can be recognized in the applet > Preferences->Display->Resolution. > Can you tell me what the mechanism in that? That

Re: [PATCH] edid: Fix the HDTV sync pulse adjustment

2010-07-29 Thread Adam Jackson
On Tue, 2010-07-27 at 19:20 -0500, Pat Kane wrote: > Reviewed-by: Patrick E. Kane > > The lines of context appear to show that both hsize and vsize are being > changed, could include a comment to explain why only HSync* needs to > be adjusted? This quirk only happens for standard mode codes, whi

Re: [PATCH] dix: Better document the functions Dispatch(), WaitForSomething() and alike.

2010-07-29 Thread Fernando Carrijo
Tiago Vignatti wrote: > On Wed, Jul 28, 2010 at 10:26:34PM +0200, ext Fernando Carrijo wrote: > > +/* clientReady: > > + * array of clients ready for input and/or output. Actually, the > > + * array is not composed of clients, but of the indexes they occupy > > + * in the global variable cl

Re: Resolution revert on application crash

2010-07-29 Thread Alan Coopersmith
Luke Benstead wrote: > Hi all, > > I did bring this issue up for discussion about a year ago here: > http://www.mail-archive.com/xorg-devel@lists.x.org/msg00832.html > > But that thread sort of died, and this is still an issue. There is a bug > report for it here: https://bugs.freedesktop.org/sho

Re: [PATCH] dix: Better document the functions Dispatch(), WaitForSomething() and alike.

2010-07-29 Thread Fernando Carrijo
Jamey Sharp wrote: > On Wed, Jul 28, 2010 at 05:26:34PM -0300, Fernando Carrijo wrote: > > --- > > Wrote this patch more as an exercise than anything else. And while I > > realize that there's a thin line between what people consider benign > > and pernicious commenting styles, I tend to believe

[PATCH xf86-video-trident] Fix up deprecated/obsolete code.

2010-07-29 Thread Trevor Woerner
From: Trevor Woerner The compile issues several warnings regarding obsolete or deprecated code (moving away from Xalloc(), Xcalloc(), Xfree() etc...). This change removes all such warnings. Signed-off-by: Trevor Woerner --- src/trident_dga.c|6 +++--- src/trident_driver.c | 18 ++

Resolution revert on application crash

2010-07-29 Thread Luke Benstead
Hi all, I did bring this issue up for discussion about a year ago here: http://www.mail-archive.com/xorg-devel@lists.x.org/msg00832.html But that thread sort of died, and this is still an issue. There is a bug report for it here: https://bugs.freedesktop.org/show_bug.cgi?id=14255 I've been tryin

Resolution revert on application crash

2010-07-29 Thread Luke Benstead
Hi all, I did bring this issue up for discussion about a year ago here: http://www.mail-archive.com/xorg-devel@lists.x.org/msg00832.html But that thread sort of died, and this is still an issue. There is a bug report for it here: https://bugs.freedesktop.org/show_bug.cgi?id=14255 I've been tryin

[PATCH] nls: Switch one of the interrobang sequences to gnaborretni

2010-07-29 Thread Adam Jackson
Since gnaborretni is primarily used in LTR locales, the ? part of the sequence reflects the position of the bulge in the ?. When scanning an inverted interrobang left-to-right, you see the bulge first, so the compose sequence ?! is used; upright interrobang shows the bulge last, so it's !?. This

Re: Multikey autorepetition

2010-07-29 Thread Éric Piel
Op 28-07-10 11:43, Антон Ерофеевский schreef: : > Has decided to write for this purpose - that most to understand - > whether is it in linux a defect or and has been conceived > > The basic question in that is that if to press 2 keys - why one > repeats only? Hei, I like very much this idea. Indee

Re: [PATCH] dix: Better document the functions Dispatch(), WaitForSomething() and alike.

2010-07-29 Thread Tiago Vignatti
On Wed, Jul 28, 2010 at 10:26:34PM +0200, ext Fernando Carrijo wrote: > Signed-off-by: Fernando Carrijo > --- > Wrote this patch more as an exercise than anything else. And while I > realize that there's a thin line between what people consider benign > and pernicious commenting styles, I tend to

Re: [RFC] Refactoring of dix/dixutils.c

2010-07-29 Thread Vignatti Tiago (Nokia-MS/Helsinki)
On Thu, Jul 29, 2010 at 05:59:06AM +0200, ext Jamey Sharp wrote: > > The proposed "lookup.c" is mostly about protocol implementation, though, > and I'd be happy to see another patch after this series that reorganizes > dix/ to highlight the protocol implementation bits. Perhaps a separate > top-le