[PATCH:libX11] Mark atom names argument to XInternAtoms as const

2010-11-22 Thread Alan Coopersmith
Updates code docs for XInternAtoms. The single atom name argument to XInternAtom was already const char * in the code, but not the docs, so updated it in the docs too. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- include/X11/Xlib.h|2 +- man/XInternAtom.man |8

Where to free screen pixmap driver private?

2010-11-22 Thread fancy fang
Dear all, If I use driver pixmap, the screen pixmap also has an allocated driver private. However, when xorg terminates, the driver DestroyPixmap can not be executed. So, the screen pixmap driver private can not be freed. Is this a bug? Can anyone explain it? Thanks a lot! Best

Re: tiling support in EXA

2010-11-22 Thread fancy fang
Thanks a lot! This is very useful. Best wishes, Fancy 2010/10/20 Alex Deucher alexdeuc...@gmail.com On Tue, Oct 19, 2010 at 9:58 PM, fancy fang fancyfl...@gmail.com wrote: Hello, all CreatePixmap2 was added to ExaDriverRec for drivers with tiling support. I can not understand

Re: [PATCH:libfontenc] Fail configure if zlib.h -lz not found

2010-11-22 Thread Dan Nicholson
On Sun, Nov 21, 2010 at 6:28 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Dan Nicholson wrote: On Sun, Nov 21, 2010 at 2:59 PM, Rémi Cardona r...@gentoo.org wrote: Le 20/11/2010 07:04, Alan Coopersmith a écrit :  # zlib - -AC_CHECK_LIB(z, gzclose) +AC_CHECK_HEADER([zlib.h], [],

[PATCH RESEND app-xdm 0/9] Review xdm configuration - Part 4

2010-11-22 Thread Gaetan Nadon
This set reworks selinux, pam, arc4random and dev/random consistently using pre-searched system libs in $LIBS. Comment and relocate some config fragments. Gaetan Nadon (9): config: isolating -lselinux to a single target is not required config: upgrade the checking for PAM support config:

[PATCH app-xdm 1/9] config: isolating -lselinux to a single target is not required

2010-11-22 Thread Gaetan Nadon
Due to previous patches, -lselinux, if installed on the configured system, is included in $LIBS already. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index

[PATCH app-xdm 2/9] config: upgrade the checking for PAM support

2010-11-22 Thread Gaetan Nadon
Use AC_CHECK_FUNCS to get the consistent #define HAVE_xxx Use auto rather than try for consistency with other modules. Update help string to mention default value. Unchanged: if configured --with-pam and -lpam is misisng, abort the configuration. Signed-off-by: Gaetan Nadon mems...@videotron.ca

[PATCH app-xdm 5/9] config: rework check for random number generator

2010-11-22 Thread Gaetan Nadon
Following a similar pattern to PAM and SELinux checks. Unchanged: if a user has requested the use of a random device and none can be found, the configuration aborts. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac | 36 +++- 1 files changed, 15

[PATCH app-xdm 6/9] config: comment libxtrans macros as they are order sensitive

2010-11-22 Thread Gaetan Nadon
XTRANS_SECURE_RPC_FLAGS must be called after XTRANS_CONNECTION_FLAGS which finds libraries like -lsockect, -lnsl or -lws32_32. The found libraries are pre-pended to $LIBS which is not obvious. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |4 +++- 1 files changed, 3

[PATCH app-xdm 7/9] config: relocate AC_FUNC_FORK in section Check for system library functions

2010-11-22 Thread Gaetan Nadon
No configuration changes. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 70d5676..59bc5ee 100644 --- a/configure.ac +++ b/configure.ac @@ -88,16 +88,12 @@

[PATCH app-xdm 8/9] config: relocate key_setnet in section Check for header files

2010-11-22 Thread Gaetan Nadon
No configuration changes Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 59bc5ee..7781034 100644 --- a/configure.ac +++ b/configure.ac @@ -84,6 +84,13 @@

[PATCH app-xdm 9/9] config: use AM_V_GEN instead of customized macros for AM_SILENT_RULES

2010-11-22 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon mems...@videotron.ca --- config/Makefile.am |2 +- configure.ac |3 --- cpprules.in|9 + 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/config/Makefile.am b/config/Makefile.am index d13645f..30e22ea 100644 ---

[PATCH app-xdm 00/16] Review xdm configuration - Part 5

2010-11-22 Thread Gaetan Nadon
This series refactors common header files in an include directory and moves each target in its own directory. Gaetan Nadon (7): config: move man pages into their own directory config: move chooser into its own directory config: move xdmshell into its own directory config: move common

[PATCH app-xdm 1/5] config: move man pages into their own directory

2010-11-22 Thread Gaetan Nadon
Replace lowercase $(xdmlibdir) with $(XXDMLIBDIR) Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Makefile.am | 37 ++- configure.ac |6 +++- man/Makefile.am | 55

[PATCH app-xdm 2/5] config: move chooser into its own directory

2010-11-22 Thread Gaetan Nadon
Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- .gitignore |1 - Makefile.am| 23 +-- chooser/.gitignore |1 +

[PATCH app-xdm 3/5] config: move xdmshell into its own directory

2010-11-22 Thread Gaetan Nadon
Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- .gitignore|1 - Makefile.am | 21 ++--- configure.ac |

[PATCH app-xdm 5/5] config: mv xdm in its own directory

2010-11-22 Thread Gaetan Nadon
Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- .gitignore |5 +-- Makefile.am | 60 +-- configure.ac |1 +

[PATCH app-xdm 6/7] config: move appdefault makefile to app-defaults dir.

2010-11-22 Thread Gaetan Nadon
For this package it is best not to break the pattern of each directory having its own makefile. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Makefile.am |8 +++- app-defaults/Makefile.am |1 + configure.ac |1 + 3 files changed, 5 insertions(+), 5

[PATCH app-xdm 7/7] config: AM_PROG_CC_C_O is no longer needed

2010-11-22 Thread Gaetan Nadon
All per-target flags have been removed now that each target sits in its own directory. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 41220d1..8b90cb6 100644 ---

Re: [PATCH RESEND app-xdm 0/9] Review xdm configuration - Part 4

2010-11-22 Thread Mikhail Gusarov
Twas brillig at 10:32:10 22.11.2010 UTC-05 when mems...@videotron.ca did gyre and gimble: GN This set reworks selinux, pam, arc4random and dev/random GN consistently using pre-searched system libs in $LIBS. Comment and GN relocate some config fragments. For the series: Reviewed-by: Mikhail

Re: [PATCH] test: compare byte padding macros against the expected bytes.

2010-11-22 Thread Julien Cristau
On Fri, Nov 19, 2010 at 11:26:13 +1000, Peter Hutterer wrote: We calculate the expected bytes for each value, let's use it. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/input.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) Reviewed-by: Julien Cristau

Re: [PATCH] test: reduce range of byte-padding macro tests.

2010-11-22 Thread Julien Cristau
On Fri, Nov 19, 2010 at 11:38:03 +1000, Peter Hutterer wrote: Byte padding and conversion is interesting for the rage of 0-8 bytes, and then interesting towards the end of the valid range (INT_MAX - 7 and INT_MAX - 3). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- This

Re: [PATCH app-xdm 2/9] config: upgrade the checking for PAM support

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: + [Use PAM for authentication (default is autodected)]), s/autodected/autodetected/ -# ifdef USE_PAM +# ifdef HAVE_PAM_OPEN_SESSION USE_PAM really does seem more descriptive in this case than HAVE_PAM_OPEN_SESSION though, since it's the whole framework we care about

Re: [PATCH app-xdm 4/9] config: integrate check for arc4random in appropriate sections

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: The AC_SEARCH_LIBS is done in Check for libraries section. Move AC_SUBST and AM_CONDITIONAL over there as well. Move AC_CHECK_FUNCS for arc4random to library functions section No function change. Signed-off-by: Gaetan Nadon mems...@videotron.ca Reviewed-by: Alan

Re: [PATCH app-xdm 5/9] config: rework check for random number generator

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: Following a similar pattern to PAM and SELinux checks. Unchanged: if a user has requested the use of a random device and none can be found, the configuration aborts. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac | 36

Re: [PATCH app-xdm 7/9] config: relocate AC_FUNC_FORK in section Check for system library functions

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: No configuration changes. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 70d5676..59bc5ee 100644 --- a/configure.ac +++

Re: [PATCH app-xdm 6/9] config: comment libxtrans macros as they are order sensitive

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: XTRANS_SECURE_RPC_FLAGS must be called after XTRANS_CONNECTION_FLAGS which finds libraries like -lsockect, -lnsl or -lws32_32. s/-lsockect/-lsocket/ The found libraries are pre-pended to $LIBS which is not obvious. Signed-off-by: Gaetan Nadon mems...@videotron.ca ---

Re: [PATCH app-xdm 9/9] config: use AM_V_GEN instead of customized macros for AM_SILENT_RULES

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: Signed-off-by: Gaetan Nadon mems...@videotron.ca --- config/Makefile.am |2 +- configure.ac |3 --- cpprules.in|9 + 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/config/Makefile.am b/config/Makefile.am index

Re: [PATCH app-xdm 2/5] config: move chooser into its own directory

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- .gitignore |1 - Makefile.am| 23 +--

Re: [PATCH app-xdm 3/5] config: move xdmshell into its own directory

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Signed-off-by: Gaetan Nadon mems...@videotron.ca Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith-alan.coopersm...@oracle.com

Re: [PATCH app-xdm 4/5] config: move common headers into the include directory

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: They provide interfaces to multiple executables Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Makefile.am| 10 +++--- chooser/Makefile.am|2 +- configure.ac |1 + greeter/Makefile.am

Re: [PATCH xserver (rev2) 1/9] Create/Destroy/Trigger/Reset Fence Sync objects

2010-11-22 Thread Adam Jackson
Reviewed-by: Adam Jackson a...@redhat.com for the series. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

xinput/evdev switch events+state

2010-11-22 Thread Rafi Rubin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Some tablets (such as dell and hp) report hinge rotation as EV_SW events. Does it make sense to handle events and state in the X evdev driver and xinput? Rafi -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with

[PATCH xinit] Minor typo

2010-11-22 Thread Matthieu Herrb
From: Tom Doherty t...@singlesecond.com Date: Mon, 22 Nov 2010 21:27:13 +0100 Subject: [PATCH] Minor typo. Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- xinit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xinit.c b/xinit.c index dd4e0a2..1aafbd9 100644

Re: [PATCH xinit] Minor typo

2010-11-22 Thread Alan Coopersmith
Matthieu Herrb wrote: From: Tom Doherty t...@singlesecond.com Date: Mon, 22 Nov 2010 21:27:13 +0100 Subject: [PATCH] Minor typo. Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- xinit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xinit.c b/xinit.c

Re: [PATCH app-xdm 7/7] config: AM_PROG_CC_C_O is no longer needed

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: All per-target flags have been removed now that each target sits in its own directory. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [PATCH app-xdm 6/7] config: move appdefault makefile to app-defaults dir.

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: For this package it is best not to break the pattern of each directory having its own makefile. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Makefile.am |8 +++- app-defaults/Makefile.am |1 + configure.ac |1 + 3

Re: [PATCH app-xdm 5/5] config: mv xdm in its own directory

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- .gitignore |5 +-- Makefile.am | 60 +--

Re: [PATCH app-xdm 1/5] config: move man pages into their own directory

2010-11-22 Thread Alan Coopersmith
Gaetan Nadon wrote: Replace lowercase $(xdmlibdir) with $(XXDMLIBDIR) s/XXDM/XDM/ Other than that, Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System

[PATCH] xfree86: Remove the xf8_16bpp overlay module

2010-11-22 Thread Adam Jackson
Only one (marginal) driver was using it, and it's been fixed to just implement it directly. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac|1 - hw/xfree86/Makefile.am |4 +- hw/xfree86/xf8_16bpp/Makefile.am| 11 -

Re: [PATCH:libX11] Mark atom names argument to XInternAtoms as const

2010-11-22 Thread Peter Hutterer
On Mon, Nov 22, 2010 at 12:04:04AM -0800, Alan Coopersmith wrote: Updates code docs for XInternAtoms. The single atom name argument to XInternAtom was already const char * in the code, but not the docs, so updated it in the docs too. Signed-off-by: Alan Coopersmith

Re: [PATCH] glx: Remove swap barrier and hyperpipe support

2010-11-22 Thread Mario Kleiner
On 11/19/2010 07:52 PM, Adam Jackson wrote: Never implemented in any open source driver. The implementation assumed explicit DDX driver knowledge of how the client-side driver worked, since at the time the server's GL renderer was not a DRI driver. But now, it is, so any implementation of these

[PATCH libICE docs] Add top-level target for documentation.

2010-11-22 Thread Trevor Woerner
From: Trevor Woerner twoer...@gmail.com Builds user and developer documentation/specifications. Signed-off-by: Trevor Woerner twoer...@gmail.com --- Makefile.am |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index c2110ec..d0102e8 100644

Re: xinput/evdev switch events+state

2010-11-22 Thread Peter Hutterer
On Mon, Nov 22, 2010 at 01:53:22PM -0500, Rafi Rubin wrote: Some tablets (such as dell and hp) report hinge rotation as EV_SW events. Does it make sense to handle events and state in the X evdev driver and xinput? yes, but I don't think button events are the right method for this. in the XI2

Re: [PATCH] glx: Remove swap barrier and hyperpipe support

2010-11-22 Thread Adam Jackson
On Mon, 2010-11-22 at 23:16 +0100, Mario Kleiner wrote: On 11/19/2010 07:52 PM, Adam Jackson wrote: Never implemented in any open source driver. The implementation assumed explicit DDX driver knowledge of how the client-side driver worked, since at the time the server's GL renderer was not

Re: [PATCH libICE docs] Add top-level target for documentation.

2010-11-22 Thread Julien Cristau
On Mon, Nov 22, 2010 at 17:26:38 -0500, Trevor Woerner wrote: From: Trevor Woerner twoer...@gmail.com Builds user and developer documentation/specifications. Signed-off-by: Trevor Woerner twoer...@gmail.com --- Makefile.am |7 ++- 1 files changed, 6 insertions(+), 1

Re: [PATCH libICE docs] Add top-level target for documentation.

2010-11-22 Thread Trevor Woerner
On Mon, Nov 22, 2010 at 7:21 PM, Gaetan Nadon mems...@videotron.ca wrote: On Mon, 2010-11-22 at 17:26 -0500, Trevor Woerner wrote: -.PHONY: ChangeLog INSTALL +.PHONY: ChangeLog INSTALL documents I don't think it should be a PHONY target, documents is not a file. It's like the lint target. I

[PATCH 1/6] dix: replace a manual valuator check with valuator_get_mode().

2010-11-22 Thread Peter Hutterer
This check was missing the OutOfProximity mask and resulted in the wrong bits being set in InternalEvents. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/getevents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index

[PATCH 2/6] dix: when comparing axis modes, compare the bits, not the bytes.

2010-11-22 Thread Peter Hutterer
The DeviceEvent's mode field is a set of bits for each valuator, not bytes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/eventconvert.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dix/eventconvert.c b/dix/eventconvert.c index 46eb4ff..b92169e

[PATCH 3/6] dix: when converting to XI 1.x events, use the first_valuator's device mode

2010-11-22 Thread Peter Hutterer
Don't stop processing events when a valuator's mode doesn't match the 0th valuator's mode. Instead, start with the first_valuator in the event and keep stacking them on until the first valuator with a different mode is hit. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---

[PATCH 4/6] dix: GetProximityEvents needs to check up to the last valuator

2010-11-22 Thread Peter Hutterer
valuator_mask_size() returns the highest valuator set as opposed to the number of set bits (which obviously changes as we unset valuators). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/getevents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 5/6] dix: fix typo, set the second valuator with the y-axis data.

2010-11-22 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Tested-by: Jeremy Huddleston jerem...@apple.com --- dix/getevents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index f80e87c..f19c991 100644 --- a/dix/getevents.c +++

[PATCH 6/6] dix: add a fixme about a corner-case that should probably be fixed.

2010-11-22 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/getevents.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index f19c991..0d59290 100644 --- a/dix/getevents.c +++ b/dix/getevents.c @@ -1255,6 +1255,10 @@

Re: [PATCH] Build libxf86config with -fPIC.

2010-11-22 Thread Peter Hutterer
On Mon, Nov 15, 2010 at 04:11:11PM -0800, Dan Nicholson wrote: On Mon, Nov 15, 2010 at 10:38 AM, Julien Cristau jcris...@debian.org wrote: On Mon, Nov 15, 2010 at 13:28:34 -0500, Gaetan Nadon wrote: On Mon, 2010-11-15 at 15:35 +0100, Julien Cristau wrote: If you want to install it as a

Re: [RFC XI 2.1 - inputproto] Various fixes in response to Peter Hutterer's review

2010-11-22 Thread Peter Hutterer
On Fri, Nov 19, 2010 at 01:52:39PM -0500, Chase Douglas wrote: --- Normally I'd just squash this in and make a v2 patch, but this is the most important part of the MT work and it's easier to review separately :). I'll squash later. XI2.h|3 +++ XI2proto.txt | 39