Re: [PATCH:libXmu] XmuCvtStringToCursor: sprintf - snprintf check for XtMalloc failure

2010-12-06 Thread walter harms
Am 05.12.2010 23:53, schrieb Julien Cristau: On Sun, Dec 5, 2010 at 21:43:50 +0100, walter harms wrote: Can you use XFNasprintf() here ? libXmu is not the X server. That does not mean not to use helper from the server side. Otherwise you would have to reimplement everything also in the

Re: [PATCH v4 6/7] Replace alloc+strcpy+strcat with asprintf() XNFasprintf() calls

2010-12-06 Thread Alan Coopersmith
walter harms wrote: Am 05.12.2010 18:51, schrieb Alan Coopersmith: diff --git a/hw/xfree86/common/xf86ShowOpts.c b/hw/xfree86/common/xf86ShowOpts.c index ce86090..c0fa80a 100644 --- a/hw/xfree86/common/xf86ShowOpts.c +++ b/hw/xfree86/common/xf86ShowOpts.c @@ -97,11 +97,8 @@ void

Re: [PATCH xrdb] predefined cpp macros can produce unexpected results (bug 3413)

2010-12-06 Thread Alan Coopersmith
Matthieu Herrb wrote: You loose, but iirc Solaris or other cpp I know of don't pre-define any macro. They do - it's always fun explaining to people why they get Welcome to 1 on the xdm login screen when they name their host sun or similar variants. On the other hand, some people do want to

Re: Reviewed patches from the Ubuntu tree

2010-12-06 Thread Alan Coopersmith
Christopher James Halse Rogers wrote: I've been cleaning up the Ubuntu X packages, and I've run across some patches that have been reviewed some time ago but aren't yet in master. Resending them, since I've clearly dropped them on the floor at one point. If they're for X server, don't forgot

Re: [PATCH:libXmu] XmuCvtStringToCursor: sprintf - snprintf check for XtMalloc failure

2010-12-06 Thread Alan Coopersmith
walter harms wrote: Am 05.12.2010 23:53, schrieb Julien Cristau: On Sun, Dec 5, 2010 at 21:43:50 +0100, walter harms wrote: Can you use XFNasprintf() here ? libXmu is not the X server. That does not mean not to use helper from the server side. Otherwise you would have to reimplement

XInput2 Raw Messages

2010-12-06 Thread Patrick Baggett
I'm using Ubuntu 10.10 and testing out some examples using XI2. I don't appear to be getting all the raw messages I've selected however, and I can't explain why. I've attached a program that demonstrates my problem. I can only get the XI_RawMotion and XI_RawButtonPress events to show up when I

Re: [PATCH] Fixes v5: Cursor barriers

2010-12-06 Thread Owen Taylor
Reviewed-by: Owen Taylor otay...@fishsoup.net This looks good to me - it look like it is sufficient to meet the need of making easy-to-hit hot corners on a multi-head displays with a good amount of flexibility but without adding a lot of unmotivated complexity. Creating barriers relative to any

Re: [PATCH v4 6/7] Replace alloc+strcpy+strcat with asprintf() XNFasprintf() calls

2010-12-06 Thread walter harms
Am 06.12.2010 09:34, schrieb Alan Coopersmith: walter harms wrote: Am 05.12.2010 18:51, schrieb Alan Coopersmith: diff --git a/hw/xfree86/common/xf86ShowOpts.c b/hw/xfree86/common/xf86ShowOpts.c index ce86090..c0fa80a 100644 --- a/hw/xfree86/common/xf86ShowOpts.c +++

Re: [PATCH] xfree86: Allow InputClass entries to specify match type

2010-12-06 Thread Dan Nicholson
On Sun, Dec 5, 2010 at 9:29 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Dec 02, 2010 at 06:19:15AM -0800, Dan Nicholson wrote: The InputClass Match* entries are currently hardwired to offer a certain variant of comparison for matching. For example, the MatchProduct entry uses

Re: [PATCH 1/6 v2] Add X*asprintf() routines to mirror common asprintf() routines

2010-12-06 Thread Daniel Stone
On Fri, Dec 03, 2010 at 09:57:42AM -0800, Alan Coopersmith wrote: I can wrap in in #ifndef HAVE_ASPRINTF but then either have to guess which autoconf header to include for that (dix-config.h in most of the server, xorg-server.h in drivers) or require all callers to include it in an appropriate

Re: [PATCH] xfree86: use xf86AllocateInput() for xorg.conf devices too.

2010-12-06 Thread Dan Nicholson
On Sun, Dec 5, 2010 at 9:08 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Single allocation point for input devices, most notably a single point to reset default values. Without this patch, the file descriptor default was -1 for hotplugged devices and 0 for config devices. Drivers that

Re: [PATCH] xfree86: don't overwrite option list (#32115)

2010-12-06 Thread Dan Nicholson
On Sun, Dec 5, 2010 at 9:07 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Options set in the configuration file were unconditionally overwritten by the server. Merge the already existing options and the new options together instead of just overwriting ones. The iref_option_lst only

Re: [PATCH] Fixes v5: Cursor barriers

2010-12-06 Thread Adam Jackson
On Mon, 2010-12-06 at 06:27 -0500, Owen Taylor wrote: Reviewed-by: Owen Taylor otay...@fishsoup.net This looks good to me - it look like it is sufficient to meet the need of making easy-to-hit hot corners on a multi-head displays with a good amount of flexibility but without adding a lot of

Re: [PATCH] Fixes v5: Cursor barriers

2010-12-06 Thread Owen Taylor
On Mon, 2010-12-06 at 09:41 -0500, Adam Jackson wrote: On Mon, 2010-12-06 at 06:27 -0500, Owen Taylor wrote: Reviewed-by: Owen Taylor otay...@fishsoup.net This looks good to me - it look like it is sufficient to meet the need of making easy-to-hit hot corners on a multi-head displays

Re: Re:What's the meaning of XSyncAlarmNotify ?

2010-12-06 Thread Daniel Stone
Hi, On Mon, Dec 06, 2010 at 11:53:37AM +0800, danny wrote: And why sometimes the xevent-type is not right? (if the event_base = 96 , then sometimes the xevent-type always be 98 but not 97) Sometimes before always sounds pretty confusing to me. :) Those codes are from gnome-power-manager

Re: [PATCH libxkbcommon 0/6] Upgrade configuration to current X.Org standards - Part 1

2010-12-06 Thread Daniel Stone
On Fri, Dec 03, 2010 at 03:40:16PM -0500, Gaetan Nadon wrote: This initial set of patches brings the module to a partial working state as outlined in the New Modules Guidelines http://wiki.x.org/wiki/NewModuleGuidelines. The distcheck target is still failing and will be addressed later.

Re: Sprite transforms in RandR

2010-12-06 Thread Daniel Stone
Hi, On Sun, Dec 05, 2010 at 06:15:04PM -0800, Keith Packard wrote: On Sun, 5 Dec 2010 16:38:52 -0800, Aaron Plattner aplatt...@nvidia.com wrote: The actual text sounds reasonable to me, but it's not clear what the 'rotations' field of RRCreateScanoutPixmap is used for. Is it a set of

Re: [PATCH evdev] Return error codes from EvdevOpenDevice()

2010-12-06 Thread Daniel Stone
On Mon, Dec 06, 2010 at 03:01:11PM +1000, Peter Hutterer wrote: The server's behaviour is to stop adding new devices when a BadAlloc occurs on any device (on the assumption that new devices won't magically have more memory). Change EvdevOpenDevice() to return an error code of BadValue when it

Re: [PATCH] xfree86: use xf86AllocateInput() for xorg.conf devices too.

2010-12-06 Thread Daniel Stone
On Mon, Dec 06, 2010 at 03:08:56PM +1000, Peter Hutterer wrote: Single allocation point for input devices, most notably a single point to reset default values. Without this patch, the file descriptor default was -1 for hotplugged devices and 0 for config devices. Drivers that don't overwrite

Re: [PATCH] xfree86: add option Floating, deprecate SendCoreEvents and friends.

2010-12-06 Thread Daniel Stone
On Mon, Dec 06, 2010 at 05:02:03PM +1000, Peter Hutterer wrote: On Mon, Dec 06, 2010 at 04:50:17PM +1000, Peter Hutterer wrote: Some devices should be initialised as floating from the start (e.g. Joysticks and accelerometers benefit from this). Currently users use the SendCoreEvents off

[PATCH libSM] Export only public API symbols

2010-12-06 Thread Cristian Rodríguez
Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 1098679..d194d3f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -6,7 +6,7 @@ if

[PATCH libFS] Export only public API symbols

2010-12-06 Thread Cristian Rodríguez
Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 103..ed70165 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -35,7 +35,7 @@

[PATCH] Export only public API symbols

2010-12-06 Thread Cristian Rodríguez
Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index fd508da..744ee13 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -12,7 +12,7 @@ AM_CFLAGS

[PATCH libXScrnSaver] Export only public API symbols

2010-12-06 Thread Cristian Rodríguez
Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index aa923b1..e8c43a0 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -12,7 +12,7 @@

Re: Sprite transforms in RandR

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 15:20:01 +, Daniel Stone dan...@fooishbar.org wrote: Nope, we don't have any per-CRTC differences there, it's just that rotation is essentially another property of the mode that we need to know about in order to set up both the CRTC and the underlying surfaces, rather

Re: [PATCH] xfree86: don't overwrite option list (#32115)

2010-12-06 Thread David Ronis
I applied the patches and the problem is gone. Thanks David On Mon, 2010-12-06 at 05:59 -0800, Dan Nicholson wrote: On Sun, Dec 5, 2010 at 9:07 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Options set in the configuration file were unconditionally overwritten by the server. Merge

[PATCH libfontenc] Export only public API symbols

2010-12-06 Thread Cristian Rodríguez
Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 96d0a38..d4d613a 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -17,7 +17,7 @@ INCLUDES =

Re: [PATCH] RandR version 1.4 additions

2010-12-06 Thread Aaron Plattner
On Sun, Dec 05, 2010 at 08:43:07PM -0800, Keith Packard wrote: On Sun, 5 Dec 2010 16:38:52 -0800, Aaron Plattner aplatt...@nvidia.com wrote: This adds the specification and protocol header definitions for the RandR 1.4 protocol changes, including * Per crtc pixmaps and pixmap origins

Re: Sprite transforms in RandR

2010-12-06 Thread Aaron Plattner
On Sun, Dec 05, 2010 at 08:47:15PM -0800, Keith Packard wrote: On Sun, 5 Dec 2010 16:38:52 -0800, Aaron Plattner aplatt...@nvidia.com wrote: The crtc shadow functions seem obsolete given the new scanout pixmap creation function, but they can be removed in a later ABI. So, I was

Re: Sprite transforms in RandR

2010-12-06 Thread Aaron Plattner
On Sun, Dec 05, 2010 at 06:17:12PM -0800, Keith Packard wrote: On Sun, 5 Dec 2010 16:42:43 -0800, Aaron Plattner aplatt...@nvidia.com wrote: Unless it's very generic or just a string to present to the user, I don't think trying to encode this in the protocol is going to be reasonable. We

Re: [RFC XI 2.1 - xf86-input-evdev 2/3] Add experimental XI 2.1 multitouch support

2010-12-06 Thread Chase Douglas
On 12/05/2010 10:41 PM, Peter Hutterer wrote: if the kernel can send it through one device, we can handle it, right? if both are sent through the same axes (and need a serial or something to differentiate like the wacom drivers) then yes, they need to be split up into multiple devices. I

Re: libpciaccess bogus bridge data - commit 2bda5b73

2010-12-06 Thread Jesse Barnes
On Wed, 1 Dec 2010 18:54:22 -0800 Bryce Harrington br...@canonical.com wrote: Jesse, I have a question about change 2bda5b73 that you did to libpciaccess last year, to stop pci_device_get_bridge_buses() from looking at bus data if the bridge data was not read. A ubuntu bug reporter says

Re: Sprite transforms in RandR

2010-12-06 Thread Aaron Plattner
On Mon, Dec 06, 2010 at 08:44:41AM -0800, Keith Packard wrote: On Mon, 6 Dec 2010 15:20:01 +, Daniel Stone dan...@fooishbar.org wrote: Nope, we don't have any per-CRTC differences there, it's just that rotation is essentially another property of the mode that we need to know about in

Re: [PATCH 1/2] Whitespace cleanups in randrproto.txt

2010-12-06 Thread Gaetan Nadon
On Sun, 2010-12-05 at 20:39 -0800, Keith Packard wrote: @@ -29,14 +29,14 @@ protocol described here, as it has been overtaken by events. These events include: ► Modern toolkits (in this case, GTK+ 2.x) have progressed to the point -of implementing migration between

Re: [PATCH] RandR version 1.4 additions

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 09:20:29 -0800, Aaron Plattner aplatt...@nvidia.com wrote: I don't see a corresponding #undef PictFormat. Nice catch. This still causes pangs of worry that it's going to cause some weird interaction problem down the road with features like stereo or overlays or whatever,

Re: [PULL] DRI2 fixes and extensions

2010-12-06 Thread Jesse Barnes
On Wed, 24 Nov 2010 11:21:18 -0800 Keith Packard kei...@keithp.com wrote: On Fri, 5 Nov 2010 11:25:00 +0200, Pauli Nieminen ext-pauli.niemi...@nokia.com wrote: Pauli Nieminen (5): DRI2: Avoid call to NULL pointer DRI2: Add error message when working around driver bug

Re: Sprite transforms in RandR

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 09:42:24 -0800, Aaron Plattner aplatt...@nvidia.com wrote: On Mon, Dec 06, 2010 at 08:44:41AM -0800, Keith Packard wrote: On Mon, 6 Dec 2010 15:20:01 +, Daniel Stone dan...@fooishbar.org wrote: Nope, we don't have any per-CRTC differences there, it's just that

Re: [PATCH libSM] Export only public API symbols

2010-12-06 Thread Alan Coopersmith
Cristian Rodríguez wrote: Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 1098679..d194d3f 100644 --- a/src/Makefile.am +++

Re: [PATCH] Fixes v5: Cursor barriers

2010-12-06 Thread Adam Jackson
On Mon, 2010-12-06 at 09:59 -0500, Owen Taylor wrote: On Mon, 2010-12-06 at 09:41 -0500, Adam Jackson wrote: On Mon, 2010-12-06 at 06:27 -0500, Owen Taylor wrote: Creating barriers relative to any window rather than to a root window isn't needed for the hot-corner case, but since the

[PATCH libXdmcp] Export only public API symbols

2010-12-06 Thread Cristian Rodríguez
Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index c3b85aa..3da33e5 100644 --- a/Makefile.am +++ b/Makefile.am @@ -7,7 +7,7 @@ AM_CFLAGS = \

Re: [PATCH libSM] Export only public API symbols

2010-12-06 Thread Julien Cristau
On Mon, Dec 6, 2010 at 12:19:12 -0300, Cristian Rodríguez wrote: Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 1098679..d194d3f

Re: libpciaccess bogus bridge data - commit 2bda5b73

2010-12-06 Thread Bryce Harrington
On Mon, Dec 06, 2010 at 09:35:48AM -0800, Jesse Barnes wrote: On Wed, 1 Dec 2010 18:54:22 -0800 Bryce Harrington br...@canonical.com wrote: Jesse, I have a question about change 2bda5b73 that you did to libpciaccess last year, to stop pci_device_get_bridge_buses() from looking at bus

Re: XInput2 Raw Messages

2010-12-06 Thread Chase Douglas
On 12/06/2010 02:09 AM, Patrick Baggett wrote: I'm using Ubuntu 10.10 and testing out some examples using XI2. I don't appear to be getting all the raw messages I've selected however, and I can't explain why. I've attached a program that demonstrates my problem. I can only get the XI_RawMotion

Re: [PATCH 4/6] hw/xfree86/modes: Add optional driver API for RRSetCrtcConfigs

2010-12-06 Thread Simon Thum
On 12/05/2010 11:22 PM, Keith Packard wrote: This provides a driver hook which can either completely replace, or just validate the parameters for, the RRSetCrtcConfigs request. It makes a lot of sense and contains an equal lot of whitespace changes ;) Otherwise, feel free to assume my r-b.

Re: XInput2 Raw Messages

2010-12-06 Thread Patrick Baggett
Thanks! I'll check that out. Patrick On Mon, Dec 6, 2010 at 1:48 PM, Chase Douglas chase.doug...@canonical.comwrote: On 12/06/2010 02:09 AM, Patrick Baggett wrote: I'm using Ubuntu 10.10 and testing out some examples using XI2. I don't appear to be getting all the raw messages I've

Re: [RFC XI 2.1 - xf86-input-evdev 2/3] Add experimental XI 2.1 multitouch support

2010-12-06 Thread Ping Cheng
On Mon, Dec 6, 2010 at 9:41 AM, Chase Douglas chase.doug...@canonical.com wrote: On 12/05/2010 10:41 PM, Peter Hutterer wrote: if the kernel can send it through one device, we can handle it, right? if both are sent through the same axes (and need a serial or something to differentiate like the

Re: Sprite transforms in RandR

2010-12-06 Thread Keith Packard
Yes, definitely. #2 seems easier. If you also turn on panning so the whole screen area is accessible, then it seems better than #1 too because the compositor is probably going to often be the window manager as well, so #1 may still leave you with windows that you can't get to. As annoying

Re: [PATCH] RandR version 1.4 additions

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 10:09:00 -0800, Aaron Plattner aplatt...@nvidia.com wrote: I like the idea of not freezing the screen when the CM crashes. Yeah, the only trick will be to automagically resize the screen pixmap to hold the crtc, but I think even that's pretty easy. This will also encourage me

Re: RandR 1.4 additional X server patches

2010-12-06 Thread Aaron Plattner
On Sun, Dec 05, 2010 at 09:05:47PM -0800, Keith Packard wrote: I've added code to handle the separation screen and screen pixmap sizes, and fixed a couple of minor issues from the previous patches. [PATCH 1/3] DIX is responsible for ref counting scanout pixmaps. DDX was double

Re: [PATCH] Fixes v5: Cursor barriers

2010-12-06 Thread Keith Packard
On Mon, 06 Dec 2010 14:09:49 -0500, Adam Jackson a...@redhat.com wrote: Can we think of a need for window-relative barriers? It seems neat, but not especially useful, and it's not what I have implemented. Barring that, should the spec explicitly require a root window, just so we can add

[PATCH xserver (v4) 05/10] Move some sync code to miext

2010-12-06 Thread James Jones
As a precursor to the fence sync object video driver and extension API, move some code from Xext to miext/sync. Most of this is just code to set up the build system to include the new directory. No functional code is added in this change. Signed-off-by: James Jones jajo...@nvidia.com ---

[PATCH xserver (v4) 02/10] Create SyncObject base type.

2010-12-06 Thread James Jones
SyncObject is now the base type for SyncCounter. Data to be used by all sync types is stored in the base object. SyncCounter can be safely cast to SyncObject, and a SyncObject can be cast to the correct type based on SyncObject::type. Signed-off-by: James Jones jajo...@nvidia.com ---

[PATCH xserver (v4) 04/10] Factor out generic code from ProcSyncAwait()

2010-12-06 Thread James Jones
In preparation for adding more sync object types that will need Await requests of their own, factor out some setup and finalization code from ProcSyncAwait() into SyncAwaitPrologue() and SyncAwaitEpilogue() Signed-off-by: James Jones jajo...@nvidia.com --- Xext/sync.c | 110

[PATCH xserver (v4) 07/10] Require xextproto 7.1.99

2010-12-06 Thread James Jones
Subsequent changes rely on fence sync protocol in the sync extension. This protocol is only complete in xextproto version 7.1.99 and above. Signed-off-by: James Jones jajo...@nvidia.com --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac

[PATCH xserver (v4) 10/10] Expose Sync Fence Object protocol

2010-12-06 Thread James Jones
Add the new protocol handlers for XSync 3.1 to the dispatch tables and report support for Sync protocol version 3.1. Signed-off-by: James Jones jajo...@nvidia.com --- Xext/sync.c | 24 include/protocol-versions.h |2 +- 2 files changed, 25

[PATCH xserver (v4) 06/10] Add fence sync driver interface

2010-12-06 Thread James Jones
-Add fence sync objects -Add fence sync devPrivates -Add a X sync module screen private -Add wrappable functions to create and destroy fence sync objects -Give fence sync objects wrappable functions to trigger, test, and reset their 'triggered' value. -Give fence sync objects wrappable

[PATCH xserver (v4) 09/10] Add XSyncAwaitFence() handler

2010-12-06 Thread James Jones
-Add the actual ProcSyncAwaitFence() dispatch func -Add support for fence sync triggers. Signed-off-by: James Jones jajo...@nvidia.com --- Xext/sync.c| 183 ++-- Xext/syncsrv.h |1 - 2 files changed, 152 insertions(+), 32 deletions(-)

[PATCH xserver (v4) 08/10] Create/Destroy/Trigger/Reset/Query Fence Sync objs

2010-12-06 Thread James Jones
Initial server side implementation of fence sync objects. Allows creation, management, and state queries of binary state objects. Currently they are not very useful as there is no way to wait for them efficiently. The basic trigger operation added here triggers relative to a given X screen's

[PATCH xserver (v4) 00/10] X Server support for Fence Sync

2010-12-06 Thread James Jones
In v4: Completely reorganized patch basedo on Keith Packard's feedback. End result is almost identical, but the road there is very different. I've prepended a patch to add SERVER_SYNC_*_VERSION to the whole series. That this was previously missing makes the re-organization less useful, since

[PATCH xserver (v4) 01/10] Add and use SERVER_SYNC_*_VERSION

2010-12-06 Thread James Jones
Most extensions have a version defined in the protocol headers, and also in the server's protocol-versions.h. The latter defines which version the server advertises support for. Sync wasn't included in protocol-versions.h, and was advertising support for whatever was in the protocol headers the

Re: [PATCH libSM] Export only public API symbols

2010-12-06 Thread Gaetan Nadon
On Mon, 2010-12-06 at 20:35 +0100, Julien Cristau wrote: +libSM_la_LDFLAGS = -export-symbols-regex Sm.* -version-number 6:0:1 -no-undefined Do we want to use that rather than explicitly adding _X_EXPORT or _X_HIDDEN to the right places in the source? That sounds like a better

[PATCH] fonts: Fix typo in async ListFonts logic

2010-12-06 Thread Adam Jackson
This was introduced in 3ab6cd31cbdf8095b2948034fce5fb645422d8da. Mea culpa. This logic is still incorrect [1], but at least it's less incorrect. [1] - https://bugzilla.redhat.com/658587 Signed-off-by: Adam Jackson a...@redhat.com --- dix/dixfonts.c |2 +- 1 files changed, 1 insertions(+),

Re: RandR 1.4 additional X server patches

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:36:43 -0800, Aaron Plattner aplatt...@nvidia.com wrote: The change to decouple the screen and screen pixmap sizes scares me. We're going to have to go through our driver with a fine-toothed comb to make sure we use the right ones in all the right places. Understood. You

Re: [PATCH libfontenc] Export only public API symbols

2010-12-06 Thread Peter Hutterer
On Mon, Dec 06, 2010 at 01:56:49PM -0300, Cristian Rodríguez wrote: Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 96d0a38..d4d613a

Re: [PATCH xserver (v4) 01/10] Add and use SERVER_SYNC_*_VERSION

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:53:15 -0800, James Jones jajo...@nvidia.com wrote: Most extensions have a version defined in the protocol headers, and also in the server's protocol-versions.h. The latter defines which version the server advertises support for. Sync wasn't included in

Re: [PATCH xserver (v4) 02/10] Create SyncObject base type.

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:53:16 -0800, James Jones jajo...@nvidia.com wrote: -if (!AddResource(id, RTCounter, (pointer) pCounter)) +if (!(pSync = (SyncObject *)malloc(syncSize))) + return NULL; + +if (!AddResource(id, resType, (pointer) pSync)) { - free(pCounter); +

Re: [PATCH xserver (v4) 03/10] Make Await SyncTrigger functions generic

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:53:17 -0800, James Jones jajo...@nvidia.com wrote: Update all the functions dealing with Await sync triggers handle generic sync objects instead of just counters. This will facilitate code sharing between the counter sync waits and the fence sync waits. -if

Re: RandR 1.4 additional X server patches

2010-12-06 Thread Aaron Plattner
On Mon, Dec 06, 2010 at 02:44:08PM -0800, Keith Packard wrote: On Mon, 6 Dec 2010 14:36:43 -0800, Aaron Plattner aplatt...@nvidia.com wrote: The change to decouple the screen and screen pixmap sizes scares me. We're going to have to go through our driver with a fine-toothed comb to make

Re: [PATCH xserver (v4) 04/10] Factor out generic code from ProcSyncAwait()

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:53:18 -0800, James Jones jajo...@nvidia.com wrote: In preparation for adding more sync object types that will need Await requests of their own, factor out some setup and finalization code from ProcSyncAwait() into SyncAwaitPrologue() and SyncAwaitEpilogue()

Re: [PATCH xserver (v4) 05/10] Move some sync code to miext

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:53:19 -0800, James Jones jajo...@nvidia.com wrote: As a precursor to the fence sync object video driver and extension API, move some code from Xext to miext/sync. Most of this is just code to set up the build system to include the new directory. No functional code is

Re: [PATCH xserver (v4) 06/10] Add fence sync driver interface

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:53:20 -0800, James Jones jajo...@nvidia.com wrote: -Add fence sync objects -Add fence sync devPrivates -Add a X sync module screen private -Add wrappable functions to create and destroy fence sync objects -Give fence sync objects wrappable functions to

Re: [PATCH xserver (v4) 07/10] Require xextproto 7.1.99

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:53:21 -0800, James Jones jajo...@nvidia.com wrote: Subsequent changes rely on fence sync protocol in the sync extension. This protocol is only complete in xextproto version 7.1.99 and above. Signed-off-by: James Jones jajo...@nvidia.com Reviewed-by: Keith Packard

Re: [PATCH xserver (v4) 08/10] Create/Destroy/Trigger/Reset/Query Fence Sync objs

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:53:22 -0800, James Jones jajo...@nvidia.com wrote: +case SYNC_FENCE: + resType = RTFence; + pSync = (SyncObject *)dixAllocateObjectWithPrivates(SyncFence, + PRIVATE_SYNC_FENCE);

Re: [PATCH] Fixes v5: Cursor barriers

2010-12-06 Thread Peter Hutterer
On Mon, Nov 15, 2010 at 05:11:54PM -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- COPYING|1 + fixesproto.txt | 73 --- xfixesproto.h | 30 +++ xfixeswire.h | 18

Re: [PATCH] xfree86: Allow InputClass entries to specify match type

2010-12-06 Thread Peter Hutterer
On Mon, Dec 06, 2010 at 05:47:02AM -0800, Dan Nicholson wrote: On Sun, Dec 5, 2010 at 9:29 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Dec 02, 2010 at 06:19:15AM -0800, Dan Nicholson wrote: The InputClass Match* entries are currently hardwired to offer a certain variant of

[PULL] new Floating option, xorg.conf fixes

2010-12-06 Thread Peter Hutterer
Keith, Please pull the below. The DGA patch has never seen any review love (despite being on the list 2 or 3 times) but it's harmless. This set adds the new Floating option for devices instead of the now-deprecated SendCoreEvents option. The last two in this list fix a nasty bug, since input ABI

Re: [PATCH xserver (v4) 10/10] Expose Sync Fence Object protocol

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:53:24 -0800, James Jones jajo...@nvidia.com wrote: Add the new protocol handlers for XSync 3.1 to the dispatch tables and report support for Sync protocol version 3.1. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpyPJv9pnfoD.pgp

Re: [PATCH xserver (v3) 00/10] X Server support for Fence Sync

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 14:59:17 -0800, James Jones jajo...@nvidia.com wrote: Took me a while to re-verify, but it's reworked and ready for review again. Thanks for the feedback. Note it won't help a lot with bisect because XSync wasn't using protocol-versions.h, but it is better organized now.

Re:Re: Re:What's the meaning of XSyncAlarmNotify ?

2010-12-06 Thread danny
Hi, Sounds like you're receiving a different event then; if you know what that event is, then great, else just ignore it in your handler, I guess. (In other words, if the event type isn't XSyncAlarmNotify, then it's not an XSyncAlarmNotify event.) But in this situation I could not get the

Re: [PULL] Xserver-spec, Solaris warnings, and first set of memory alloc cleanups

2010-12-06 Thread Keith Packard
On Tue, 30 Nov 2010 16:45:49 -0800, Alan Coopersmith alan.coopersm...@oracle.com wrote: Alan Coopersmith (16): Xserver-spec: Update Memory Management functions Xserver-spec: Replace deprecated resource id lookup functions Xserver-spec: Remove CreateCallbackList

Re: [PATCH] fonts: Fix typo in async ListFonts logic

2010-12-06 Thread Peter Hutterer
On Mon, Dec 06, 2010 at 06:06:57PM -0500, Adam Jackson wrote: This was introduced in 3ab6cd31cbdf8095b2948034fce5fb645422d8da. Mea culpa. This logic is still incorrect [1], but at least it's less incorrect. [1] - https://bugzilla.redhat.com/658587 Signed-off-by: Adam Jackson

Re: [PULL updated] XQuartz: disabling OSX screensaver, RandR regression, and some warning cleanups

2010-12-06 Thread Keith Packard
On Fri, 03 Dec 2010 17:34:22 -0800, Jeremy Huddleston jerem...@apple.com wrote: Jeremy Huddleston (4): XQuartz: Disable the Mac OS X screensaver when in full screen mode XQuartz: Remove one more backing store leftover XQuartz: Cleanup some compiler warnings

Re: [PATCH v2 xserver] config: build Xserver man pages using XORG_MANPAGE_SECTIONS

2010-12-06 Thread Keith Packard
On Sat, 04 Dec 2010 16:13:29 -0500, Gaetan Nadon mems...@videotron.ca wrote: Nothing requires the use of a C preprocessor Using standard file exentions (.man) means no need for .gitignore Use standard directory and makefile Fix man page whitespace issues Reviewed-by: Alan Coopersmith

Re: [PULL] new Floating option, xorg.conf fixes

2010-12-06 Thread Keith Packard
On Tue, 7 Dec 2010 12:03:33 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Eoghan Sherry (1): Xi: Fix master button update when slave buttons are mapped. #24887 Peter Hutterer (5): dix: don't stop processing valuators when the mode changes. mi: handle DGA subtypes

Re: [PULL xserver] X Server support for Fence Sync

2010-12-06 Thread Keith Packard
On Mon, 6 Dec 2010 19:21:55 -0800, James Jones jajo...@nvidia.com wrote: This is the exact patch series (v4) sent out earlier plus a few of the cosmetic suggestions applied. For the removal of assert and a couple other things, I'll need to think about it a bit and retest. If you want to

Re: [PATCH] Make pm2's xv driver collect options like all other drivers.

2010-12-06 Thread Jesse Adkins
That's a good question. The old code checked for VideoAdaptor references in xorg.conf (named input for the input, and output for the output). If it found one and your board wasn't supported, it would complain that your board was not supported. With the patch, it just checks your board and