[PATCH:libXft 2/2] XftGlyphFontSpecCore: check to make sure glyphs are in range

2011-02-02 Thread Alan Coopersmith
From: Derek Wang This fixes a crash reported when selecting "View Page Source" in Mozilla on Solaris 10, due to invalid parameters being given to XPutImage. http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6261221 Signed-off-by: Alan Coopersmith --- I can't claim to understand this

[PATCH:libXft 1/2] XftDrawSrcPicture: fail if info->solidFormat is NULL

2011-02-02 Thread Alan Coopersmith
From: Jay Cotton Fixed a core dump in x11perf render tests when a driver was returning incorrect information due to a bug in the driver. http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6872780 Signed-off-by: Alan Coopersmith --- src/xftdraw.c |2 +- 1 files changed, 1 insertion

Re: Xorg code style guide?

2011-02-02 Thread Pat Kane
> Do we have an Xorg code style guide? Just after I sent that email Google found this link: http://www.x.org/wiki/CodingStyle sorry for the noise. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel I

Xorg code style guide?

2011-02-02 Thread Pat Kane
Do we have an Xorg code style guide? [1] I'm trying to improve the XShape man pages and would like to include a small example program, so I'd like to format it correctly (dot all the T's and cross all the I's :-) Pat --- [1] By default I'll just look at some of the latest GIT change sets ..

[PATCH 2/2 - libXi] Move Xinput server API documentation from libXi to xserver

2011-02-02 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- Makefile.am |2 +- configure.ac|1 - doc/Makefile.am | 63 --- doc/porting.xml | 1209 --- 4 files changed, 1 insertions(+), 1274 deletions(-) delete mode 100644 doc/Makefile.am delete mode

[PATCH 1/2 - xserver] Move Xinput server API documentation from libXi to doc/xml

2011-02-02 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- doc/xml/Makefile.am |2 +- doc/xml/Xinput.xml | 1209 +++ 2 files changed, 1210 insertions(+), 1 deletions(-) create mode 100644 doc/xml/Xinput.xml diff --git a/doc/xml/Makefile.am b/doc/xml/Makefile.am ind

Re: [PATCH libXmu 1/1] config: remove config test for snprintf

2011-02-02 Thread Alan Coopersmith
On 02/ 2/11 05:02 PM, Gaetan Nadon wrote: > The macro HAS_SNPRINTF is hard coded to always be defined. > If it were not defined, Lower.c would include snprintf.c > which does not exit. Seems to be relics from IMakefile "exist", not "exit", I assume. > > Other modules are using snprintf unconditi

Re: [PATCH libXmu 1/1] config: remove config test for snprintf

2011-02-02 Thread Julien Cristau
On Wed, Feb 2, 2011 at 20:02:59 -0500, Gaetan Nadon wrote: > The macro HAS_SNPRINTF is hard coded to always be defined. > If it were not defined, Lower.c would include snprintf.c > which does not exit. Seems to be relics from IMakefile > > Other modules are using snprintf unconditionally. > > S

[PATCH libXmu 1/1] config: remove config test for snprintf

2011-02-02 Thread Gaetan Nadon
The macro HAS_SNPRINTF is hard coded to always be defined. If it were not defined, Lower.c would include snprintf.c which does not exit. Seems to be relics from IMakefile Other modules are using snprintf unconditionally. Signed-off-by: Gaetan Nadon --- configure.ac | 17 - src

Re: [PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2011-02-02 Thread Chris Wilson
On Thu, 16 Dec 2010 15:55:42 +0100, Michel Dänzer wrote: > [ Dropping dri-devel list as this seems strictly an xserver issue ] > > On Fre, 2010-12-10 at 14:49 +0100, Michel Dänzer wrote: > > On Fre, 2010-12-10 at 13:38 +, Chris Wilson wrote: > > > Although there may be more than one resou

Re: [PULL] DGA fixes, minor ABI bump

2011-02-02 Thread Keith Packard
On Thu, 3 Feb 2011 09:08:53 +1000, Peter Hutterer wrote: > updated. note that the minor bump to ABI 12.2 doesn't have a reviewed by. I > hope you trust me to commit that unreviewed ;) Merged. 12b0f7d..ea1ffd3 master -> master -- keith.pack...@intel.com pgpr1dxlkvlB0.pgp Description: PGP

Re: [PATCH xrdb] Properly honor -nocpp

2011-02-02 Thread Alan Coopersmith
On 02/ 2/11 11:33 AM, Jeremy Huddleston wrote: > > Previously, if the user passed -nocpp and there was a cpp present, > cpp would be used. This patch fixes that case. > > Signed-off-by: Jeremy Huddleston > --- > xrdb.c | 30 +- > 1 files changed, 17 insertions(+),

Re: [PULL] DGA fixes, minor ABI bump

2011-02-02 Thread Peter Hutterer
On Wed, Feb 02, 2011 at 03:02:01PM -0800, Keith Packard wrote: > On Thu, 3 Feb 2011 08:59:50 +1000, Peter Hutterer > wrote: > > > sorry, I did and forgot to add the tag when merging. want me to > > update? > > Sure, always nice to have things tagged properly. updated. note that the minor bump

Re: [PULL] DGA fixes, minor ABI bump

2011-02-02 Thread Keith Packard
On Thu, 3 Feb 2011 08:59:50 +1000, Peter Hutterer wrote: > sorry, I did and forgot to add the tag when merging. want me to > update? Sure, always nice to have things tagged properly. -- keith.pack...@intel.com pgpQEyBAEq2bL.pgp Description: PGP signature

Re: [PULL] DGA fixes, minor ABI bump

2011-02-02 Thread Peter Hutterer
On Wed, Feb 02, 2011 at 02:49:59PM -0800, Keith Packard wrote: > On Thu, 27 Jan 2011 14:43:48 +1000, Peter Hutterer > wrote: > > > Ville Syrjala (11): > > include: Fix a copy/paste error in a comment > > xfree86/input: Restore DGAStealKeyEvent() > > xfree86/dga: Install the DGA

Re: [PULL] xserver: enable TLS even if AIGLX is not enabled

2011-02-02 Thread Keith Packard
On Mon, 31 Jan 2011 23:41:47 +0100, Samuel Thibault wrote: > Samuel Thibault (1): > xserver: enable TLS even if AIGLX is not enabled Merged. 541b250..0b15033 master -> master For such a small patch, it might be better to just post to the list; it's easier to review that way. -- kei

Re: [PULL xserver] XQuartz updates

2011-02-02 Thread Keith Packard
On Fri, 28 Jan 2011 21:17:32 -0800, Jeremy Huddleston wrote: > Jeremy Huddleston (5): > XQuartz: Update copyright dates in bundle's plist > XQuartz: Bump version string to 2.6.1 > XQuartz: Call RRScreenSizeNotify after handling externally-generated > XP_EVENT_DISPLAY_CHANGED >

Re: [PULL] DGA fixes, minor ABI bump

2011-02-02 Thread Keith Packard
On Thu, 27 Jan 2011 14:43:48 +1000, Peter Hutterer wrote: > Ville Syrjala (11): > include: Fix a copy/paste error in a comment > xfree86/input: Restore DGAStealKeyEvent() > xfree86/dga: Install the DGA event handler when DGA2 is used > xfree86/dga: Remove the ET_DGAEvent

Re: [PULL] Fix compilation of xf86bigfont.c

2011-02-02 Thread Keith Packard
On Tue, 25 Jan 2011 15:00:45 +, Jon TURNEY wrote: > Jon TURNEY (1): > Fix compilation of xf86bigfont.c Merged. 3a91c2d..70f2d39 master -> master I wouldn't mind someone just deleting this extension though; I don't think it's useful anymore. -- keith.pack...@intel.com pgpe3VVV

Re: [PULL] Various build fixes

2011-02-02 Thread Keith Packard
On Sat, 8 Jan 2011 09:22:02 -0800, Dan Nicholson wrote: > Dan Nicholson (1): > xfree86: Convert libxf86config to static libtool library > > Tom Fogal (2): > Add macro for detecting thread local storage support. > Autodetect TLS support instead of defaulting to disabled. Merged

Re: [PATCH evdev] Export device node as property.

2011-02-02 Thread Dan Nicholson
On Wed, Feb 2, 2011 at 1:21 PM, Peter Hutterer wrote: > On Wed, Feb 02, 2011 at 06:17:22AM -0800, Dan Nicholson wrote: >> On Tue, Feb 1, 2011 at 9:32 PM, Peter Hutterer >> wrote: >> > There is currently no mapping between XI devices and physical devices other >> > than what can be extracted by p

Re: [PATCH] xselinux: Fix GetDrawableContext

2011-02-02 Thread Keith Packard
On Thu, 20 Jan 2011 23:01:03 -0500, Adam Jackson wrote: > M_DRAWABLE_PIXMAP is the lookup mask to dixLookupDrawable, and _not_ the > type value in the drawable itself. Merged. be3be75..ac0a00a master -> master -- keith.pack...@intel.com pgpp8x4Cqjw22.pgp Description: PGP signature __

Re: [PATCH libFS] config: splitting FS and XTRANS compiler option no longer required

2011-02-02 Thread Alan Coopersmith
On 02/ 2/11 01:34 PM, Gaetan Nadon wrote: > This was done for the wrong reasons and fixed in commit: > 87c96993d17812a55d92ef32a91083614e258f02 > where the libfs.pc.in was fixed. > > Signed-off-by: Gaetan Nadon Reviewed-by: Alan Coopersmith -- -Alan Coopersmith-alan.coopersm.

[PATCH libFS] config: splitting FS and XTRANS compiler option no longer required

2011-02-02 Thread Gaetan Nadon
This was done for the wrong reasons and fixed in commit: 87c96993d17812a55d92ef32a91083614e258f02 where the libfs.pc.in was fixed. Signed-off-by: Gaetan Nadon --- configure.ac|7 +-- src/Makefile.am | 11 --- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/co

Re: [PATCH evdev] Export device node as property.

2011-02-02 Thread Peter Hutterer
On Wed, Feb 02, 2011 at 06:17:22AM -0800, Dan Nicholson wrote: > On Tue, Feb 1, 2011 at 9:32 PM, Peter Hutterer > wrote: > > There is currently no mapping between XI devices and physical devices other > > than what can be extracted by parsing the Xorg logfile. Add new property > > "Device Node" t

[PATCH xrdb] Properly honor -nocpp

2011-02-02 Thread Jeremy Huddleston
Previously, if the user passed -nocpp and there was a cpp present, cpp would be used. This patch fixes that case. Signed-off-by: Jeremy Huddleston --- xrdb.c | 30 +- 1 files changed, 17 insertions(+), 13 deletions(-) diff --git a/xrdb.c b/xrdb.c index 2e5882a..c

Re: [PATCH:libX11 1/2] Expand GetSizeOfFile() macro at the one place it's called

2011-02-02 Thread Julien Cristau
On Wed, Feb 2, 2011 at 10:18:43 -0800, Alan Coopersmith wrote: > Removes XrmI.h header that only contained this single macro > > Signed-off-by: Alan Coopersmith > --- > src/Makefile.am |1 - > src/Xrm.c |9 +++-- > src/XrmI.h | 46 --

[PATCH:libX11 2/2] Xrm.c: ReadInFile: refactor fstat error handling

2011-02-02 Thread Alan Coopersmith
We can simplify the fstat failure case now that the GetFileSize macro has been expanded inline. Signed-off-by: Alan Coopersmith --- src/Xrm.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/Xrm.c b/src/Xrm.c index 4337534..49fc258 100644 --- a/src/Xrm.c +

[PATCH:libX11 1/2] Expand GetSizeOfFile() macro at the one place it's called

2011-02-02 Thread Alan Coopersmith
Removes XrmI.h header that only contained this single macro Signed-off-by: Alan Coopersmith --- src/Makefile.am |1 - src/Xrm.c |9 +++-- src/XrmI.h | 46 -- 3 files changed, 7 insertions(+), 49 deletions(-) delete mode 100644

Re: Pull request for reviewed static analysis fixes, second batch

2011-02-02 Thread Alan Coopersmith
On 02/ 1/11 11:33 PM, Erkki Seppala wrote: > The following changes since commit e994ab227ed28655565c3193e63733630105e7f9: > Erkki Seppälä (1): > Comparing array against NULL is not useful "&xkb->server->vmods != > NULL" > > are available in the git repository at: > > g...@gitorious.o

Re: [PATCH:xman 4/4] Use snprintf to PATH_MAX sized buffers to construct filenames

2011-02-02 Thread Alan Coopersmith
On 02/ 1/11 10:41 PM, Guillem Jover wrote: > Hi! > > On Fri, 2011-01-28 at 23:14:00 -0800, Alan Coopersmith wrote: >> diff --git a/misc.c b/misc.c >> index 0921307..8818aa8 100644 >> --- a/misc.c >> +++ b/misc.c >> @@ -693,7 +693,7 @@ ConstructCommand(cmdbuf, path, filename, tempfile) >> FILE

Re: PendingBegin flag on XI_TouchMotionUnowned events?

2011-02-02 Thread Chase Douglas
On 01/25/2011 12:11 PM, Chase Douglas wrote: > On 01/25/2011 04:58 AM, Daniel Stone wrote: >> On Tue, Jan 25, 2011 at 11:35:37AM +1000, Peter Hutterer wrote: >>> On Mon, Jan 24, 2011 at 12:25:25PM -0500, Chase Douglas wrote: We currently have a mechanism for clients selecting for unowned event

Re: [PATCH] Xi: constify XIChangeDeviceProperty()

2011-02-02 Thread Chase Douglas
On 01/30/2011 10:54 PM, Peter Hutterer wrote: > We don't modify "value", make it official. > > Signed-off-by: Peter Hutterer Reviewed-by: Chase Douglas > --- > Xi/xiproperty.c|2 +- > include/exevents.h |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Xi

Re: [PATCH evdev] Export device node as property.

2011-02-02 Thread Dan Nicholson
On Tue, Feb 1, 2011 at 9:32 PM, Peter Hutterer wrote: > There is currently no mapping between XI devices and physical devices other > than what can be extracted by parsing the Xorg logfile. Add new property > "Device Node" to the driver to export the open device file. > > The client is responsible

Re: [PATCH evdev v2] Add third button emulation.

2011-02-02 Thread Benjamin Tissoires
Hi Peter, well, I still have troubles (again, based on the backport to 2.6.0). ;) On 02/02/2011 07:35 AM, Peter Hutterer wrote: New properties: "Evdev Third Button Emulation" → switch on/off "Evdev Third Button Emulation Timeout" → timeout until event is delivered "Evdev Third Button Emulation

Re: [PATCH evdev] Export device node as property.

2011-02-02 Thread Peter Korsgaard
> "Peter" == Peter Hutterer writes: Hi Peter, Thanks for picking this up again, I unfortunately have been busy with other things .. Peter> There is currently no mapping between XI devices and physical Peter> devices other than what can be extracted by parsing the Xorg Peter> logfile. Add