Re: setxkbmap: Refactoring for better style and maintainability?

2011-02-14 Thread Daniel Stone
Hi, On Fri, Feb 11, 2011 at 03:55:16AM +0300, Van de Bugger wrote: Advantages are obvious: better maintainability due to (1) better type control from compiler (because the first argument is of unique type, not widely used faceless int), (2) not using global variables, etc. Who is the

Re: [PATCH 1/4] xkb: Use snprintf to measure string lengths instead of manual strlen math

2011-02-14 Thread Daniel Stone
On Sun, Feb 13, 2011 at 09:36:02PM -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com For the series: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel signature.asc Description: Digital signature

Re: [PATCH evdev] evdev: added property Evdev Axes Rotation. #27688

2011-02-14 Thread Paolo D'Apice
Hi Peter, I'm sorry I reply so late. Anyway, I did the changes you suggested me to do. Now, how can I submit the new patch? Can I use again the git send-email or attach it to the X.Org Bug 27688? Cheers, Paolo ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 3/8] fbdevhw: Remove the non-sysfs hack for mapping from PCI to fbdev

2011-02-14 Thread Mark Kettenis
Date: Sun, 13 Feb 2011 08:48:16 -0800 From: Alan Coopersmith alan.coopersm...@oracle.com On 02/12/11 02:13 PM, Mark Kettenis wrote: From: Adam Jackson a...@redhat.com Date: Sun, 23 Jan 2011 23:18:07 -0500 It's broken for devices with BARs above 4G, and the sysfs method should work

Re: [PATCH] fixes: Pointer barriers

2011-02-14 Thread Soeren Sandmann
Adam Jackson a...@redhat.com writes: This is pretty much a 'version 0' kind of thing, it looks right to me but reviews strongly needed. A conceptual question I have is: What is supposed to happen on diagonal movement? A possibility is to decompose such movement into a horizontal and a vertical

Re: [PATCH] savage: More (intermediate) casts to silence warnings

2011-02-14 Thread Mark Kettenis
Date: Sun, 13 Feb 2011 21:40:50 +0100 From: Tormod Volden lists.tor...@gmail.com On Sat, Feb 12, 2011 at 10:43 PM, Mark Kettenis wrote: This isn't really the right way to fix things.  At least the casts should use uintptr_t instead of int.  That way you won't truncate addresses on true

[PATCH synaptics] Stop scrolling if not exactly two fingers on touchpad.

2011-02-14 Thread Daniel Kurtz
X.Org Bug 34257 http://bugs.freedesktop.org/show_bug.cgi?id=34257 Signed-off-by: Daniel Kurtz djku...@google.com --- src/synaptics.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index 783bd64..6e826f1 100644 --- a/src/synaptics.c +++

Re: [PATCH] Fix build with BSD make.

2011-02-14 Thread Dan Nicholson
On Sun, Feb 13, 2011 at 11:43 PM, Matthieu Herrb matthieu.he...@laas.fr wrote: On Sun, Feb 13, 2011 at 04:44:35PM -0800, Alan Coopersmith wrote: On 02/13/11 12:51 PM, Matthieu Herrb wrote: $ is not allowed in explicit rules. Solaris make has the same limitation, but since I have to use gnu

Re: [PATCH] Fix build with BSD make.

2011-02-14 Thread Alan Coopersmith
On 02/14/11 06:18 AM, Dan Nicholson wrote: On Sun, Feb 13, 2011 at 11:43 PM, Matthieu Herrb matthieu.he...@laas.fr wrote: On Sun, Feb 13, 2011 at 04:44:35PM -0800, Alan Coopersmith wrote: On 02/13/11 12:51 PM, Matthieu Herrb wrote: $ is not allowed in explicit rules. Solaris make has the

Re: [PATCH] Fix build with BSD make.

2011-02-14 Thread Gaetan Nadon
On Mon, 2011-02-14 at 07:29 -0800, Alan Coopersmith wrote: On 02/14/11 06:18 AM, Dan Nicholson wrote: On Sun, Feb 13, 2011 at 11:43 PM, Matthieu Herrb matthieu.he...@laas.fr wrote: On Sun, Feb 13, 2011 at 04:44:35PM -0800, Alan Coopersmith wrote: On 02/13/11 12:51 PM, Matthieu Herrb

Re: xorg-server/*bsd: moving from hal support to devd support?

2011-02-14 Thread Martin Wilke
Hi Cyril, I cc Warner here, he is the author of devd maybe he can say more about that. Thanks Martin On Sun, Feb 13, 2011 at 8:40 PM, Cyril Brulebois k...@debian.org wrote: Hi FreeBSD/X11 folks, as an occasional GNU/kFreeBSD porter, I've been wondering what's going to happen with hal

[PATCH 1/2] Fix memory leak in mode validation

2011-02-14 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- src/vesa.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/vesa.c b/src/vesa.c index 2523d76..ef01881 100644 --- a/src/vesa.c +++ b/src/vesa.c @@ -391,6 +391,7 @@ VESAValidMode(int scrn, DisplayModePtr p, Bool flag, int

[PATCH 2/2] Be forgiving of character-cell size mismatches in mode sizes

2011-02-14 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- src/vesa.c | 28 +--- 1 files changed, 25 insertions(+), 3 deletions(-) diff --git a/src/vesa.c b/src/vesa.c index ef01881..61d3550 100644 --- a/src/vesa.c +++ b/src/vesa.c @@ -317,6 +317,30 @@

Re: [PATCH] Fix build with BSD make.

2011-02-14 Thread Alan Coopersmith
On 02/14/11 08:52 AM, Gaetan Nadon wrote: On Mon, 2011-02-14 at 07:29 -0800, Alan Coopersmith wrote: On 02/14/11 06:18 AM, Dan Nicholson wrote: On Sun, Feb 13, 2011 at 11:43 PM, Matthieu Herrb matthieu.he...@laas.fr mailto:matthieu.he...@laas.fr wrote: On Sun, Feb 13, 2011 at 04:44:35PM

Re: [PATCH] [xserver] record: avoid crash when calling RecordFlushReplyBuffer recursively

2011-02-14 Thread Oliver McFadden
I don't think this has been merged into master yet (and we should apply it to the 1.9.xxx branches too), so I've added my Reviewed-by below. Good catch! On Thu, 2011-02-10 at 15:35 +0200, ext Erkki Seppälä wrote: RecordFlushReplyBuffer can call itself recursively through

Re: [PATCH] [xserver] record: avoid crash when calling RecordFlushReplyBuffer recursively

2011-02-14 Thread Oliver McFadden
On Mon, 2011-02-14 at 19:59 +0200, Oliver McFadden wrote: I don't think this has been merged into master yet (and we should apply it to the 1.9.xxx branches too), so I've added my Reviewed-by below. Good catch! Sorry for the bump again. I was asked to add the Reported-by and Tested-by tags on

Re: [PATCH 1/2] Fix memory leak in mode validation

2011-02-14 Thread Julien Cristau
On Mon, Feb 14, 2011 at 12:45:34 -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- src/vesa.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/vesa.c b/src/vesa.c index 2523d76..ef01881 100644 --- a/src/vesa.c +++ b/src/vesa.c @@

Re: [PATCH 2/2] Be forgiving of character-cell size mismatches in mode sizes

2011-02-14 Thread Julien Cristau
On Mon, Feb 14, 2011 at 12:45:35 -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- src/vesa.c | 28 +--- 1 files changed, 25 insertions(+), 3 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH 0/3] fix regressions from glx request length checks

2011-02-14 Thread Julien Cristau
On Wed, Feb 9, 2011 at 11:08:27 +0100, Julien Cristau wrote: On Thu, Jan 27, 2011 at 10:32:06 +0100, Julien Cristau wrote: This series fixes regressions introduced in my previous glx patchset. The first two fix wrong checks, and patch 3 relaxes a few checks to work around incorrect

Re: [PATCH] Fix build with BSD make.

2011-02-14 Thread Dan Nicholson
On Mon, Feb 14, 2011 at 9:58 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 02/14/11 08:52 AM, Gaetan Nadon wrote: On Mon, 2011-02-14 at 07:29 -0800, Alan Coopersmith wrote: On 02/14/11 06:18 AM, Dan Nicholson wrote: On Sun, Feb 13, 2011 at 11:43 PM, Matthieu Herrb

Re: [PATCH] [xserver] record: avoid crash when calling RecordFlushReplyBuffer recursively

2011-02-14 Thread Julien Cristau
On Mon, Feb 14, 2011 at 20:05:45 +0200, Oliver McFadden wrote: On Mon, 2011-02-14 at 19:59 +0200, Oliver McFadden wrote: I don't think this has been merged into master yet (and we should apply it to the 1.9.xxx branches too), so I've added my Reviewed-by below. Good catch! Sorry for the

Re: xorg-server/*bsd: moving from hal support to devd support?

2011-02-14 Thread Warner Losh
I'm mentioned this several times now: Get me a spec for what Linux udev provides, and what services are needed, and I'll make a compatible implementation on FreeBSD. While it is unfortunate that Linux didn't pickup my interface that mostly pre-dated its implementation, I expect the two are

Re: [PATCH] [xserver] record: avoid crash when calling RecordFlushReplyBuffer recursively

2011-02-14 Thread Oliver McFadden
On Mon, 2011-02-14 at 19:23 +0100, ext Julien Cristau wrote: On Mon, Feb 14, 2011 at 20:05:45 +0200, Oliver McFadden wrote: On Mon, 2011-02-14 at 19:59 +0200, Oliver McFadden wrote: I don't think this has been merged into master yet (and we should apply it to the 1.9.xxx branches too),

Re: [PATCH v2 08/10] dri2: Send events only to known clients

2011-02-14 Thread Ville Syrjälä
On Tue, Feb 08, 2011 at 11:42:54PM +0200, ext Pauli wrote: From: Pauli Nieminen ext-pauli.niemi...@nokia.com If client disconnects and new client gets same id DRI2 events may end to wrong client. DRI2 reference list can be checked to see if the client still owns the DRI2Drawable.

Re: [PATCH] Fix build with BSD make.

2011-02-14 Thread Gaetan Nadon
On Mon, 2011-02-14 at 10:15 -0800, Dan Nicholson wrote: Oh, what we can do is touch the sdksyms.dep file during configure. This is how the other .dep files are handled and what is going on during the executing defiles commands message is printed during config.status. So, I think we just need

Re: [PATCH setxkbmap] Data refactored: list_t introduced to keep list and its sizes together.

2011-02-14 Thread Van de Bugger
Please note: I did not added another list implementation. That was already in place. I just refactored the data layout to make it a bit better. Regarding the list.h... Do you mean /usr/include/xorg/list.h? I am looking at that file... It is self-sufficient and does not require any library. Ok,

Re: [PATCH v2 03/10] dri2: Change driver interface to support DRI2Drawable

2011-02-14 Thread Ville Syrjälä
On Thu, Feb 10, 2011 at 06:22:24PM +0200, Pauli Nieminen wrote: On 10/02/11 17:40 +0200, Ville Syrjälä wrote: On Tue, Feb 08, 2011 at 11:42:49PM +0200, ext Pauli wrote: From: Pauli Nieminen ext-pauli.niemi...@nokia.com void -DRI2WaitMSCComplete(ClientPtr client, DrawablePtr pDraw,

Re: [PATCH] Fix build with BSD make.

2011-02-14 Thread Dan Nicholson
On Mon, Feb 14, 2011 at 11:35 AM, Gaetan Nadon mems...@videotron.ca wrote: On Mon, 2011-02-14 at 10:15 -0800, Dan Nicholson wrote: Oh, what we can do is touch the sdksyms.dep file during configure. This is how the other .dep files are handled and what is going on during the executing defiles

Re: [PATCH 2/2] Be forgiving of character-cell size mismatches in mode sizes

2011-02-14 Thread Adam Jackson
On Feb 14, 2011, at 1:12 PM, Matt Turner wrote: This looks like a good idea. For both patches: Reviewed-by: Matt Turner matts...@gmail.com Pushed, thanks. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 0/3] fix regressions from glx request length checks

2011-02-14 Thread Adam Jackson
On Feb 14, 2011, at 1:12 PM, Julien Cristau wrote: On Wed, Feb 9, 2011 at 11:08:27 +0100, Julien Cristau wrote: On Thu, Jan 27, 2011 at 10:32:06 +0100, Julien Cristau wrote: glx/glxcmds.c | 31 +-- 1 files changed, 25 insertions(+), 6 deletions(-) [PATCH 1/3]

[Patch synaptics] add hysteresis-based noise cancellation

2011-02-14 Thread Simon Thum
This adresses the noise motion coming from most touchpads. The reviews have been incorporated, the code now get fuzz from the kernel if that is set (which it usually isn't). Also included: minor documentation fixes. Cheers, Simon From 174882a675bf36b766f697958813ff0f8028a6ee Mon Sep 17 00:00:00

Re: [PATCH 2/8] int10: warning fix

2011-02-14 Thread Adam Jackson
On Feb 12, 2011, at 5:05 PM, Mark Kettenis wrote: From: Adam Jackson a...@redhat.com Date: Sun, 23 Jan 2011 23:18:06 -0500 helper_exec.c: In function 'pciCfg1in': helper_exec.c:507:4: warning: passing argument 2 of 'pci_device_cfg_read_u32' from incompatible pointer type

[Patch xserver] (percent) option parsing fixes

2011-02-14 Thread Simon Thum
The attached patches allow to not just parse, but use percent options as double. It seems this has been the intent, as only one function was returning int. This makes sense mainly to adjust the newly-added synaptics noise cancellation in the low percent range. Next, don't emit warnings when not

Re: [PATCH/RFC] Move Trapezoids and Triangles code to pixman

2011-02-14 Thread Adam Jackson
On Feb 11, 2011, at 9:54 AM, Søren Sandmann Pedersen wrote: What follows is six patches for pixman, and three patches for the X server. Together they move the code for the Trapezoids and Triangles requests into pixman. Moving them into pixman has some advantages: - It is a performance

Re: [PATCH] xserver: Don't crash if Xv is not initialized

2011-02-14 Thread Dave Airlie
On Tue, Feb 8, 2011 at 8:39 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: The xf86-video-v4l video driver calls xf86XVQueryOffscreenImages() function in order to probe for the Xv FOURCC formats supported for PutVideo ops. However, as this support is deprecated on most of the modern

Re: [PATCH 1/4] xkb: Use snprintf to measure string lengths instead of manual strlen math

2011-02-14 Thread Peter Hutterer
On Sun, Feb 13, 2011 at 09:36:02PM -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- xkb/ddxLoad.c | 21 +++-- xkb/maprules.c |3 +-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/xkb/ddxLoad.c

[PATCH] xserver: Don't crash if Xv is not initialized

2011-02-14 Thread Mauro Carvalho Chehab
The xf86-video-v4l video driver calls xf86XVQueryOffscreenImages() function in order to probe for the Xv FOURCC formats supported for PutVideo ops. However, as this support is deprecated on most of the modern drivers, a call to this method will cause a crash: X: ../../../include/privates.h:115:

Re: [PATCH setxkbmap] Data refactored: list_t introduced to keep list and its sizes together.

2011-02-14 Thread Peter Hutterer
On Mon, Feb 14, 2011 at 10:38:06PM +0300, Van de Bugger wrote: Please note: I did not added another list implementation. That was already in place. I just refactored the data layout to make it a bit better. Regarding the list.h... Do you mean /usr/include/xorg/list.h? I am looking at that

Re: [PATCH:setxkbmap] Use snprintf instead of trying to pre-measure sprintf result sizes.

2011-02-14 Thread Peter Hutterer
On Thu, Feb 10, 2011 at 12:00:11AM -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- setxkbmap.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/setxkbmap.c b/setxkbmap.c index 868b727..9593ba4 100644 ---

Re: [PATCH:setxkbmap] Use snprintf instead of trying to pre-measure sprintf result sizes.

2011-02-14 Thread Alan Coopersmith
On 02/14/11 04:48 PM, Peter Hutterer wrote: On Thu, Feb 10, 2011 at 12:00:11AM -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- setxkbmap.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/setxkbmap.c b/setxkbmap.c

Re: [PATCH] xserver: Don't crash if Xv is not initialized

2011-02-14 Thread Keith Packard
+if (!OffscreenPrivateKey-initialized) { + *num = 0; + return NULL; +} Please use dixPrivateKeyRegistered instead of looking inside the structure. -- keith.pack...@intel.com pgpVm8QakooVK.pgp Description: PGP signature ___

Window procedures in ScreenRec not populated by DDX driver. why?

2011-02-14 Thread kumar vemuri
Hi, In most of the reference DDX driver implementations, the Pixmap procedures (CreatePixmap, etc) are being implemented by the driver and also are getting populated in the ScreenRec structure by the driver. But none of the Window procedures (like CreateWindow, DestroyWindow ...) are being

Re: [PATCH v2 08/10] dri2: Send events only to known clients

2011-02-14 Thread Pauli Nieminen
On 14/02/11 21:06 +0200, Ville Syrjälä wrote: On Tue, Feb 08, 2011 at 11:42:54PM +0200, ext Pauli wrote: From: Pauli Nieminen ext-pauli.niemi...@nokia.com If client disconnects and new client gets same id DRI2 events may end to wrong client. DRI2 reference list can be checked to see if

[PATCH:mkfontscale] Sort contents of encodings.dir

2011-02-14 Thread Alan Coopersmith
Allows easier comparison between builds to detect changes. Helps reduce deltas in packaging systems that compare old new versions. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- list.c| 34 ++ list.h|1 + mkfontscale.c |

[PATCH:encodings] cns11643-x encodings don't need to alias to themselves

2011-02-14 Thread Alan Coopersmith
Removes duplicate lines in encodings.dir (noticed when sorting encodings.dir) Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- large/cns11643-1.enc |1 - large/cns11643-2.enc |1 - large/cns11643-3.enc |1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git