Re: Alignment error in libXi

2011-03-25 Thread Matt Turner
On Sun, Mar 13, 2011 at 10:11 PM, Christian Weisgerber na...@mips.inka.de wrote: GTK+3 blows up on LP64 archs with strict alignment.  This comes down to an unaligned access error in libXi, specifically in the XIButtonClass case in copy_classes() in XExtInt.c.    cls_lib-num_buttons =

Re: Alignment error in libXi

2011-03-25 Thread Jeremy Huddleston
On Mar 24, 2011, at 11:06 PM, Matt Turner wrote: Is this one of those cases where someone, long ago, thought using longs was inherently good? Can we just change labels to be an array of ints, or is that too easy? You can just get the latest libXi release with the fix.

Re: Alignment error in libXi

2011-03-25 Thread Matt Turner
On Fri, Mar 25, 2011 at 6:19 AM, Jeremy Huddleston jerem...@apple.com wrote: On Mar 24, 2011, at 11:06 PM, Matt Turner wrote: Is this one of those cases where someone, long ago, thought using longs was inherently good? Can we just change labels to be an array of ints, or is that too easy?

xf86-video-xgi xf86-video-xgixp: Tinderbox build failures for big endian

2011-03-25 Thread Jeremy Huddleston
xf86-video-xgi and xf86-video-xgixp fail to build on BigEndian architectures due to: http://tinderbox.x.org/builds/2011-03-25-0003/logs/xf86-video-xgi/#build src/xgi_accel.c references undefined CurrentColorDepth http://tinderbox.x.org/builds/2011-03-25-0003/logs/xf86-video-xgixp/#build

Re: Alignment error in libXi

2011-03-25 Thread Jeremy Huddleston
Don't feel too bad. I missed it too and bugged Peter about it before I pushed the release ;) On Mar 24, 2011, at 11:31 PM, Matt Turner wrote: On Fri, Mar 25, 2011 at 6:19 AM, Jeremy Huddleston jerem...@apple.com wrote: On Mar 24, 2011, at 11:06 PM, Matt Turner wrote: Is this one of

Re: [PATCH] [xorg/xserver] os/client: Prevent rare fd leak in DetermineClientPid

2011-03-25 Thread Erkki Seppala
On 24.03.2011 19:31, Keith Packard wrote: On Thu, 24 Mar 2011 15:18:17 +0100 (CET), Mark Kettenismark.kette...@xs4all.nl wrote: Actually, checking the return value of close(2) is fairly silly, at least in this context. So you could write this as: Yeah, what error are they looking for here?

[PATCH v2] [xorg/xserver] os/client: Prevent rare fd leak in DetermineClientPid

2011-03-25 Thread Erkki Seppälä
DetermineClientPid didn't close file descriptor if read on /proc/pid/cmdline failed. Adjusted the code to disregard the close return value and perform the return after that, if the read failed or returned EOF. Signed-off-by: Mark Kettenis mark.kette...@xs4all.nl Signed-off-by: Erkki Seppälä

Re: Spinning in _XReply

2011-03-25 Thread Michal Suchanek
On 16 March 2011 02:40, Karl Tomlinson xm...@karlt.net wrote: Jamey Sharp writes: So I don't see anything we can do except require that callers meet the documented requirements for XSetErrorHandler. I did try to find a kludge to let existing apps survive this bug, but anything I could think

[PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping, the DRI2 buffer information for the compositing manager's output window (typically the Composite Overlay Window or root window) may become stale,

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Ville Syrjälä
On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping, the DRI2 buffer information for the compositing manager's output window

Re: [PATCH sgml-doctools] DocBook/XML: add support for docbook external references

2011-03-25 Thread Dan Nicholson
On Wed, Mar 23, 2011 at 6:59 PM, Gaetan Nadon mems...@videotron.ca wrote: Documents external references This looks like a nice feature, and I applaud you for powering through that external link setup. A couple comments below. - A new feature with version 1.7 is

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Jakob Bornecrantz
On Mar 25, 2011, at 13:47, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping, the DRI2 buffer information

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
On Fre, 2011-03-25 at 06:10 -0700, Jakob Bornecrantz wrote: On Mar 25, 2011, at 13:47, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Ville Syrjälä
On Fri, Mar 25, 2011 at 06:10:42AM -0700, ext Jakob Bornecrantz wrote: On Mar 25, 2011, at 13:47, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a

[PATCH] xorg: remove unused assigned values all over the server

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- The first hunk is the most bizarre found and a bit harder to review. For this, I didn't want to change the logic from the original and seems the functioning is not correct. Xext/xtest.c |5 + Xi/getprop.c

[PATCH] dix: remove unused debug code

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/dixfonts.c | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index d8f1529..316a8a5 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -66,10 +66,6 @@ Equipment

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
On Fre, 2011-03-25 at 14:47 +0200, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping, the DRI2

[PATCH] dix: remove unused macro

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/dixfonts.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 316a8a5..71689cf 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -70,8 +70,6 @@ Equipment Corporation.

Re: [PATCH] dix: remove unused debug code

2011-03-25 Thread Mark Kettenis
From: Tiago Vignatti tiago.vigna...@nokia.com Date: Fri, 25 Mar 2011 16:31:41 +0200 Sorry, but what gives you the authority to say this debug code isn't useful? Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/dixfonts.c | 12 1 files changed, 0 insertions(+),

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
On Fre, 2011-03-25 at 15:45 +0100, Mario Kleiner wrote: On Mar 25, 2011, at 3:32 PM, Michel Dänzer wrote: On Fre, 2011-03-25 at 14:47 +0200, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this,

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Mario Kleiner
On Mar 25, 2011, at 3:32 PM, Michel Dänzer wrote: On Fre, 2011-03-25 at 14:47 +0200, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Ville Syrjälä
On Fri, Mar 25, 2011 at 03:32:06PM +0100, ext Michel Dänzer wrote: On Fre, 2011-03-25 at 14:47 +0200, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a

Re: [PATCH xorg-docs 2/2] Replace XMLTO with XSLTPROC, XMLLINT and W3M tools

2011-03-25 Thread Matt Dew
On 03/22/2011 06:14 PM, Dan Nicholson wrote: On Tue, Mar 22, 2011 at 4:28 PM, Matt Dewmar...@osource.org wrote: On 03/22/2011 03:25 PM, Dan Nicholson wrote: On Tue, Mar 22, 2011 at 7:19 AM, Gaetan Nadonmems...@videotron.ca wrote: Xmlto is a script that selects the appropriate back-end

Re: [PATCH] dix: remove unused debug code

2011-03-25 Thread Daniel Stone
On Fri, Mar 25, 2011 at 03:42:46PM +0100, Mark Kettenis wrote: Sorry, but what gives you the authority to say this debug code isn't useful? Are you asserting that it's useful? If so, what gives _you_ the authority to say that? Cheers, Daniel, who totally loves nothing more than content-free

Re: [PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
On Fre, 2011-03-25 at 17:27 +0200, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 03:32:06PM +0100, ext Michel Dänzer wrote: On Fre, 2011-03-25 at 14:47 +0200, Ville Syrjälä wrote: On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com

Re: [PATCH xorg-docs 2/2] Replace XMLTO with XSLTPROC, XMLLINT and W3M tools

2011-03-25 Thread Gaetan Nadon
On Fri, 2011-03-25 at 09:28 -0600, Matt Dew wrote: Dan, which justifications do you feel are incorrect? Agreed that accurate commit msgs are important so we'll try to clear them up. I think the issue has been resolved with the new series I have posted and Dan has acknowledged the

[PATCH xserver 1/2] dri2: Always re-generate front buffer information when asked for it.

2011-03-25 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Otherwise we might keep stale cached information, e.g. after the driver performed page flipping. This is part of the fix for https://bugs.freedesktop.org/show_bug.cgi?id=35452 . Signed-off-by: Michel Dänzer daen...@vmware.com Reviewed-by: Ville Syrjälä

[PATCH xserver 2/2] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

2011-03-25 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Without this, when a compositing manager unredirects a fullscreen window which uses DRI2 and page flipping, the DRI2 buffer information for the compositing manager's output window (typically the Composite Overlay Window or root window) may become stale,

Re: [PATCH xorg-docs 2/2] Replace XMLTO with XSLTPROC, XMLLINT and W3M tools

2011-03-25 Thread Matt Dew
On 03/25/2011 11:21 AM, Gaetan Nadon wrote: On Fri, 2011-03-25 at 09:28 -0600, Matt Dew wrote: Dan, which justifications do you feel are incorrect? Agreed that accurate commit msgs are important so we'll try to clear them up. I think the issue has been resolved with the new series I have

[PATCH v2 sgml-doctools 1/1] DocBook/XML: add support for docbook external references

2011-03-25 Thread Gaetan Nadon
Documents external references - A new feature with version 1.7 is references to documents in other packages. For example a protocol specifications may refer to another one or to a library implementing it. This feature works with PDF, HTML, PS (and epub?) generated

[PATCH 02/11] mi: fix memory leak in miInitVisuals

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- mi/micmap.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mi/micmap.c b/mi/micmap.c index 41e0300..7448ef8 100644 --- a/mi/micmap.c +++ b/mi/micmap.c @@ -564,6 +564,8 @@ miInitVisuals(VisualPtr *visualp,

[PATCH 04/11] xi: fix memory leak in ProcXListProperties and ProcXIListProperties

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/xiproperty.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Xi/xiproperty.c b/Xi/xiproperty.c index 83ce930..b55e7f3 100644 --- a/Xi/xiproperty.c +++ b/Xi/xiproperty.c @@ -904,8 +904,8 @@

[PATCH 01/11] xfree86: dri2: fix memory leak in DRI2AddDrawableRef

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/dri2/dri2.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index 9ca378f..53f1e33 100644 --- a/hw/xfree86/dri2/dri2.c +++ b/hw/xfree86/dri2/dri2.c

[PATCH 03/11] xi: fix memory leak in ProcXIQueryDevice

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/xiquerydevice.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Xi/xiquerydevice.c b/Xi/xiquerydevice.c index 8b54211..8b69904 100644 --- a/Xi/xiquerydevice.c +++ b/Xi/xiquerydevice.c @@ -107,8 +107,10 @@

[PATCH 07/11] Xi: fix memory leak in ProcXGetSelectedExtensionEvents

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/getselev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Xi/getselev.c b/Xi/getselev.c index 09a53f4..7304738 100644 --- a/Xi/getselev.c +++ b/Xi/getselev.c @@ -152,8 +152,8 @@

[PATCH 09/11] xfree86: fix memory leak in xf86ConfigFbEntity

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c index 1a5bf8a..62395ae 100644 --- a/hw/xfree86/common/xf86Helper.c +++

[PATCH 11/11] xfree86: fix memory leak in xf86LoadModules

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Init.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86Init.c b/hw/xfree86/common/xf86Init.c index e664ce4..d81303e 100644 --- a/hw/xfree86/common/xf86Init.c +++

[PATCH 05/11] mi: fix memory leak in miFillUniqueSpanGroup

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- mi/mispans.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mi/mispans.c b/mi/mispans.c index 53539e5..92f0d02 100644 --- a/mi/mispans.c +++ b/mi/mispans.c @@ -458,6 +458,8 @@ void

[PATCH 10/11] xfree86: fix memory leak in configLayout

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Config.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c index 4b897a1..82754fc 100644 --- a/hw/xfree86/common/xf86Config.c +++

[PATCH 06/11] dix: fix memory leak in SetDefaultFontPath

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/dixfonts.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 71689cf..793ce08 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -1815,8 +1815,10 @@

[PATCH 08/11] fb: fix memory leak in fbOverlayFinishScreenInit

2011-03-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- fb/fboverlay.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/fb/fboverlay.c b/fb/fboverlay.c index 7fca89c..99985a5 100644 --- a/fb/fboverlay.c +++ b/fb/fboverlay.c @@ -390,12 +390,16 @@

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-25 Thread Matt Turner
On Thu, Mar 24, 2011 at 10:44 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Thu, Mar 24, 2011 at 2:17 PM, Matt Turner matts...@gmail.com wrote: On Thu, Mar 24, 2011 at 7:19 PM, Matt Turner matts...@gmail.com wrote: On Thu, Mar 24, 2011 at 7:09 PM, Dan Nicholson dbn.li...@gmail.com wrote: On

[PULL] Fix XWin compilation after commit 769531b9

2011-03-25 Thread Jon TURNEY
Hi Keith, Please consider pulling this patch into master. For my future reference, do you have any preference to receive single patches as pull requests or as a patch? Thanks. The following changes since commit 03f45df93469f6aef391e97007b9614e0770cc4c: Merge remote-tracking branch

Re: [PULL] Fix XWin compilation after commit 769531b9

2011-03-25 Thread Keith Packard
On Fri, 25 Mar 2011 19:34:04 +, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Hi Keith, Please consider pulling this patch into master. For my future reference, do you have any preference to receive single patches as pull requests or as a patch? I'm easy -- do whichever you prefer.

Re: [PATCH 11/11] xfree86: fix memory leak in xf86LoadModules

2011-03-25 Thread Nicolas PENINGUY
On Fri, 2011-03-25 at 20:41 +0200, Tiago Vignatti wrote: diff --git a/hw/xfree86/common/xf86Init.c b/hw/xfree86/common/xf86Init.c index e664ce4..d81303e 100644 --- a/hw/xfree86/common/xf86Init.c +++ b/hw/xfree86/common/xf86Init.c @@ -1433,6 +1433,7 @@ xf86LoadModules(char **list, pointer

Re: [PATCH 02/11] mi: fix memory leak in miInitVisuals

2011-03-25 Thread Nicolas PENINGUY
On Fri, 2011-03-25 at 20:41 +0200, Tiago Vignatti wrote: diff --git a/mi/micmap.c b/mi/micmap.c index 41e0300..7448ef8 100644 --- a/mi/micmap.c +++ b/mi/micmap.c @@ -564,6 +564,8 @@ miInitVisuals(VisualPtr *visualp, DepthPtr *depthp, int *nvisualp, { vid = malloc(nvtype *

Re: [PATCH 04/11] xi: fix memory leak in ProcXListProperties and ProcXIListProperties

2011-03-25 Thread Nicolas PENINGUY
On Fri, 2011-03-25 at 20:41 +0200, Tiago Vignatti wrote: diff --git a/Xi/xiproperty.c b/Xi/xiproperty.c index 83ce930..b55e7f3 100644 --- a/Xi/xiproperty.c +++ b/Xi/xiproperty.c @@ -904,8 +904,8 @@ ProcXListDeviceProperties (ClientPtr client) { client-pSwapReplyFunc =

Re: xf86-video-xgi xf86-video-xgixp: Tinderbox build failures for big endian

2011-03-25 Thread Adam Jackson
On 3/25/11 2:40 AM, Jeremy Huddleston wrote: xf86-video-xgi and xf86-video-xgixp fail to build on BigEndian architectures due to: http://tinderbox.x.org/builds/2011-03-25-0003/logs/xf86-video-xgi/#build src/xgi_accel.c references undefined CurrentColorDepth

Re: [PATCH xorg-docs 2/2] Replace XMLTO with XSLTPROC, XMLLINT and W3M tools

2011-03-25 Thread Matt Dew
On 03/23/2011 01:58 PM, Gaetan Nadon wrote: On Tue, 2011-03-22 at 14:25 -0700, Dan Nicholson wrote: If you pass -x to xmlto instead of -m, you can use a full stylesheet instead of a fragment. Moving to xsltproc means you have to duplicate the internal smarts of xmlto. I have verified -x works

Re: [PATCH 10/11] xfree86: fix memory leak in configLayout

2011-03-25 Thread Nicolas PENINGUY
On Fri, 2011-03-25 at 20:41 +0200, Tiago Vignatti wrote: diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c index 4b897a1..82754fc 100644 --- a/hw/xfree86/common/xf86Config.c +++ b/hw/xfree86/common/xf86Config.c @@ -1659,6 +1659,7 @@ configLayout(serverLayoutPtr

Re: [PATCH 07/11] Xi: fix memory leak in ProcXGetSelectedExtensionEvents

2011-03-25 Thread Nicolas PENINGUY
On Fri, 2011-03-25 at 20:41 +0200, Tiago Vignatti wrote: diff --git a/Xi/getselev.c b/Xi/getselev.c index 09a53f4..7304738 100644 --- a/Xi/getselev.c +++ b/Xi/getselev.c @@ -152,8 +152,8 @@ ProcXGetSelectedExtensionEvents(ClientPtr client) if (total_length) {

Re: [PATCH 07/11] Xi: fix memory leak in ProcXGetSelectedExtensionEvents

2011-03-25 Thread Alan Coopersmith
On 03/25/11 05:12 PM, Nicolas PENINGUY wrote: On Fri, 2011-03-25 at 20:41 +0200, Tiago Vignatti wrote: diff --git a/Xi/getselev.c b/Xi/getselev.c index 09a53f4..7304738 100644 --- a/Xi/getselev.c +++ b/Xi/getselev.c @@ -152,8 +152,8 @@ ProcXGetSelectedExtensionEvents(ClientPtr client)

Re: GSoC Proposal the second

2011-03-25 Thread Michal Suchanek
Hello, On 25 March 2011 23:32, janikjaskol...@aol.com wrote: Hello Michal, first of all, thanks a lot for your feedback. I must admit though, that I get the feeling, that you did either not fully comprehend my intention, or else, have not read some of the latest research results on multi

Re: xf86-video-xgi xf86-video-xgixp: Tinderbox build failures for big endian

2011-03-25 Thread Jeremy Huddleston
Thank's I've removed them from the skip list. --Jeremy On Mar 25, 2011, at 3:55 PM, Adam Jackson wrote: On 3/25/11 2:40 AM, Jeremy Huddleston wrote: xf86-video-xgi and xf86-video-xgixp fail to build on BigEndian architectures due to:

Re: [PATCH synaptics 09/17] eventcomm: print an error when axis range failed.

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): Judging by a quick google search, this isn't a common error that the user will see, it's a bug. So print out information useful for those triaging/debugging. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril

Re: [PATCH synaptics 01/17] eventcomm: add a missing break statement

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): If the EV_SYN wasn't SYN_REPORT, we'd fall through to key event processing, which almost certainly won't do what we want and/or need. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org

Re: [PATCH synaptics 02/17] eventcomm: factor out finger counting.

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): one, two, three, many. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___

Re: [PATCH synaptics 03/17] eventcomm: extern EventReadHwState to allow for testing.

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH synaptics 04/17] eventcomm: replace synaptics-custom TEST_BIT with server's BitIsOn.

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH synaptics 05/17] eventcomm: rename parameter name grab to test_grab

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): We don't permanently grab the device here, we just check whether a grab is possible. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature

Re: [PATCH synaptics 06/17] eventcomm: document event_query_is_touchpad

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/eventcomm.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index eeebafb..30146af 100644 ---

Re: [PATCH synaptics 12/17] eventcomm: fix indentation in EventAutoDevProbe

2011-03-25 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/03/2011): Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org