On Wed, 2011-05-04 at 16:16 -0700, Jesse Barnes wrote:
> On Wed, 04 May 2011 15:17:31 -0700
> Ian Romanick wrote:
>
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA1
> >
> > On 05/03/2011 12:21 PM, Jesse Barnes wrote:
> > > We only spec a 32 bit swap count, so drop the high sbc field.
> > >
Yeah... so considering the comments in mesa-dev earlier today, I was really
surprised to see that glproto and dri2proto were tagged today. I think we need
to brownbag retract and rethink this.
These changes break API. I'm all for fixing the structs, but anything that
breaks API (or worse, pro
We were using XIShouldNotify(client, device) as a test for whether or
not to send XKB map/state/etc changed events, which limits it to only
sending events for the current ClientPointer/ClientKeyboard for that
client. While this makes perfect sense for core events (e.g.
MappingNotify), XKB events c
Due to an unfortunate sense inversion incident while switching from a
if (foo) { ... } to if (!foo) continue; style in f06a9d, we punished any
client who attempted to use XKB to restrict the MapNotify events they
wanted by sending them exactly the events they _didn't_ want, and
nothing else.
NewKe
Previously we had:
foreach (device + slaves of device) {
XkbCopyDeviceKeymap(i, device);
[...]
}
if (device was last slave of its MD) {
XkbCopyDeviceKeymap(master, device);
}
and now:
foreach (device + slaves of device + MD if device was last slave) {
When we change the keymap on a device, send the NewKeyboardNotify for
that device before we copy the keymap to and notify for its attached
master/slave devices.
Signed-off-by: Daniel Stone
---
xkb/xkb.c | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff --g
Replace:
for (stuff; things; etc) {
if (misc || other) {
[...]
}
}
with:
for (stuff; things; etc) {
if (!misc && !other)
continue;
[...]
}
Signed-off-by: Daniel Stone
---
xkb/xkb.c | 29 +++--
1 fil
In the XKB GetKeyboardByName handler, we had the following pseudocode:
if (device was last slave of its MD) {
XkbCopyDeviceKeymap(master, slave);
XkbSendNewKeyboardNotify(slave, ¬ify);
}
Even if the SendNewKeyboardNotify line nominated the correct device,
which it didn't, i
Hi,
This series cleans up XKB event sending a bit, and hopefully fixes a
couple of regressions from f06a9d. If these seem happy in master then
I'll nominate them for stable branches too.
Cheers,
Daniel
___
xorg-devel@lists.x.org: X.Org development
Archi
On Thu, 5 May 2011 11:17:02 +1000
Dave Airlie wrote:
> So I wasn't watching and glproto broke its interface, and I think its bad.
>
> Why?
>
> You can no longer bisect things across this point without now moving glproto.
> glxproto.h:xGLXBufferSwapComplete was a released header file
> definitio
So I wasn't watching and glproto broke its interface, and I think its bad.
Why?
You can no longer bisect things across this point without now moving glproto.
glxproto.h:xGLXBufferSwapComplete was a released header file
definition, you cannot go back and change history.
This should have been hand
On Wed, 4 May 2011 17:49:37 -0700
Jesse Barnes wrote:
> How about you look at git and see what happened last time?
>
> We added some dri2 proto requests, and people wanted to build with old
> versions w/o the new requests. So they added some ifdefs but didn't
> check all the combos (now not just
On Thu, 05 May 2011 09:32:46 +1000
Dave Airlie wrote:
> On Wed, 2011-05-04 at 16:16 -0700, Jesse Barnes wrote:
> > On Wed, 04 May 2011 15:17:31 -0700
> > Ian Romanick wrote:
> >
> > > -BEGIN PGP SIGNED MESSAGE-
> > > Hash: SHA1
> > >
> > > On 05/03/2011 12:21 PM, Jesse Barnes wrote:
>
On Thu, May 05, 2011 at 02:04:12AM +0200, Cyril Brulebois wrote:
> Signed-off-by: Cyril Brulebois
Reviewed-by: Peter Hutterer for the series
Feel free to push these once the requires is updated.
Cheers,
Peter
> ---
> src/acecad.c | 39 +--
> 1 files cha
On Thu, May 05, 2011 at 08:48:19AM +1000, Peter Hutterer wrote:
> The macro is sufficient if called during a development cycle, but not
> sufficient information when triggered by a user (e.g.
> https://bugzilla.redhat.com/show_bug.cgi?id=688693).
>
> Expand what this does to print the event conten
On Thu, May 05, 2011 at 02:04:10AM +0200, Cyril Brulebois wrote:
> Signed-off-by: Cyril Brulebois
> ---
> configure.ac |2 +-
> src/acecad.c | 75 +++--
> src/acecad.h |5
> 3 files changed, 5 insertions(+), 77 deletions(-)
>
> d
On Thu, May 05, 2011 at 02:04:06AM +0200, Cyril Brulebois wrote:
> nothing fancy, I hope. Just addressing a few compiler warnings, and
> following Peter's suggestion, dropping support for input ABI < 12.
For the series:
Reviewed-by: Daniel Stone
Cheers,
Daniel
___
On Wed, May 04, 2011 at 10:12:36AM +1000, Peter Hutterer wrote:
> Grabbing an SD device temporary floats the device but we must not release
> the buttons. Introduced in
>
> commit 9d23459415b84606ee4f38bb2d19054c432c8552
> Author: Peter Hutterer
> Date: Fri Feb 25 11:08:19 2011 +100
This is mostly Daniel's branch minus the commit that added the button grab
issue (and another cleanup one that conflicted after removing the first).
Plus the bugfix for the SD grab issue we've been seeing.
The following changes since commit 5cb31cd0cbf83fff5f17a475e7b0e45246b19bf3:
Merge remot
On Wed, May 04, 2011 at 10:15:22AM +0200, Chase Douglas wrote:
> On 05/03/2011 03:28 AM, Peter Hutterer wrote:
> > On Mon, Apr 25, 2011 at 12:58:17PM -0400, Chase Douglas wrote:
> >> On 04/21/2011 03:35 AM, Peter Hutterer wrote:
> >>> Unconditionally drop the valuators back into the mask when they
Signed-off-by: Cyril Brulebois
---
src/acecad.c | 39 +--
1 files changed, 17 insertions(+), 22 deletions(-)
diff --git a/src/acecad.c b/src/acecad.c
index de2577e..ad6d793 100644
--- a/src/acecad.c
+++ b/src/acecad.c
@@ -729,7 +729,7 @@ ReadInput (InputInfo
Move this function next to its unique caller (AceCadPreInit), and only
declare/define it when the input ABI is strictly less than 12.
Signed-off-by: Cyril Brulebois
---
src/acecad.c | 31 +++
src/acecad.h |2 +-
2 files changed, 16 insertions(+), 17 deletions(-)
Signed-off-by: Cyril Brulebois
---
src/acecad.c | 22 --
1 files changed, 0 insertions(+), 22 deletions(-)
diff --git a/src/acecad.c b/src/acecad.c
index 17e141f..de2577e 100644
--- a/src/acecad.c
+++ b/src/acecad.c
@@ -79,10 +79,8 @@
#endif
#endif
-#if GET_ABI_MAJOR(AB
InputDriverRec's last field is a char**, not a const char**, fix this
warning accordingly:
| CC acecad.lo
| acecad.c:132:1: warning: initialization from incompatible pointer type
[enabled by default]
| acecad.c:132:1: warning: (near initialization for 'ACECAD.default_options')
[enabled by d
Signed-off-by: Cyril Brulebois
---
configure.ac |2 +-
src/acecad.c | 75 +++--
src/acecad.h |5
3 files changed, 5 insertions(+), 77 deletions(-)
diff --git a/configure.ac b/configure.ac
index 4c76754..5b11092 100644
--- a/confi
Get us rid of:
| CC acecad.lo
| acecad.c: In function 'USBReadInput':
| acecad.c:1052:43: warning: 'report_y' may be used uninitialized in this
function [-Wuninitialized]
| acecad.c:1052:43: warning: 'report_x' may be used uninitialized in this
function [-Wuninitialized]
Both code paths (w
Hi,
nothing fancy, I hope. Just addressing a few compiler warnings, and
following Peter's suggestion, dropping support for input ABI < 12.
Mraw,
KiBi.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: h
Reviewed-by: Jeremy Huddleston
On May 4, 2011, at 4:14 PM, Peter Hutterer wrote:
> Static analysis claims that ptr += size may assign garbage. But since the
> protocol requires format to be 8, 16 or 32, size should always have a valid
> value. Initialize to 0 to shut up clang.
>
> Signed-off-by
Thanks,
Reviewed-by: Jeremy Huddleston
On May 4, 2011, at 4:14 PM, Peter Hutterer wrote:
> If we ever print for those, we have a buggy X server that's
> breaking the protocol. Until that happens this is just to shut up clang.
>
> All three are assigned constant strings only, no free() needed
On Wed, 4 May 2011 16:16:37 -0700
Jesse Barnes wrote:
> On Wed, 04 May 2011 15:17:31 -0700
> Ian Romanick wrote:
>
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA1
> >
> > On 05/03/2011 12:21 PM, Jesse Barnes wrote:
> > > We only spec a 32 bit swap count, so drop the high sbc field.
> > >
On Wed, 04 May 2011 15:17:31 -0700
Ian Romanick wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 05/03/2011 12:21 PM, Jesse Barnes wrote:
> > We only spec a 32 bit swap count, so drop the high sbc field.
> >
> > Signed-off-by: Jesse Barnes
>
> Is there any way we could do this
If we ever print for those, we have a buggy X server that's
breaking the protocol. Until that happens this is just to shut up clang.
All three are assigned constant strings only, no free() needed.
Signed-off-by: Peter Hutterer
---
src/test_xi2.c |5 +++--
1 files changed, 3 insertions(+),
Static analysis claims that ptr += size may assign garbage. But since the
protocol requires format to be 8, 16 or 32, size should always have a valid
value. Initialize to 0 to shut up clang.
Signed-off-by: Peter Hutterer
---
src/property.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
The macro is sufficient if called during a development cycle, but not
sufficient information when triggered by a user (e.g.
https://bugzilla.redhat.com/show_bug.cgi?id=688693).
Expand what this does to print the event content and a backtrace, so at
least we know where we're coming from. Only the f
ed area.
given that we haven't seen any actual issues yet, it suggests that this code
is never hit by our current layouts.
Cheers,
Peter
> or should we just be skipping the check (which is what I accidentally pushed)?
>
> http://people.freedesktop.org/~jeremyhu/analyzer/yuffie/2
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 05/03/2011 12:21 PM, Jesse Barnes wrote:
> Ian reminded me that we changed the spec to fit within an XEvent, but we
> never updated the code to match. This set of patches (much simpler than
> the last) does just that. Wrapping support can be added
On Wed, May 04, 2011 at 11:50:49AM -0700, Jeremy Huddleston wrote:
>
> XKBGeom.c:118:27: warning: Assigned value is always the same as the existing
> value
> for (key=row->keys,pos=k=0;knum_keys;k++,key++) {
>~~~^~~~
> XKBGeom.c:115:5: warning: Value stored to 'pos' is
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 05/03/2011 12:21 PM, Jesse Barnes wrote:
> We only spec a 32 bit swap count, so drop the high sbc field.
>
> Signed-off-by: Jesse Barnes
Is there any way we could do this and NOT break building older versions
of Mesa? I'd like to be able to buil
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 05/03/2011 02:08 PM, Jesse Barnes wrote:
> On Tue, 3 May 2011 14:02:31 -0700
> Jesse Barnes wrote:
>
>> On Tue, 03 May 2011 13:54:38 -0700
>> Keith Packard wrote:
>>
>>> On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes
>>> wrote:
>>>
We on
If multiple drawables are doing page flipping, the global drmmode
structure can't be used to keep per swap information. For example
flip_count can increase prematurely due to another swap request,
and then the previous swap request never gets completed, leading to a
stuck client. Move the relevant
I came to the conclusion that the xserver DRI2 invalidate patches that
have been discussed aren't really fixing the problem. I suppose they may
make the problem slightly less likely to happen, but at least for me that
likelyhood is still very high. The whole mess looks like a simple driver
bug to m
Buffer exchange assumes that the front buffer pixmap and name
information is accurate. That may not be the case eg. if the window
has been (un)redirected since the buffer was created.
Signed-off-by: Ville Syrjala
---
src/radeon_dri2.c | 45 -
1 files
nalyzer/yuffie/20110504-/libX11/report-F0RlNS.html#EndPath
On May 4, 2011, at 11:50, Jeremy Huddleston wrote:
>
> XKBGeom.c:191:25: warning: Access to field 'x1' results in a dereference of a
> null pointer (loaded from variable 'rbounds')
>
XKBGeom.c:118:27: warning: Assigned value is always the same as the existing
value
for (key=row->keys,pos=k=0;knum_keys;k++,key++) {
~~~^~~~
XKBGeom.c:115:5: warning: Value stored to 'pos' is never read
pos= 0;
^~
Found-by: clang static analyzer
Signed-off-
XKBGeom.c:191:25: warning: Access to field 'x1' results in a dereference of a
null pointer (loaded from variable 'rbounds')
_XkbCheckBounds(bounds,rbounds->x1,rbounds->y1);
^~~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston
---
src/x
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston
---
configure.ac |2 +-
include/X11/Xlibint.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index ce86c93..a39ab8d 100644
--- a/configure.ac
+++ b/configure.ac
@@
My brain-dead self accidentally git push'd these already, but please still
review in case it needs to be changed.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/x
Contains everything from my last 1.10 pull request, plus three more.
---
The following changes since commit be3f41d1ec5413d0ad05ef18e145714201d602aa:
dix: fix typo in direction calculation (2011-05-04 10:14:10 +1000)
are available in the git repository at:
ssh://people.freedesktop.org/~ajax
The following changes since commit 5cb31cd0cbf83fff5f17a475e7b0e45246b19bf3:
Merge remote-tracking branch 'jturney/remove-opengl-spec-download'
(2011-04-29 09:59:49 -0700)
are available in the git repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
Jeremy Huddleston (4):
The following changes since commit 5cb31cd0cbf83fff5f17a475e7b0e45246b19bf3:
Merge remote-tracking branch 'jturney/remove-opengl-spec-download'
(2011-04-29 09:59:49 -0700)
are available in the git repository at:
git://gitorious.org/vsyrjala/xserver.git composite_validatetree_2
Ville Syrjäl
On 05/ 4/11 02:45 AM, Cyril Brulebois wrote:
> I so like people breaking stuff which was working.
Isn't that ConsoleKit's entire reason for existence? I've still never
gotten a good explanation of what problem it's intended to solve or how
it makes the system better instead of just more complica
On Wed, 4 May 2011 16:18:58 +1000, Peter Hutterer
wrote:
> please don't pull this one yet,
Thanks for the update; I'll sit tight.
--
keith.pack...@intel.com
pgpOID5fAgk9F.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
2011/2/24 Fernando Tarlá Cardoso Lemos :
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=17325
>
> Since ConsoleKit 0.4.2, the sessions created by ck-launch-session are no
> longer marked as local and active. This means that distributions can't simply
> call ck-launch-session in Xsession.d an
Hi,
(just witnessed I can no longer halt or reboot my computer, and
ck-list-sessions pretends it's a non-local session.)
Fernando Tarlá Cardoso Lemos (24/02/2011):
> Since ConsoleKit 0.4.2, the sessions created by ck-launch-session
> are no longer marked as local and active. This means that
> di
On 05/03/2011 03:28 AM, Peter Hutterer wrote:
> On Mon, Apr 25, 2011 at 12:58:17PM -0400, Chase Douglas wrote:
>> On 04/21/2011 03:35 AM, Peter Hutterer wrote:
>>> Unconditionally drop the valuators back into the mask when they were there
>>> in the first place. Otherwise, sending identical coordin
55 matches
Mail list logo
