Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-05 Thread Dave Airlie
On Wed, 2011-05-04 at 16:16 -0700, Jesse Barnes wrote: On Wed, 04 May 2011 15:17:31 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2011 12:21 PM, Jesse Barnes wrote: We only spec a 32 bit swap count, so drop the high sbc field.

Re: xf86-video-ati page flipping fixes

2011-05-05 Thread Michel Dänzer
On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote: I came to the conclusion that the xserver DRI2 invalidate patches that have been discussed aren't really fixing the problem. I suppose they may make the problem slightly less likely to happen, but at least for me that likelyhood is still

Re: [PATCH xf86-video-ati 1/2] dri2: Update front buffer pixmap and name before exchanging buffers

2011-05-05 Thread Michel Dänzer
On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote: Buffer exchange assumes that the front buffer pixmap and name information is accurate. That may not be the case eg. if the window has been (un)redirected since the buffer was created. Signed-off-by: Ville Syrjala syrj...@sci.fi ---

Re: [PATCH 0/6] XKB event regression fixes and cleanup

2011-05-05 Thread Daniel Stone
On Thu, May 05, 2011 at 02:34:05AM +0100, Daniel Stone wrote: This series cleans up XKB event sending a bit, and hopefully fixes a couple of regressions from f06a9d. If these seem happy in master then I'll nominate them for stable branches too. Oh, and for those of you who prefer branches,

[PATCH] Added confine protocol.

2011-05-05 Thread Philipp Reh
--- XI2proto.h | 83 --- 1 files changed, 62 insertions(+), 21 deletions(-) diff --git a/XI2proto.h b/XI2proto.h index 84574a5..5ded2f3 100644 --- a/XI2proto.h +++ b/XI2proto.h @@ -71,27 +71,29 @@ /** * XI2 Request opcodes */

Re: xf86-video-ati page flipping fixes

2011-05-05 Thread Ville Syrjälä
On Thu, May 05, 2011 at 11:46:45AM +0200, Michel Dänzer wrote: On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote: I came to the conclusion that the xserver DRI2 invalidate patches that have been discussed aren't really fixing the problem. I suppose they may make the problem slightly

[PATCH] Added WithConfine functions.

2011-05-05 Thread Philipp Reh
--- include/X11/extensions/XInput2.h | 43 +++ src/XIGrabDevice.c | 18 +++-- src/XIPassiveGrab.c | 52 + 3 files changed, 98 insertions(+), 15 deletions(-) diff --git

[PATCH] Added processing of confine protocol.

2011-05-05 Thread Philipp Reh
--- Xi/extinit.c |8 ++- Xi/xigrabdev.c | 101 + Xi/xigrabdev.h |3 + Xi/xipassivegrab.c | 139 +++- Xi/xipassivegrab.h |2 + 5 files changed, 194 insertions(+), 59 deletions(-) diff

Re: [PATCH xf86-video-ati 1/2] dri2: Update front buffer pixmap and name before exchanging buffers

2011-05-05 Thread Ville Syrjälä
On Thu, May 05, 2011 at 12:28:20PM +0200, Michel Dänzer wrote: On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote: Buffer exchange assumes that the front buffer pixmap and name information is accurate. That may not be the case eg. if the window has been (un)redirected since the buffer

Adding Reviewed-by (and the like) tags

2011-05-05 Thread Cyril Brulebois
Hi, I guess it might be worth mentioning somewhere in the wiki how to easily (in an automated fashion) add r-b tags to a range of commits. Following Jon's suggestion on IRC, I've opted for: git filter-branch --msg-filter 'add-tag.sh Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

Re: xf86-video-ati page flipping fixes

2011-05-05 Thread Mario Kleiner
On May 5, 2011, at 4:23 PM, Ville Syrjälä wrote: On Thu, May 05, 2011 at 11:46:45AM +0200, Michel Dänzer wrote: On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote: I came to the conclusion that the xserver DRI2 invalidate patches that have been discussed aren't really fixing the problem.

Re: [Mesa-dev] glproto changes

2011-05-05 Thread Eric Anholt
On Wed, 4 May 2011 18:21:20 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Thu, 5 May 2011 11:17:02 +1000 Dave Airlie airl...@gmail.com wrote: So I wasn't watching and glproto broke its interface, and I think its bad. Why? You can no longer bisect things across this point

Re: [Mesa-dev] glproto changes

2011-05-05 Thread Jesse Barnes
On Wed, 4 May 2011 21:29:23 -0700 Jeremy Huddleston jerem...@freedesktop.org wrote: Yeah... so considering the comments in mesa-dev earlier today, I was really surprised to see that glproto and dri2proto were tagged today. I think we need to brownbag retract and rethink this. Damnit; right

Re: Adding Reviewed-by (and the like) tags

2011-05-05 Thread Daniel Stone
Hi, On Thu, May 05, 2011 at 05:01:06PM +0200, Cyril Brulebois wrote: git filter-branch --msg-filter 'add-tag.sh Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org' origin/master.. Or, in ~/.gitconfig: [aliases] addrb = filter-branch

Re: xf86-video-ati page flipping fixes

2011-05-05 Thread Ville Syrjälä
On Thu, May 05, 2011 at 05:09:56PM +0200, Mario Kleiner wrote: On May 5, 2011, at 4:23 PM, Ville Syrjälä wrote: On Thu, May 05, 2011 at 11:46:45AM +0200, Michel Dänzer wrote: On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote: I came to the conclusion that the xserver DRI2 invalidate

Re: [PATCH] Don't call pixman_disable_out_of_bounds_workaround() anymore.

2011-05-05 Thread Cyril Brulebois
Soeren Sandmann sandm...@cs.au.dk (03/05/2011): Jeremy Huddleston jerem...@apple.com writes: Is pixman_disable_out_of_bounds_workaround now just a no-op, or was the symbol removed from pixman? Hopefully the former, but I wanted to make sure... Yes, the function still exists as a no-op.

Re: xf86-video-ati page flipping fixes

2011-05-05 Thread Mario Kleiner
On May 5, 2011, at 6:06 PM, Ville Syrjälä wrote: On Thu, May 05, 2011 at 05:09:56PM +0200, Mario Kleiner wrote: On May 5, 2011, at 4:23 PM, Ville Syrjälä wrote: On Thu, May 05, 2011 at 11:46:45AM +0200, Michel Dänzer wrote: On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote: I came to

Re: xf86-video-ati page flipping fixes

2011-05-05 Thread Jesse Barnes
On Thu, 5 May 2011 18:33:11 +0200 Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: Are you sure this is also the case even when kms page flipping is used for fullscreen drawables? The workaround i implemented in my toolkit for the page flipping problem when using fullscreen drawables

Re: [PATCH] libX11: allow inclusion of system level compose files

2011-05-05 Thread Daniel Stone
Hi, Sorry this has taken so long ... On Sun, Oct 11, 2009 at 09:12:09PM +0300, Marko Myllynen wrote: with the release of XFree86 4.4 an inclusion system of compose files was added to Xlib to allow inclusion of the default compose file (with %L), any compose files from user's home directory

Re: [Mesa-dev] glproto changes

2011-05-05 Thread Jeremy Huddleston
Why is sbc a 32bit field in xGLXBufferSwapComplete2 and xDRI2BufferSwapComplete2 when it is a 64bit field in GLXBufferSwapComplete? The hunk at the bottom will result in casting a 64bit int to a 32bit int. If you're going to change this, shouldn't you also change GLXBufferSwapComplete,

Re: xf86-video-ati page flipping fixes

2011-05-05 Thread Ville Syrjälä
On Thu, May 05, 2011 at 09:54:48AM -0700, Jesse Barnes wrote: On Thu, 5 May 2011 18:33:11 +0200 Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: Are you sure this is also the case even when kms page flipping is used for fullscreen drawables? The workaround i implemented in my

Re: [Mesa-dev] glproto changes

2011-05-05 Thread Jesse Barnes
On Thu, 5 May 2011 10:07:24 -0700 Jeremy Huddleston jerem...@freedesktop.org wrote: Why is sbc a 32bit field in xGLXBufferSwapComplete2 and xDRI2BufferSwapComplete2 when it is a 64bit field in GLXBufferSwapComplete? The hunk at the bottom will result in casting a 64bit int to a 32bit int.

Re: xf86-video-ati page flipping fixes

2011-05-05 Thread Ville Syrjälä
On Thu, May 05, 2011 at 06:33:11PM +0200, ext Mario Kleiner wrote: On May 5, 2011, at 6:06 PM, Ville Syrjälä wrote: On Thu, May 05, 2011 at 05:09:56PM +0200, Mario Kleiner wrote: On May 5, 2011, at 4:23 PM, Ville Syrjälä wrote: On Thu, May 05, 2011 at 11:46:45AM +0200, Michel Dänzer

Re: [PATCH] libX11: allow inclusion of system level compose files

2011-05-05 Thread James Cloos
DS == Daniel Stone dan...@fooishbar.org writes: Please consider something like the patch below to allow one to include system level compose files with the following kind of syntax: include %S/en_US.UTF-8/Compose DS This looks fine to me. DS Reviewed-by: Daniel Stone dan...@fooishbar.org

Compatible GLX swap event fixes

2011-05-05 Thread Jesse Barnes
This set is compatible with existing code bases since it adds a new struct to the glx and dri2 proto files instead of renaming existing fields. New clients with old servers will see larger, but still broken, SBC values. Old clients with new servers will see the same bad values they see today.

[PATCH] glproto: add a new GLXBufferSwapComplete struct that matches the spec

2011-05-05 Thread Jesse Barnes
Just add a new struct to remain compatible with existing code. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git a/configure.ac b/configure.ac index a3047e4..a6c301c 100644 --- a/configure.ac +++ b/configure.ac @@ -1,5 +1,5 @@ AC_PREREQ([2.60]) -AC_INIT([GLProto], [1.4.13],

[PATCH] mesa/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jesse Barnes
Use the new swap event type so we get valid SBC values. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git a/configure.ac b/configure.ac index 54d9c29..fb38a4e 100644 --- a/configure.ac +++ b/configure.ac @@ -21,8 +21,8 @@ dnl Versions for external dependencies

Re: Compatible GLX swap event fixes

2011-05-05 Thread Jesse Barnes
On Thu, 5 May 2011 12:38:24 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: This set is compatible with existing code bases since it adds a new struct to the glx and dri2 proto files instead of renaming existing fields. New clients with old servers will see larger, but still broken, SBC

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jeremy Huddleston
For *proto/mesa: Reviewed-by: Jeremy Huddleston jerem...@apple.com For xserver: This looks incomplete. You also need to update swap_count in DRI2DrawableRec to be CARD32. On May 5, 2011, at 12:45 PM, Jesse Barnes wrote: Use the new event types so we can pass a valid SBC value to clients.

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jesse Barnes
On Thu, 05 May 2011 12:59:50 -0700 Jeremy Huddleston jerem...@apple.com wrote: For *proto/mesa: Reviewed-by: Jeremy Huddleston jerem...@apple.com Thanks. For xserver: This looks incomplete. You also need to update swap_count in DRI2DrawableRec to be CARD32. That value is used in other

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jeremy Huddleston
On May 5, 2011, at 1:09 PM, Jesse Barnes wrote: On Thu, 05 May 2011 12:59:50 -0700 Jeremy Huddleston jerem...@apple.com wrote: For *proto/mesa: Reviewed-by: Jeremy Huddleston jerem...@apple.com Thanks. For xserver: This looks incomplete. You also need to update swap_count in

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jeremy Huddleston
Yes, I realize that there are some areas that use 64bit for sbc. Do we really need 64bits for this? If so, how do we properly to communicate the 64bit value between server/client? Currently, your changes result in an implicit cast from 64bit to 32bits in DRI2SwapComplete which will cause

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jesse Barnes
On Thu, 05 May 2011 13:36:40 -0700 Jeremy Huddleston jerem...@apple.com wrote: Yes, I realize that there are some areas that use 64bit for sbc. Do we really need 64bits for this? If so, how do we properly to communicate the 64bit value between server/client? Currently, your changes

Re: [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Jesse Barnes
if (swap_complete) { if (pPriv-swap_count 0x) ErrorF(something appropriate); swap_complete(client, swap_data, type, ust, frame, (CARD32)pPriv-swap_count); } Yeah, it's annoying. How about I leave out the error message and handle wrapping on

Re: [Mesa-dev] [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-05 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/05/2011 01:25 PM, Jesse Barnes wrote: On Thu, 05 May 2011 13:17:13 -0700 Jeremy Huddleston jerem...@apple.com wrote: Yes, I realize that there are some areas that use 64bit for sbc. Do we really need 64bits for this? If so, how do we

Re: [Mesa-dev] Compatible GLX swap event fixes

2011-05-05 Thread Jesse Barnes
On Thu, 05 May 2011 14:15:33 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/05/2011 12:38 PM, Jesse Barnes wrote: This set is compatible with existing code bases since it adds a new struct to the glx and dri2 proto files instead of

Re: [PATCH] libX11: allow inclusion of system level compose files

2011-05-05 Thread Alan Coopersmith
On 05/ 5/11 11:42 AM, James Cloos wrote: DS == Daniel Stone dan...@fooishbar.org writes: Please consider something like the patch below to allow one to include system level compose files with the following kind of syntax: include %S/en_US.UTF-8/Compose DS This looks fine to me. DS

Re: Adding Reviewed-by (and the like) tags

2011-05-05 Thread Peter Hutterer
Slightly less fancy than the other two, but the few lines below do the job when using gitsnippets http://who-t.blogspot.com/2010/11/adding-reviewed-by-tags-to-patches.html ---%- #!/bin/sh # fake some name that looks like a git commit to vim FAKE_GIT_DIR=/tmp/filter-branch-msg/.git

Re: xf86-input-synaptics

2011-05-05 Thread Peter Hutterer
On Thu, May 05, 2011 at 09:35:52AM +0200, Cedric Sodhi wrote: Hello list, I've two questions concerning synaptic: 1.) I've one of those snyaptics driven HP Clickpads (HP Touchsmart tm2) and it has a little LED on it, which is supposed to be lit when the TP is off, but it doesn't when I

Re: [PATCH] libX11: allow inclusion of system level compose files

2011-05-05 Thread Daniel Stone
On Thu, May 05, 2011 at 02:51:19PM -0700, Alan Coopersmith wrote: On 05/ 5/11 11:42 AM, James Cloos wrote: DS == Daniel Stone dan...@fooishbar.org writes: DS This looks fine to me. DS DS Alan - thoughts? Didn't we already push this? Or something based on this? I thought so - and

Re: xf86-input-synaptics

2011-05-05 Thread Daniel Stone
On Fri, May 06, 2011 at 09:16:38AM +1000, Peter Hutterer wrote: On Thu, May 05, 2011 at 09:35:52AM +0200, Cedric Sodhi wrote: I've two questions concerning synaptic: 1.) I've one of those snyaptics driven HP Clickpads (HP Touchsmart tm2) and it has a little LED on it, which is supposed

Re: xf86-input-synaptics

2011-05-05 Thread Peter Hutterer
On Fri, May 06, 2011 at 01:06:41AM +0100, Daniel Stone wrote: On Fri, May 06, 2011 at 09:16:38AM +1000, Peter Hutterer wrote: On Thu, May 05, 2011 at 09:35:52AM +0200, Cedric Sodhi wrote: I've two questions concerning synaptic: 1.) I've one of those snyaptics driven HP Clickpads (HP

Re: xf86-input-synaptics

2011-05-05 Thread Daniel Stone
On Fri, May 06, 2011 at 10:23:48AM +1000, Peter Hutterer wrote: On Fri, May 06, 2011 at 01:06:41AM +0100, Daniel Stone wrote: On Fri, May 06, 2011 at 09:16:38AM +1000, Peter Hutterer wrote: On Thu, May 05, 2011 at 09:35:52AM +0200, Cedric Sodhi wrote: 2.) Would you consider including an

[PATCH libXi 1/3] man: fix typo, layout in XGetExtensionVersion.man

2011-05-05 Thread Peter Hutterer
Fix a typo and move from MPX to XI2. Add a linebreak to make the depreciation separate from the function description. Changes in the second paragraph are just realignment due to the linebreak. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- man/XGetExtensionVersion.txt | 11

[PATCH libXi 2/3] Silence compiler warning in XListDProp.c

2011-05-05 Thread Peter Hutterer
XListDProp.c: In function 'XListDeviceProperties': XListDProp.c:72:9: warning: pointer targets in passing argument 2 of '_XRead32' differ in signedness /usr/include/X11/Xlibint.h:652:13: note: expected 'long int *' but argument is of type 'Atom *' Signed-off-by: Peter Hutterer

[PATCH libXi 3/3] Silence compiler warning due to differnent event conversion procs

2011-05-05 Thread Peter Hutterer
XExtInt.c:161:5: warning: initialization from incompatible pointer type XSndExEv.c: In function 'XSendExtensionEvent': XSndExEv.c:84:8: warning: assignment from incompatible pointer type Xlib and libXi differ in the conversion functions. libXi takes an xEvent** and a num_events parameter since

Re: [PATCH libXi 2/3] Silence compiler warning in XListDProp.c

2011-05-05 Thread Daniel Stone
On Fri, May 06, 2011 at 10:46:02AM +1000, Peter Hutterer wrote: XListDProp.c: In function 'XListDeviceProperties': XListDProp.c:72:9: warning: pointer targets in passing argument 2 of '_XRead32' differ in signedness /usr/include/X11/Xlibint.h:652:13: note: expected 'long int *' but argument

Re: xf86-input-synaptics

2011-05-05 Thread Peter Hutterer
On Fri, May 06, 2011 at 01:45:18AM +0100, Daniel Stone wrote: On Fri, May 06, 2011 at 10:23:48AM +1000, Peter Hutterer wrote: On Fri, May 06, 2011 at 01:06:41AM +0100, Daniel Stone wrote: On Fri, May 06, 2011 at 09:16:38AM +1000, Peter Hutterer wrote: On Thu, May 05, 2011 at 09:35:52AM

Re: [PATCH libXi 2/3] Silence compiler warning in XListDProp.c

2011-05-05 Thread Peter Hutterer
On Fri, May 06, 2011 at 01:57:32AM +0100, Daniel Stone wrote: On Fri, May 06, 2011 at 10:46:02AM +1000, Peter Hutterer wrote: XListDProp.c: In function 'XListDeviceProperties': XListDProp.c:72:9: warning: pointer targets in passing argument 2 of '_XRead32' differ in signedness

Are we ready to tag release libXext 1.3.0?

2011-05-05 Thread Alan Coopersmith
It looks like we've still not done a release of libXext with the new XSyncAwaitFence() API yet, even though the proto server were released a while ago - is there anything remaining to do there or any reason not to go ahead and make a libXext 1.3.0 release? -- -Alan Coopersmith-

Re: Are we ready to tag release libXext 1.3.0?

2011-05-05 Thread James Jones
I'm not aware of any fence sync issues that would hold up a release. Everything should be ready to go. Thanks, -James nvpublic On 5/5/11 7:09 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: It looks like we've still not done a release of libXext with the new XSyncAwaitFence() API

[PULL updated] input fixes

2011-05-05 Thread Peter Hutterer
Same as before, with the two patches daniel fixed up now and a number of XKB cleanups added. The following changes since commit 5cb31cd0cbf83fff5f17a475e7b0e45246b19bf3: Merge remote-tracking branch 'jturney/remove-opengl-spec-download' (2011-04-29 09:59:49 -0700) are available in the git