On Wed, Sep 14, 2011 at 04:57:09PM -0500, Jamey Sharp wrote:
Excellent, thanks Sam.
Reviewed-by: Jamey Sharp ja...@minilop.net
Peter says he'll route this through his tree, so I'll leave it to him.
thanks, I've got this (finally) in my next branch, so this should land on
master soon.
This is a resend of the pull request
http://lists.freedesktop.org/archives/xorg-devel/2011-September/024938.html
This time all three (smooth scrolling, -next and two-screen-coordinates) in
one branch. Neither smooth scrolling nor two-screen-coordinates has reviews
but I've stopped caring now. If
From: Adam Jackson a...@redhat.com
So on RHEL5 anaconda sets an xorg.conf with a fixed 800x600 mode in it,
we run radeonfb and fbdev since ati won't work in userspace due to domain
issues in the older codebase.
On certain pseries blades the built-in KVM can't accept an 800x600-43 mode,
it
Hi,
On Mon, Aug 22, 2011 at 03:35:15PM +1000, Peter Hutterer wrote:
+#ifdef HAVE_SMOOTH_SCROLLING
+if (axis == REL_WHEEL)
+SetScrollValuator(device, axnum, SCROLL_TYPE_VERTICAL, 1.0,
SCROLL_FLAG_PREFERRED);
+else if (axis == REL_DIAL)
+
Hi,
On Mon, Aug 22, 2011 at 03:35:17PM +1000, Peter Hutterer wrote:
+If more than one scroll valuator of the same type is present on a device,
+the valuator marked with Preferred is used to convert legacy button events
+into scroll valuator events. If no valuator is marked Preferred or more
On Mon, Aug 22, 2011 at 03:35:21PM +1000, Peter Hutterer wrote:
Add the required constants to pretend to support XI 2.1.
Having named constants for 2.1 seems a bit pointless, so let's just use the
numbers directly.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Jeremy
On Mon, Aug 22, 2011 at 03:35:14PM +1000, Peter Hutterer wrote:
This is the patchset for the revised smooth scrolling support. The basic
principle stays the same (valuator information instead of button
clicks), the protocol itself chanages a bit. Instead of a dedicated virtual
axis, mark those
On Wed, Aug 24, 2011 at 07:51:44AM +1000, Peter Hutterer wrote:
This flag is part of the future (currently unreleased) XI 2.1 protocol.
Introduced in 2c5187d0099e6c7588828ba9931d27f5c64bbaec
Reported-by: Chris Ball c...@laptop.org
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
On Mon, Aug 22, 2011 at 03:35:22PM +1000, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Daniel Stone dan...@fooishbar.org
___
xorg-devel@lists.x.org: X.Org development
Archives:
On Fri, Sep 09, 2011 at 02:20:47PM +1000, Peter Hutterer wrote:
Switching screens relies on rootx/y to be set to the correct value. Note:
though we technically take a mask for GetKeyboardEvents we don't actually
handle it properly to move the pointer as required (and generate motion
events if
On Fri, Sep 09, 2011 at 02:20:48PM +1000, Peter Hutterer wrote:
We don't actually handle the mask correctly. They're clipped and dropped
into the event but that's about it. I don't think we did since 1.4, let's
warn the user if this happens.
Signed-off-by: Peter Hutterer
On Mon, Aug 22, 2011 at 03:35:24PM +1000, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Daniel Stone dan...@fooishbar.org
But shouldn't this come last in the series, when we actually have scroll
support in place, rather than first?
Cheers,
Daniel
On Mon, Aug 22, 2011 at 03:35:25PM +1000, Peter Hutterer wrote:
And use this occasion to switch InitValuatorAxisStruct to return Bool
instead of just silently ignoring issues.
Relative axes are initialized with 0, -1 but so far this never had any
effect as all users of this function (for
On Wed, Aug 24, 2011 at 07:51:44AM +1000, Peter Hutterer wrote:
This flag is part of the future (currently unreleased) XI 2.1 protocol.
Introduced in 2c5187d0099e6c7588828ba9931d27f5c64bbaec
You can change this to HAVE_XI21 now. Either way:
Reviewed-by: Daniel Stone dan...@fooishbar.org
On Mon, Aug 22, 2011 at 03:35:23PM +1000, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Daniel Stone dan...@fooishbar.org
However ...
+# XI2.1 support
+PKG_CHECK_MODULES(XI21, [xi = 1.4.99.1] [inputproto = 2.0.99.1],
+
On Fri, Sep 09, 2011 at 02:20:49PM +1000, Peter Hutterer wrote:
When a screen switch is triggered by PointerKeys, the device for
NewCurrentScreen is the keyboard. Submitting pointer events for this
keyboard (without valuators) has no effect as GPE ignores the event.
Force the dequeuing
On Fri, Sep 09, 2011 at 02:20:50PM +1000, Peter Hutterer wrote:
We need this from other files too.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Daniel Stone dan...@fooishbar.org
___
xorg-devel@lists.x.org: X.Org development
On Fri, Sep 09, 2011 at 02:20:52PM +1000, Peter Hutterer wrote:
For Zaphod mode screen crossing handling we need to know the size of all
screens together (i.e. the desktop size). Store that in the screenInfo to
have it readily available in events.
Signed-off-by: Peter Hutterer
On Mon, Aug 22, 2011 at 03:35:18PM +1000, Peter Hutterer wrote:
@@ -1564,13 +1576,13 @@ wireToDeviceChangedEvent(xXIDeviceChangedEvent *in,
XGenericEventCookie *cookie)
out-deviceid = in-deviceid;
out-sourceid = in-sourceid;
out-reason = in-reason;
-out-num_classes =
Hi,
On Mon, Aug 22, 2011 at 03:35:27PM +1000, Peter Hutterer wrote:
+if (*current_ax != -1 axnum != *current_ax)
+{
+ax = dev-valuator-axes[*current_ax];
+if (ax-scroll.type == type (flags SCROLL_FLAG_PREFERRED) ==
(ax-scroll.flags SCROLL_FLAG_PREFERRED))
+
The 'Dispatch' function accesses freed client structure if a client
happens to kill itself in a request. For example, I have a test client
that is used to check that it handles the XIO error correctly. The XIO
error is generated by requesting the client to kill itself with
XKillClient.
On Thu, 2011-09-22 at 09:21 +1000, Peter Hutterer wrote:
I've gone ahead and merged this patch for now. It has the desired
effect on
my machine and until we figure out what's going on at least the
behaviour is
fixed. Once we know what exactly is causing this, we can revert the
patch.
I
Review is inline:
On Wednesday 21 September 2011, Barry Scott barry.sc...@onelan.co.uk wrote:
It is useful to be able to run an external program to analyse
a crashed server process. The server will run an user surplied
^
On 17/09/2011 05:45, Alan Coopersmith wrote:
Based on similar commit dac73a519816 to libXft
And similar to that libXft commit, this needs fixing to work correctly
when builddir != srcdir (found by tinderbox, see [1])
... and looking at the history of libXft after that commit, it looks like
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
---
src/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 45a1442..a44dcb3 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -20,7 +20,7 @@ INCLUDES =
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
---
.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index e11a257..6d8cab1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -76,3 +76,4 @@ core
# Edit the following section
Hello,
Can anybody, please, explain how this bug[1] could have remained in
Xorg for two years assuming any sanity is remaining among Xorg
developers?
Thanks
Michal
[1] https://bugs.freedesktop.org/show_bug.cgi?id=23705
___
xorg-devel@lists.x.org:
From: Pauli Nieminen pauli.niemi...@linux.intel.com
Driver may change screen pixmaps after page flipping that would then
make damage lose track of the root pixmap.
Using root window for shadow damages fixes the problem because
SetWindowPixmap is implemented in shadow code.
Signed-off-by: Pauli
On Wednesday 21 September 2011 21:27:11 Jeremy Huddleston wrote:
I like the idea in theory, but I have a few requests:
1) Check for errors on the write. (eg: EAGAIN is not handled properly)
2) grammer:
+wait for a line to written out on the handlers stdout.
should be:
+wait for a
On Thursday 22 September 2011 11:56:09 Simon Farnsworth wrote:
Review is inline:
On Wednesday 21 September 2011, Barry Scott barry.sc...@onelan.co.uk wrote:
It is useful to be able to run an external program to analyse
a crashed server process. The server will run an user surplied
I'd rather see a real loop than one simulated by an extra variable and
a goto. You just need to move the fbdevHWSetMode up to where the break
statement is, and only break if setting the mode succeeded--right?
Jamey
On 9/22/11, Dave Airlie airl...@gmail.com wrote:
From: Adam Jackson
It is useful to be able to run an external program to analyse
a crashed server process. The server will run a user supplied
program in a subprocess of the server.
The subprocess is created when the server starts up so that all
resources needed to create the subprocess are available. It is not
From 9d328847722ce401097bfb32e93f3b7a9d76f73a Mon Sep 17 00:00:00 2001
From: Sam Spilsbury sam.spilsb...@canonical.com
Date: Fri, 23 Sep 2011 00:24:09 +0800
Subject: [PATCH] Check for existing definitions of TRUE, FALSE, MINSHORT and
MAXSHORT before redefining them as otherwise we may
This patch makes sense to me, but I have a couple of requests:
I'm not sure why you extracted out a separate function; I'm not
convinced that makes the code more clear, in this case.
More importantly, I'd like to see justification in the commit message
for deleting LBX support here. I seem to
On 09/22/11 08:32, Michal Suchanek wrote:
Hello,
Can anybody, please, explain how this bug[1] could have remained in
Xorg for two years assuming any sanity is remaining among Xorg
developers?
If we were sane, we wouldn't still be working on X, especially not
after people pile on abuse for
On Thu, 2011-09-22 at 14:52 +0100, Jon TURNEY wrote:
On 17/09/2011 05:45, Alan Coopersmith wrote:
Based on similar commit dac73a519816 to libXft
And similar to that libXft commit, this needs fixing to work correctly
when builddir != srcdir (found by tinderbox, see [1])
... and looking
On 09/13/11 15:55, Jamey Sharp wrote:
diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
index f8e6c8b..7c76fa8 100644
--- a/hw/xfree86/common/xf86Helper.c
+++ b/hw/xfree86/common/xf86Helper.c
@@ -1583,16 +1583,6 @@ xf86GetAllowMouseOpenFail(void)
}
-Bool
On Thu, 22 Sep 2011 18:38:53 +0300, Pauli Nieminen suok...@gmail.com wrote:
Using root window for shadow damages fixes the problem because
SetWindowPixmap is implemented in shadow code.
This seems reasonable to me, independent of page flipping or other
under-the-covers manipulations of the
No content change to copyright text.
Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
This patch requires Assign ids to more tags in Xserver-Dtrace.xml 17
Sep 2011 15:53:10 -0400
doc/dtrace/Xserver-DTrace.xml |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff
This sentence contradicts the document license which is the X.Org
preferred License as found in the License document. This sentence
is internationally no longer required as of 2000.
http://en.wikipedia.org/wiki/All_rights_reserved:
the phrase continues to hold popular currency and serve as a
The word provider should be capitalized.
Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
doc/dtrace/Xserver-DTrace.xml |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/doc/dtrace/Xserver-DTrace.xml b/doc/dtrace/Xserver-DTrace.xml
index 5118777..362763c 100644
---
On 09/22/11 11:56, Gaetan Nadon wrote:
No content change to copyright text.
Signed-off-by: Gaetan Nadonmems...@videotron.ca
---
This patch requires Assign ids to more tags in Xserver-Dtrace.xml 17
Sep 2011 15:53:10 -0400
doc/dtrace/Xserver-DTrace.xml |6 +++---
1 files
On 09/22/11 11:56, Gaetan Nadon wrote:
This sentence contradicts the document license which is the X.Org
preferred License as found in the License document. This sentence
is internationally no longer required as of 2000.
http://en.wikipedia.org/wiki/All_rights_reserved:
the phrase continues to
On 09/22/11 11:56, Gaetan Nadon wrote:
The word provider should be capitalized.
Signed-off-by: Gaetan Nadonmems...@videotron.ca
---
doc/dtrace/Xserver-DTrace.xml |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/doc/dtrace/Xserver-DTrace.xml
Since I was working on some extensions to DRI2 protocol for handling
video, it occurred to me that it might be easier to extend the
protocol if there weren't N different copies of dri2.c floating around
in various different src trees.. also, for video, with one or two
other small extensions (ie.
On 09/21/11 16:53, Gaetan Nadon wrote:
On Wed, 2011-09-21 at 14:05 -0600, Matt Dew wrote:
---
specs/dbelib.xml | 68 +++---
1 files changed, 34 insertions(+), 34 deletions(-)
After you fix the long long long one-liner commit text,
+1
On Thu, Sep 22, 2011 at 08:51:01AM -0400, Gaetan Nadon wrote:
On Thu, 2011-09-22 at 09:21 +1000, Peter Hutterer wrote:
I've gone ahead and merged this patch for now. It has the desired
effect on
my machine and until we figure out what's going on at least the
behaviour is
fixed. Once
On Thu, Sep 22, 2011 at 11:13:30AM +0100, Daniel Stone wrote:
Hi,
On Mon, Aug 22, 2011 at 03:35:27PM +1000, Peter Hutterer wrote:
+if (*current_ax != -1 axnum != *current_ax)
+{
+ax = dev-valuator-axes[*current_ax];
+if (ax-scroll.type == type (flags
On Thu, Sep 22, 2011 at 11:06:54AM +0100, Daniel Stone wrote:
Hi,
On Mon, Aug 22, 2011 at 03:35:17PM +1000, Peter Hutterer wrote:
+If more than one scroll valuator of the same type is present on a device,
+the valuator marked with Preferred is used to convert legacy button events
+into
Since makekeys is built using build environment's gcc and
runs natively, we have to make sure that the size of the
Signature type is the same on both the native environment
and the target, otherwise we get mismatches upon running X,
and some LSB test failures (xts5).
Use an unsigned 32-bit
On 09/22/11 06:52, Jon TURNEY wrote:
On 17/09/2011 05:45, Alan Coopersmith wrote:
Based on similar commit dac73a519816 to libXft
And similar to that libXft commit, this needs fixing to work correctly
when builddir != srcdir (found by tinderbox, see [1])
... and looking at the history of
woha, I didn't notice someone else stepped up and did it even better
(XIScrollClass co by Peter). I'll look into that now, sorry for the noise.
Max
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info:
No functional changes, just clarifying the code. If we skip over unknown
classes, lib-num_classes != wire-num_classe. Use a separate variable to
make that change more explicit and align the code closer with
wireToDeviceChangedEvent.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Like
On Thu, Sep 22, 2011 at 11:05:42AM +0100, Daniel Stone wrote:
Hi,
On Mon, Aug 22, 2011 at 03:35:15PM +1000, Peter Hutterer wrote:
+#ifdef HAVE_SMOOTH_SCROLLING
+if (axis == REL_WHEEL)
+SetScrollValuator(device, axnum, SCROLL_TYPE_VERTICAL, 1.0,
On 09/22/11 15:16, Peter Hutterer wrote:
On Thu, Sep 22, 2011 at 08:51:01AM -0400, Gaetan Nadon wrote:
On Thu, 2011-09-22 at 09:21 +1000, Peter Hutterer wrote:
I've gone ahead and merged this patch for now. It has the desired
effect on
my machine and until we figure out what's going on at
On 09/20/11 06:00, Jon TURNEY wrote:
On 17/09/2011 02:11, Alan Coopersmith wrote:
On 09/16/11 06:04, Jon TURNEY wrote:
On 16/09/2011 05:21, Alan Coopersmith wrote:
On 09/12/11 07:18, Jon TURNEY wrote:
+# XORG_FONT_MKFONTDIR()
+# ---
+# Minimum version: 1.1.1
Shouldn't that
Alex Deucher alexdeucher@... writes:
On Thu, Sep 15, 2011 at 1:17 PM, Keith Packard keithp@... wrote:
On Thu, 15 Sep 2011 12:34:51 -0400, Alex Deucher
alexdeucher@... wrote:
The number of ABI breaks is minimal (usually 1 per
xserver) and those can usually be fixed within a day or so
Studio 12.0 and later have builtin support for __builtin_constant_p and
if you try to define a function with that name, they issue an error:
../include/misc.h, line 271: syntax error before or at: __builtin_constant_p
For older versions, the fallback definition needs to specify it returns
an int,
On Thu, 2011-09-22 at 12:45 -0700, Alan Coopersmith wrote:
On 09/22/11 11:56, Gaetan Nadon wrote:
This sentence contradicts the document license which is the X.Org
preferred License as found in the License document. This sentence
is internationally no longer required as of 2000.
The more recent inclusions of this file haven't been checking for
HAVE_STDINT_H, so might as well make the older ones consistent.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Xext/xcmisc.c |5 -
dbe/dbe.c |5 -
include/dix-config.h.in |
On Thu, Sep 22, 2011 at 04:55:27PM +, David Collier-Brown wrote:
Alex Deucher alexdeucher@... writes:
On Thu, Sep 15, 2011 at 1:17 PM, Keith Packard keithp@... wrote:
On Thu, 15 Sep 2011 12:34:51 -0400, Alex Deucher
alexdeucher@... wrote:
The number of ABI breaks is minimal
I found a bug in the stack of scrolling patches that caused a server lockup.
Introduced by a recent rebase, but I found a few other issues and
incorporated daniels' comments into this patch and squashed them all
together. This is just one big patch to add smooth scrolling support instead
of the
On Thu, Sep 22, 2011 at 04:22:18PM -0700, Alan Coopersmith wrote:
On 09/22/11 15:16, Peter Hutterer wrote:
On Thu, Sep 22, 2011 at 08:51:01AM -0400, Gaetan Nadon wrote:
On Thu, 2011-09-22 at 09:21 +1000, Peter Hutterer wrote:
I've gone ahead and merged this patch for now. It has the desired
On Thu, Sep 22, 2011 at 8:31 PM, Alan Coopersmith
alan.coopersm...@oracle.com wrote:
Studio 12.0 and later have builtin support for __builtin_constant_p and
if you try to define a function with that name, they issue an error:
../include/misc.h, line 271: syntax error before or at:
On Thu, Sep 22, 2011 at 11:17:50AM +0100, Daniel Stone wrote:
On Mon, Aug 22, 2011 at 03:35:24PM +1000, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Daniel Stone dan...@fooishbar.org
But shouldn't this come last in the series, when we actually
The error attribute appeared in gcc-4.3
The return type of __builtin_constant_p is int
Found by Tinderbox.
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
include/misc.h | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/include/misc.h
Ack, this is gonna conflict with the patch I just sent. I'll roll this into
mine and send a new one in a sec.
On Sep 22, 2011, at 18:59, Matt Turner wrote:
On Thu, Sep 22, 2011 at 8:31 PM, Alan Coopersmith
alan.coopersm...@oracle.com wrote:
Studio 12.0 and later have builtin support for
Reviewed-by: Jamey Sharp ja...@minilop.net
Seems like there ought to be a better way than listing which compilers
support it, though. I considered an autoconf test to check whether
__builtin_constant_p is defined, but that doesn't tell you which
compiler is pulling in misc.h each time it's used.
1) The error attribute appeared in gcc-4.3
2) The return type of __builtin_constant_p is int
3) Sun Studio 12.0 and later builtin support for __builtin_constant_p
Found by Tinderbox.
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
include/misc.h | 14 +-
1 files changed, 9
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Sep 22, 2011, at 17:55, Alan Coopersmith wrote:
The more recent inclusions of this file haven't been checking for
HAVE_STDINT_H, so might as well make the older ones consistent.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Return errors instead of silently ignoring them.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
split out from previous patch (input: allow for max min for relative axes
on InitValuatorAxisStruct)
Xi/exevents.c |8 +---
hw/xfree86/common/xf86Xinput.c |8
Relative axes are initialized with 0, -1 but so far this never had any
effect as all users of this function (for relative axes) just set it to the
defaults anyway.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
This time without the change to return Bool.
Xi/exevents.c |2 +-
1
On Thu, Sep 22, 2011 at 11:25:33AM +0100, Daniel Stone wrote:
On Fri, Sep 09, 2011 at 02:20:47PM +1000, Peter Hutterer wrote:
Switching screens relies on rootx/y to be set to the correct value. Note:
though we technically take a mask for GetKeyboardEvents we don't actually
handle it
On Thu, Sep 22, 2011 at 11:28:31AM +0100, Daniel Stone wrote:
On Fri, Sep 09, 2011 at 02:20:52PM +1000, Peter Hutterer wrote:
For Zaphod mode screen crossing handling we need to know the size of all
screens together (i.e. the desktop size). Store that in the screenInfo to
have it readily
On 09/22/2011 03:13 PM, Alan Coopersmith wrote:
On 09/21/11 16:53, Gaetan Nadon wrote:
On Wed, 2011-09-21 at 14:05 -0600, Matt Dew wrote:
---
specs/dbelib.xml | 68
+++---
1 files changed, 34 insertions(+), 34 deletions(-)
After you fix the long
On Thu, Sep 22, 2011 at 10:11 PM, Jeremy Huddleston jerem...@apple.com wrote:
1) The error attribute appeared in gcc-4.3
2) The return type of __builtin_constant_p is int
3) Sun Studio 12.0 and later builtin support for __builtin_constant_p
Found by Tinderbox.
Signed-off-by: Jeremy
The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb:
Merge remote-tracking branch 'mattst88/for-keith' (2011-09-21 14:34:27 -0700)
are available in the git repository at:
git://people.freedesktop.org/~jeremyhu/xserver master
Adam Jackson (16):
xfree86: Move
On 09/22/11 07:11 PM, Jeremy Huddleston wrote:
-static inline void __builtin_constant_p(int x)
+static inline int constant_p(int x)
{
+#if defined(__GNUC__) || (defined(__SUNPRO_C) (__SUNPRO_C= 0x590))
+ return __builtin_constant_p(x);
+#else
return 0;
-}
#endif
+}
Since
On Sep 22, 2011, at 19:49, Alan Coopersmith wrote:
On 09/22/11 07:11 PM, Jeremy Huddleston wrote:
-static inline void __builtin_constant_p(int x)
+static inline int constant_p(int x)
{
+#if defined(__GNUC__) || (defined(__SUNPRO_C) (__SUNPRO_C= 0x590))
+return
On 09/22/11 07:49 PM, Alan Coopersmith wrote:
On 09/22/11 07:11 PM, Jeremy Huddleston wrote:
-static inline void __builtin_constant_p(int x)
+static inline int constant_p(int x)
{
+#if defined(__GNUC__) || (defined(__SUNPRO_C) (__SUNPRO_C= 0x590))
+ return __builtin_constant_p(x);
+#else
return
Reviewed-by: Jamey Sharp ja...@minilop.net
On Thu, Sep 22, 2011 at 05:55:33PM -0700, Alan Coopersmith wrote:
The more recent inclusions of this file haven't been checking for
HAVE_STDINT_H, so might as well make the older ones consistent.
Signed-off-by: Alan Coopersmith
On 09/22/11 07:58 PM, Jeremy Huddleston wrote:
On Sep 22, 2011, at 19:49, Alan Coopersmith wrote:
On 09/22/11 07:11 PM, Jeremy Huddleston wrote:
-static inline void __builtin_constant_p(int x)
+static inline int constant_p(int x)
{
+#if defined(__GNUC__) || (defined(__SUNPRO_C)
Reviewed-by: Jamey Sharp ja...@minilop.net
What I said for Alan's patch goes for this one too:
Seems like there ought to be a better way than listing which compilers
support it, though. I considered an autoconf test to check whether
__builtin_constant_p is defined, but that doesn't tell you
On 09/22/11 08:23 PM, Jamey Sharp wrote:
Reviewed-by: Jamey Sharpja...@minilop.net
What I said for Alan's patch goes for this one too:
Seems like there ought to be a better way than listing which compilers
support it, though. I considered an autoconf test to check whether
__builtin_constant_p
On Thu, 22 Sep 2011 19:06:16 -0700, Jeremy Huddleston jerem...@apple.com
wrote:
The error attribute appeared in gcc-4.3
The return type of __builtin_constant_p is int
Thanks for coming up with this patch. I'd like to hear from Matt, and
ideally Alan Coopersmith as to whether this seems
On Sep 22, 2011, at 20:23, Jamey Sharp wrote:
Reviewed-by: Jamey Sharp ja...@minilop.net
What I said for Alan's patch goes for this one too:
Seems like there ought to be a better way than listing which compilers
support it, though. I considered an autoconf test to check whether
On Thu, 22 Sep 2011 19:49:18 -0700, Alan Coopersmith
alan.coopersm...@oracle.com wrote:
Since __builtin_constant_p is more of a keyword than a function, does the
magic still work when you have the extra level of indirection?
Could just be a macro if necessary. Either seems fine to me.
--
On Fri, Sep 23, 2011 at 12:55 AM, Keith Packard kei...@keithp.com wrote:
On Thu, 22 Sep 2011 19:06:16 -0700, Jeremy Huddleston jerem...@apple.com
wrote:
The error attribute appeared in gcc-4.3
The return type of __builtin_constant_p is int
Thanks for coming up with this patch. I'd like to
Hi everyone,
Notebooks usually have a touchpad as the default pointing device, and it
is most often placed just below the keyboard. This makes typing
sometimes annoying because users might touch the touchpad
unintentionally and cause the cursor to move away from your current
window or
On Thu, 22 Sep 2011 19:52:05 -0700, Jeremy Huddleston jerem...@apple.com
wrote:
git://people.freedesktop.org/~jeremyhu/xserver master
This sequence needs the following patch somewhere:
diff --git a/hw/xfree86/modes/xf86Cursors.c b/hw/xfree86/modes/xf86Cursors.c
index 23c48eb..e244a2d 100644
On Fri, Sep 23, 2011 at 01:22:37PM +0800, JJ Ding wrote:
Hi everyone,
Notebooks usually have a touchpad as the default pointing device, and it
is most often placed just below the keyboard. This makes typing
sometimes annoying because users might touch the touchpad
unintentionally and cause
91 matches
Mail list logo
