Hi,
On 1 December 2011 20:53, Adam Jackson a...@redhat.com wrote:
Two minor additions. The atomic query requests I think I've proposed
before but got distracted by the XI2 interaction. The latter moves
PropertyNotify filtering into the server, to avoid waking up every
client uselessly just
On Thu, 1 Dec 2011 15:53:40 -0500, Adam Jackson a...@redhat.com wrote:
+ If the pointer argument is None, information for the core pointer is
+ returned. Otherwise, if the server supports the X Input Extension
+ version 2 or greater, the pointer argument may name any pointer
+
Hi,
A little while later (cough), I've finally finished cleaning up and
rebasing my extmod changes, based on the review comments I got the first
time around. I'm running this now, and it seems fine -- including having
the Composite visual created in GLX too.
Anything with 'v2' in the subject is
libxorgxkb.a contains a number of libraries which are used by XKB action
code to call back into the DDX, e.g. for VT switching, termination, grab
breaking, et al. Make sure libxkb.a comes first in the link order, so
it can mark XkbDDX* as used in order for the linker to not discard them.
Does what it says on the box, replacing those from Xi/ and glx/.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Reviewed-by: Cyril Brulebois k...@debian.org
Reviewed-by: Jamey Sharp ja...@minilop.net
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
Signed-off-by: Peter Hutterer
Huh, so I guess INITARGS used to be int argc, char *argv then. Either
way, it's now void, so fix that ...
Signed-off-by: Daniel Stone dan...@fooishbar.org
Reviewed-by: Cyril Brulebois k...@debian.org
Reviewed-by: Jamey Sharp ja...@minilop.net
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
externsion.h required bits from Xfuncproto.h and dixstruct.h, but
included neither; fix that.
It also had _XFUNCPROTOBEGIN and _XFUNCPROTOEND wrappers, which is a bit
pointless for a server-only library, as it's only needed for C++.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Reviewed-by:
EXTERN_MODULE was used to specify that we shouldn't worry about modules
lacking a ModuleData object. It was also completely unused. *shrug*
Signed-off-by: Daniel Stone dan...@fooishbar.org
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
hw/xfree86/common/xf86Module.h |3 ---
Reorder static extension initialisation in miinitext for non-Xorg
servers to match Xorg's order.
Tested with Xephyr; checked that the extension list was identical before
and after.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
From: Tomas Carnecky t...@dbservice.com
If DBE support is compiled in the server, just man up and build it into
the server, rather than having it as an external module.
Signed-off-by: Tomas Carnecky t...@dbservice.com
Reviewed-by: Daniel Stone dan...@fooishbar.org
Reviewed-by: Jamey Sharp
xf86ExtensionInit is called after configuration file parsing, so it can
perform the two parts of extension initialisation currently done by
extmod: enabling and disabling of extensions through an 'omit' option,
and SELinux configuration.
Signed-off-by: Daniel Stone dan...@fooishbar.org
From: Tomas Carnecky t...@dbservice.com
If we've built MIT-SCREEN-SAVER support, then just build it into the
main binary, rather than leaving it in extmod.
Signed-off-by: Tomas Carnecky t...@dbservice.com
Reviewed-by: Daniel Stone dan...@fooishbar.org
Reviewed-by: Jamey Sharp ja...@minilop.net
We no longer have anything in the tree that checks for XorgLoader. This
was a fairly monumental hack: xvdi.h used to hide all its functions
behind #ifndef XorgLoader, solely to avoid sdksyms.sh picking up its
symbols, as it was previously a module rather than built-in.
This is no longer the
Now that libXextmodule.la is both empty and unused, we can just build
the one libXext.la for everyone, rather than having Xorg be special and
unique.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Reviewed-by: Jamey Sharp ja...@minilop.net
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
AM_CFLAGS will suffice, given we only have one target in this directory.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Reviewed-by: Cyril Brulebois k...@debian.org
---
hw/xfree86/dri/Makefile.am | 25 -
1 files changed, 12 insertions(+), 13 deletions(-)
diff --git
extmod was originally a big pointless module. Now it's an empty,
pointless module. This commit makes it unexist.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xext/Makefile.am
As PseudoramiX is a DDX-specific extension, move its loading and
initialisation to hw/xquartz. This creates a QuartzExtensionInit()
similar in spirit to xf86ExtensionInit.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
v2: New.
hw/xquartz/quartz.c | 19 +++
1 files
From: Tomas Carnecky t...@dbservice.com
Xv used to call XvScreenInit and co. through function pointers, as
XvScreenInit may have been sitting on the other side of a module
boundary from xf86XvScreenInit. Why this was so is a mystery, but make
it not so any more.
Signed-off-by: Tomas Carnecky
Rather than building the tiny amount of code required for XFree86-DRI as
an external module, build it in if it's enabled at configure time.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
configure.ac |6 +-
hw/xfree86/Makefile.am |7 ++-
Even though we hide local-only extensions from remote clients in the
extension list, make doubly sure they can't make a local-only request.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
dix/dispatch.c | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git
We already hide the extension from clients and deny their requests, so I
doubt we'll be needing the LocalClient() check anymore.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/kdrive/ephyr/ephyrdriext.c | 62 +-
hw/xfree86/common/xf86DGA.c |5 +-
If an extension is declared as being for local use only, don't show it
to remote clients in the extension list.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Reviewed-by: Jamey Sharp ja...@minilop.net
---
dix/extension.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff
Rather than having a non-Xorg and an Xorg-specific path which basically
just duplicated each other for no reason, we could ... just have one.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/xfree86/dixmods/Makefile.am |2 +-
mi/miinitext.c | 91
Remove _X_EXPORT tags from functions not used by any drivers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/xfree86/common/xf86Module.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/common/xf86Module.h b/hw/xfree86/common/xf86Module.h
index
Hi,
As the name implies, go through and remove the _X_EXPORT tag from
anything in the server which was completely unused by any clients. The
follow-up commits also cull any code which was completely dead and
discarded by the linker, as well as a couple of fixes (e.g. Xinerama
regeneration and
Remove _X_EXPORT tags from symbols which aren't used by, and are useless
to, drivers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
miext/damage/damage.h | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/miext/damage/damage.h b/miext/damage/damage.h
index
Remove _X_EXPORT tags from symbols which were never used by drivers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/xfree86/parser/configProcs.h |6 +++---
hw/xfree86/parser/xf86Optrec.h | 31 +++
hw/xfree86/parser/xf86Parser.h | 30
Remove useless _X_EXPORT tags from functions which are not supposed to
be exported to drivers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/xfree86/modes/xf86Crtc.h| 20 ++--
hw/xfree86/modes/xf86Modes.h | 22 +++---
Remove unnecessary _X_EXPORT tags.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
xfixes/xfixes.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/xfixes/xfixes.h b/xfixes/xfixes.h
index 5765e64..0793f08 100644
--- a/xfixes/xfixes.h
+++ b/xfixes/xfixes.h
@@
Remove unnecessary _X_EXPORT tags from mi headers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
mi/mi.h| 44 ++--
mi/micmap.h|2 +-
mi/mifpoly.h |2 +-
mi/mipointer.h | 20 ++--
mi/mipoly.h| 10
Remove unnecessary _X_EXPORT tags from functions not meant to be
exported to drivers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/xfree86/dri2/dri2.h | 23 +++
1 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/hw/xfree86/dri2/dri2.h
Remove the _X_EXPORT tag from functions unused by any drivers. Sadly,
i810 still exists, so we can't bin AGP support.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/xfree86/os-support/bus/xf86Pci.h |6 ++--
hw/xfree86/os-support/xf86_OSproc.h | 44
Remove _X_EXPORT tags from functions which are only called in
dix/main.c.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
include/hotplug.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hotplug.h b/include/hotplug.h
index d074df3..229913a 100644
---
Remove _X_EXPORT tags from symbols which aren't and shouldn't be used by
drivers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
include/client.h|7 +-
include/dixstruct.h | 30 +-
include/os.h| 162 +-
3 files
Remove needless exporting of pretty much every symbol in XKB, but leave
just enough so that drivers can build their own keymaps if necessary.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
include/xkbfile.h | 60 ++--
include/xkbrules.h | 10 ++--
include/xkbsrv.h |
Remove _X_EXPORT tags from functions not useful to drivers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
miext/sync/misync.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/miext/sync/misync.h b/miext/sync/misync.h
index 1c82ea5..8479137 100644
---
Remove unnecessary _X_EXPORT tags from symbols not used by any driver.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
randr/randrstr.h| 186 +-
randr/rrtransform.h | 12 ++--
2 files changed, 99 insertions(+), 99 deletions(-)
diff
Remove _X_EXPORT tag from needlessly exported symbols.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
include/XIstubs.h |6 +++---
include/cursor.h | 26 +-
include/dix.h | 28 ++--
include/dixevents.h| 38
Remove remnants of an earlier experiment which had the GE extension
handling event delivery directly. Nothing's used the resource since, so
purge it.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
Xext/geext.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git
No-one ever did anything with this variable except assign its default
value to it.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/kdrive/ephyr/ephyr.c | 12
hw/kdrive/ephyr/ephyrinit.c |2 --
os/utils.c |1 -
3 files changed, 0 insertions(+),
These were an unused remnant of earlier MPX work; their only users got
cleared out in dc153271, but the mask declarations remained. Remove
them, and move DevicePropertyNotify's mask up to be contiguous with the
rest of the range.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
Xi/extinit.c
Remove _X_EXPORT tags from functions not used by any drivers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
dix/dispatch.c |2 +-
include/callback.h |4 +-
include/dix.h| 54 +-
include/dixevents.h |4 +-
include/dixfont.h
No-one has used this since 0a71e154.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
render/glyph.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/render/glyph.c b/render/glyph.c
index 7193d47..2f8b424 100644
--- a/render/glyph.c
+++ b/render/glyph.c
@@ -80,8
No drivers used this, so it got unexported, and now it's so unused it
got culled during the link. Take the poor function out behind the shed
and put it out of its misery.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/xfree86/os-support/shared/vidmem.c | 12
Similar (identical) to how it interacts with Render and XFixes, also
call PanoramiXCompositeReset() to restore the Composite dispatch table
to how it was when it started, on reset.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
Xext/panoramiX.c |3 +++
1 files changed, 3 insertions(+),
I wonder if this even works across multiple generations.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
Xext/xvmc.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/Xext/xvmc.c b/Xext/xvmc.c
index 5f6574f..a3cf67e 100644
--- a/Xext/xvmc.c
+++ b/Xext/xvmc.c
@@ -38,8
These codepaths were never called by anyone. Shame there weren't more
of them.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
xkb/XKBGAlloc.c | 128 ---
xkb/xkbgeom.h | 17 ---
2 files changed, 0 insertions(+), 145 deletions(-)
Remove _X_EXPORT tags from functions not used by any drivers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/xfree86/common/dgaproc.h | 54 ++--
hw/xfree86/common/vidmodeproc.h | 58 +++---
hw/xfree86/common/xf86.h
Remove _X_EXPORT tags from functions not used by any drivers.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
hw/xfree86/ddc/xf86DDC.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/xfree86/ddc/xf86DDC.h b/hw/xfree86/ddc/xf86DDC.h
index 16a8641..60fc227
From: Tomas Carnecky t...@dbservice.com
Always build XRes support into the core server, rather than letting it
languish in extmod.
Signed-off-by: Tomas Carnecky t...@dbservice.com
Reviewed-by: Daniel Stone dan...@fooishbar.org
Reviewed-by: Jamey Sharp ja...@minilop.net
Signed-off-by: Peter
DRI2DestroyDrawable() was still being _X_EXPORTed, but hasn't existed
since 1da1f33f last year.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Reviewed-by: Cyril Brulebois k...@debian.org
Reviewed-by: Jamey Sharp ja...@minilop.net
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
When resetting the extension, make sure we also destroy the system
counters we created at ExtensionInit time as well.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
Xext/sync.c | 20
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/Xext/sync.c
Make sure we add static extensions before anything in a module. This is
more or less a no-op at the moment, but will come in handy later when
extension dependency sorting is removed.
Signed-off-by: Daniel Stone dan...@fooishbar.org
---
v2: New, fixes GLX vs. Composite visual creation.
Hi Jamey,
On Thu, Jun 30, 2011 at 04:06:02PM -0700, Jamey Sharp wrote:
I sure like the results of this series. I've reviewed the patches as I
found them on your personal branch. The abbreviated commit hashes that I
reviewed are listed together with their commit summaries below.
Thanks a heap
On Fri, 2 Dec 2011 11:31:06 +, Daniel Stone dan...@fooishbar.org wrote:
As the name implies, go through and remove the _X_EXPORT tag from
anything in the server which was completely unused by any clients. The
follow-up commits also cull any code which was completely dead and
discarded
Hi,
On 2 December 2011 12:19, Keith Packard kei...@keithp.com wrote:
On Fri, 2 Dec 2011 11:31:06 +, Daniel Stone dan...@fooishbar.org wrote:
As the name implies, go through and remove the _X_EXPORT tag from
anything in the server which was completely unused by any clients. The
follow-up
From: Adam Jackson a...@redhat.com
Date: Thu, 1 Dec 2011 16:50:59 -0500
We don't do anything with EDID v2 blocks besides publish them on the
root window. Worse, the check deleted by this patch would attempt to
take a checksum of arbitrary memory if the rawData array isn't 256+
bytes long
From: Adam Jackson a...@redhat.com
Date: Thu, 1 Dec 2011 16:50:57 -0500
This was an ancient hack to try to fetch the EDID block by reusing the
vertical sync pin as a serial line. It's never been very reliable, and
DDC2 was introduced in 1994 which is plenty recent enough.
Hmm, if
On 12/2/11 12:01 PM, Mark Kettenis wrote:
However, rather than breaking drivers, can we
just replace xf86DoEDID_DDC1() with a dummy version that prints a
warning message and just returns NULL? That should keep drivers from
breaking.
I'm completely fine with patching the drivers to only call
On 12/1/11 5:51 PM, Michal Suchanek wrote:
On 1 December 2011 22:51, Adam Jacksona...@redhat.com wrote:
The important part of this is the mode list, which we already print in
another form. Everything else is cosmetic and better done in the
session.
Where is this information available if
On 12/2/11 12:09 AM, Peter Hutterer wrote:
On Thu, Dec 01, 2011 at 03:53:41PM -0500, Adam Jackson wrote:
+RemovePropertyFilter
+
+ window: WINDOW
+ property: LISTofATOM
+
+ This request modifies the property filter for the named
On 12/2/11 5:19 AM, Daniel Stone wrote:
Sounds good to me: I don't suppose I could convince you to take a look
at https://bugs.freedesktop.org/show_bug.cgi?id=41784 as well?
Sure.
- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives:
On 2 December 2011 16:13, James Jones jajo...@nvidia.com wrote:
Reviewed-by: James Jones jajo...@nvidia.com
Thanks. :)
Cheers,
Daniel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info:
The code that used getisax to check for MMX support was moved to pixman
and removed from the X server by commit eb2d7fe02f9cbc.
The code that used HAVE_MKSTEMP was deleted by the Xprint removal in
commit 1c8bd318fbaf.
All alloca calls were removed by the patch series end in commit 5e363500c8,
Fixes Sun cc warning that was recently elevated to error by the
stricter default CFLAGS changes to xorg-macros:
loadmod.c, line 914: improper pointer/integer combination: op
Should have been changed when commit ab7f057ce9df4e905b12 changed the
LoaderOpen return type from int to void *.
Changes
Replace multiple methods of checking for funcs calls with AC_CHECK_FUNCS
Replace multiple methods of selecting fallback funcs with AC_REPLACE_FUNCS
Replace HAS_* and NEED_* #defines with autogenerated HAVE_*
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
configure.ac
Started cleaning up some of our libc fallback function checks in configure
and the more I cleaned the more layers of crud I found underneath.
Also silences some annoying warning noise from gcc, and two warnings
from the Sun compiler that the recent changes to xorg-macros had promoted
to errors,
Required in order to build with Studio cc now that xorg-macros is
setting -errwarn=E_FUNC_HAS_NO_RETURN_STMT since it doesn't
recognize that the noreturn attribute makes it pointless.
Otherwise compiler exits with errors:
Display.c, line 65: Function has no return statement : x_io_error_handler
On 6/28/11 3:27 PM, Daniel Stone wrote:
externsion.h required bits from Xfuncproto.h and dixstruct.h, but
included neither; fix that.
^ typo, s/ern/en/
- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives:
On 6/28/11 3:27 PM, Daniel Stone wrote:
Extensions could previously declare initialisation dependencies on other
extensions, which would then get nicely sorted by the loader. We only
had one user for this, GLX, which had one pointless (Composite) and one
possibly useful dependency (DBE). As
On 12/02/11 03:27, Daniel Stone wrote:
Similar to the fix for Xinerama, make sure PseudoramiXExtensionInit is
declared as taking no arguments, since its only callers call it with no
arguments ...
Signed-off-by: Daniel Stonedan...@fooishbar.org
Reviewed-by: Alan Coopersmith
2011/12/2 Daniel Stone dan...@fooishbar.org:
@@ -90,6 +104,9 @@ load_extension_config(void)
}
#endif
}
+
+ for (i = 0; i ARRAY_SIZE(extensionModules); i++)
+ LoadExtension(extensionModules[i], TRUE);
}
void
With this statement, Xorg will try to load its modules
On 12/02/11 13:05, Aaron Plattner wrote:
Some of these changes could use corresponding changes to doc/Xserver-spec.xml.
As well as hw/xfree86/doc/ddxDesign.xml
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
On Fri, 2011-12-02 at 10:48 -0800, Alan Coopersmith wrote:
The code that used getisax to check for MMX support was moved to
pixman
and removed from the X server by commit eb2d7fe02f9cbc.
The code that used HAVE_MKSTEMP was deleted by the Xprint removal in
commit 1c8bd318fbaf.
All alloca
On Fri, 2011-12-02 at 10:48 -0800, Alan Coopersmith wrote:
Replace multiple methods of checking for funcs calls with
AC_CHECK_FUNCS
Replace multiple methods of selecting fallback funcs with
AC_REPLACE_FUNCS
A feature of autoconf I had not encountered yet. AC_REPLACE_FUNCS uses
AC_LIBOBJ
On 12/02/11 18:30, Gaetan Nadon wrote:
This os Makefile.am should read:
libos_la_LIBADD = @SHA1_LIBS@ $(DLOPEN_LIBS) $(LTLIBOBJS) -- Use LTLIBOBJS
rather than LIBOBJS
I get a successful build now.
It links with .lo files now:
[...] -lcrypto -ldl strlcat.lo strlcpy.lo -lm-lrt
Thanks
Uses /proc/pid/psinfo to read command partial arguments.
Moves cmdsize argsize variables into non-Solaris #else clause
to avoid unused variable warnings.
Fixes format mismatch errors when building with DEBUG defined on
a 64-bit platform (where Mask is defined as CARD32).
Signed-off-by: Alan
77 matches
Mail list logo
