Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
glx/glxdri2.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index 8187a3e..b2174f5 100644
--- a/glx/glxdri2.c
+++
All the callers were already checking for failure, except that
createSourcePicture() itself was failing to check whether it
successfully allocated the Picture.
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
render/picture.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
From: Paulo Zanoni paulo.r.zan...@intel.com
We were correctly swapping the valuator values, but we were not
calling valuator_mask_unset() when needed, so the cursor kept jumping
to the edges.
This patch does the swapping before the main for, so we don't need to
store unswapped_{x,y} and
On Wed, Dec 14, 2011 at 20:43:11 +0900, Kusanagi Kouichi wrote:
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
glx/glxdri2.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/glx/glxdri2.c
On Wed, 14 Dec 2011 19:37:26 +0100, Julien Cristau jcris...@debian.org wrote:
On Wed, Dec 14, 2011 at 15:55:22 +, Chris Wilson wrote:
All the callers were already checking for failure, except that
createSourcePicture() itself was failing to check whether it
successfully allocated the
On Thu, 01 Dec 2011 17:42:40 -0500, Adam Jackson a...@redhat.com wrote:
Minor memory usage reductions, some code cleanups, and the connection
handshake hack for clients to request being treated as non-local (so ssh
forwarded connecitons don't appear to be local).
---
The following changes
On Wed, Dec 14, 2011 at 11:30:37 -0800, Keith Packard wrote:
On Thu, 01 Dec 2011 17:42:40 -0500, Adam Jackson a...@redhat.com wrote:
The following changes since commit fb22a408c69a84f81905147de9e82cf66ffb6eb2:
Save major/minor opcodes in ClientRec for RecordAReply (2011-12-01
On Mon, 12 Dec 2011 17:25:06 -0800, Alan Coopersmith
alan.coopersm...@oracle.com wrote:
Alan Coopersmith (24):
xf86RegisterRootWindowProperty is confused about xnfcalloc
Even more correctly free config file names
CheckForEmptyMask does not need to declare int n twice
On Tue, 13 Dec 2011 15:15:22 +1000, Peter Hutterer peter.hutte...@who-t.net
wrote:
Alan Coopersmith (4):
Include client name if available in PrintDeviceGrabInfo
Fix deconstifying cast warning in xi2_get_type
Use const cast in BitIsOn macro to avoid angering gcc
Signed-off-by: Adam Jackson a...@redhat.com
---
specs/sect1-9.xml | 15 +++
1 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/specs/sect1-9.xml b/specs/sect1-9.xml
index edc2971..7e5896c 100644
--- a/specs/sect1-9.xml
+++ b/specs/sect1-9.xml
@@ -1157,10 +1157,17 @@ the
On 12/13/2011 02:56 PM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Chase Douglas chase.doug...@canonical.com
And pushed to inputproto branch multitouch-devel.
___
xorg-devel@lists.x.org: X.Org development
On 12/13/2011 02:56 PM, Peter Hutterer wrote:
Emulated pointer events will have button 1 logically down, but touch events
only represent the actual button state, irrespective of the touches.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Chase Douglas
On 12/14/2011 09:23 AM, przan...@gmail.com wrote:
From: Paulo Zanoni paulo.r.zan...@intel.com
We were correctly swapping the valuator values, but we were not
calling valuator_mask_unset() when needed, so the cursor kept jumping
to the edges.
This patch does the swapping before the main
On Wed, 2011-12-14 at 20:33 +0100, Julien Cristau wrote:
On Wed, Dec 14, 2011 at 11:30:37 -0800, Keith Packard wrote:
On Thu, 01 Dec 2011 17:42:40 -0500, Adam Jackson a...@redhat.com wrote:
The following changes since commit
fb22a408c69a84f81905147de9e82cf66ffb6eb2:
Save
On Wed, 14 Dec 2011 10:34:19 +1000, Peter Hutterer peter.hutte...@who-t.net
wrote:
We do the same thing for libraries and optional modules already, and it's
much easier to read when one of them changes
Merged.
7da7aa9..f7ea7a3 master - master
--
keith.pack...@intel.com
Could you have a look at my patches to do this, from October? I believe
Keith just wanted an ABI bump before merge, but I'd run out of time by
then, and now I assume it's too late for this cycle.
They're still sitting on my reviewed branch:
On 12/14/11 15:57, Jamey Sharp wrote:
Could you have a look at my patches to do this, from October? I believe
Keith just wanted an ABI bump before merge, but I'd run out of time by
then, and now I assume it's too late for this cycle.
It's not too late yet, but will be in about a week and a
On Mon, Oct 17, 2011 at 02:06:55PM -0700, Keith Packard wrote:
On Wed, 5 Oct 2011 08:30:56 -0700, Jamey Sharp ja...@minilop.net wrote:
Alright, the pixmap hooks have weird undocumented constraints, and
maybe we'll figure out something clever someday. Meanwhile, would you
please merge the
This is the set of patches to add multitouch support to the X server.
The lot can be found in the 'multitouch' branches of the following
repositories
git://people.freedesktop.org/~whot/xserver
git://people.freedesktop.org/~whot/inputproto
Previous declaration required the use of a message + printf varargs. We
obviously want to allow the use of just a message.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
include/misc.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/misc.h
For future touch points, we need positionSprite to calculate the coordinates
but we don't want to actually change the cursor position for non-emulating
touches.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/getevents.c |7 +--
1 files changed, 5 insertions(+), 2
No functional changes.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/exevents.c | 46 +-
1 files changed, 29 insertions(+), 17 deletions(-)
diff --git a/Xi/exevents.c b/Xi/exevents.c
index 45a289a..ad9c3d6 100644
--- a/Xi/exevents.c
All the DeepCopy stuff really needs to be shared between the init calls the
drivers use and this code here. Too many bugs by not keeping the two in
sync.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/exevents.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 27bf6ab..e2d91f2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -776,7 +776,7 @@ XPROTO=xproto = 7.0.22
Touch event mask must be set for all three event types.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
test/xi2/protocol-xipassivegrabdevice.c |2 +-
test/xi2/protocol-xiselectevents.c | 38 --
2 files changed, 31 insertions(+), 9 deletions(-)
Plus, use the actual definition from the protocol instead of the numeric
values. Turns out not everyone knows the protocol event IDs by heart.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
include/inputstr.h |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git
TOUCH_CLIENT_ID is set if the touch was generated from a client ID instead
of a DDX/driver touch ID. i.e. submitted by the dix.
TOUCH_END is a special flag that's required to force the touch to end.
Since the protocol with grab replaying and pointer emulation is rather
complex, it's quite hard to
The are the same as device events internally but require the touch ID
separately from the detail.button field (the protocol uses the detail field
for the touch id).
For simpler integration of pointer emulation we need to set the
detail.button field while keeping the touchid around.
Add the three
No-one can generated them yet, but if they could, we'd be processing them
like there was no tomorrow.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/exevents.c |3 +++
Xi/extinit.c |3 +++
Xi/xiselectev.c|5 -
dix/eventconvert.c | 12
This patch applies most of the protocol conversions and the internal event
type for ownership events.
Note that ownership events are generated by the DIX only, they do not pass
through the event queue.
Co-authored-by: Daniel Stone dan...@fooishbar.org
Signed-off-by: Peter Hutterer
From: Daniel Stone dan...@fooishbar.org
xf86PostTouchEvent is the driver API to submit touch events to the server.
This API doesn't do anything yet though but now we can at least bump the
API.
For valuators, drivers should use the existing xf86InitValuatorAxisStruct
function.
Signed-off-by:
From: Daniel Stone dan...@fooishbar.org
These structs will be used to store touch-related data, events and
information.
Drivers must call InitTouchClassDeviceStruct to set up a multi-touch capable
device.
Touchpoints for the DDX and the DIX are handled separately - touchpoints
submitted by the
New additions to the API:
- InitTouchClassDeviceStruct
- xf86PostTouchEvent
Changes to the ABI:
- DeviceIntRec now contains a TouchClassPtr
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
hw/xfree86/common/xf86Module.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
DDX touch points are the ones that keep records of the driver-submitted
touchpoints. They're unaffected by the grab state and terminate on a
TouchEnd submitted by the driver.
The client ID assigned is server-global.
Since drivers usually submit in the SIGIO handler, we cannot allocate in the
The SIGIO handler forces us to drop the current touch and schedule the
actual resize for later. Should not happen if the device sets up the
TouchClassRec with the correct number of touchpoints.
Co-authored-by: Daniel Stone dan...@fooishbar.org
Signed-off-by: Peter Hutterer
The DIX touchpoints are the ones used for event processing.
Co-authored-by: Daniel Stone dan...@fooishbar.org
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/touch.c | 123 +++
include/input.h |5 ++
test/touch.c|
From: Daniel Stone dan...@fooishbar.org
No callers yet. This API is not to be used by drivers, it's an API for the
DIX which will create ownership events mainly on touch acceptance/rejection.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/getevents.c | 35
From: Daniel Stone dan...@fooishbar.org
The touchpoints are generated, enqueued but not processed since we don't
handle them in the event processing yet.
Co-authored-by: Peter Hutterer peter.hutte...@who-t.net
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/getevents.c | 148
The DIX needs to submit touch events for e.g. TouchEnd after an
acceptance/rejection. These have the TOUCH_CLIENT_ID flag set.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/getevents.c | 77 --
1 files changed, 57
From: Daniel Stone dan...@fooishbar.org
Selecting for any of XI_TouchBegin/Update/End/Ownership requires the three
bits for begin/update/end to be set.
Only one client at a time may select for XI_TouchBegin event
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/xiselectev.c | 43
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
include/protocol-versions.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/protocol-versions.h b/include/protocol-versions.h
index 832bcf7..479ac2f 100644
--- a/include/protocol-versions.h
+++
If touch client has not registered for ownership events and a grab above
that client is rejected, the client needs to receive the complete event
history.
The history currently doesn't really do fancy overflow handling. We assume
that the first TOUCH_HISTORY_SIZE events are the important ones and
From: Daniel Stone dan...@fooishbar.org
Touch events' sprite trace stays the same for the duration of the touch
sequence.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/touch.c | 87 +++
include/input.h |4 ++
2 files
From: Daniel Stone dan...@fooishbar.org
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/exevents.c | 30 ++
dix/window.c |9 +++--
include/exevents.h |4
3 files changed, 41 insertions(+), 2 deletions(-)
diff --git
From: Chase Douglas chase.doug...@canonical.com
Returns the respective pointer event type for a given touch event type.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/touch.c | 21 +
include/input.h |1 +
2 files changed, 22 insertions(+), 0
The DIX will call TouchSetupListeners once for a new touch. After that
the listener list remains static, with listeners only dropping out when they
either reject the grab or disappear.
Exception: if grabs activate they are prefixed to the listeners.
Signed-off-by: Peter Hutterer
The first listener in the sequence is the owner of the touch sequence.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/touch.c | 10 ++
include/input.h |1 +
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/dix/touch.c b/dix/touch.c
index
Update the logical button state for pointer-emulating events. Button state
must be kept separate from the ButtonClassRec to avoid clearing the button
state on a touch end if there is a physical button still down.
And obviously don't change the button state if we're currently replaying the
event
If a pointer-emulating touch caused a button to be logically down, set that
state in the input events.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/inpututils.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/dix/inpututils.c b/dix/inpututils.c
Does not include pointer emulation handling.
Does include partial ownership handling but not the actual processing of
ownership events.
Note: this commit is a retroactive commit extracted from a series of ~50
commits and may thus appear a bit more complicated than what you'd write out
from
For touch events with pointer emulation, the event that triggers the grab
(the pointer event) is not the same as the actual event (the touch event).
For replaying, we need to store the real event then.
No effective changes at this point, for the current caller event and
real_event are identical.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/touch.c | 62 +++
include/input.h |2 +
2 files changed, 64 insertions(+), 0 deletions(-)
diff --git a/dix/touch.c b/dix/touch.c
index c320ff1..09ae864 100644
---
Includes a hack for implicit grab activation, because integrating this
requires a larger rewrite and I'm not sleeping enough as it is.
Right now, we deliver the event and check before/after if there is an
implicit grab on. If one activated, then store the event in the grab and
switch the listener
Ownership changes don't get processed directly when they happen, instead the
DIX submits an ownership event which goes through ProcessTouchEvents and
ProcessTouchOwnershipEvents.
Then on the required events are generated and sent to clients.
Co-authored-by: Daniel Stone dan...@fooishbar.org
Consists mostly of generating an ownership event and processing it.
Co-authored-by: Daniel Stone dan...@fooishbar.org
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/xiallowev.c | 53 -
1 files changed, 52 insertions(+), 1
Co-authored-by: Daniel Stone dan...@fooishbar.org
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/exevents.c | 28
Xi/xipassivegrab.c | 17 +++--
include/exevents.h |8
3 files changed, 51 insertions(+), 2 deletions(-)
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/events.c| 37 +
dix/touch.c | 26 ++
include/input.h |1 +
3 files changed, 60 insertions(+), 4 deletions(-)
diff --git a/dix/events.c b/dix/events.c
index
From: Daniel Stone dan...@fooishbar.org
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/grabs.c |3 +++
dix/touch.c | 41 +
include/input.h |1 +
3 files changed, 45 insertions(+), 0 deletions(-)
diff --git a/dix/grabs.c
No functional changes.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
mi/mieq.c | 22 +++---
1 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/mi/mieq.c b/mi/mieq.c
index ea8bcf0..5bdf971 100644
--- a/mi/mieq.c
+++ b/mi/mieq.c
@@ -471,6 +471,19 @@
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
mi/mieq.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/mi/mieq.c b/mi/mieq.c
index 5bdf971..6c46eb9 100644
--- a/mi/mieq.c
+++ b/mi/mieq.c
@@ -514,6 +514,12 @@ mieqProcessDeviceEvent(DeviceIntPtr dev,
From: Carlos Garnacho carl...@gnome.org
CreateGrab() expects the keyboard mode to be stored in grab_mode, and the
pointer mode in other_device_mode, so respect this in passive XI2 grabs,
and switch modes if needed.
Signed-off-by: Carlos Garnacho carl...@gnome.org
Signed-off-by: Peter Hutterer
On 12/14/11 19:01, Peter Hutterer wrote:
Previous declaration required the use of a message + printf varargs. We
obviously want to allow the use of just a message.
Signed-off-by: Peter Huttererpeter.hutte...@who-t.net
---
include/misc.h |4 ++--
1 files changed, 2 insertions(+), 2
On 2011-12-14 19:35:37 +0100, Julien Cristau wrote:
On Wed, Dec 14, 2011 at 20:43:11 +0900, Kusanagi Kouichi wrote:
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
glx/glxdri2.c | 13 +++--
1 files changed, 7
On 12/11/11 16:30, Robert Bragg wrote:
This function was constructing an address from a port string allocating
a buffer according to the size of the string but then later copying
the address according to sizeof(struct sockaddr).
This patch ensures that we allocate a struct sockaddr buffer with
On 12/14/11 19:01, Peter Hutterer wrote:
For future touch points, we need positionSprite to calculate the coordinates
but we don't want to actually change the cursor position for non-emulating
touches.
Signed-off-by: Peter Huttererpeter.hutte...@who-t.net
Reviewed-by: Alan Coopersmith
On Wed, Dec 14, 2011 at 12:09:23PM -0800, Chase Douglas wrote:
On 12/14/2011 09:23 AM, przan...@gmail.com wrote:
From: Paulo Zanoni paulo.r.zan...@intel.com
We were correctly swapping the valuator values, but we were not
calling valuator_mask_unset() when needed, so the cursor kept
On 12/14/11 19:01, Peter Hutterer wrote:
No functional changes.
Signed-off-by: Peter Huttererpeter.hutte...@who-t.net
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X
On 12/14/11 19:01, Peter Hutterer wrote:
All the DeepCopy stuff really needs to be shared between the init calls the
drivers use and this code here. Too many bugs by not keeping the two in
sync.
Signed-off-by: Peter Huttererpeter.hutte...@who-t.net
Reviewed-by: Alan Coopersmith
On 12/14/11 19:01, Peter Hutterer wrote:
Signed-off-by: Peter Huttererpeter.hutte...@who-t.net
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 27bf6ab..e2d91f2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -776,7
On Wed, Dec 14, 2011 at 03:23:36PM -0200, przan...@gmail.com wrote:
From: Paulo Zanoni paulo.r.zan...@intel.com
We were correctly swapping the valuator values, but we were not
calling valuator_mask_unset() when needed, so the cursor kept jumping
to the edges.
This patch does the swapping
On 12/14/11 19:01, Peter Hutterer wrote:
Plus, use the actual definition from the protocol instead of the numeric
values. Turns out not everyone knows the protocol event IDs by heart.
Signed-off-by: Peter Huttererpeter.hutte...@who-t.net
Reviewed-by: Alan Coopersmith
On Thu, Dec 15, 2011 at 01:01:37PM +1000, Peter Hutterer wrote:
This is the set of patches to add multitouch support to the X server.
The lot can be found in the 'multitouch' branches of the following
repositories
git://people.freedesktop.org/~whot/xserver
On 11/03/2011 11:16 AM, Keith Packard wrote:
On Sat, 29 Oct 2011 20:47:16 +0700, Antoine Martin anto...@nagafix.co.uk
wrote:
Keith, is there anything else I should do to get this merged?
This kind of patch could really use some careful review by someone with
a good knowledge of Posix
On 11/11/2011 08:59 AM, Jamey Sharp wrote:
On 11/10/11, Alan Hourihane al...@fairlite.co.uk wrote:
On 11/10/11 23:40, Peter Hutterer wrote:
I wonder how much effort it would be to write a xf86-video-vnc that runs
on xfree86 ddx.
That would be interesting to try, and there's some library out
This patch obviously doesn't change any behavior, but wouldn't it be
more clear to just factor out the beginning of positionSprite to a
computeSpritePosition or something?
I suppose there's a later patch that justifies this approach, but I
can't help thinking that returning early by adding
On 12/14/11, Antoine Martin anto...@nagafix.co.uk wrote:
On 11/11/2011 08:59 AM, Jamey Sharp wrote:
Or use a modern implementation like x11vnc that uses COMPOSITE so it
doesn't need any server-side code at all. :-) That's the approach
we're trying to adopt in this new project.
This approach
On Thu, Dec 15, 2011 at 13:41:25 +0900, Kusanagi Kouichi wrote:
On 2011-12-14 19:35:37 +0100, Julien Cristau wrote:
seems like you're trading a memory leak for a fd leak?
IIUC, a returned fd is being managed by a driver.
Oh, alright then, thanks.
Cheers,
Julien
77 matches
Mail list logo
