Re: [PATCH synaptics 3/3] test: fix build error introduced in 9f9b55ab55ed5

2012-01-03 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (03/01/2012): Bad search/replace, ended up in two xf86SetStrOption declarations which differed on ABIs 14. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=44335 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Cyril Brulebois

Re: PING: [PATCH xserver] xkb: Message actions suppress other key presses #28575

2012-01-03 Thread Daniel Stone
Hi, On 2 January 2012 20:44, Jeremy Huddleston jerem...@apple.com wrote: Poking Daniel, Chase, and Peter directly since they understand this magic best. On Nov 30, 2011, at 2:20 PM, Andreas Wettstein wrote: When a key to which a message action is mapped is held down, presses of other keys

Request review patch compose key sequences musical symbols

2012-01-03 Thread Pander
Hi all, Please review attached patch to complere compose key sequences for musical symbols as is described in: https://bugs.freedesktop.org/show_bug.cgi?id=44313 Best regards, Pander diff --git a/nls/en_US.UTF-8/Compose.pre b/nls/en_US.UTF-8/Compose.pre index d5b01b1..39bd047 100644 ---

Re: [PATCH libXrender] Fix alpha premultiplication in XRenderParseColor.

2012-01-03 Thread Jeremy Huddleston
I believe just the division is unsigned with those changes. The multiplication will still be signed. On Jan 2, 2012, at 2:58 PM, Emanuele Giaquinta wrote: Due to C arithmetic conversion rules we must use an unsigned constant (or a cast) to perform the multiplication using unsigned

Re: [PATCH libXrender] Fix alpha premultiplication in XRenderParseColor.

2012-01-03 Thread Emanuele Giaquinta
On Tue, Jan 03, 2012 at 08:21:32AM -0500, Jeremy Huddleston wrote: I believe just the division is unsigned with those changes. The multiplication will still be signed. No, the type of XRenderColor fields is unsigned short. On Jan 2, 2012, at 2:58 PM, Emanuele Giaquinta wrote: Due to C

Re: [PATCH xserver] dix: Set XITouchEmulatingPointer on events from the touch sequence emulating pointer events

2012-01-03 Thread Chase Douglas
On 01/02/2012 05:43 PM, carl...@gnome.org wrote: From: Carlos Garnacho carl...@gnome.org The internal flag is kept around, merely translated to XITouchEmulatingPointer when creating the XI2 events that will be delivered to the client. Signed-off-by: Carlos Garnacho carl...@gnome.org Looks

Re: [PATCH XTS] lib/Xinput: include stdlib for getenv

2012-01-03 Thread Chase Douglas
On 01/02/2012 09:52 PM, Peter Hutterer wrote: Crashes XSetDeviceFocus and probably everything else in XI that relies on d = getenv(DISPLAY); dpy = XOpenDisplay(d); With this patch, the tests now change from UNRESOLVED to UNTESTED. Hooray. Signed-off-by: Peter Hutterer

Re: [PATCH XTS] lib/Xinput: check for the new device usage types

2012-01-03 Thread Chase Douglas
On 01/02/2012 10:00 PM, Peter Hutterer wrote: IsXExtensionPointer/Keyboard were introduced with XI 1.4, check for those too before claiming there aren't any devices. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks right to me. Reviewed-by: Chase Douglas

support for APL character overstrikes in en_US.UTF-8/Compose

2012-01-03 Thread Geoff Streeter
I have proposed some additional compositions to support the APL programming language. See https://bugs.freedesktop.org/show_bug.cgi?id=44059 APL started with IBM golf ball terminals and has always had the concept of composed characters which were built with overstrikes. So ∇ overstruck |

Re: [PATCH xorg-docs] informaltable cleanup

2012-01-03 Thread Gaetan Nadon
On 12-01-02 10:40 PM, Matt Dew wrote: On certain tables, add top and bottom borders to table header and a bottom border to the table. This matches what those tables in the old pdfs looked like. the ?dbfo keep-together='always' prevents tables from splitting across pages. Useful for tiny

Re: [PATCH XTS] lib/Xinput: include stdlib for getenv

2012-01-03 Thread Alan Coopersmith
On 01/02/12 21:52, Peter Hutterer wrote: Crashes XSetDeviceFocus and probably everything else in XI that relies on d = getenv(DISPLAY); dpy = XOpenDisplay(d); With this patch, the tests now change from UNRESOLVED to UNTESTED. Hooray. Signed-off-by: Peter

Re: [PATCH xorg-docs] informaltable cleanup

2012-01-03 Thread Matt Dew
On 01/03/2012 08:41 AM, Gaetan Nadon wrote: On 12-01-02 10:40 PM, Matt Dew wrote: On certain tables, add top and bottom borders to table header and a bottom border to the table. This matches what those tables in the old pdfs looked like. the?dbfo keep-together='always' prevents tables from

Re: [PATCH v2] Workaround conflict between Solaris sys/list.h Xorg list.h definitions

2012-01-03 Thread Aaron Plattner
Tested-by: Aaron Plattner aplatt...@nvidia.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com Grammar nitpick: Workaround is a noun. Work around is a (compound) verb. On 12/23/2011 03:23 PM, Alan Coopersmith wrote: sys/ipc_impl.h includes the Solarissys/list.h but doesn't use any

Re: [PATCH] Always install xaa sdk headers

2012-01-03 Thread Julien Cristau
On Tue, Jan 3, 2012 at 16:22:24 +1000, Peter Hutterer wrote: From: Adam Jackson a...@redhat.com Always install XAA SDK headers so drivers still build even with --disable-xaa Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/Makefile.am |2 --

Re: [PATCH libpciaccess] OpenBSD: Implement map_legacy and legacy_io

2012-01-03 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sat, 31 Dec 2011 15:08:52 -0500 On Dec 31, 2011, at 2:50 PM, Mark Kettenis wrote: From: Jeremy Huddleston jerem...@apple.com Date: Sat, 31 Dec 2011 10:28:11 -0500 There is a logic error in the preprocessing which seems to assume

Re: [PATCH] Always install xaa sdk headers

2012-01-03 Thread Adam Jackson
On 1/3/12 2:18 PM, Julien Cristau wrote: On Tue, Jan 3, 2012 at 16:22:24 +1000, Peter Hutterer wrote: From: Adam Jacksona...@redhat.com Always install XAA SDK headers so drivers still build even with --disable-xaa Signed-off-by: Peter Huttererpeter.hutte...@who-t.net ---

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Ian Romanick
On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find input file: `tests/Makefile.in' Before I raise a bug am I doing

Re: X.org testing with Google Test

2012-01-03 Thread Ian Romanick
On 01/02/2012 06:06 PM, Chase Douglas wrote: On 01/02/2012 05:54 PM, Jeremy Huddleston wrote: Also, the tinderbox currently does make use of the existing unit tests in the server by running 'make check' after the build. I assume we could easily add these new unit tests to 'make check' and it

Re: [PATCH libXrender] Fix alpha premultiplication in XRenderParseColor.

2012-01-03 Thread Jeremy Huddleston
Ah, ok. Reviewed-by: Jeremy Huddleston jerem...@apple.com On Jan 3, 2012, at 8:42 AM, Emanuele Giaquinta wrote: On Tue, Jan 03, 2012 at 08:21:32AM -0500, Jeremy Huddleston wrote: I believe just the division is unsigned with those changes. The multiplication will still be signed. No, the

Re: [PATCH:libX11] Add more Xkb man pages to the See Also lists for core keyboard functions

2012-01-03 Thread Peter Hutterer
On Wed, Dec 28, 2011 at 09:38:51PM -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter --- man/IsCursorKey.man|1 + man/XChangeKeyboardControl.man |4

Re: [PATCH intel-gpu-tools 0/4] Upgrade module configuration and packaging

2012-01-03 Thread Ben Widawsky
On 01/02/2012 08:17 AM, Gaetan Nadon wrote: This module is hosted as an X.Org app and is published as such. This patch adds some missing packaging files and sets some basic infrastructure common to all xorg modules which saves maintenance in the long run.

[PATCH xf86-input-evdev] Set the default resolution to 0

2012-01-03 Thread Chase Douglas
If we don't know the resolution, set it to 0. This is invalid, and tells the X client that we don't know the resolution, rather than reporting an incorrect value. This value was originally from commit 6271494faa4c45f4fa10509f72e0515f2cef36c6, which is the initial commit from Adam Jackson adding

Re: [xproto: PATCH] Xmd.h: amd64-x32 ABI defines sizeof(long) == sizeof (void*) == 4

2012-01-03 Thread Peter Harris
On 2011-12-30 15:07, Sergei Trofimovich wrote: On Wed, 28 Dec 2011 12:45:03 -0800 Alan Coopersmith alan.coopersm...@oracle.com wrote: C code checking __amd64__ mostly does so to find out the size of long pointers. Instructions are usually at the assembly level, not the C code level.

[PATCH v2 xf85-input-evdev] Set the default resolution to 0

2012-01-03 Thread Chase Douglas
If we don't know the resolution, set it to 0. This is invalid, and tells the X client that we don't know the resolution, rather than reporting an incorrect value. This value was originally from commit 6271494faa4c45f4fa10509f72e0515f2cef36c6, which is the initial commit from Adam Jackson adding

Re: [PATCH 02/11] glx: Don't track GLClientmajorVersion or GLClientminorVersion

2012-01-03 Thread Jesse Barnes
On Fri, 23 Dec 2011 15:18:20 -0800 Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Nothing uses these fields anywhere in the server. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- Looks fine. Reviewed-by: Jesse Barnes

Re: [PATCH 03/11] glx: Extend __GLXscreen::createContext to take attributes

2012-01-03 Thread Jesse Barnes
On Fri, 23 Dec 2011 15:18:21 -0800 Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- glx/glxcmds.c | 13 ++--- glx/glxdri.c | 10 +- glx/glxdri2.c |5 -

Re: [PATCH 05/11] glx: Optionally call DRI2 createContextAttribs from __glXDRIscreenCreateContext

2012-01-03 Thread Jesse Barnes
On Fri, 23 Dec 2011 15:18:23 -0800 Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- glx/glxdri2.c | 143 ++-- 1 files changed, 137

Re: [PATCH 07/11] glx: Initialize all context fields together

2012-01-03 Thread Jesse Barnes
On Fri, 23 Dec 2011 15:18:25 -0800 Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- glx/glxcmds.c | 23 --- 1 files changed, 8 insertions(+), 15 deletions(-) Seems like a

Re: [PATCH 08/11] glx: Initialize remaining context fields

2012-01-03 Thread Jesse Barnes
On Fri, 23 Dec 2011 15:18:26 -0800 Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com There is no reason to assume the screen's context allocated initialized these fields, so don't. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- glx/glxcmds.c

Re: [PATCH 09/11] glx: Use one function to add a context to all global tables

2012-01-03 Thread Jesse Barnes
On Fri, 23 Dec 2011 15:18:27 -0800 Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Instead of having separate __glXAddContextToList and AddResource functions, just have one function that does both steps. Signed-off-by: Ian Romanick

Re: [xproto: PATCH] Xmd.h: amd64-x32 ABI defines sizeof(long) == sizeof (void*) == 4

2012-01-03 Thread Adam Jackson
On 12/28/11 3:29 PM, Lu, Hongjiu wrote: __LP64__ isn't the part of x86-64 psABI while GCC always define __LP64__ for 64bit long on x86. I can check if other compilers do the same. In most cases, __amd64__ is checked for 64bit instructions and we have ported those we have found so far to x32 so

Re: [PATCH 05/11] glx: Optionally call DRI2 createContextAttribs from __glXDRIscreenCreateContext

2012-01-03 Thread Ian Romanick
On 01/03/2012 04:22 PM, Jesse Barnes wrote: On Fri, 23 Dec 2011 15:18:23 -0800 Ian Romanicki...@freedesktop.org wrote: From: Ian Romanickian.d.roman...@intel.com Signed-off-by: Ian Romanickian.d.roman...@intel.com --- glx/glxdri2.c | 143

Re: [PATCH 09/11] glx: Use one function to add a context to all global tables

2012-01-03 Thread Ian Romanick
On 01/03/2012 04:28 PM, Jesse Barnes wrote: On Fri, 23 Dec 2011 15:18:27 -0800 Ian Romanicki...@freedesktop.org wrote: From: Ian Romanickian.d.roman...@intel.com Instead of having separate __glXAddContextToList and AddResource functions, just have one function that does both steps.

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Gaetan Nadon
On 12-01-03 03:27 PM, Ian Romanick wrote: On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find input file:

[PATCH xf86-input-evdev] Copy last valuator values into new touch valuator masks

2012-01-03 Thread Chase Douglas
Evdev is a 100% stateful protocol. The following is correct, and represents a double tap: ABS_MT_SLOT 0 /* Set touch slot */ ABS_MT_TRACKING_ID 0 /* New touch with ID 0 in slot 0 */ ABS_MT_POSITION_X 500 /* Initial X position */ ABS_MT_POSITION_Y 500

[PATCH intel-gpu-tools 00/10] Upgrade module configuration and packaging (reposted to .cc)

2012-01-03 Thread Gaetan Nadon
This module is hosted as an X.Org app and is published as such. This patch adds some missing packaging files and sets some basic infrastructure common to all xorg modules which saves maintenance in the long run. http://www.x.org/wiki/NewModuleGuidelines This series applies some xorg project

[PATCH intel-gpu-tools 01/10] Add mandatory COPYING file.

2012-01-03 Thread Gaetan Nadon
This module is hosted as an X.Org app and is published as such. This file is a summary of the copyright statements in the source code. http://www.x.org/wiki/NewModuleGuidelines Acked-by: Cyril Brulebois k...@debian.org Reviewed-by: Ben Widawsky b...@bwidawsk.net Signed-off-by: Gaetan Nadon

[PATCH intel-gpu-tools 03/10] Man pages still showing version 1.0 in the 1.1 release

2012-01-03 Thread Gaetan Nadon
The patch coverts the man subdir to the standard xorg man page makefile. The version number is automatically updated when a new release is made. The man page section number is no longer hard coded either. The package util-macros at version 1.8 or greater is required. Acked-by: Cyril Brulebois

[PATCH intel-gpu-tools 04/10] Add mandatory ChangeLog and INSTALL files

2012-01-03 Thread Gaetan Nadon
These are generated from a macro in the util-macros package Refer to the wiki for more details. http://www.x.org/wiki/NewModuleGuidelines. Acked-by: Cyril Brulebois k...@debian.org Reviewed-by: Ben Widawsky b...@bwidawsk.net Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Makefile.am |

[PATCH intel-gpu-tools 05/10] config: remove unrequired AM_PROG_CC_C_O

2012-01-03 Thread Gaetan Nadon
Required when using per-target flags or subdir-objects with C sources. http://www.gnu.org/software/automake/manual/automake.html Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac

[PATCH intel-gpu-tools 06/10] config: remove duplicate AC_PROG_CC and AC_PROG__CC_99

2012-01-03 Thread Gaetan Nadon
The compiler was configured three times. It is done once by XORG_DEFAULT_OPTIONS in util-macros. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac | 21 ++--- 1 files changed, 6 insertions(+), 15 deletions(-) diff --git a/configure.ac b/configure.ac index

[PATCH intel-gpu-tools 07/10] config: use project wide xorg warnings variable

2012-01-03 Thread Gaetan Nadon
Use CWARNFLAGS as in all of xorg. There seems to be no reason why this module should be different. The warnings were updated recently for those who install the latest util-macros. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- benchmarks/Makefile.am |2 +- configure.ac | 12

[PATCH intel-gpu-tools 08/10] config: set-up xorg automatic rebuilding rules

2012-01-03 Thread Gaetan Nadon
The current code is a noop. Use the same configuration as all the other xorg modules. This will change in the future but it is less confusing when all modules behave the same way. Note that these rules apply to building from a tarball only. Restore autogen.sh to be identical in all xorg modules.

[PATCH intel-gpu-tools 09/10] config: the minimum version for autoconf is 2.60

2012-01-03 Thread Gaetan Nadon
A version later than 2.60 can be used, but no new features from such a later version can be used in configure.ac. The toolchain version requirements are documented here: http://www.x.org/wiki/ModularDevelopersGuide#GNU_Build_System Minimum version for Automake is 1.10 but we have not written it

[PATCH intel-gpu-tools 10/10] config: restore the libtool minimum version to 1.5

2012-01-03 Thread Gaetan Nadon
Very few systems still use this old version, but it would be inconvenient to build a video driver with libtool 1.5 and have to build the gpu tools on another system having libtool 2.2. The toolchain version requirements are documented here:

Re: [PATCH intel-gpu-tools 00/10] Upgrade module configuration - Part 2

2012-01-03 Thread Eric Anholt
On Mon, 02 Jan 2012 18:23:15 -0500, Gaetan Nadon mems...@videotron.ca wrote: This series applies some xorg project policies and code reuse from util-macros. In some cases it reverts upgrades that were too new for the overall xorg. There were no bug fixes, things went smoothly. Both series

[PATCH sis] Use miPointerSetPosition, not miPointerAbsoluteCursor

2012-01-03 Thread Peter Hutterer
miPointerAbsoluteCursor was removed in '09. Technically this shouldn't just work on the VCP since any master pointer may end up in the dead area. However, I suspect the Venn diagramm of MPX users and sis merged framebuffer users shows little overlap. miPointerSetPosition's prototype changed a

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Ian Romanick
On 01/03/2012 06:06 PM, Mike Lothian wrote: On 3 January 2012 20:27, Ian Romanicki...@freedesktop.org wrote: On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating

[PATCH sis] Untangle XF86DRI from the driver-specific DRI define

2012-01-03 Thread Peter Hutterer
XF86DRI is defined by xorg-server.h, so --disable-dri in the sis driver itself does exactly nothing other than not fill in the CFLAGS and thus stop the driver from compiling. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- configure.ac |4 ++-- src/sis.h| 16

[PATCH] mi/mibitblt: Fix an overflow bug of bit shift.

2012-01-03 Thread zhigang . gong
From: Zhigang Gong zhigang.g...@linux.intel.com When depth equal to 32 and planeMask equal to 0, the overflow will occur and cause the pixmap can't be cleared. There are some test cases in XTS hit this bug, and this fix can eliminate the corresponding failures. Signed-off-by: Zhigang Gong

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Mike Lothian
Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find input file: `tests/Makefile.in' Before I raise a bug am I doing something stupid? Cheers Mike

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Mike Lothian
On 3 January 2012 20:27, Ian Romanick i...@freedesktop.org wrote: On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Mike Lothian
On 3 January 2012 20:27, Ian Romanick i...@freedesktop.org wrote: On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find