Re: [PATCH] dix: put warning in for scroll increments of 0

2012-03-15 Thread Keith Packard
#part sign=pgpmime On Thu, 15 Mar 2012 13:46:56 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: If the increment is 0 but this is a scroll axis, it's definitely a bug. Nonetheless, it has happened, so put a warning in and a return statement that we avoid the infinite loop and hopefully

vmware driver freeing non malloced object

2012-03-15 Thread Dave Airlie
Just packaged xorg-x11-drv-vmware-12.0.1 and got this in build logs /bin/sh ../libtool --silent --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..-Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing

Re: [PATCH v2 6/9] Xext: store the bracket values for idle counters in the private

2012-03-15 Thread Jamey Sharp
A small detail: On 3/14/12, Peter Hutterer peter.hutte...@who-t.net wrote: static void IdleTimeWakeupHandler (pointer pCounter, int rc, pointer LastSelectMask) { -SyncCounter *counter = IdleTimeCounter; +SyncCounter *counter = pCounter; ... @@ -2814,7 +2817,7 @@

Re: [PATCH evdev] Fix inverted horizontal scroll (#46205)

2012-03-15 Thread Chase Douglas
On 03/14/2012 10:56 PM, Peter Hutterer wrote: REL_HWHEEL has a positive increment, not a negative one like REL_WHEEL. X.Org Bug 46205 http://bugs.freedesktop.org/show_bug.cgi?id=46205 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net I have seen this bug too, but haven't had a chance

Re: [PATCH v2 9/9] Xext: Add per-device SyncCounters

2012-03-15 Thread Jamey Sharp
For the series v2: Looks good! Reviewed-by: Jamey Sharp ja...@minilop.net Although I'd suggest dropping the unnecessary cast I pointed out in patch 6. Jamey On 3/14/12, Peter Hutterer peter.hutte...@who-t.net wrote: Previously, we only had one idle alarm that was triggered for all devices,

Re: server-1.12-branch

2012-03-15 Thread Daniel Stone
Hi, On 14 March 2012 04:09, Keith Packard kei...@keithp.com wrote: #part sign=pgpmime On Wed, 14 Mar 2012 01:45:47 +, Daniel Stone dan...@fooishbar.org wrote: I can definitely see the argument here.  Keith, do you want me to send you an automated whole-tree changeset, followed by a

Re: [PATCH 0/9] per-device idle counters

2012-03-15 Thread James Jones
On 3/14/12 5:20 PM, Peter Hutterer wrote: On Wed, Mar 14, 2012 at 05:11:04PM -0700, James Jones wrote: I like the cleanups here. I prefer the SysCounterGetPrivate() helper over the macro, but don't particularly think the need to allow SyncNumSystemCounters to go negative by decrementing in

Re: server-1.12-branch

2012-03-15 Thread Keith Packard
#part sign=pgpmime On Thu, 15 Mar 2012 15:20:58 +, Daniel Stone dan...@fooishbar.org wrote: OK, it's on people.fd.o/~daniels/xserver:coding-style now (d2949a1), plus one small fixup for a really obnoxiously-formatted block in, surprise surprise, Xinerama. Although it was pretty

Re: vmware driver freeing non malloced object

2012-03-15 Thread Zack Rusin
On Thursday, March 15, 2012 10:14:25 AM Dave Airlie wrote: Just packaged xorg-x11-drv-vmware-12.0.1 and got this in build logs /bin/sh ../libtool --silent --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..-Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes

Re: [PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions

2012-03-15 Thread Julian Pidancet
On Fri, Mar 9, 2012 at 2:08 AM, Guillem Jover guil...@hadrons.org wrote: On Fri, 2012-03-09 at 00:02:55 +, Julian Pidancet wrote: Some instructions are not emulated correctly by x86emu when they are prefixed by the 0x66 opcode. I've identified problems in the emulation of these

Re: [PATCH v2] x86emu: Correctly handle 0x66 prefix for some instructions

2012-03-15 Thread Julian Pidancet
On Thu, Mar 15, 2012 at 10:39 PM, Julian Pidancet julian.pidan...@gmail.com wrote: On Fri, Mar 9, 2012 at 2:08 AM, Guillem Jover guil...@hadrons.org wrote: On Fri, 2012-03-09 at 00:02:55 +, Julian Pidancet wrote: Some instructions are not emulated correctly by x86emu when they are prefixed