Re: XQuartz tablet mouse events are at the wrong location and other Xinput headaches

2012-03-21 Thread Jeremy Huddleston
On Mar 20, 2012, at 8:07 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sat, Mar 17, 2012 at 12:49:53AM -0700, Jeremy Huddleston wrote: Here are some examples. The first is just valuator_mask_get_double(..., #) for the valuators of the event we enqueue with QueuePointerEvents(pDev,

Re: [PATCH] dix: set raw event values before adding up relative values (#46976)

2012-03-21 Thread Daniel Stone
Hi, On 21 March 2012 04:09, Peter Hutterer peter.hutte...@who-t.net wrote: Regression introduced in 4e52cc0ef48145134cd58d357fb7289e6f8bb709 Raw event values are values as-is from the driver, modified only be transformation or acceleration. 4e52cc caused the mask to be updated from

[PATCH] dri2: SProcDRI2Connect - send the response.

2012-03-21 Thread Michal Srb
The swapped implementation of DRI2Connect is always responding with empty device and driver values. However the response was only prepared and never sent (also had undefined .type member), causing e.g. glxinfo get stuck waiting for response when started remotely from machine with different

Re: [PATCH] dri2: SProcDRI2Connect - send the response.

2012-03-21 Thread Jeremy Huddleston
/facepalm Reviewed-by: Jeremy Huddleston jerem...@apple.com On Mar 21, 2012, at 7:14 AM, Michal Srb m...@suse.com wrote: The swapped implementation of DRI2Connect is always responding with empty device and driver values. However the response was only prepared and never sent (also had

[PATCH xf86-input-synaptics 2/4] Fix clickfinger actions when buttons other than 1 are reported

2012-03-21 Thread Chase Douglas
The old logical state now holds the clickfinger action button. In order to check for proper clickpad press transition, we need to check if any of the left, middle, and right logical button states are pressed. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/synaptics.c |3 ++-

[PATCH xf86-input-synaptics 1/4] Fix clickfinger actions when middle button emulation is enabled

2012-03-21 Thread Chase Douglas
When MBE is enabled, a physical left button press is delayed until a timeout is reached. This results in the logical left button being depressed while the physical left button is pressed. The physical state is stored as the old hw state, and it is used for detecting a transition from depressed to

[PATCH xf86-input-synaptics 3/4] Keep track of which touch slots are open

2012-03-21 Thread Chase Douglas
This change adds a new touch slot state that denotes when the slot is open but does not have any new data to report. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/eventcomm.c |3 ++- src/synproto.c | 13 - src/synproto.h |1 + 3 files changed, 15

[PATCH xf86-input-synaptics 4/4] Include open but unchanged touches when guessing clickfingers

2012-03-21 Thread Chase Douglas
On a clickpad, when the button is pressed the clickfinger guessing will only work properly if all touches have new data to report. If a touch has not changed, then it will not be counted. This leads to inaccurate finger counts. This change ensures that all active touches are counted. Note that

Re: [PATCH] dix: set raw event values before adding up relative values (#46976)

2012-03-21 Thread Simon Thum
On 03/21/2012 05:09 AM, Peter Hutterer wrote: Regression introduced in 4e52cc0ef48145134cd58d357fb7289e6f8bb709 Raw event values are values as-is from the driver, modified only be transformation or acceleration. 4e52cc caused the mask to be updated from driver-submitted relative to

X server source code re-indented

2012-03-21 Thread Keith Packard
I've taken Daniel's indent recipe, fixed it up a bit and applied it to the master branch in the X server. To help get other branches cleaned up in a compatible fashion, I've stuck the scripts I used in the util/modular repository. They're called x-indent-all.sh and x-indent.sh. Patches going

Re: X server source code re-indented

2012-03-21 Thread Chase Douglas
On 03/21/2012 02:25 PM, Keith Packard wrote: I've taken Daniel's indent recipe, fixed it up a bit and applied it to the master branch in the X server. To help get other branches cleaned up in a compatible fashion, I've stuck the scripts I used in the util/modular repository. They're called

Re: X server source code re-indented

2012-03-21 Thread Daniel Stone
Hi, On 21 March 2012 22:27, Chase Douglas chase.doug...@canonical.com wrote: On 03/21/2012 02:25 PM, Keith Packard wrote: I'll also happily take whitespace cleanup patches that recover from mistakes made by indent. I haven't made any attempt to learn the new style yet. Is there a guide

Re: X server source code re-indented

2012-03-21 Thread Peter Hutterer
On Wed, Mar 21, 2012 at 03:27:52PM -0700, Chase Douglas wrote: On 03/21/2012 02:25 PM, Keith Packard wrote: I've taken Daniel's indent recipe, fixed it up a bit and applied it to the master branch in the X server. To help get other branches cleaned up in a compatible fashion, I've stuck

Re: X server source code re-indented

2012-03-21 Thread Chase Douglas
On 03/21/2012 05:21 PM, Peter Hutterer wrote: On Wed, Mar 21, 2012 at 03:27:52PM -0700, Chase Douglas wrote: On 03/21/2012 02:25 PM, Keith Packard wrote: I've taken Daniel's indent recipe, fixed it up a bit and applied it to the master branch in the X server. To help get other branches

[PULL] next, dtrace, idlecounters

2012-03-21 Thread Peter Hutterer
This is my -next branch with a bunch of misc fixes, merged with the input API dtrace, merged with the per-device idle counters (and matching cleanups) All patches were rebased on top of the indentation cleanups. Commit a7eac500e652f30deffd9dc5e623fab701077738. The following changes since commit

Re: [PATCH xf86-input-synaptics 1/4] Fix clickfinger actions when middle button emulation is enabled

2012-03-21 Thread Peter Hutterer
On Wed, Mar 21, 2012 at 12:58:27PM -0700, Chase Douglas wrote: When MBE is enabled, a physical left button press is delayed until a timeout is reached. This results in the logical left button being depressed while the physical left button is pressed. The physical state is stored as the old hw

[PATCH synaptics] conf: enable right-button click by default on non-Apple clickpads

2012-03-21 Thread Peter Hutterer
The right-half of the bottom 30% of the touchpad are enabled as right button by default. On Apple touchpads (these don't have marking for the right button) disable them by default. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- conf/50-synaptics.conf | 18 ++ 1