[PATCH synaptics] Don't check for soft buttons if a button is already down

2012-05-09 Thread Peter Hutterer
Moving into a different soft button's area during drag-n-drop would trigger a click of that button. http://bugzilla.redhat.com/819348 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/synaptics.c

[PATCH synaptics] Fix coasting speed trigger

2012-05-09 Thread Peter Hutterer
CoastingSpeed is defined as scrolls/s. The previous code just used delta/seconds which depended on the device coordinate range and exceeded the default CoastingSpeed at almost any scroll event. Divide the estimated delta by the scroll distance to get the accurate scrolls/s number. Since that now

Re: [PATCH synaptics 0/3] synaptics indentation

2012-05-09 Thread Peter Hutterer
On Wed, May 09, 2012 at 12:18:09PM +1000, Peter Hutterer wrote: This has always annoyed me anyway and now that we managed to get the server done we might as well do synaptics. Same indentation style. Patch 1/3 is too big for the list, I've uploaded it here. It's just a run of the

Re: [PATCH 2/2] xfree86: use udev to provide device enumeration for kms devices

2012-05-09 Thread Dave Airlie
Well the problem is I've no idea what hotplug on any other OS is going to look like, and I really don't want to invent an abstraction without input from either someone a) who cares about another OS b) has time to help me now, not in 6 months. Well, okay, but there's two things here.  

[PATCH] xfree86: use udev to provide device enumeration for kms devices (v2)

2012-05-09 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com On Linux in order for future hotplug work, we are required to interface to udev to detect device creation/removal. In order to try and get some earlier testing on this, this patch adds the ability to use udev for device enumeration on Linux. At startup the

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-05-09 Thread Ran Benita
On Tue, May 08, 2012 at 05:35:23PM +0100, Daniel Stone wrote: Hi Ran, Sorry for the delay, have been sidetracked by core Wayland stuff for a bit. Hi! Thanks a bunch for all your last changes too, I've merged everything except the DFLT_XKB_CONFIG_ROOT change and the Unicode tests. Again for

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-05-09 Thread Kristian Høgsberg
Hi Ran, Let me just point you to this branch as well: http://cgit.freedesktop.org/~krh/libxkbcommon/log/?h=keysyms I've been talking with Daniel about this in IRC, but I thought you might want to take a look too. With those patches the API is completely self-contained. We still need xproto,

Re: [PATCH synaptics 0/3] synaptics indentation

2012-05-09 Thread Chase Douglas
On 05/08/2012 07:18 PM, Peter Hutterer wrote: This has always annoyed me anyway and now that we managed to get the server done we might as well do synaptics. Same indentation style. It's all fine by me. Reviewed-by: Chase Douglas chase.doug...@canonical.com

Re: [PATCH synaptics] Don't check for soft buttons if a button is already down

2012-05-09 Thread Chase Douglas
On 05/08/2012 11:36 PM, Peter Hutterer wrote: Moving into a different soft button's area during drag-n-drop would trigger a click of that button. http://bugzilla.redhat.com/819348 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/synaptics.c |2 +- 1 file changed, 1

Re: [PATCH synaptics 09/10] Move synaptics.h leftovers to synapticsstr.h, drop synaptics.h

2012-05-09 Thread Chase Douglas
On 05/08/2012 10:34 PM, Peter Hutterer wrote: This leaves us with a duplicated define for the maxbuttons but I'll live with that for now. include/synaptics.h isn't fully removed as I expected from the subject of this patch. Did I misinterpret things, or is the patch wrong? -- Chase

Re: [PATCH synaptics 00/10] Purging features

2012-05-09 Thread Chase Douglas
On 05/08/2012 10:34 PM, Peter Hutterer wrote: Well, features is probably pushing the term. More like bugs in disguise since several of those haven't been tested for multiple releases. The driver has become mostly unmaintainable, so a few features are shown the door. I'm sure things like

Re: [PATCH] dix: disable all devices before shutdown

2012-05-09 Thread Chase Douglas
On 05/08/2012 04:26 PM, Peter Hutterer wrote: f3410b97cf9b48a47bee3d15d232f8a88e75f4ef introduced a regression on server shutdown. If any button or key was held on shutdown (ctrl, alt, backspace are usually still down) sending a raw event will segfault the server. The the root windows are set

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-05-09 Thread Daniel Stone
Hi, On 9 May 2012 16:13, Ran Benita ran...@gmail.com wrote: On Tue, May 08, 2012 at 05:35:23PM +0100, Daniel Stone wrote: Thanks a bunch for all your last changes too, I've merged everything except the DFLT_XKB_CONFIG_ROOT change and the Unicode tests.  Again for the Unicode tests I want to

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-05-09 Thread Ran Benita
On Wed, May 09, 2012 at 06:20:35PM +0100, Daniel Stone wrote: On 9 May 2012 16:13, Ran Benita ran...@gmail.com wrote: On Tue, May 08, 2012 at 05:35:23PM +0100, Daniel Stone wrote: Thanks a bunch for all your last changes too, I've merged everything except the DFLT_XKB_CONFIG_ROOT change and

Re: [PATCH] dix: disable all devices before shutdown

2012-05-09 Thread Julien Cristau
On Wed, May 9, 2012 at 09:26:00 +1000, Peter Hutterer wrote: f3410b97cf9b48a47bee3d15d232f8a88e75f4ef introduced a regression on server shutdown. If any button or key was held on shutdown (ctrl, alt, backspace are usually still down) sending a raw event will segfault the server. The the root

Re: [PATCH] dix: disable all devices before shutdown

2012-05-09 Thread Peter Hutterer
On Wed, May 09, 2012 at 09:31:23PM +0200, Julien Cristau wrote: On Wed, May 9, 2012 at 09:26:00 +1000, Peter Hutterer wrote: f3410b97cf9b48a47bee3d15d232f8a88e75f4ef introduced a regression on server shutdown. If any button or key was held on shutdown (ctrl, alt, backspace are usually

Re: [PATCH synaptics 09/10] Move synaptics.h leftovers to synapticsstr.h, drop synaptics.h

2012-05-09 Thread Peter Hutterer
On Wed, May 09, 2012 at 09:34:20AM -0700, Chase Douglas wrote: On 05/08/2012 10:34 PM, Peter Hutterer wrote: This leaves us with a duplicated define for the maxbuttons but I'll live with that for now. include/synaptics.h isn't fully removed as I expected from the subject of this patch.

Re: [PATCH synaptics 00/10] Purging features

2012-05-09 Thread Peter Hutterer
On Wed, May 09, 2012 at 09:37:02AM -0700, Chase Douglas wrote: On 05/08/2012 10:34 PM, Peter Hutterer wrote: Well, features is probably pushing the term. More like bugs in disguise since several of those haven't been tested for multiple releases. The driver has become mostly

Re: [PATCH synaptics 09/10] Move synaptics.h leftovers to synapticsstr.h, drop synaptics.h

2012-05-09 Thread Chase Douglas
On 05/09/2012 04:24 PM, Peter Hutterer wrote: On Wed, May 09, 2012 at 09:34:20AM -0700, Chase Douglas wrote: On 05/08/2012 10:34 PM, Peter Hutterer wrote: This leaves us with a duplicated define for the maxbuttons but I'll live with that for now. include/synaptics.h isn't fully removed as I

[PATCH v2] Don't check for soft buttons if a button is already down

2012-05-09 Thread Peter Hutterer
Moving into a different soft button's area during drag-n-drop would trigger a click of that button. We only have the current button state and we mess with it, so the conditions for a possible clickpad soft-button event are: - hw-left is down now - none of left|right|middle were down before. since

Re: [PATCH] xfree86: use udev to provide device enumeration for kms devices (v2)

2012-05-09 Thread Peter Hutterer
On Wed, May 09, 2012 at 12:10:11PM +0100, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com On Linux in order for future hotplug work, we are required to interface to udev to detect device creation/removal. In order to try and get some earlier testing on this, this patch adds the

[PULL] logging cleanups

2012-05-09 Thread Peter Hutterer
The following changes since commit 97041364a6acb2b66b5cfd06757c90a006ad50e9: Merge remote-tracking branch 'whot/for-keith' (2012-05-02 20:47:25 -0700) are available in the git repository at: git://people.freedesktop.org/~whot/xserver for-keith for you to fetch changes up to

Re: [PATCH synaptics 06/10] Drop circular pad support

2012-05-09 Thread Eric Anholt
On Wed, 9 May 2012 15:34:34 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Do such devices still exist? Yeah, I use a 6 year old one as my i915 test system. But then, it doesn't have any particular synaptics configuration done to it, so I guess the driver never knew it. Nor do I

Re: [PATCH synaptics 06/10] Drop circular pad support

2012-05-09 Thread Peter Hutterer
On Wed, May 09, 2012 at 08:27:29PM -0700, Eric Anholt wrote: On Wed, 9 May 2012 15:34:34 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Do such devices still exist? Yeah, I use a 6 year old one as my i915 test system. But then, it doesn't have any particular synaptics

Re: [PATCH 0/1] Fix RANDR’s gamma_to_ramp()

2012-05-09 Thread Keith Packard
On Tue, 08 May 2012 18:21:36 -0400, James Cloos cl...@jhcloos.com wrote: James Cloos (1): Fix RANDR’s gamma_to_ramp(). e501c34..afc153a master - master -- keith.pack...@intel.com pgp2erbL1DwpC.pgp Description: PGP signature ___

Re: [PULL] logging cleanups

2012-05-09 Thread Keith Packard
On Thu, 10 May 2012 12:51:15 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Daniel Kurtz (4): os/log: trivial cleanups os/xprintf: add Xvscnprintf and Xscnprintf os/log: only write timestamp if a message is actually written to logfile os/log: refactor logging

[PATCH] include: add BUG_RETURN_* macros

2012-05-09 Thread Peter Hutterer
Helper functions to avoid things like if (foo) { BUG_WARN(foo); return 1; } Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- include/misc.h |9 + 1 file changed, 9 insertions(+) diff --git a/include/misc.h b/include/misc.h index 41c1333..a57efa0 100644 ---

Re: libX11: Changes to 'master'

2012-05-09 Thread Jeremy Huddleston
This commit introduced a 'make check' failure due by duplicating existing entries: make[2]: Entering directory `/home/jeremy/src/freedesktop/jhbuild/src/xorg/lib/libX11/nls' Clash with existing sequence in en_US.UTF-8/Compose on line 5826: Multi_key equal slash line #5826: Multi_key equal

Re: [PATCH] include: add BUG_RETURN_* macros

2012-05-09 Thread Peter Hutterer
On Thu, May 10, 2012 at 02:25:25PM +1000, Peter Hutterer wrote: Helper functions to avoid things like if (foo) { BUG_WARN(foo); return 1; } urgh, nevermind about this patch, it's bogus. Cheers, Peter --- include/misc.h |9 + 1 file changed, 9 insertions(+)

Re: [PATCH] include: add BUG_RETURN_* macros

2012-05-09 Thread Keith Packard
On Thu, 10 May 2012 14:25:25 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: +#define BUG_RETURN(cond) \ +do { __BUG_WARN_MSG(cond, 0, NULL); return; } while(0) I'm not a huge fan of macros hiding control flow... -- keith.pack...@intel.com pgpKUGgs25PmH.pgp Description: PGP

Re: [PATCH] include: add BUG_RETURN_* macros

2012-05-09 Thread Peter Hutterer
On Wed, May 09, 2012 at 10:05:51PM -0700, Keith Packard wrote: On Thu, 10 May 2012 14:25:25 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: +#define BUG_RETURN(cond) \ +do { __BUG_WARN_MSG(cond, 0, NULL); return; } while(0) I'm not a huge fan of macros hiding control

Re: xserver: Branch 'server-1.12-branch' - 5 commits

2012-05-09 Thread Peter Hutterer
On Wed, May 02, 2012 at 09:11:21PM -0700, Jeremy Huddleston wrote: commit 90299556db24543bb7365e8c2897deca3aa219e7 Author: Peter Hutterer peter.hutte...@who-t.net Date: Mon Apr 30 10:01:48 2012 +1000 dix: when disabling a device, release all buttons and keys A