Re: [PATCH v2] os: print newline after printing display name

2012-07-25 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: oh, right. I wonder why git rebase didn't think so. either way, thanks. Weird. Oh well, better to make sure in any case. -- keith.pack...@intel.com pgpsrIZRU7JnJ.pgp Description: PGP signature ___

Re: [PATCH] glx: drop GLX_LIBS from X server and workaround sdksyms.

2012-07-25 Thread Daniel Stone
Hi, On 25 July 2012 05:39, Dave Airlie airl...@gmail.com wrote: We've had reports of two copies of the GLX bits, one in the server and one in libglx.so causing problems, I didn't understand why the X server needed a copy so drop it, however then we have to fix a missing GlxExtensionInit that

Re: [PATCH 2/3] Restore extern to the declaration of __glXDRISWRastProvider

2012-07-25 Thread Daniel Stone
Hi, On 12 July 2012 14:30, Jon TURNEY jon.tur...@dronecode.org.uk wrote: b86aa74 dropped the 'extern' from the declaration of __glXDRISWRastProvider This turns out to be important to me, as without it, the final link only gets the tentative definition of __glXDRISWRastProvider implied by the

Re: [PATCH] glx: drop GLX_LIBS from X server and workaround sdksyms.

2012-07-25 Thread Jon TURNEY
On 25/07/2012 04:39, Dave Airlie wrote: From: Dave Airlie airlied-h+wxahxf7alqt0dzr+a...@public.gmane.org We've had reports of two copies of the GLX bits, one in the server and one in libglx.so causing problems, I didn't understand why the X server needed a copy so drop it, however then we

Re: [PATCH 3/4] Generate swrast GLX extension list, rather than using a fixed list

2012-07-25 Thread Jeremy Huddleston Sequoia
On Jul 25, 2012, at 6:45 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: +#ifndef __APPLE__ +__glXEnableExtension(screen-glx_enable_bits, GLX_SGIS_multisample); +#endif As far as I can tell, this conditional is entirely pointless (now, I'm guessing that there is some historical

Re: [PATCH 1/3] rrproviderproperty.c: free newly allocated prop in more error paths

2012-07-25 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Reported by parfait 1.0: Error: Memory leak (CWE 401) Memory leak of pointer 'prop' allocated with RRCreateProviderProperty(property) at line 221 of randr/rrproviderproperty.c in function 'RRChangeProviderProperty'.

Re: [PATCH test/xts 04/18] Build Xt3

2012-07-25 Thread Aaron Plattner
On 07/24/2012 12:00 PM, Peter Harris wrote: Signed-off-by: Peter Harris phar...@opentext.com This causes the build to fail on my system: make[4]: Entering directory `/home/aaron/git/x/xts/xts5/Xt3' CCLD CompositeWidget ../../xts5/src/.libs/libxts5.so: undefined reference to

Re: [PATCH 3/4] Generate swrast GLX extension list, rather than using a fixed list

2012-07-25 Thread Ian Romanick
On 07/25/2012 08:36 AM, Jeremy Huddleston Sequoia wrote: On Jul 25, 2012, at 6:45 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: +#ifndef __APPLE__ +__glXEnableExtension(screen-glx_enable_bits, GLX_SGIS_multisample); +#endif As far as I can tell, this conditional is entirely pointless

Re: [PATCH 2/3] rrproperty.c: free newly allocated prop in more error paths

2012-07-25 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Reported by parfait 1.0: Error: Memory leak (CWE 401) Memory leak of pointer 'prop' allocated with RRCreateOutputProperty(property) at line 220 of randr/rrproperty.c in function 'RRChangeOutputProperty'. 'prop'

Re: [PATCH 3/3] RRModeCreate: plug memory leak of newModes if AddResource fails

2012-07-25 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Reported by parfait 1.0: Error: Memory leak (CWE 401) Memory leak of pointer 'newModes' allocated with realloc(((char*)modes), ((num_modes + 1) * 8)) at line 93 of randr/rrmode.c in function 'RRModeCreate'. pointer

Re: [PATCH 1/2] Fix up formatting of initializers for arrays of structs

2012-07-25 Thread Keith Packard
Daniel Stone dan...@fooishbar.org writes: It'd be nice if this consistently used spaces or no spaces padding the inside of the braces. It'd be even nicer if this consistently used spaces. ;) Alan -- are you planning on updating this patch with fixed whitespace? Or should I just take it as-is

Re: [PATCH 1/2] Fix up formatting of initializers for arrays of structs

2012-07-25 Thread Alan Coopersmith
On 07/25/12 09:20 AM, Keith Packard wrote: Daniel Stone dan...@fooishbar.org writes: It'd be nice if this consistently used spaces or no spaces padding the inside of the braces. It'd be even nicer if this consistently used spaces. ;) Alan -- are you planning on updating this patch with

Re: [PATCH 0/3] Post-XAAectomy cleanup

2012-07-25 Thread Aaron Plattner
On 07/25/2012 09:26 AM, Keith Packard wrote: Daniel Stone dan...@fooishbar.org writes: Dang, forgot about cw! I'd love to boot it from the server for 1.13 -- shall I just do that in the next RC and see if anyone screams? I recall that the nvidia binary driver used it for a while, presumably

Re: [PATCH test/xts 04/18] Build Xt3

2012-07-25 Thread Peter Harris
On 2012-07-25 12:24, Aaron Plattner wrote: ... and this fixes it: Thanks. I'll squash that in and post a v2 shortly. Thanks, Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and Development

Re: [PATCH xorg-gtest] xserver: add environment variable to suspend after startup

2012-07-25 Thread Chase Douglas
On 07/25/2012 10:53 AM, Chase Douglas wrote: On 07/24/2012 06:26 PM, Peter Hutterer wrote: Allows for attaching gdb to a server without messing around too much in the test code. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- README |5 + src/xserver.cpp |6

[PATCH xorg-gtest 2/4] Disable PDF documentation generation

2012-07-25 Thread Chase Douglas
It's not installed and likely no one uses it. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- doc/Doxyfile.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/Doxyfile.in b/doc/Doxyfile.in index 357d429..cea27ce 100644 --- a/doc/Doxyfile.in +++

[PATCH xorg-gtest 3/4] Disable man page documentation generation and installation

2012-07-25 Thread Chase Douglas
Now that we have marked some methods as deprecated, a deprecated.3 man page is created. Since the filename isn't namespaced, it could collide with other documentation. The man pages are kinda nice, but they really aren't that useful. It's much better to use the HTML documentation. The simplest

[PATCH xorg-gtest 4/4] Uninstall documentation too

2012-07-25 Thread Chase Douglas
Caught by 'make distcheck'. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- doc/Makefile.am |3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/Makefile.am b/doc/Makefile.am index 7f8..9c52e84 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -34,6 +34,9 @@

[PATCH test/xts v2 03/20] Build libXtaw

2012-07-25 Thread Peter Harris
libXtaw is used by the Xt tests. Signed-off-by: Peter Harris phar...@opentext.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com --- configure.ac|3 ++- xts5/src/Makefile.am|2 +- xts5/src/libXtaw/Viewport.c | 10 -- 3 files changed, 7 insertions(+), 8

[PATCH test/xts v2 01/20] Ignore generated man page

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com --- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 906e545..cb12cbb 100644 --- a/.gitignore +++ b/.gitignore @@ -31,3 +31,5 @@

[PATCH test/xts v2 05/20] Build Xt4

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/Xt4/.gitignore | 33 ++ xts5/Xt4/Makefile.am | 55 ++ 4 files changed, 90 insertions(+), 1

[PATCH test/xts v2 07/20] Build Xt6

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/Xt6/.gitignore |7 +++ xts5/Xt6/Makefile.am | 29 + 4 files changed, 38 insertions(+), 1 deletions(-) create mode 100644

[PATCH test/xts v2 09/20] Build Xt8

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/Xt8/.gitignore |7 +++ xts5/Xt8/Makefile.am | 32 4 files changed, 41 insertions(+), 1 deletions(-) create mode 100644

[PATCH test/xts v2 06/20] Build Xt5

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/Xt5/.gitignore | 10 ++ xts5/Xt5/Makefile.am | 32 4 files changed, 44 insertions(+), 1 deletions(-) create mode 100644

[PATCH test/xts v2 08/20] Build Xt7

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/Xt7/.gitignore | 11 +++ xts5/Xt7/Makefile.am | 33 + 4 files changed, 46 insertions(+), 1 deletions(-) create mode 100644

[PATCH test/xts v2 11/20] Build Xt10

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |3 ++- xts5/Xt10/.gitignore |8 xts5/Xt10/Makefile.am | 30 ++ 4 files changed, 41 insertions(+), 1 deletions(-) create mode 100644

[PATCH test/xts v2 10/20] Build Xt9

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/Xt9/.gitignore | 33 +++ xts5/Xt9/Makefile.am | 61 ++ 4 files changed, 96 insertions(+), 1

[PATCH test/xts v2 15/20] Build Xt14

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/Xt14/.gitignore |2 ++ xts5/Xt14/Makefile.am | 24 4 files changed, 28 insertions(+), 1 deletions(-) create mode 100644 xts5/Xt14/.gitignore

[PATCH test/xts v2 14/20] Build Xt13

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/Xt13/.gitignore | 39 + xts5/Xt13/Makefile.am | 64 + 4 files changed, 105 insertions(+), 1

[PATCH test/xts v2 17/20] Build XtC

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/XtC/.gitignore | 29 xts5/XtC/Makefile.am | 51 ++ 4 files changed, 82 insertions(+), 1

[PATCH test/xts v2 16/20] Build Xt15

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/Xt15/.gitignore |1 + xts5/Xt15/Makefile.am | 23 +++ 4 files changed, 26 insertions(+), 1 deletions(-) create mode 100644 xts5/Xt15/.gitignore

[PATCH test/xts v2 19/20] Revert Delete the Xt scenarios from 'all'

2012-07-25 Thread Peter Harris
All the Xt tests build now. This reverts commit 106e89be471ddd99972a602a789352ca53fc2a88. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/tet_scen | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/xts5/tet_scen b/xts5/tet_scen index

[PATCH test/xts v2 20/20] Add ShapeExt section to all.

2012-07-25 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- xts5/tet_scen |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/xts5/tet_scen b/xts5/tet_scen index a552d05..fa13bca 100644 --- a/xts5/tet_scen +++ b/xts5/tet_scen @@ -184,6 +184,8 @@ all

[PATCH test/xts v2 18/20] Build XtE

2012-07-25 Thread Peter Harris
Rename StringDefs.h.m to StringDefs.m to avoid confusing AutoFoo. Signed-off-by: Peter Harris phar...@opentext.com --- configure.ac |1 + xts5/Makefile.am |2 +- xts5/XtE/.gitignore |1 + xts5/XtE/Makefile.am

[PATCH test/xts] Fix build of Xt* tests on Fedora

2012-07-25 Thread Peter Harris
--- This can be committed separately, although I'm inclined to squash it into patch 03/20. configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 6c162dc..07abff3 100644 --- a/configure.ac +++ b/configure.ac @@ -64,7 +64,7 @@

Re: [PATCH] dix: don't use new as a parameter name

2012-07-25 Thread Keith Packard
Aaron Plattner aplatt...@nvidia.com writes: new is a reserved word in C++. Merged. 77de299..83df169 master - master -- keith.pack...@intel.com pgphCCc7d8bWq.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PULL] More XQuartz regression fixes

2012-07-25 Thread Keith Packard
Jeremy Huddleston Sequoia jerem...@apple.com writes: XQuartz: Build fix for __GLXscreen::createContext changes XQuartz: Fix runtime regressions introduced by extension loading changes (Cc'd Daniel in case he wants to check the miinitext.c changes) Merged. 83df169..20b4d90

Re: [PATCH 1/2] Fix up formatting of initializers for arrays of structs

2012-07-25 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Yeah, I was going to do that, just hadn't got back to it yet - will try to do so this week. No worries, just wondering whether to merge them as-is or wait. -- keith.pack...@intel.com pgpsmGPI9nwlU.pgp Description: PGP signature

Re: [PATCH] hw/xquartz: Various fixes for pseudoramiX.c

2012-07-25 Thread Jeremy Huddleston Sequoia
Yeah, I'll do that for my next [PULL] request. On Jul 25, 2012, at 14:00, Keith Packard kei...@keithp.com wrote: Jeremy Huddleston Sequoia jerem...@apple.com writes: Seems right to me: Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com Do you want to pull this into your tree on

Re: [PATCH] dix: fix scale_to_desktop for edge ABS events

2012-07-25 Thread Yufeng Shen
On Tue, Jul 24, 2012 at 10:44 PM, Daniel Kurtz djku...@chromium.org wrote: On Wed, Jul 25, 2012 at 2:04 AM, Jeremy Huddleston Sequoia jerem...@apple.com wrote: Yick. This is why origin/size are better descriptors =( Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On Jul 20,

[PATCH] glx: drop GLX_LIBS from X server and workaround sdksyms.

2012-07-25 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com We've had reports of two copies of the GLX bits, one in the server and one in libglx.so causing problems, I didn't understand why the X server needed a copy so drop it, however then we have to fix a missing GlxExtensionInit that comes from sdksyms, so work

Re: [PATCH xorg-gtest 4/4] Uninstall documentation too

2012-07-25 Thread Peter Hutterer
On Wed, Jul 25, 2012 at 11:46:51AM -0700, Chase Douglas wrote: Caught by 'make distcheck'. Signed-off-by: Chase Douglas chase.doug...@canonical.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net for the reset of the series Cheers, Peter --- doc/Makefile.am |3 +++ 1 file

Re: [PATCH test/xts v2 01/20] Ignore generated man page

2012-07-25 Thread Peter Hutterer
On Wed, Jul 25, 2012 at 03:05:23PM -0400, Peter Harris wrote: Signed-off-by: Peter Harris phar...@opentext.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com --- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index

[PATCH] randr: add slave support to ProcRRSelectInput

2012-07-25 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This needed to send events for the slave crtcs/outputs. Pointed out by Keith. Signed-off-by: Dave Airlie airl...@redhat.com --- randr/rrdispatch.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/randr/rrdispatch.c b/randr/rrdispatch.c