Re: [PATCH:libXext] Avoid having macros expand code to be: ((f) ? (f)-m1 : NULL)-m2

2012-07-30 Thread Peter Hutterer
On Wed, Jul 18, 2012 at 11:40:18PM +0200, Thomas Klausner wrote: From Matthew R. Green m...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org applied, thanks. Cheers, Peter --- src/XSync.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/XSync.c

Re: [PATCH] Do sent TouchEnd to listeners that don't own an accepted touch

2012-07-30 Thread Peter Hutterer
On Thu, Jul 26, 2012 at 01:40:29PM -0700, Chase Douglas wrote: On 07/26/2012 01:31 PM, Daniel d'Andrada wrote: When the owner of a touch accepts it, the other listeners must receive a TouchEnd. Even though there's code implementing the logic above in ProcessTouchOwnershipEvent(),

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-30 Thread Michel Dänzer
On Sam, 2012-07-28 at 10:28 -0700, Jeremy Huddleston Sequoia wrote: On Jul 28, 2012, at 10:05, Julien Cristau jcris...@debian.org wrote: On Sat, Jul 28, 2012 at 09:58:46 -0700, Jeremy Huddleston Sequoia wrote: Ok, so then what do we do about this? Is it really important enough to

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-30 Thread Jeremy Huddleston Sequoia
On Jul 30, 2012, at 07:03, Michel Dänzer mic...@daenzer.net wrote: I agree that it's very unlikely that anyone would mix libglx.so and libdri2.so between versions, and yes of course making the symbol not exported would cause libglx.so to not be able to use it. And you do realize the fix

Re: [PATCH xf86-input-mouse] Fix compiler warnings

2012-07-30 Thread Jeremy Huddleston Sequoia
Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On Jul 29, 2012, at 22:53, Peter Hutterer peter.hutte...@who-t.net wrote: pnp.c: In function 'probePs2ProtocolPnP': pnp.c:711:31: warning: declaration of 'seq' shadows a previous local [-Wshadow] pnp.c:705:23: warning: shadowed

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-30 Thread Michel Dänzer
On Mon, 2012-07-30 at 09:04 -0700, Jeremy Huddleston Sequoia wrote: On Jul 30, 2012, at 07:03, Michel Dänzer mic...@daenzer.net wrote: That will get us into a situation where some servers advertising the same ABI version have DRI2CreateDrawable2 and some don't. You could bump the ABI

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-30 Thread Jeremy Huddleston Sequoia
On Jul 30, 2012, at 09:15, Michel Dänzer mic...@daenzer.net wrote: On Mon, 2012-07-30 at 09:04 -0700, Jeremy Huddleston Sequoia wrote: Ok. I think that letting DRI destroy the GLX drawable is just all kinds of ugly from the layering perspective. That's not happening. The fix makes GLX

Re: [PATCH xf86-input-mouse] Install xf86-mouse.pc file

2012-07-30 Thread Jeremy Huddleston Sequoia
Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com But I'm curious what the point of it is. Nobody's going to be linking against it. On Jul 29, 2012, at 16:08, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Makefile.am |

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-30 Thread Michel Dänzer
On Mon, 2012-07-30 at 09:36 -0700, Jeremy Huddleston Sequoia wrote: On Jul 30, 2012, at 09:15, Michel Dänzer mic...@daenzer.net wrote: I think an ABI minor bump would be the safest solution. Would you mind sending me a [PULL]? Sorry, I don't have time for this right now. Ok,

[PULL 1.12] glx/dri2: Fix bug #50019

2012-07-30 Thread Julien Cristau
On Mon, Jul 30, 2012 at 09:04:20 -0700, Jeremy Huddleston Sequoia wrote: Would you mind sending me a [PULL]? Here goes. I added in another (harmless) cherry-pick to avoid a conflict in hw/xfree86/dri2/dri2.h. The following changes since commit 60e0d205666c1fc0c818b9430c1e20428c9d3808:

[PATCH 1/5] ephyr: Fix up some bizarre formatting

2012-07-30 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- hw/kdrive/ephyr/hostx.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c index 6988f16..e13910b 100644 --- a/hw/kdrive/ephyr/hostx.c +++ b/hw/kdrive/ephyr/hostx.c @@

[PATCH 0/5] Misc fixes from RHEL6

2012-07-30 Thread Adam Jackson
Aside from 1/5, which is a driveby formatting cleanup, the rest of these are things we've been carrying in RHEL6 and that I didn't enjoy rebasing across the codingstyle change. (There's more stuff in RHEL6 than this, but the rest are either ABI breaks or have portability or conceptual issues.)

[PATCH 3/5] kinput: allocate enough space for null character.

2012-07-30 Thread Adam Jackson
From: Dave Airlie airl...@redhat.com This code wasn't allocating enough space and was assigning the NULL one past the end. Pointed out by coverity. Reviewed-by: Jeremy Huddleston jerem...@apple.com Reviewed-by: Adam Jackson a...@redhat.com Signed-off-by: Dave Airlie airl...@redhat.com ---

[PATCH 4/5] randr: Fix up yet another corner case in preferred mode selection

2012-07-30 Thread Adam Jackson
Let's say - purely for the sake of argument, mind you - that you had a server GPU with anemic memory bandwidth, and you walked up to it and plugged in a monitor that was 1920x1080 because that's what happened to be on the crash cart. Say the memory bandwidth is such that anything larger than

[PATCH 5/5] xf86RandR12: Don't call ConstrainCursorHarder() if panning is enabled

2012-07-30 Thread Adam Jackson
From: Rui Matos tiagoma...@gmail.com Panning is at odds with CRTC cursor confinement. This disables CRTC cursor confinement as long as panning is enabled. Fixes regression introduced in 56c90e29f04727c903bd0f084d23bf44eb1a0a11. Reviewed-by: Adam Jackson a...@redhat.com Signed-off-by: Rui Matos

[PATCH 2/5] ephyr: Resize screen automatically when parent window is resized

2012-07-30 Thread Adam Jackson
From: Vic Lee ll...@163.com Bugzilla: https://bugs.freedesktop.org/25804 Reviewed-by: Adam Jackson a...@redhat.com Signed-off-by: Vic Lee ll...@163.com --- hw/kdrive/ephyr/ephyr.c | 47 +++ hw/kdrive/ephyr/hostx.c | 33

Re: [PATCH 4/5] randr: Fix up yet another corner case in preferred mode selection

2012-07-30 Thread Alex Deucher
On Mon, Jul 30, 2012 at 2:32 PM, Adam Jackson a...@redhat.com wrote: Let's say - purely for the sake of argument, mind you - that you had a server GPU with anemic memory bandwidth, and you walked up to it and plugged in a monitor that was 1920x1080 because that's what happened to be on the

Re: [PATCH 1/5] ephyr: Fix up some bizarre formatting

2012-07-30 Thread Alex Deucher
On Mon, Jul 30, 2012 at 2:32 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- hw/kdrive/ephyr/hostx.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

[PATCH] vbe: Fix caching of DDC support status

2012-07-30 Thread Adam Jackson
There are multiple kinds of not supported here. One of them is where the video BIOS doesn't support the entrypoint. Another is where the BIOS returns nothing because no monitor happens to be connected. In the latter case we should just pretend we haven't checked yet, otherwise plugging in a

Re: [PATCH xf86-input-mouse] Install xf86-mouse.pc file

2012-07-30 Thread Alan Coopersmith
On 07/29/12 04:08 PM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Makefile.am |3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile.am b/Makefile.am index 01da486..77e9962 100644 --- a/Makefile.am +++ b/Makefile.am @@ -21,6 +21,9 @@

Re: [PATCH xf86-input-mouse] Install xf86-mouse.pc file

2012-07-30 Thread Alan Coopersmith
On 07/30/12 09:06 AM, Jeremy Huddleston Sequoia wrote: Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com But I'm curious what the point of it is. Nobody's going to be linking against it. -I path for the header file that defines the Xi properties now exported by the driver for

[RFC PATCH] xfree86: Lid status hack

2012-07-30 Thread Adam Jackson
If more than one output is connected, and there's only one ACPI lid device, proxy the state of the lid into the LVDS / eDP connectivity. This way we don't suffer from broken lid-status from the firmware in a way that would result in nothing lighting up. This is terribly Linux-specific and I don't

Re: [RFC PATCH] xfree86: Lid status hack

2012-07-30 Thread Alex Deucher
On Mon, Jul 30, 2012 at 3:43 PM, Adam Jackson a...@redhat.com wrote: If more than one output is connected, and there's only one ACPI lid device, proxy the state of the lid into the LVDS / eDP connectivity. This way we don't suffer from broken lid-status from the firmware in a way that would

Re: [RFC PATCH] xfree86: Lid status hack

2012-07-30 Thread Aaron Plattner
On 07/30/2012 01:08 PM, Alex Deucher wrote: On Mon, Jul 30, 2012 at 3:43 PM, Adam Jackson a...@redhat.com wrote: If more than one output is connected, and there's only one ACPI lid device, proxy the state of the lid into the LVDS / eDP connectivity. This way we don't suffer from broken

Re: [RFC PATCH] xfree86: Lid status hack

2012-07-30 Thread Adam Jackson
On 7/30/12 4:08 PM, Alex Deucher wrote: On Mon, Jul 30, 2012 at 3:43 PM, Adam Jackson a...@redhat.com wrote: If more than one output is connected, and there's only one ACPI lid device, proxy the state of the lid into the LVDS / eDP connectivity. This way we don't suffer from broken lid-status

[PATCH xf86-input-mouse] Rename xf86-mouse.pc to xorg-mouse.pc

2012-07-30 Thread Peter Hutterer
Other input drivers already shipping pkgconfig files use this naming scheme and since the 1.8 release didn't install the file anyway, renaming is still acceptable at this point. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Makefile.am |2 +- configure.ac |2 +-

Re: [PATCH xf86-input-mouse] Rename xf86-mouse.pc to xorg-mouse.pc

2012-07-30 Thread Alan Coopersmith
On 07/30/12 03:51 PM, Peter Hutterer wrote: Other input drivers already shipping pkgconfig files use this naming scheme and since the 1.8 release didn't install the file anyway, renaming is still acceptable at this point. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---

Re: NetBSD patches: how to move forward

2012-07-30 Thread Alan Coopersmith
On 07/27/12 01:45 PM, Thomas Klausner wrote: Hi! No comments and no commits for my patches in the last week. Is there a procedure I should follow so these don't get dropped, or should I just be more patient because it's holiday season? :) Even during non-holiday seasons, patience is

[PATCH:xf86-input-mouse] Fix compiler warning in sun_mouse.c (Solaris-only)

2012-07-30 Thread Alan Coopersmith
sun_mouse.c: In function 'vuidRemoveMouse': sun_mouse.c:150:42: warning: declaration of 'time' shadows a global declaration Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/sun_mouse.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sun_mouse.c

Re: [PATCH:xf86-input-mouse] Fix compiler warning in sun_mouse.c (Solaris-only)

2012-07-30 Thread Peter Hutterer
On Mon, Jul 30, 2012 at 03:56:18PM -0700, Alan Coopersmith wrote: sun_mouse.c: In function 'vuidRemoveMouse': sun_mouse.c:150:42: warning: declaration of 'time' shadows a global declaration Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com applied, thanks. Cheers, Peter ---

Re: [PULL 1.12] glx/dri2: Fix bug #50019

2012-07-30 Thread Michel Dänzer
On Mon, 2012-07-30 at 19:36 +0200, Julien Cristau wrote: On Mon, Jul 30, 2012 at 09:04:20 -0700, Jeremy Huddleston Sequoia wrote: Would you mind sending me a [PULL]? Here goes. I added in another (harmless) cherry-pick to avoid a conflict in hw/xfree86/dri2/dri2.h. Thanks, Julien!