Re: [ANNOUNCE] xorg-server 1.12.4

Simon, Do you think you'll be able to come up with a fix for this regression tomorrow (ie before Saturday)? If not, we should revert the change from master before we tag 1.13 on Tuesday. I'll also revert it from server-1.12-branch if a fix isn't found. --Jeremy On Aug 30, 2012, at 11:38,

Re: [ANNOUNCE] xorg-server 1.12.4

On 31 August 2012 08:24, Jeremy Huddleston Sequoia jerem...@freedesktop.org wrote: Simon, Do you think you'll be able to come up with a fix for this regression tomorrow (ie before Saturday)? If not, we should revert the change from master before we tag 1.13 on Tuesday. I'll also revert it

Re: [ANNOUNCE] xorg-server 1.12.4

On 08/31/2012 09:18 AM, Michal Suchanek wrote: On 31 August 2012 08:24, Jeremy Huddleston Sequoia jerem...@freedesktop.org wrote: Simon, Do you think you'll be able to come up with a fix for this regression tomorrow (ie before Saturday)? If not, we should revert the change from master

Re: [ANNOUNCE] xorg-server 1.12.4

On 31 August 2012 11:49, Simon Schubert 2...@0x2c.org wrote: On 08/31/2012 09:18 AM, Michal Suchanek wrote: On 31 August 2012 08:24, Jeremy Huddleston Sequoia jerem...@freedesktop.org wrote: Simon, Do you think you'll be able to come up with a fix for this regression tomorrow (ie before

[PATCH xf86-input-mouse] Fix attempting to log data in a signal unsafe manner warning

(EE) BUG: triggered 'if (inSignalContext)' (EE) BUG: /var/tmp/portage/x11-base/xorg-server-1.12.99.905/work/xorg-server-1.12.99.905/os/log.c:472 in LogVMessageVerb() (EE) Warning: attempting to log data in a signal unsafe manner while in signal context. Please update to check inSignalContext

Re: [PATCH xf86-input-mouse] Fix attempting to log data in a signal unsafe manner warning

On 08/31/2012 09:13 AM, Markus Trippelsdorf wrote: (EE) BUG: triggered 'if (inSignalContext)' (EE) BUG: /var/tmp/portage/x11-base/xorg-server-1.12.99.905/work/xorg-server-1.12.99.905/os/log.c:472 in LogVMessageVerb() (EE) Warning: attempting to log data in a signal unsafe manner while in

Re: [PATCH xorg-gtest] Remove mention of dummy where it's not true anymore

On 08/29/2012 09:12 PM, Peter Hutterer wrote: These messages are not correct when the server isn't started with the dummy driver. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- README | 7 +++ configure.ac| 2 +- src/xorg-gtest_main.cpp | 4

[PATCH:libXrandr] Constify a couple string arguments that are just copied, not modified

Fixes compiler warnings when building app/xrandr: xrandr.c: In function ‘crtc_set_transform’: xrandr.c:1459:9: warning: passing argument 4 of ‘XRRSetCrtcTransform’ discards qualifiers from pointer target type X11/extensions/Xrandr.h:419:1: note: expected ‘char *’ but argument is of type ‘const

[PATCH:xscope 03/24] Define *HEADER constants as string pointers, not arrays

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- print11.c |8 x11.h |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/print11.c b/print11.c index e7da143..36b335f 100644 --- a/print11.c +++ b/print11.c @@ -179,10 +179,10 @@

[PATCH:xscope 04/24] Convert some for loops to use C99-style inline variable declarations

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- common.c|3 +-- decode11.c | 14 ++ decode_glx.c|3 +-- decode_render.c |8 +++- fd.c|7 ++- print_render.c |3 +-- prtype.c| 49

[PATCH:xscope 05/24] Move debug statement before panic() call, so it can actually run

Fixes compiler warning: fd.c, line 481: warning: statement not reached Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- fd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fd.c b/fd.c index 00a68a2..8b85460 100644 --- a/fd.c +++ b/fd.c @@ -477,8 +477,8 @@

[PATCH:xscope 01/24] Use local variable for ioctl argument instead of a static

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- common.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/common.c b/common.c index d6f4d7c..c0e9fd6 100644 --- a/common.c +++ b/common.c @@ -187,8 +187,6 @@ static int ListenTransCount; #include netinet/in.h

[PATCH:xscope 00/24] Clean up build up to adding RANDR 1.4 support

Sure I thought, it will be easy to update the RANDR support in xscope to the new version 1.4 - it's almost there, right? Nope, turns out xscope's RANDR support was still 0.x only - no 1.0 or later. And around every corner trying to get to 1.4 was something else to fix first. 24 commits later and

[PATCH:xscope 02/24] Combine usage message into single string for fprintf

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- scope.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/scope.c b/scope.c index 9928bad..2f9befc 100644 --- a/scope.c +++ b/scope.c @@ -649,18 +649,19 @@ GetScopePort(void) static

[PATCH:xscope 08/24] Add _X_NORETURN to additional functions suggested by gcc warnings

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- common.c |4 ++-- scope.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/common.c b/common.c index 0492e47..8c88aae 100644 --- a/common.c +++ b/common.c @@ -107,14 +107,14 @@ SignalINT(int sig)

[PATCH:xscope 09/24] Convert remaining bcopy() calls to memcpy()

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- common.c |2 +- fd.c |2 +- server.c |6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/common.c b/common.c index 8c88aae..3997464 100644 --- a/common.c +++ b/common.c @@ -277,7 +277,7 @@

[PATCH:xscope 06/24] SaveBytes: drop unnecessary casts in bcopy() call

Clears gcc warning from casting a const char * to char *: server.c: In function `SaveBytes': server.c:203: warning: cast discards qualifiers from pointer target type Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- server.c |6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH:xscope 11/24] Move ILong, IShort, etal to inline functions in x11.h

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- scope.h |3 ++- server.c | 57 x11.h| 63 +++--- 3 files changed, 58 insertions(+), 65 deletions(-) diff

[PATCH:xscope 12/24] ILong: shift each byte individually, then OR them together

instead of shifting the whole word as each byte is loaded into place Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- x11.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x11.h b/x11.h index ed0f3d6..a3c8cb9 100644 --- a/x11.h +++ b/x11.h @@ -547,8

[PATCH:xscope 07/24] Convert remaining sprintf calls to snprintf

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- common.c |2 +- fd.c |8 +--- prtype.c |4 ++-- scope.c |6 +++--- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/common.c b/common.c index 3c59c0b..0492e47 100644 --- a/common.c +++

[PATCH:xscope 13/24] Handle big-requests when calculating request contents from length field

Adds a getreqlen inline function to handle the big requests check. As noted in the comment, it must be called *before* the printreqlen macro does its own check, since printreqlen fixes the buf pointer when it's done to align all the remaining fields with their correct positions after skipping over

[PATCH:xscope 14/24] Convert ValueRec structures from unsigned long to uint32_t values

Used for GC struct members, which are defined in the protocol as 32-bit, so no need to waste time and memory copying into 64-bit longs everywhere Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- print11.c |4 ++-- prtype.c |2 +- table11.c | 16 x11.h

[PATCH:xscope 15/24] Record atoms from InternAtom and GetAtomName requests

Uses them to display strings instead of just numeric ids for atoms beyond the builtin set in other requests, such as property lookups. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- COPYING |3 +- print11.c | 92

[PATCH:xscope 10/24] Convert ILong, IShort, etal to return C99 uint*_t types

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- server.c |8 x11.h| 10 ++ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/server.c b/server.c index 3369460..5226a03 100644 --- a/server.c +++ b/server.c @@ -138,7 +138,7 @@ pad(long n)

[PATCH:xscope 17/24] Print UTF8_STRING properties as text if locale uses UTF-8 charset

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- prtype.c | 19 --- scope.c | 24 +++- scope.h |3 ++- 4 files changed, 42 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index

[PATCH:xscope 18/24] Add support for printing more types of property value

Prints atoms, cardinals, integers, and windows as formatted values instead of lists of bytes. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- prtype.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/prtype.c

[PATCH:xscope 16/24] Create PrintPropertyValues function for property requests

Currently used for core protocol window properties, but will be used for extensions that have similar property handling requests in the future. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- print11.c | 16 +--- proto.h |3 +++ prtype.c | 18

[PATCH:xscope 19/24] Add -I command line flag to enter interactive mode at startup

Avoids having to try to time a ^C after the signal handler is set up but before any data is handled. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- man/xscope.man |9 +++-- scope.c|5 + 2 files changed, 12 insertions(+), 2 deletions(-) diff --git

[PATCH:xscope 23/24] Refactor error printing to use common functions

All errors currently recognized by xscope fall into two forms, with or without a 32-bit value to print as a bad value, so use common implementations for those two forms so we can stop duplicating that code for every new extension-defined error. Signed-off-by: Alan Coopersmith

[PATCH:xscope 21/24] Refactor fd closing into CloseFD helper function

All versions now perform same check for XtransConn data to decide whether to use _X11TransClose or regular close, which is needed for being able to read data from pre-recorded files instead of live sockets. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- fd.c| 23

[PATCH:randrproto 01/12] spec: Correct length for RRCreateMode in encoding section

(1 + 1 + 2 + 4 + 32) / 4 is 10 words, not 12 10 also matches the sz_xRRCreateModeReq value of 40 in randrproto.h Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/randrproto.txt b/randrproto.txt

[PATCH:randrproto 00/12] Protocol spec corrections

One side benefit of adding RANDR support to xscope is it's basically writing a second independent implementation of the protocol code from the spec, since it doesn't use the Xlib, XCB, or Xserver code for decoding. Thus, inconsistencies and nits in the spec were uncovered, and I've tried to guess

[PATCH:randrproto 03/12] spec: Update data type sections

Make definitions more consistent about use of {} for enums, [] for structs Reflect the incorporation of more types from the Render spec in 1.3 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt | 47 +-- 1 file changed, 33

[PATCH:randrproto 02/12] spec: Fix typos in text

At least I'm assuming providre is a typo, not just a non-American variant. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/randrproto.txt b/randrproto.txt index e263108..8c6292a

[PATCH:randrproto 04/12] spec: Correct size of outputs in RRSetCrtcConfig encoding

Each OUTPUT is 4 bytes, not 8. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/randrproto.txt b/randrproto.txt index 478c507..27fc2f3 100644 --- a/randrproto.txt +++ b/randrproto.txt @@

[PATCH:randrproto 07/12] spec: Make description of RRProviderChangeNotify match encoding header

The encoding section matches randrproto.h - neither of which have the config-timestamp, root, or crtc members. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/randrproto.txt

[PATCH:randrproto 08/12] spec: Make encoding of RRGetProviders match description header

The description section matches randrproto.h - neither of which have the maximum masters or flags members, but do have padding before the providers list starts. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt |5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH:randrproto 05/12] spec: Correct length calculation in encoding of gamma lists

The padding for RRGetCrtcGamma RRSetCrtcGamma is a variable p, not a fixed 2 bytes, since it depends on how many values are included in the lists. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH:randrproto 06/12] spec: correct sub-code values for RRProvider*Notify event encoding

These values match the RRNotify_* definitions in randrproto.h and don't overlap with the RROutput*Notify codes from RandR 1.2. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH:randrproto 09/12] spec: Make encoding of RRGetProviderInfo match header

The encoding is missing the 8 bytes of padding at the end of the base reply struct before the variable length lists begin. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt |1 + 1 file changed, 1 insertion(+) diff --git a/randrproto.txt b/randrproto.txt index

[PATCH:randrproto 11/12] spec: Add config-timestamp to descriptions of OffloadSink OutputSource

Present in header encoding section, just not in the descriptions of RRSetProviderOffloadSink RRSetProviderOutputSource Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/randrproto.txt

[PATCH:randrproto 10/12] spec: Add PROVIDER_CAPS encoding to Appendix A

Uses values found in randr.h Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt |7 +++ 1 file changed, 7 insertions(+) diff --git a/randrproto.txt b/randrproto.txt index b52a7c5..9887ded 100644 --- a/randrproto.txt +++ b/randrproto.txt @@ -2169,6 +2169,13 @@

[PATCH:randrproto 12/12] spec: Correct lengths in encoding of OffloadSink OutputSource

Make listed lengths match data shown values in header for RRSetProviderOffloadSink RRSetProviderOutputSource Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- randrproto.txt |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/randrproto.txt b/randrproto.txt